[jira] [Commented] (CB-7698) CLI: no validation for globally required plugin variables
[ https://issues.apache.org/jira/browse/CB-7698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14362682#comment-14362682 ] ASF GitHub Bot commented on CB-7698: Github user omefire closed the pull request at: https://github.com/apache/cordova-lib/pull/184 CLI: no validation for globally required plugin variables - Key: CB-7698 URL: https://issues.apache.org/jira/browse/CB-7698 Project: Apache Cordova Issue Type: Bug Components: CLI Reporter: Bryan Higgins Assignee: Bryan Higgins Priority: Minor CLI should check that any globally required variables (preference at root level in plugin.xml) have been provided before calling plugman.install on the platforms. Otherwise the plugin is added to the project but plugman fails to install to any platforms. From the docs: plugman checks that these required preferences are passed in. If not, it should warn the user how to pass the variable in and exit with a non-zero code. http://cordova.apache.org/docs/en/3.6.0/plugin_ref_spec.md.html#Plugin%20Specification -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7698) CLI: no validation for globally required plugin variables
[
https://issues.apache.org/jira/browse/CB-7698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14360470#comment-14360470
]
ASF GitHub Bot commented on CB-7698:
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/184#discussion_r26392721
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -185,8 +185,9 @@ module.exports = function plugin(command, targets,
opts) {
});
if (missingVariables.length) {
shell.rm('-rf', dir);
-events.emit('results', 'Variable(s) missing
(use: --variable ' + missingVariables.join('=value --variable ') + '=value).');
-return;
+var msg = 'Variable(s) missing (use:
--variable ' + missingVariables.join('=value --variable ') + '=value).';
+events.emit('results', msg);
--- End diff --
There is no need to emit the results event to log error message to console.
There is a an error handler in cordova-cli which does this already.
CLI: no validation for globally required plugin variables
-
Key: CB-7698
URL: https://issues.apache.org/jira/browse/CB-7698
Project: Apache Cordova
Issue Type: Bug
Components: CLI
Reporter: Bryan Higgins
Assignee: Bryan Higgins
Priority: Minor
CLI should check that any globally required variables (preference at root
level in plugin.xml) have been provided before calling plugman.install on the
platforms. Otherwise the plugin is added to the project but plugman fails to
install to any platforms.
From the docs:
plugman checks that these required preferences are passed in. If not, it
should warn the user how to pass the variable in and exit with a non-zero
code.
http://cordova.apache.org/docs/en/3.6.0/plugin_ref_spec.md.html#Plugin%20Specification
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7698) CLI: no validation for globally required plugin variables
[ https://issues.apache.org/jira/browse/CB-7698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14360476#comment-14360476 ] ASF GitHub Bot commented on CB-7698: Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/184#issuecomment-79026418 This is merged in https://github.com/apache/cordova-lib/commit/b03b4d7ddec982b00e6f009468ffa8db59c56e1c. @omefire could you please close this CLI: no validation for globally required plugin variables - Key: CB-7698 URL: https://issues.apache.org/jira/browse/CB-7698 Project: Apache Cordova Issue Type: Bug Components: CLI Reporter: Bryan Higgins Assignee: Bryan Higgins Priority: Minor CLI should check that any globally required variables (preference at root level in plugin.xml) have been provided before calling plugman.install on the platforms. Otherwise the plugin is added to the project but plugman fails to install to any platforms. From the docs: plugman checks that these required preferences are passed in. If not, it should warn the user how to pass the variable in and exit with a non-zero code. http://cordova.apache.org/docs/en/3.6.0/plugin_ref_spec.md.html#Plugin%20Specification -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7698) CLI: no validation for globally required plugin variables
[ https://issues.apache.org/jira/browse/CB-7698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14359977#comment-14359977 ] ASF GitHub Bot commented on CB-7698: Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/184#issuecomment-78815446 @vladimir-kotikov Can you please help review? CLI: no validation for globally required plugin variables - Key: CB-7698 URL: https://issues.apache.org/jira/browse/CB-7698 Project: Apache Cordova Issue Type: Bug Components: CLI Reporter: Bryan Higgins Assignee: Bryan Higgins Priority: Minor CLI should check that any globally required variables (preference at root level in plugin.xml) have been provided before calling plugman.install on the platforms. Otherwise the plugin is added to the project but plugman fails to install to any platforms. From the docs: plugman checks that these required preferences are passed in. If not, it should warn the user how to pass the variable in and exit with a non-zero code. http://cordova.apache.org/docs/en/3.6.0/plugin_ref_spec.md.html#Plugin%20Specification -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7698) CLI: no validation for globally required plugin variables
[ https://issues.apache.org/jira/browse/CB-7698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14356401#comment-14356401 ] ASF GitHub Bot commented on CB-7698: Github user glasser commented on the pull request: https://github.com/apache/cordova-lib/pull/184#issuecomment-78213647 Awesome, thanks! CLI: no validation for globally required plugin variables - Key: CB-7698 URL: https://issues.apache.org/jira/browse/CB-7698 Project: Apache Cordova Issue Type: Bug Components: CLI Reporter: Bryan Higgins Assignee: Bryan Higgins Priority: Minor CLI should check that any globally required variables (preference at root level in plugin.xml) have been provided before calling plugman.install on the platforms. Otherwise the plugin is added to the project but plugman fails to install to any platforms. From the docs: plugman checks that these required preferences are passed in. If not, it should warn the user how to pass the variable in and exit with a non-zero code. http://cordova.apache.org/docs/en/3.6.0/plugin_ref_spec.md.html#Plugin%20Specification -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7698) CLI: no validation for globally required plugin variables
[ https://issues.apache.org/jira/browse/CB-7698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14356398#comment-14356398 ] ASF GitHub Bot commented on CB-7698: GitHub user omefire opened a pull request: https://github.com/apache/cordova-lib/pull/184 CB-7698 BugFix: For plugins which require variables, 'cordova plugin add FOO' should fail when no variables specified. CB-7698 BugFix: For plugins which require variables, 'cordova plugin add FOO' should fail when no variables specified. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-7698 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/184.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #184 commit a5098b7758d6ad11e7fa7f2b0b22090088103314 Author: Omar Mefire ommen...@microsoft.com Date: 2015-03-11T06:46:07Z CB-7698 BugFix: For plugins which require variables, 'cordova plugin add FOO' should fail when no variables specified. CLI: no validation for globally required plugin variables - Key: CB-7698 URL: https://issues.apache.org/jira/browse/CB-7698 Project: Apache Cordova Issue Type: Bug Components: CLI Reporter: Bryan Higgins Assignee: Bryan Higgins Priority: Minor CLI should check that any globally required variables (preference at root level in plugin.xml) have been provided before calling plugman.install on the platforms. Otherwise the plugin is added to the project but plugman fails to install to any platforms. From the docs: plugman checks that these required preferences are passed in. If not, it should warn the user how to pass the variable in and exit with a non-zero code. http://cordova.apache.org/docs/en/3.6.0/plugin_ref_spec.md.html#Plugin%20Specification -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7698) CLI: no validation for globally required plugin variables
[ https://issues.apache.org/jira/browse/CB-7698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14356283#comment-14356283 ] David Glasser commented on CB-7698: --- It doesn't seem like this error causes `plugin add` to exit with a non-zero code. CLI: no validation for globally required plugin variables - Key: CB-7698 URL: https://issues.apache.org/jira/browse/CB-7698 Project: Apache Cordova Issue Type: Bug Components: CLI Reporter: Bryan Higgins Assignee: Bryan Higgins Priority: Minor CLI should check that any globally required variables (preference at root level in plugin.xml) have been provided before calling plugman.install on the platforms. Otherwise the plugin is added to the project but plugman fails to install to any platforms. From the docs: plugman checks that these required preferences are passed in. If not, it should warn the user how to pass the variable in and exit with a non-zero code. http://cordova.apache.org/docs/en/3.6.0/plugin_ref_spec.md.html#Plugin%20Specification -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7698) CLI: no validation for globally required plugin variables
[ https://issues.apache.org/jira/browse/CB-7698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156652#comment-14156652 ] ASF subversion and git services commented on CB-7698: - Commit 242a8d760267379e963977de68d49aae96928562 in cordova-lib's branch refs/heads/master from [~bhiggins_bb] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=242a8d7 ] CB-7698 CLI - Validate top-level plugin variables before installing CLI: no validation for globally required plugin variables - Key: CB-7698 URL: https://issues.apache.org/jira/browse/CB-7698 Project: Apache Cordova Issue Type: Bug Components: CLI Reporter: Bryan Higgins Assignee: Bryan Higgins Priority: Minor CLI should check that any globally required variables (preference at root level in plugin.xml) have been provided before calling plugman.install on the platforms. Otherwise the plugin is added to the project but plugman fails to install to any platforms. From the docs: plugman checks that these required preferences are passed in. If not, it should warn the user how to pass the variable in and exit with a non-zero code. http://cordova.apache.org/docs/en/3.6.0/plugin_ref_spec.md.html#Plugin%20Specification -- This message was sent by Atlassian JIRA (v6.3.4#6332)
