[jira] [Commented] (CB-8056) Implement splashscreen for Windows platform

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270815#comment-15270815
 ] 

ASF subversion and git services commented on CB-8056:
-

Commit 3d924fce1bc1d6b1d1d6414ad93fb7fe3f6b111a in 
cordova-plugin-splashscreen's branch refs/heads/master from [~daserge]
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-splashscreen.git;h=3d924fc
 ]

CB-8056 Updated the dependency version, added it to the docs


> Implement splashscreen for Windows platform
> ---
>
> Key: CB-8056
> URL: https://issues.apache.org/jira/browse/CB-8056
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen, Windows
>Affects Versions: 3.6.0
>Reporter: Doug Estey
>Assignee: Sergey Shakhnazarov
>  Labels: reproduced, triaged, windows
>
> {code:title=config.xml|borderStyle=solid}
> 
> 
> 
> {code}
> This has no effect on the cordova-windows platform. Splash screen autohides 
> after <1000ms.
> Tested on WP 8.1.
> Let me know if there's any other information I can provide. The documentation 
> for splash screens on 8.1 seems to be somewhat lacking, so I may have missed 
> something somewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8056) Implement splashscreen for Windows platform

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270816#comment-15270816
 ] 

ASF GitHub Bot commented on CB-8056:


Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-splashscreen/pull/100


> Implement splashscreen for Windows platform
> ---
>
> Key: CB-8056
> URL: https://issues.apache.org/jira/browse/CB-8056
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen, Windows
>Affects Versions: 3.6.0
>Reporter: Doug Estey
>Assignee: Sergey Shakhnazarov
>  Labels: reproduced, triaged, windows
>
> {code:title=config.xml|borderStyle=solid}
> 
> 
> 
> {code}
> This has no effect on the cordova-windows platform. Splash screen autohides 
> after <1000ms.
> Tested on WP 8.1.
> Let me know if there's any other information I can provide. The documentation 
> for splash screens on 8.1 seems to be somewhat lacking, so I may have missed 
> something somewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8056) Implement splashscreen for Windows platform

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15264460#comment-15264460
 ] 

ASF GitHub Bot commented on CB-8056:


Github user rakatyal commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/100#issuecomment-215833256
  
LGTM.


> Implement splashscreen for Windows platform
> ---
>
> Key: CB-8056
> URL: https://issues.apache.org/jira/browse/CB-8056
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen, Windows
>Affects Versions: 3.6.0
>Reporter: Doug Estey
>Assignee: Sergey Shakhnazarov
>  Labels: reproduced, triaged, windows
>
> {code:title=config.xml|borderStyle=solid}
> 
> 
> 
> {code}
> This has no effect on the cordova-windows platform. Splash screen autohides 
> after <1000ms.
> Tested on WP 8.1.
> Let me know if there's any other information I can provide. The documentation 
> for splash screens on 8.1 seems to be somewhat lacking, so I may have missed 
> something somewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8056) Implement splashscreen for Windows platform

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15264045#comment-15264045
 ] 

ASF GitHub Bot commented on CB-8056:


GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-splashscreen/pull/100

CB-8056 Updated the dependency version, added it to the docs

Related to https://github.com/apache/cordova-windows/pull/172

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-splashscreen CB-8056

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-splashscreen/pull/100.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #100


commit 3d924fce1bc1d6b1d1d6414ad93fb7fe3f6b111a
Author: daserge 
Date:   2016-04-29T13:26:20Z

CB-8056 Updated the dependency version, added it to the docs




> Implement splashscreen for Windows platform
> ---
>
> Key: CB-8056
> URL: https://issues.apache.org/jira/browse/CB-8056
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen, Windows
>Affects Versions: 3.6.0
>Reporter: Doug Estey
>Assignee: Sergey Shakhnazarov
>  Labels: reproduced, triaged, windows
>
> {code:title=config.xml|borderStyle=solid}
> 
> 
> 
> {code}
> This has no effect on the cordova-windows platform. Splash screen autohides 
> after <1000ms.
> Tested on WP 8.1.
> Let me know if there's any other information I can provide. The documentation 
> for splash screens on 8.1 seems to be somewhat lacking, so I may have missed 
> something somewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8056) Implement splashscreen for Windows platform

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15261809#comment-15261809
 ] 

ASF subversion and git services commented on CB-8056:
-

Commit bbd8de71dbfa8c3b03f5e67c60a63f6818ca42eb in cordova-windows's branch 
refs/heads/master from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=bbd8de7 ]

CB-8056 Revert version that was mistakengly changed in d6988f5c


> Implement splashscreen for Windows platform
> ---
>
> Key: CB-8056
> URL: https://issues.apache.org/jira/browse/CB-8056
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen, Windows
>Affects Versions: 3.6.0
>Reporter: Doug Estey
>Assignee: Sergey Shakhnazarov
>  Labels: reproduced, triaged, windows
>
> {code:title=config.xml|borderStyle=solid}
> 
> 
> 
> {code}
> This has no effect on the cordova-windows platform. Splash screen autohides 
> after <1000ms.
> Tested on WP 8.1.
> Let me know if there's any other information I can provide. The documentation 
> for splash screens on 8.1 seems to be somewhat lacking, so I may have missed 
> something somewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8056) Implement splashscreen for Windows platform

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254696#comment-15254696
 ] 

ASF GitHub Bot commented on CB-8056:


Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-213589583
  
it does


> Implement splashscreen for Windows platform
> ---
>
> Key: CB-8056
> URL: https://issues.apache.org/jira/browse/CB-8056
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen, Windows
>Affects Versions: 3.6.0
>Reporter: Doug Estey
>Assignee: Sergey Shakhnazarov
>  Labels: reproduced, triaged, windows
>
> {code:title=config.xml|borderStyle=solid}
> 
> 
> 
> {code}
> This has no effect on the cordova-windows platform. Splash screen autohides 
> after <1000ms.
> Tested on WP 8.1.
> Let me know if there's any other information I can provide. The documentation 
> for splash screens on 8.1 seems to be somewhat lacking, so I may have missed 
> something somewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8056) Implement splashscreen for Windows platform

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254684#comment-15254684
 ] 

ASF GitHub Bot commented on CB-8056:


Github user RobPosener commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-213588273
  
Spinner has never worked in Windows 10 
It should.


> Implement splashscreen for Windows platform
> ---
>
> Key: CB-8056
> URL: https://issues.apache.org/jira/browse/CB-8056
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen, Windows
>Affects Versions: 3.6.0
>Reporter: Doug Estey
>Assignee: Sergey Shakhnazarov
>  Labels: reproduced, triaged, windows
>
> {code:title=config.xml|borderStyle=solid}
> 
> 
> 
> {code}
> This has no effect on the cordova-windows platform. Splash screen autohides 
> after <1000ms.
> Tested on WP 8.1.
> Let me know if there's any other information I can provide. The documentation 
> for splash screens on 8.1 seems to be somewhat lacking, so I may have missed 
> something somewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8056) Implement splashscreen for Windows platform

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254621#comment-15254621
 ] 

ASF GitHub Bot commented on CB-8056:


Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-windows/pull/141#issuecomment-213581048
  
Verified, and merged. Thanks!


> Implement splashscreen for Windows platform
> ---
>
> Key: CB-8056
> URL: https://issues.apache.org/jira/browse/CB-8056
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen, Windows
>Affects Versions: 3.6.0
>Reporter: Doug Estey
>Assignee: Sergey Shakhnazarov
>  Labels: reproduced, triaged, windows
>
> {code:title=config.xml|borderStyle=solid}
> 
> 
> 
> {code}
> This has no effect on the cordova-windows platform. Splash screen autohides 
> after <1000ms.
> Tested on WP 8.1.
> Let me know if there's any other information I can provide. The documentation 
> for splash screens on 8.1 seems to be somewhat lacking, so I may have missed 
> something somewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8056) Implement splashscreen for Windows platform

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254619#comment-15254619
 ] 

ASF GitHub Bot commented on CB-8056:


Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/141


> Implement splashscreen for Windows platform
> ---
>
> Key: CB-8056
> URL: https://issues.apache.org/jira/browse/CB-8056
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen, Windows
>Affects Versions: 3.6.0
>Reporter: Doug Estey
>Assignee: Sergey Shakhnazarov
>  Labels: reproduced, triaged, windows
>
> {code:title=config.xml|borderStyle=solid}
> 
> 
> 
> {code}
> This has no effect on the cordova-windows platform. Splash screen autohides 
> after <1000ms.
> Tested on WP 8.1.
> Let me know if there's any other information I can provide. The documentation 
> for splash screens on 8.1 seems to be somewhat lacking, so I may have missed 
> something somewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8056) Implement splashscreen for Windows platform

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254623#comment-15254623
 ] 

ASF GitHub Bot commented on CB-8056:


Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-213581077
  
Verified, and merged. Thanks!


> Implement splashscreen for Windows platform
> ---
>
> Key: CB-8056
> URL: https://issues.apache.org/jira/browse/CB-8056
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen, Windows
>Affects Versions: 3.6.0
>Reporter: Doug Estey
>Assignee: Sergey Shakhnazarov
>  Labels: reproduced, triaged, windows
>
> {code:title=config.xml|borderStyle=solid}
> 
> 
> 
> {code}
> This has no effect on the cordova-windows platform. Splash screen autohides 
> after <1000ms.
> Tested on WP 8.1.
> Let me know if there's any other information I can provide. The documentation 
> for splash screens on 8.1 seems to be somewhat lacking, so I may have missed 
> something somewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8056) Implement splashscreen for Windows platform

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254617#comment-15254617
 ] 

ASF subversion and git services commented on CB-8056:
-

Commit d6988f5c863ec3ba5cde33a678a4b93badc64395 in cordova-windows's branch 
refs/heads/master from [~daserge]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=d6988f5 ]

CB-8056 Implement splashscreen for Windows platform

Updated version to 5.0.0


> Implement splashscreen for Windows platform
> ---
>
> Key: CB-8056
> URL: https://issues.apache.org/jira/browse/CB-8056
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen, Windows
>Affects Versions: 3.6.0
>Reporter: Doug Estey
>Assignee: Sergey Shakhnazarov
>  Labels: reproduced, triaged, windows
>
> {code:title=config.xml|borderStyle=solid}
> 
> 
> 
> {code}
> This has no effect on the cordova-windows platform. Splash screen autohides 
> after <1000ms.
> Tested on WP 8.1.
> Let me know if there's any other information I can provide. The documentation 
> for splash screens on 8.1 seems to be somewhat lacking, so I may have missed 
> something somewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8056) Implement splashscreen for Windows platform

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254607#comment-15254607
 ] 

ASF GitHub Bot commented on CB-8056:


Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-splashscreen/pull/76


> Implement splashscreen for Windows platform
> ---
>
> Key: CB-8056
> URL: https://issues.apache.org/jira/browse/CB-8056
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen, Windows
>Affects Versions: 3.6.0
>Reporter: Doug Estey
>Assignee: Sergey Shakhnazarov
>  Labels: reproduced, triaged, windows
>
> {code:title=config.xml|borderStyle=solid}
> 
> 
> 
> {code}
> This has no effect on the cordova-windows platform. Splash screen autohides 
> after <1000ms.
> Tested on WP 8.1.
> Let me know if there's any other information I can provide. The documentation 
> for splash screens on 8.1 seems to be somewhat lacking, so I may have missed 
> something somewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8056) Implement splashscreen for Windows platform

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254606#comment-15254606
 ] 

ASF subversion and git services commented on CB-8056:
-

Commit acb45f3a386bbb80d1d52cbe9d26f3de2617bfe0 in 
cordova-plugin-splashscreen's branch refs/heads/master from [~daserge]
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-splashscreen.git;h=acb45f3
 ]

CB-8056 Implement splashscreen for Windows platform

The plugin implementation has been moved to the platform code
Documented SplashScreenBackgroundColor preference for Windows
Updated the docs
Updated plugin dependencies - cordova-windows@5 is required
Updated the plugin version to 4.0.0


> Implement splashscreen for Windows platform
> ---
>
> Key: CB-8056
> URL: https://issues.apache.org/jira/browse/CB-8056
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen, Windows
>Affects Versions: 3.6.0
>Reporter: Doug Estey
>Assignee: Sergey Shakhnazarov
>  Labels: reproduced, triaged, windows
>
> {code:title=config.xml|borderStyle=solid}
> 
> 
> 
> {code}
> This has no effect on the cordova-windows platform. Splash screen autohides 
> after <1000ms.
> Tested on WP 8.1.
> Let me know if there's any other information I can provide. The documentation 
> for splash screens on 8.1 seems to be somewhat lacking, so I may have missed 
> something somewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8056) Implement splashscreen for Windows platform

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254102#comment-15254102
 ] 

ASF GitHub Bot commented on CB-8056:


Github user daserge commented on the pull request:

https://github.com/apache/cordova-windows/pull/141#issuecomment-213476651
  
@chrigi, note that I haven't addressed this:

> It does not set the statusbar color to the splashScreenBackgroundColor

I will file a separate issue for this when the PRs are merged.


> Implement splashscreen for Windows platform
> ---
>
> Key: CB-8056
> URL: https://issues.apache.org/jira/browse/CB-8056
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen, Windows
>Affects Versions: 3.6.0
>Reporter: Doug Estey
>Assignee: Sergey Shakhnazarov
>  Labels: reproduced, triaged, windows
>
> {code:title=config.xml|borderStyle=solid}
> 
> 
> 
> {code}
> This has no effect on the cordova-windows platform. Splash screen autohides 
> after <1000ms.
> Tested on WP 8.1.
> Let me know if there's any other information I can provide. The documentation 
> for splash screens on 8.1 seems to be somewhat lacking, so I may have missed 
> something somewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8056) Implement splashscreen for Windows platform

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254098#comment-15254098
 ] 

ASF GitHub Bot commented on CB-8056:


Github user daserge commented on the pull request:

https://github.com/apache/cordova-windows/pull/141#issuecomment-213475272
  
@SunboX, @chrigi, I've rebased and updated the PRs, could you please try 
how it works for you?
`cordova platform add 
https://github.com/MSOpenTech/cordova-windows#d6988f5c863ec3ba5cde33a678a4b93badc64395`
`cordova plugin add 
https://github.com/MSOpenTech/cordova-plugin-splashscreen#acb45f3a386bbb80d1d52cbe9d26f3de2617bfe0`

Sample config.xml:
```
















```


> Implement splashscreen for Windows platform
> ---
>
> Key: CB-8056
> URL: https://issues.apache.org/jira/browse/CB-8056
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen, Windows
>Affects Versions: 3.6.0
>Reporter: Doug Estey
>Assignee: Sergey Shakhnazarov
>  Labels: reproduced, triaged, windows
>
> {code:title=config.xml|borderStyle=solid}
> 
> 
> 
> {code}
> This has no effect on the cordova-windows platform. Splash screen autohides 
> after <1000ms.
> Tested on WP 8.1.
> Let me know if there's any other information I can provide. The documentation 
> for splash screens on 8.1 seems to be somewhat lacking, so I may have missed 
> something somewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8056) Implement splashscreen for Windows platform

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226840#comment-15226840
 ] 

ASF GitHub Bot commented on CB-8056:


Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-windows/pull/141#issuecomment-205929216
  
This now has conflicts, can we get a rebase and a merge? lgtm!


> Implement splashscreen for Windows platform
> ---
>
> Key: CB-8056
> URL: https://issues.apache.org/jira/browse/CB-8056
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen, Windows
>Affects Versions: 3.6.0
>Reporter: Doug Estey
>Assignee: Sergey Shakhnazarov
>  Labels: reproduced, triaged, windows
>
> {code:title=config.xml|borderStyle=solid}
> 
> 
> 
> {code}
> This has no effect on the cordova-windows platform. Splash screen autohides 
> after <1000ms.
> Tested on WP 8.1.
> Let me know if there's any other information I can provide. The documentation 
> for splash screens on 8.1 seems to be somewhat lacking, so I may have missed 
> something somewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8056) Implement splashscreen for Windows platform

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15188940#comment-15188940
 ] 

ASF GitHub Bot commented on CB-8056:


Github user SunboX commented on the pull request:

https://github.com/apache/cordova-windows/pull/141#issuecomment-194745886
  
> * calling navigator.splashscreen.hide(); does not hide the splash screen 
(Windows 10, Lumia 950, build Cordova 6.0 as UWP 10)

Ok, this was my fault. I had the splashscreen plugin installed 
additionally. Removed it, now it works as expected. Thanks for your work!


> Implement splashscreen for Windows platform
> ---
>
> Key: CB-8056
> URL: https://issues.apache.org/jira/browse/CB-8056
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen, Windows
>Affects Versions: 3.6.0
>Reporter: Doug Estey
>Assignee: Sergey Shakhnazarov
>  Labels: reproduced, triaged, windows
>
> {code:title=config.xml|borderStyle=solid}
> 
> 
> 
> {code}
> This has no effect on the cordova-windows platform. Splash screen autohides 
> after <1000ms.
> Tested on WP 8.1.
> Let me know if there's any other information I can provide. The documentation 
> for splash screens on 8.1 seems to be somewhat lacking, so I may have missed 
> something somewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8056) Implement splashscreen for Windows platform

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15187219#comment-15187219
 ] 

ASF GitHub Bot commented on CB-8056:


Github user SunboX commented on the pull request:

https://github.com/apache/cordova-windows/pull/141#issuecomment-194337561
  
Two comments on this:

* calling `navigator.splashscreen.hide();` does not hide the splash screen 
(Windows 10, Lumia 950, build Cordova 6.0 as UWP 10)
* calling `StatusBar.show();` should not show the status bar while the 
splash screen is shown (and should show the status bar automatically after the 
splash screen gets hidden)


> Implement splashscreen for Windows platform
> ---
>
> Key: CB-8056
> URL: https://issues.apache.org/jira/browse/CB-8056
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen, Windows
>Affects Versions: 3.6.0
>Reporter: Doug Estey
>Assignee: Sergey Shakhnazarov
>  Labels: reproduced, triaged, windows
>
> {code:title=config.xml|borderStyle=solid}
> 
> 
> 
> {code}
> This has no effect on the cordova-windows platform. Splash screen autohides 
> after <1000ms.
> Tested on WP 8.1.
> Let me know if there's any other information I can provide. The documentation 
> for splash screens on 8.1 seems to be somewhat lacking, so I may have missed 
> something somewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8056) Implement splashscreen for Windows platform

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127872#comment-15127872
 ] 

ASF GitHub Bot commented on CB-8056:


Github user chrigi commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-178437613
  
@daserge 
I tried it on Windows Mobile 10 (windows engine) Lumia 950 XL.


> Implement splashscreen for Windows platform
> ---
>
> Key: CB-8056
> URL: https://issues.apache.org/jira/browse/CB-8056
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen, Windows
>Affects Versions: 3.6.0
>Reporter: Doug Estey
>Assignee: Sergey Shakhnazarov
>  Labels: reproduced, triaged, windows
>
> {code:title=config.xml|borderStyle=solid}
> 
> 
> 
> {code}
> This has no effect on the cordova-windows platform. Splash screen autohides 
> after <1000ms.
> Tested on WP 8.1.
> Let me know if there's any other information I can provide. The documentation 
> for splash screens on 8.1 seems to be somewhat lacking, so I may have missed 
> something somewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8056) Implement splashscreen for Windows platform

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15118923#comment-15118923
 ] 

ASF GitHub Bot commented on CB-8056:


Github user SunboX commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/76#discussion_r50958608
  
--- Diff: README.md ---
@@ -123,13 +123,26 @@ window.setTimeout(function () {
 }, splashDuration - fadeDuration);
 ```
 
-### iOS Quirks
+### iOS and Windows Quirks
 
 - `ShowSplashScreenSpinner` (boolean, defaults to `true`): Set to `false`
   to hide the splash-screen spinner.
 
 
 
+### Windows Quirks
+
+- `SplashScreenSpinnerColor` (string, defaults to system accent color): 
hash, rgb notation or CSS color name.
+
+
+
+
+
+- `SplashScreenBackgroundColor` (string, defaults to #464646): hex 
notation.
+
+
+
+
--- End diff --

Shouldn't it be mentioned to add "Scale 100", "Scale 140" and "Scale 180" 
images? (620 x 300 px, 868 x 420 px and 1116 x 540 px, 
https://msdn.microsoft.com/en-us/library/windows/apps/mt187306.aspx)


> Implement splashscreen for Windows platform
> ---
>
> Key: CB-8056
> URL: https://issues.apache.org/jira/browse/CB-8056
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen, Windows
>Affects Versions: 3.6.0
>Reporter: Doug Estey
>Assignee: Sergey Shakhnazarov
>  Labels: reproduced, triaged, windows
>
> {code:title=config.xml|borderStyle=solid}
> 
> 
> 
> {code}
> This has no effect on the cordova-windows platform. Splash screen autohides 
> after <1000ms.
> Tested on WP 8.1.
> Let me know if there's any other information I can provide. The documentation 
> for splash screens on 8.1 seems to be somewhat lacking, so I may have missed 
> something somewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8056) Implement splashscreen for Windows platform

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15118898#comment-15118898
 ] 

ASF GitHub Bot commented on CB-8056:


Github user SunboX commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-175494339
  
That's great! Just was looking for a way how to set the background color 
for UWP splash screen (Windows 10 Mobile). Thanks for your work! :+1: :heart: 


> Implement splashscreen for Windows platform
> ---
>
> Key: CB-8056
> URL: https://issues.apache.org/jira/browse/CB-8056
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen, Windows
>Affects Versions: 3.6.0
>Reporter: Doug Estey
>Assignee: Sergey Shakhnazarov
>  Labels: reproduced, triaged, windows
>
> {code:title=config.xml|borderStyle=solid}
> 
> 
> 
> {code}
> This has no effect on the cordova-windows platform. Splash screen autohides 
> after <1000ms.
> Tested on WP 8.1.
> Let me know if there's any other information I can provide. The documentation 
> for splash screens on 8.1 seems to be somewhat lacking, so I may have missed 
> something somewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8056) Implement splashscreen for Windows platform

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119007#comment-15119007
 ] 

ASF GitHub Bot commented on CB-8056:


Github user daserge commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/76#discussion_r50966450
  
--- Diff: README.md ---
@@ -123,13 +123,26 @@ window.setTimeout(function () {
 }, splashDuration - fadeDuration);
 ```
 
-### iOS Quirks
+### iOS and Windows Quirks
 
 - `ShowSplashScreenSpinner` (boolean, defaults to `true`): Set to `false`
   to hide the splash-screen spinner.
 
 
 
+### Windows Quirks
+
+- `SplashScreenSpinnerColor` (string, defaults to system accent color): 
hash, rgb notation or CSS color name.
+
+
+
+
+
+- `SplashScreenBackgroundColor` (string, defaults to #464646): hex 
notation.
+
+
+
+
--- End diff --

@SunboX, thanks, there is a separate issue for that: 
https://issues.apache.org/jira/browse/CB-9287


> Implement splashscreen for Windows platform
> ---
>
> Key: CB-8056
> URL: https://issues.apache.org/jira/browse/CB-8056
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen, Windows
>Affects Versions: 3.6.0
>Reporter: Doug Estey
>Assignee: Sergey Shakhnazarov
>  Labels: reproduced, triaged, windows
>
> {code:title=config.xml|borderStyle=solid}
> 
> 
> 
> {code}
> This has no effect on the cordova-windows platform. Splash screen autohides 
> after <1000ms.
> Tested on WP 8.1.
> Let me know if there's any other information I can provide. The documentation 
> for splash screens on 8.1 seems to be somewhat lacking, so I may have missed 
> something somewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8056) Implement splashscreen for Windows platform

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15115108#comment-15115108
 ] 

ASF GitHub Bot commented on CB-8056:


Github user daserge commented on the pull request:

https://github.com/apache/cordova-windows/pull/141#issuecomment-174487439
  
@purplecabbage, thanks for reviewing!

The main reason to move the code to the platform was the need to hook into 
activated event so that the initial splash image could be delayed until the 
plugin is configured.

I'm not sure when/if other platforms are going to be rewritten in this way.


> Implement splashscreen for Windows platform
> ---
>
> Key: CB-8056
> URL: https://issues.apache.org/jira/browse/CB-8056
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen, Windows
>Affects Versions: 3.6.0
>Reporter: Doug Estey
>Assignee: Sergey Shakhnazarov
>  Labels: reproduced, triaged, windows
>
> {code:title=config.xml|borderStyle=solid}
> 
> 
> 
> {code}
> This has no effect on the cordova-windows platform. Splash screen autohides 
> after <1000ms.
> Tested on WP 8.1.
> Let me know if there's any other information I can provide. The documentation 
> for splash screens on 8.1 seems to be somewhat lacking, so I may have missed 
> something somewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8056) Implement splashscreen for Windows platform

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109207#comment-15109207
 ] 

ASF GitHub Bot commented on CB-8056:


GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-splashscreen/pull/76

CB-8056 Implement splashscreen for Windows platform

[Jira issue](https://issues.apache.org/jira/browse/CB-8056)

The plugin implementation has been moved to the platform code
Documented SplashScreenBackgroundColor preference for Windows
Updated the docs

Related to apache/cordova-windows#141

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-splashscreen CB-8056

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-splashscreen/pull/76.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #76


commit 5ffb4cb771b11bffc0c4f6a707563b20e7d19613
Author: daserge 
Date:   2016-01-14T16:15:06Z

CB-8056 Implement splashscreen for Windows platform

The plugin implementation has been moved to the platform code
Documented SplashScreenBackgroundColor preference for Windows
Updated the docs




> Implement splashscreen for Windows platform
> ---
>
> Key: CB-8056
> URL: https://issues.apache.org/jira/browse/CB-8056
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen, Windows
>Affects Versions: 3.6.0
>Reporter: Doug Estey
>Assignee: Sergey Shakhnazarov
>  Labels: reproduced, triaged, windows
>
> {code:title=config.xml|borderStyle=solid}
> 
> 
> 
> {code}
> This has no effect on the cordova-windows platform. Splash screen autohides 
> after <1000ms.
> Tested on WP 8.1.
> Let me know if there's any other information I can provide. The documentation 
> for splash screens on 8.1 seems to be somewhat lacking, so I may have missed 
> something somewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8056) Implement splashscreen for Windows platform

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109204#comment-15109204
 ] 

ASF GitHub Bot commented on CB-8056:


GitHub user daserge opened a pull request:

https://github.com/apache/cordova-windows/pull/141

CB-8056 Implement splashscreen for Windows platform

[Jira issue](https://issues.apache.org/jira/browse/CB-8056)

Moved the implementation to the platform as per plugins triage 
recommendation and due to `ui.js` and `WinJS.UI.processAll();` are required for 
Windows Phone implementation as it uses `data-win-control="WinJS.UI.ViewBox"`.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-windows CB-8056

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/141.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #141


commit 03a6d8d45db68ac98b9209c4ffc231affb1cadef
Author: daserge 
Date:   2016-01-20T19:00:56Z

CB-8056 Implement splashscreen for Windows platform




> Implement splashscreen for Windows platform
> ---
>
> Key: CB-8056
> URL: https://issues.apache.org/jira/browse/CB-8056
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen, Windows
>Affects Versions: 3.6.0
>Reporter: Doug Estey
>Assignee: Sergey Shakhnazarov
>  Labels: reproduced, triaged, windows
>
> {code:title=config.xml|borderStyle=solid}
> 
> 
> 
> {code}
> This has no effect on the cordova-windows platform. Splash screen autohides 
> after <1000ms.
> Tested on WP 8.1.
> Let me know if there's any other information I can provide. The documentation 
> for splash screens on 8.1 seems to be somewhat lacking, so I may have missed 
> something somewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8056) Implement splashscreen for Windows platform

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109716#comment-15109716
 ] 

ASF GitHub Bot commented on CB-8056:


Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-windows/pull/141#issuecomment-173398203
  
Is there a link to the conversation around this change? ( I assume it is 
[1] )
Ultimately there are 2 pieces to splash-screen : 
1. the platform/os splash screen built into every app
2. the cordova specific plugin which processes preferences

My understanding is that if you do NOT have the plugin installed, then the 
platform/os splash is presented and dismissed automatically once the app has 
launched. The image(s) used for this can and should be controlled by 
preferences in config.xml and this should be done at build time, moving files, 
renaming files, modifying app manifests, ...

If the splash-screen plugin is installed, we gain the ability to delay 
dismissing the splash screen ( by emulating it with a full screen image which 
quickly replaces the platform/os version )

This is the way things are currently, and I DO completely support moving 
splash-screen management back into the platforms so it can be processed before 
plugins are loaded, I just want to make sure that we are moving on this for all 
platforms and that there has been enough discussion/agreement around it.
I think I expected that each of the plugin audit proposals should spawn 
it's own detailed proposal, but I may be over administering things.  As long as 
we all agree that this is the way forward, and this will be done for all 
platforms; +1

[1] 
https://github.com/cordova/cordova-discuss/pull/28/files#diff-e1c3c74bda464d02680ae112f2927180R175



> Implement splashscreen for Windows platform
> ---
>
> Key: CB-8056
> URL: https://issues.apache.org/jira/browse/CB-8056
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen, Windows
>Affects Versions: 3.6.0
>Reporter: Doug Estey
>Assignee: Sergey Shakhnazarov
>  Labels: reproduced, triaged, windows
>
> {code:title=config.xml|borderStyle=solid}
> 
> 
> 
> {code}
> This has no effect on the cordova-windows platform. Splash screen autohides 
> after <1000ms.
> Tested on WP 8.1.
> Let me know if there's any other information I can provide. The documentation 
> for splash screens on 8.1 seems to be somewhat lacking, so I may have missed 
> something somewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org