[jira] [Commented] (CB-8156) [Contacts] Cancelling pickContact should call the error callback, but callback "nothing" for now

2015-11-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022624#comment-15022624
 ] 

ASF GitHub Bot commented on CB-8156:


Github user purplecabbage commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/84#discussion_r45637931
  
--- Diff: src/windows/ContactProxy.js ---
@@ -242,7 +242,9 @@ module.exports = {
 pickRequest.done(function (contact) {
 // if contact was not picked
 if (!contact) {
-fail && fail(new Error("User did not pick a contact."));
--- End diff --

This looks good.  The implied check for `fail != null` here was unnecessary 
as ALL calls to exec proxies have valid success/error function passed in.


> [Contacts] Cancelling pickContact should call the error callback, but 
> callback "nothing" for now
> 
>
> Key: CB-8156
> URL: https://issues.apache.org/jira/browse/CB-8156
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
> Environment: I using ipad mini 8.1.2 with phonegap 3.6.3 or 3.7.1 and 
> latest contact plugin
>Reporter: Colin Bau
>Assignee: Vladimir Kotikov
>  Labels: android, ios, regression, reproduced, triaged
>
> according to this
> https://issues.apache.org/jira/browse/CB-7772
> it have been solved
> Cancelling pickContact should call the error callback, but callback "nothing" 
> (no any response) for now



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8156) [Contacts] Cancelling pickContact should call the error callback, but callback "nothing" for now

2015-11-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022629#comment-15022629
 ] 

ASF GitHub Bot commented on CB-8156:


Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/84#issuecomment-159016399
  
Looks good, except for the java implementation (re)used error code 5 
instead of the 6 used everywhere else. The added tests should reveal this.


> [Contacts] Cancelling pickContact should call the error callback, but 
> callback "nothing" for now
> 
>
> Key: CB-8156
> URL: https://issues.apache.org/jira/browse/CB-8156
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
> Environment: I using ipad mini 8.1.2 with phonegap 3.6.3 or 3.7.1 and 
> latest contact plugin
>Reporter: Colin Bau
>Assignee: Vladimir Kotikov
>  Labels: android, ios, regression, reproduced, triaged
>
> according to this
> https://issues.apache.org/jira/browse/CB-7772
> it have been solved
> Cancelling pickContact should call the error callback, but callback "nothing" 
> (no any response) for now



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8156) [Contacts] Cancelling pickContact should call the error callback, but callback "nothing" for now

2015-11-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022617#comment-15022617
 ] 

ASF GitHub Bot commented on CB-8156:


Github user purplecabbage commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/84#discussion_r45637648
  
--- Diff: src/android/ContactManager.java ---
@@ -52,6 +52,7 @@ Licensed to the Apache Software Foundation (ASF) under one
 public static final int PENDING_OPERATION_ERROR = 3;
 public static final int IO_ERROR = 4;
 public static final int NOT_SUPPORTED_ERROR = 5;
+public static final int OPERATION_CANCELLED_ERROR = 5;
--- End diff --

Isn't this supposed to be 6 as above, so below?


> [Contacts] Cancelling pickContact should call the error callback, but 
> callback "nothing" for now
> 
>
> Key: CB-8156
> URL: https://issues.apache.org/jira/browse/CB-8156
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
> Environment: I using ipad mini 8.1.2 with phonegap 3.6.3 or 3.7.1 and 
> latest contact plugin
>Reporter: Colin Bau
>Assignee: Vladimir Kotikov
>  Labels: android, ios, regression, reproduced, triaged
>
> according to this
> https://issues.apache.org/jira/browse/CB-7772
> it have been solved
> Cancelling pickContact should call the error callback, but callback "nothing" 
> (no any response) for now



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8156) [Contacts] Cancelling pickContact should call the error callback, but callback "nothing" for now

2015-11-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022638#comment-15022638
 ] 

ASF GitHub Bot commented on CB-8156:


Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/84#issuecomment-159017060
  
One more thing ...
Please add a test for the new constant to 
`contacts.spec.25 ContactError constants should be defined` at 
/tests/tests.js#L473


> [Contacts] Cancelling pickContact should call the error callback, but 
> callback "nothing" for now
> 
>
> Key: CB-8156
> URL: https://issues.apache.org/jira/browse/CB-8156
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
> Environment: I using ipad mini 8.1.2 with phonegap 3.6.3 or 3.7.1 and 
> latest contact plugin
>Reporter: Colin Bau
>Assignee: Vladimir Kotikov
>  Labels: android, ios, regression, reproduced, triaged
>
> according to this
> https://issues.apache.org/jira/browse/CB-7772
> it have been solved
> Cancelling pickContact should call the error callback, but callback "nothing" 
> (no any response) for now



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8156) [Contacts] Cancelling pickContact should call the error callback, but callback "nothing" for now

2015-11-23 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15023942#comment-15023942
 ] 

ASF subversion and git services commented on CB-8156:
-

Commit 039947aab894a0ccf8804f4199e1b0b5a2e9e10c in cordova-plugin-contacts's 
branch refs/heads/master from [~vladimir.kotikov]
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-contacts.git;h=039947a 
]

CB-8156 Call error callback on pickContact cancellation

Also introduce OPERATION_CANCELLED_ERROR as an error code for reporting contact 
picker cancellation.


> [Contacts] Cancelling pickContact should call the error callback, but 
> callback "nothing" for now
> 
>
> Key: CB-8156
> URL: https://issues.apache.org/jira/browse/CB-8156
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
> Environment: I using ipad mini 8.1.2 with phonegap 3.6.3 or 3.7.1 and 
> latest contact plugin
>Reporter: Colin Bau
>Assignee: Vladimir Kotikov
>  Labels: android, ios, regression, reproduced, triaged
>
> according to this
> https://issues.apache.org/jira/browse/CB-7772
> it have been solved
> Cancelling pickContact should call the error callback, but callback "nothing" 
> (no any response) for now



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8156) [Contacts] Cancelling pickContact should call the error callback, but callback "nothing" for now

2015-11-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15023943#comment-15023943
 ] 

ASF GitHub Bot commented on CB-8156:


Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-contacts/pull/84


> [Contacts] Cancelling pickContact should call the error callback, but 
> callback "nothing" for now
> 
>
> Key: CB-8156
> URL: https://issues.apache.org/jira/browse/CB-8156
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
> Environment: I using ipad mini 8.1.2 with phonegap 3.6.3 or 3.7.1 and 
> latest contact plugin
>Reporter: Colin Bau
>Assignee: Vladimir Kotikov
>  Labels: android, ios, regression, reproduced, triaged
>
> according to this
> https://issues.apache.org/jira/browse/CB-7772
> it have been solved
> Cancelling pickContact should call the error callback, but callback "nothing" 
> (no any response) for now



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8156) [Contacts] Cancelling pickContact should call the error callback, but callback "nothing" for now

2015-11-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15023944#comment-15023944
 ] 

ASF GitHub Bot commented on CB-8156:


Github user vladimir-kotikov commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/84#issuecomment-159188305
  
Updated. Thanks for reviewing, @purplecabbage


> [Contacts] Cancelling pickContact should call the error callback, but 
> callback "nothing" for now
> 
>
> Key: CB-8156
> URL: https://issues.apache.org/jira/browse/CB-8156
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
> Environment: I using ipad mini 8.1.2 with phonegap 3.6.3 or 3.7.1 and 
> latest contact plugin
>Reporter: Colin Bau
>Assignee: Vladimir Kotikov
>  Labels: android, ios, regression, reproduced, triaged
>
> according to this
> https://issues.apache.org/jira/browse/CB-7772
> it have been solved
> Cancelling pickContact should call the error callback, but callback "nothing" 
> (no any response) for now



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8156) [Contacts] Cancelling pickContact should call the error callback, but callback "nothing" for now

2015-11-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15020380#comment-15020380
 ] 

ASF GitHub Bot commented on CB-8156:


GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-plugin-contacts/pull/84

CB-8156 Call error callback on pickContact cancellation

Also introduce OPERATION_CANCELLED_ERROR as an error code for reporting 
contact picker cancellation.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-contacts CB-8156

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-contacts/pull/84.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #84


commit d49a9148a23a672dd9ed7e246c48227f9b5653f0
Author: Vladimir Kotikov 
Date:   2015-11-21T09:50:11Z

CB-8156 Call error callback on pickContact cancellation

Also introduce OPERATION_CANCELLED_ERROR as an error code for reporting 
contact picker cancellation.




> [Contacts] Cancelling pickContact should call the error callback, but 
> callback "nothing" for now
> 
>
> Key: CB-8156
> URL: https://issues.apache.org/jira/browse/CB-8156
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
> Environment: I using ipad mini 8.1.2 with phonegap 3.6.3 or 3.7.1 and 
> latest contact plugin
>Reporter: Colin Bau
>Assignee: Vladimir Kotikov
>  Labels: android, ios, regression, reproduced, triaged
>
> according to this
> https://issues.apache.org/jira/browse/CB-7772
> it have been solved
> Cancelling pickContact should call the error callback, but callback "nothing" 
> (no any response) for now



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8156) [Contacts] Cancelling pickContact should call the error callback, but callback "nothing" for now

2015-11-12 Thread Vladimir Kotikov (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002158#comment-15002158
 ] 

Vladimir Kotikov commented on CB-8156:
--

I see the same on Android. The current behaviour is caused by this change to 
cordova-js: https://github.com/apache/cordova-js/pull/98

> [Contacts] Cancelling pickContact should call the error callback, but 
> callback "nothing" for now
> 
>
> Key: CB-8156
> URL: https://issues.apache.org/jira/browse/CB-8156
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
>Affects Versions: 3.7.0, 3.6.3
> Environment: I using ipad mini 8.1.2 with phonegap 3.6.3 or 3.7.1 and 
> latest contact plugin
>Reporter: Colin Bau
>Assignee: Vladimir Kotikov
>  Labels: android, contacts, ios, triaged
>
> according to this
> https://issues.apache.org/jira/browse/CB-7772
> it have been solved
> Cancelling pickContact should call the error callback, but callback "nothing" 
> (no any response) for now



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8156) [Contacts] Cancelling pickContact should call the error callback, but callback nothing for now

2015-05-10 Thread Colin Bau (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537207#comment-14537207
 ] 

Colin Bau commented on CB-8156:
---

it seem solved...

 [Contacts] Cancelling pickContact should call the error callback, but 
 callback nothing for now
 

 Key: CB-8156
 URL: https://issues.apache.org/jira/browse/CB-8156
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin Contacts
Affects Versions: 3.7.0, 3.6.3
 Environment: I using ipad mini 8.1.2 with phonegap 3.6.3 or 3.7.1 and 
 latest contact plugin
Reporter: Colin Bau
  Labels: contacts

 according to this
 https://issues.apache.org/jira/browse/CB-7772
 it have been solved
 Cancelling pickContact should call the error callback, but callback nothing 
 (no any response) for now



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8156) [Contacts] Cancelling pickContact should call the error callback, but callback nothing for now

2015-03-27 Thread Colin Bau (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385126#comment-14385126
 ] 

Colin Bau commented on CB-8156:
---

why this issue still exist
anything unclear ?

 [Contacts] Cancelling pickContact should call the error callback, but 
 callback nothing for now
 

 Key: CB-8156
 URL: https://issues.apache.org/jira/browse/CB-8156
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin Contacts
Affects Versions: 3.7.0, 3.6.3
 Environment: I using ipad mini 8.1.2 with phonegap 3.6.3 or 3.7.1 and 
 latest contact plugin
Reporter: Colin Bau
  Labels: contacts

 according to this
 https://issues.apache.org/jira/browse/CB-7772
 it have been solved
 Cancelling pickContact should call the error callback, but callback nothing 
 (no any response) for now



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8156) [Contacts] Cancelling pickContact should call the error callback, but callback nothing for now

2015-02-26 Thread Colin Bau (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339512#comment-14339512
 ] 

Colin Bau commented on CB-8156:
---

this problem still occur in cordova 3.7 version

 [Contacts] Cancelling pickContact should call the error callback, but 
 callback nothing for now
 

 Key: CB-8156
 URL: https://issues.apache.org/jira/browse/CB-8156
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin Contacts
Affects Versions: 3.7.0, 3.6.3
 Environment: I using ipad mini 8.1.2 with phonegap 3.6.3 and contact 
 plugin 0.2.15
Reporter: Colin Bau
  Labels: contacts

 according to this
 https://issues.apache.org/jira/browse/CB-7772
 it have been solved
 Cancelling pickContact should call the error callback, but callback nothing 
 (no any response) for now



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8156) [Contacts] Cancelling pickContact should call the error callback, but callback nothing for now

2014-12-20 Thread Colin Bau (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254622#comment-14254622
 ] 

Colin Bau commented on CB-8156:
---

is there any feedback or ?

 [Contacts] Cancelling pickContact should call the error callback, but 
 callback nothing for now
 

 Key: CB-8156
 URL: https://issues.apache.org/jira/browse/CB-8156
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin Contacts
 Environment: I using ipad mini 8.1.2 with phonegap 3.6.3 and contact 
 plugin 0.2.15
Reporter: Colin Bau
  Labels: contacts

 according to this
 https://issues.apache.org/jira/browse/CB-7772
 it have been solved
 Cancelling pickContact should call the error callback, but callback nothing 
 (no any response) for now



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org