[jira] [Commented] (CB-8556) handleOpenURL functionality to be removed to a plugin
[ https://issues.apache.org/jira/browse/CB-8556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361380#comment-14361380 ] Shazron Abdullah commented on CB-8556: -- Both UIWebView and WKWebView handle warm and cold starts for the app scheme (handleOpenURL). The plugin is ready for extraction. > handleOpenURL functionality to be removed to a plugin > - > > Key: CB-8556 > URL: https://issues.apache.org/jira/browse/CB-8556 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 4.0.0 >Reporter: Shazron Abdullah > Fix For: 4.0.0 > > > It's already pluginized due to CB-7606 > In 4.0.0, remove the plugin from core and put it in cordova-plugins. > Possibility of release as a core plugin, not sure. > This will include functionality to configure the callback function that is > called, which is currently a global handleOpenURL function. > Remove/edit the note here as well: > https://github.com/apache/cordova-ios/blob/b3c26fcd598da7c84f020f5a6b9309fe638cbb5d/guides/Cordova%20Custom%20URL%20Scheme%20Handling.md -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8556) handleOpenURL functionality to be removed to a plugin
[ https://issues.apache.org/jira/browse/CB-8556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361377#comment-14361377 ] ASF subversion and git services commented on CB-8556: - Commit 5d5588f6926b0aca994ba97935a01e2c89bce855 in cordova-plugins's branch refs/heads/master from [~shazron] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugins.git;h=5d5588f ] CB-8556 - fix handleOpenURL for WKWebViewEngine plugin > handleOpenURL functionality to be removed to a plugin > - > > Key: CB-8556 > URL: https://issues.apache.org/jira/browse/CB-8556 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 4.0.0 >Reporter: Shazron Abdullah > Fix For: 4.0.0 > > > It's already pluginized due to CB-7606 > In 4.0.0, remove the plugin from core and put it in cordova-plugins. > Possibility of release as a core plugin, not sure. > This will include functionality to configure the callback function that is > called, which is currently a global handleOpenURL function. > Remove/edit the note here as well: > https://github.com/apache/cordova-ios/blob/b3c26fcd598da7c84f020f5a6b9309fe638cbb5d/guides/Cordova%20Custom%20URL%20Scheme%20Handling.md -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8556) handleOpenURL functionality to be removed to a plugin
[ https://issues.apache.org/jira/browse/CB-8556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359688#comment-14359688 ] Shazron Abdullah commented on CB-8556: -- http://git-wip-us.apache.org/repos/asf/cordova-ios/commit/2eea1392 > handleOpenURL functionality to be removed to a plugin > - > > Key: CB-8556 > URL: https://issues.apache.org/jira/browse/CB-8556 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 4.0.0 >Reporter: Shazron Abdullah > Fix For: 4.0.0 > > > It's already pluginized due to CB-7606 > In 4.0.0, remove the plugin from core and put it in cordova-plugins. > Possibility of release as a core plugin, not sure. > This will include functionality to configure the callback function that is > called, which is currently a global handleOpenURL function. > Remove/edit the note here as well: > https://github.com/apache/cordova-ios/blob/b3c26fcd598da7c84f020f5a6b9309fe638cbb5d/guides/Cordova%20Custom%20URL%20Scheme%20Handling.md -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8556) handleOpenURL functionality to be removed to a plugin
[
https://issues.apache.org/jira/browse/CB-8556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359666#comment-14359666
]
Shazron Abdullah commented on CB-8556:
--
This is failing on CDVWKWebViewEngine because CDVPageDidLoadNotification is
not posted once the page is loaded.
{code}
[[NSNotificationCenter defaultCenter] postNotification:[NSNotification
notificationWithName:CDVPageDidLoadNotification object:self.webView]];
{code}
> handleOpenURL functionality to be removed to a plugin
> -
>
> Key: CB-8556
> URL: https://issues.apache.org/jira/browse/CB-8556
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
>Affects Versions: 4.0.0
>Reporter: Shazron Abdullah
> Fix For: 4.0.0
>
>
> It's already pluginized due to CB-7606
> In 4.0.0, remove the plugin from core and put it in cordova-plugins.
> Possibility of release as a core plugin, not sure.
> This will include functionality to configure the callback function that is
> called, which is currently a global handleOpenURL function.
> Remove/edit the note here as well:
> https://github.com/apache/cordova-ios/blob/b3c26fcd598da7c84f020f5a6b9309fe638cbb5d/guides/Cordova%20Custom%20URL%20Scheme%20Handling.md
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8556) handleOpenURL functionality to be removed to a plugin
[ https://issues.apache.org/jira/browse/CB-8556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359650#comment-14359650 ] Shazron Abdullah commented on CB-8556: -- Tested on CDVUIWebViewEngine using steps in CB-7606 - works as expected. > handleOpenURL functionality to be removed to a plugin > - > > Key: CB-8556 > URL: https://issues.apache.org/jira/browse/CB-8556 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 4.0.0 >Reporter: Shazron Abdullah > Fix For: 4.0.0 > > > It's already pluginized due to CB-7606 > In 4.0.0, remove the plugin from core and put it in cordova-plugins. > Possibility of release as a core plugin, not sure. > This will include functionality to configure the callback function that is > called, which is currently a global handleOpenURL function. > Remove/edit the note here as well: > https://github.com/apache/cordova-ios/blob/b3c26fcd598da7c84f020f5a6b9309fe638cbb5d/guides/Cordova%20Custom%20URL%20Scheme%20Handling.md -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8556) handleOpenURL functionality to be removed to a plugin
[ https://issues.apache.org/jira/browse/CB-8556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359618#comment-14359618 ] Shazron Abdullah commented on CB-8556: -- Since the plugin code has been altered to support CDVWebViewEngineProtocol and is now async, this must be re-tested to ensure that it works on both cold and warm starts before it is broken out. > handleOpenURL functionality to be removed to a plugin > - > > Key: CB-8556 > URL: https://issues.apache.org/jira/browse/CB-8556 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 4.0.0 >Reporter: Shazron Abdullah > Fix For: 4.0.0 > > > It's already pluginized due to CB-7606 > In 4.0.0, remove the plugin from core and put it in cordova-plugins. > Possibility of release as a core plugin, not sure. > This will include functionality to configure the callback function that is > called, which is currently a global handleOpenURL function. > Remove/edit the note here as well: > https://github.com/apache/cordova-ios/blob/b3c26fcd598da7c84f020f5a6b9309fe638cbb5d/guides/Cordova%20Custom%20URL%20Scheme%20Handling.md -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8556) handleOpenURL functionality to be removed to a plugin
[ https://issues.apache.org/jira/browse/CB-8556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14343438#comment-14343438 ] sandstrom commented on CB-8556: --- I'd vote for a core plugin! In sync with Android, such that the two platforms behaves similarly on custom protocols/urls (to the extent possible). > handleOpenURL functionality to be removed to a plugin > - > > Key: CB-8556 > URL: https://issues.apache.org/jira/browse/CB-8556 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Reporter: Shazron Abdullah > Fix For: 4.0.0 > > > It's already pluginized due to CB-7606 > In 4.0.0, remove the plugin from core and put it in cordova-plugins. > Possibility of release as a core plugin, not sure. > This will include functionality to configure the callback function that is > called, which is currently a global handleOpenURL function. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
