[jira] [Commented] (CB-8634) `cordova platform add git_url` should accept custom branches and check them out
[ https://issues.apache.org/jira/browse/CB-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355124#comment-14355124 ] ASF GitHub Bot commented on CB-8634: Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/210#discussion_r26135743 --- Diff: doc/platform.txt --- @@ -42,6 +45,8 @@ Syntax . url to a git repository containing a platform . major.minor.patch version specifier + + .. name of the branch to checkout after cloning the git repo --- End diff -- Thanks! done. > `cordova platform add git_url` should accept custom branches and check them > out > --- > > Key: CB-8634 > URL: https://issues.apache.org/jira/browse/CB-8634 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > > Currently, adding a platform via a git_url, always checks out the master > branch. It would be great if we could also checkout custom branches (i.e: > pluggable_webview branch) : > `cordova platform add > https://github.com/apache/cordova-android.git#pluggable_webview` -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8634) `cordova platform add git_url` should accept custom branches and check them out
[ https://issues.apache.org/jira/browse/CB-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357756#comment-14357756 ] ASF GitHub Bot commented on CB-8634: Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/180#issuecomment-78390923 This change was merged in. > `cordova platform add git_url` should accept custom branches and check them > out > --- > > Key: CB-8634 > URL: https://issues.apache.org/jira/browse/CB-8634 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > > Currently, adding a platform via a git_url, always checks out the master > branch. It would be great if we could also checkout custom branches (i.e: > pluggable_webview branch) : > `cordova platform add > https://github.com/apache/cordova-android.git#pluggable_webview` -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8634) `cordova platform add git_url` should accept custom branches and check them out
[ https://issues.apache.org/jira/browse/CB-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356680#comment-14356680 ] ASF subversion and git services commented on CB-8634: - Commit 2eaebd89064604e85ebde068b38a4ec080da2e61 in cordova-cli's branch refs/heads/master from [~omefire] [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=2eaebd8 ] CB-8634 Adds docs about support for custom branches for `cordova platform add` This closes #210 > `cordova platform add git_url` should accept custom branches and check them > out > --- > > Key: CB-8634 > URL: https://issues.apache.org/jira/browse/CB-8634 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > > Currently, adding a platform via a git_url, always checks out the master > branch. It would be great if we could also checkout custom branches (i.e: > pluggable_webview branch) : > `cordova platform add > https://github.com/apache/cordova-android.git#pluggable_webview` -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8634) `cordova platform add git_url` should accept custom branches and check them out
[ https://issues.apache.org/jira/browse/CB-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356683#comment-14356683 ] ASF GitHub Bot commented on CB-8634: Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/210 > `cordova platform add git_url` should accept custom branches and check them > out > --- > > Key: CB-8634 > URL: https://issues.apache.org/jira/browse/CB-8634 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > > Currently, adding a platform via a git_url, always checks out the master > branch. It would be great if we could also checkout custom branches (i.e: > pluggable_webview branch) : > `cordova platform add > https://github.com/apache/cordova-android.git#pluggable_webview` -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8634) `cordova platform add git_url` should accept custom branches and check them out
[ https://issues.apache.org/jira/browse/CB-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356679#comment-14356679 ] ASF GitHub Bot commented on CB-8634: Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/180 > `cordova platform add git_url` should accept custom branches and check them > out > --- > > Key: CB-8634 > URL: https://issues.apache.org/jira/browse/CB-8634 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > > Currently, adding a platform via a git_url, always checks out the master > branch. It would be great if we could also checkout custom branches (i.e: > pluggable_webview branch) : > `cordova platform add > https://github.com/apache/cordova-android.git#pluggable_webview` -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8634) `cordova platform add git_url` should accept custom branches and check them out
[ https://issues.apache.org/jira/browse/CB-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14354951#comment-14354951 ] ASF GitHub Bot commented on CB-8634: Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-cli/pull/210#issuecomment-78062091 LGTM > `cordova platform add git_url` should accept custom branches and check them > out > --- > > Key: CB-8634 > URL: https://issues.apache.org/jira/browse/CB-8634 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > > Currently, adding a platform via a git_url, always checks out the master > branch. It would be great if we could also checkout custom branches (i.e: > pluggable_webview branch) : > `cordova platform add > https://github.com/apache/cordova-android.git#pluggable_webview` -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8634) `cordova platform add git_url` should accept custom branches and check them out
[ https://issues.apache.org/jira/browse/CB-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14354949#comment-14354949 ] ASF GitHub Bot commented on CB-8634: Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/180#issuecomment-78062068 LGTM > `cordova platform add git_url` should accept custom branches and check them > out > --- > > Key: CB-8634 > URL: https://issues.apache.org/jira/browse/CB-8634 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > > Currently, adding a platform via a git_url, always checks out the master > branch. It would be great if we could also checkout custom branches (i.e: > pluggable_webview branch) : > `cordova platform add > https://github.com/apache/cordova-android.git#pluggable_webview` -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8634) `cordova platform add git_url` should accept custom branches and check them out
[ https://issues.apache.org/jira/browse/CB-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14354943#comment-14354943 ] ASF GitHub Bot commented on CB-8634: Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/210#discussion_r26124768 --- Diff: doc/platform.txt --- @@ -42,6 +45,8 @@ Syntax . url to a git repository containing a platform . major.minor.patch version specifier + + .. name of the branch to checkout after cloning the git repo --- End diff -- If `#branch` is not specified after repo url, then `master` will be used by default, right? Could you please note this as well. > `cordova platform add git_url` should accept custom branches and check them > out > --- > > Key: CB-8634 > URL: https://issues.apache.org/jira/browse/CB-8634 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > > Currently, adding a platform via a git_url, always checks out the master > branch. It would be great if we could also checkout custom branches (i.e: > pluggable_webview branch) : > `cordova platform add > https://github.com/apache/cordova-android.git#pluggable_webview` -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8634) `cordova platform add git_url` should accept custom branches and check them out
[ https://issues.apache.org/jira/browse/CB-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14354942#comment-14354942 ] ASF GitHub Bot commented on CB-8634: Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/210#discussion_r26124764 --- Diff: doc/platform.txt --- @@ -29,11 +29,14 @@ Manage project platforms Syntax : -|| +|| --- End diff -- :nit: IMHO it's better to use `` instead of `` > `cordova platform add git_url` should accept custom branches and check them > out > --- > > Key: CB-8634 > URL: https://issues.apache.org/jira/browse/CB-8634 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > > Currently, adding a platform via a git_url, always checks out the master > branch. It would be great if we could also checkout custom branches (i.e: > pluggable_webview branch) : > `cordova platform add > https://github.com/apache/cordova-android.git#pluggable_webview` -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8634) `cordova platform add git_url` should accept custom branches and check them out
[ https://issues.apache.org/jira/browse/CB-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353830#comment-14353830 ] ASF GitHub Bot commented on CB-8634: Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/180#issuecomment-77963579 @vladimir-kotikov > `cordova platform add git_url` should accept custom branches and check them > out > --- > > Key: CB-8634 > URL: https://issues.apache.org/jira/browse/CB-8634 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > > Currently, adding a platform via a git_url, always checks out the master > branch. It would be great if we could also checkout custom branches (i.e: > pluggable_webview branch) : > `cordova platform add > https://github.com/apache/cordova-android.git#pluggable_webview` -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8634) `cordova platform add git_url` should accept custom branches and check them out
[ https://issues.apache.org/jira/browse/CB-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353828#comment-14353828 ] ASF GitHub Bot commented on CB-8634: Github user omefire commented on the pull request: https://github.com/apache/cordova-cli/pull/210#issuecomment-77963561 @vladimir-kotikov > `cordova platform add git_url` should accept custom branches and check them > out > --- > > Key: CB-8634 > URL: https://issues.apache.org/jira/browse/CB-8634 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > > Currently, adding a platform via a git_url, always checks out the master > branch. It would be great if we could also checkout custom branches (i.e: > pluggable_webview branch) : > `cordova platform add > https://github.com/apache/cordova-android.git#pluggable_webview` -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8634) `cordova platform add git_url` should accept custom branches and check them out
[ https://issues.apache.org/jira/browse/CB-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353341#comment-14353341 ] ASF GitHub Bot commented on CB-8634: Github user omefire commented on the pull request: https://github.com/apache/cordova-cli/pull/210#issuecomment-77913235 Related PR: https://github.com/apache/cordova-lib/pull/180 > `cordova platform add git_url` should accept custom branches and check them > out > --- > > Key: CB-8634 > URL: https://issues.apache.org/jira/browse/CB-8634 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > > Currently, adding a platform via a git_url, always checks out the master > branch. It would be great if we could also checkout custom branches (i.e: > pluggable_webview branch) : > `cordova platform add > https://github.com/apache/cordova-android.git#pluggable_webview` -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8634) `cordova platform add git_url` should accept custom branches and check them out
[ https://issues.apache.org/jira/browse/CB-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353336#comment-14353336 ] ASF GitHub Bot commented on CB-8634: GitHub user omefire opened a pull request: https://github.com/apache/cordova-cli/pull/210 CB-8634 `cordova platform add git_url` should accept custom branches and check them out CB-8634 `cordova platform add git_url` should accept custom branches and check them out You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-cli CB-8634 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-cli/pull/210.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #210 commit 9335c438327bcdfbe90baf2bc8ad6a44ef6af9c2 Author: Omar Mefire Date: 2015-03-09T18:23:27Z CB-8634 Document custom-branch option to > `cordova platform add git_url` should accept custom branches and check them > out > --- > > Key: CB-8634 > URL: https://issues.apache.org/jira/browse/CB-8634 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > > Currently, adding a platform via a git_url, always checks out the master > branch. It would be great if we could also checkout custom branches (i.e: > pluggable_webview branch) : > `cordova platform add > https://github.com/apache/cordova-android.git#pluggable_webview` -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8634) `cordova platform add git_url` should accept custom branches and check them out
[ https://issues.apache.org/jira/browse/CB-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353340#comment-14353340 ] ASF GitHub Bot commented on CB-8634: Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/180#issuecomment-77913170 Yes, it does need to be documented : https://github.com/apache/cordova-cli/pull/210 > `cordova platform add git_url` should accept custom branches and check them > out > --- > > Key: CB-8634 > URL: https://issues.apache.org/jira/browse/CB-8634 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > > Currently, adding a platform via a git_url, always checks out the master > branch. It would be great if we could also checkout custom branches (i.e: > pluggable_webview branch) : > `cordova platform add > https://github.com/apache/cordova-android.git#pluggable_webview` -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8634) `cordova platform add git_url` should accept custom branches and check them out
[ https://issues.apache.org/jira/browse/CB-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352326#comment-14352326 ] ASF GitHub Bot commented on CB-8634: GitHub user omefire opened a pull request: https://github.com/apache/cordova-lib/pull/180 CB-8634 : `cordova platform add git_url#custom_branch` support for custom branches CB-8634 : `cordova platform add git_url#custom_branch` support for custom branches You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-8634 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/180.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #180 commit 3c7ea3bcf54a910182252455d494d80af66e582d Author: Omar Mefire Date: 2015-03-08T22:53:38Z CB-8634 : support for custom branches > `cordova platform add git_url` should accept custom branches and check them > out > --- > > Key: CB-8634 > URL: https://issues.apache.org/jira/browse/CB-8634 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > > Currently, adding a platform via a git_url, always checks out the master > branch. It would be great if we could also checkout custom branches (i.e: > pluggable_webview branch) : > `cordova platform add > https://github.com/apache/cordova-android.git#pluggable_webview` -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
