[jira] [Commented] (CB-8694) Replace dependency plugin with plugin list parameter in createmobilespec
[
https://issues.apache.org/jira/browse/CB-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388485#comment-14388485
]
Ian Clelland commented on CB-8694:
--
I think that this patch has introduced a command-line parsing error:
I tried this morning to create mobile spec with the command line:
{code}
createmobilespec.js --ios --android --plugins cb8739
{code}
Where {{cb8739}} is the name of the project to create (I checked the man page,
and the code, and I definitely didn't use {{--plugins=cb8739}})
{{createmobilespec.js}} interpreted the project name as a plugin name, and
tried to download it from the registry.
I had to switch the parameter order around to get it to build properly:
{code}
createmobilespec.js --android --plugins --ios cb8739
{code}
Replace dependency plugin with plugin list parameter in createmobilespec
Key: CB-8694
URL: https://issues.apache.org/jira/browse/CB-8694
Project: Apache Cordova
Issue Type: Improvement
Components: mobile-spec
Reporter: Alexander Sorokin
Priority: Minor
Now createmobilespec uses dependency plugin to specify the list of plugins to
install.
This approach has some limitations, for example after the app is created the
user cannot remove particular plugin because they all are listed as
dependencies of dependency plugin.
Though developers could want to add custom plugin(s) to mobile spec for
testing. Also some plugins could not be supported under particular platform
and should not be installed.
My proposal is to replace dependency plugin with new command line parameter
for createmobilespec to specify plugin list through CLI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8694) Replace dependency plugin with plugin list parameter in createmobilespec
[ https://issues.apache.org/jira/browse/CB-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14371080#comment-14371080 ] ASF GitHub Bot commented on CB-8694: Github user asfgit closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/123 Replace dependency plugin with plugin list parameter in createmobilespec Key: CB-8694 URL: https://issues.apache.org/jira/browse/CB-8694 Project: Apache Cordova Issue Type: Improvement Components: mobile-spec Reporter: Alexander Sorokin Priority: Minor Now createmobilespec uses dependency plugin to specify the list of plugins to install. This approach has some limitations, for example after the app is created the user cannot remove particular plugin because they all are listed as dependencies of dependency plugin. Though developers could want to add custom plugin(s) to mobile spec for testing. Also some plugins could not be supported under particular platform and should not be installed. My proposal is to replace dependency plugin with new command line parameter for createmobilespec to specify plugin list through CLI. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8694) Replace dependency plugin with plugin list parameter in createmobilespec
[ https://issues.apache.org/jira/browse/CB-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14371079#comment-14371079 ] ASF subversion and git services commented on CB-8694: - Commit ac1b637baac3ac8ae65980e4db255af169ac38cc in cordova-mobile-spec's branch refs/heads/master from [~alsorokin] [ https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;h=ac1b637 ] CB-8694 Replaced dependencies plugin with command line parameter github close #123 Replace dependency plugin with plugin list parameter in createmobilespec Key: CB-8694 URL: https://issues.apache.org/jira/browse/CB-8694 Project: Apache Cordova Issue Type: Improvement Components: mobile-spec Reporter: Alexander Sorokin Priority: Minor Now createmobilespec uses dependency plugin to specify the list of plugins to install. This approach has some limitations, for example after the app is created the user cannot remove particular plugin because they all are listed as dependencies of dependency plugin. Though developers could want to add custom plugin(s) to mobile spec for testing. Also some plugins could not be supported under particular platform and should not be installed. My proposal is to replace dependency plugin with new command line parameter for createmobilespec to specify plugin list through CLI. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8694) Replace dependency plugin with plugin list parameter in createmobilespec
[ https://issues.apache.org/jira/browse/CB-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14366854#comment-14366854 ] ASF GitHub Bot commented on CB-8694: Github user alsorokin commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/123#issuecomment-82833050 @dblotsky Ah, it couldn't locate mobilespec tests, thanks for pointing that out! Fixed it. Replace dependency plugin with plugin list parameter in createmobilespec Key: CB-8694 URL: https://issues.apache.org/jira/browse/CB-8694 Project: Apache Cordova Issue Type: Improvement Components: mobile-spec Reporter: Alexander Sorokin Priority: Minor Now createmobilespec uses dependency plugin to specify the list of plugins to install. This approach has some limitations, for example after the app is created the user cannot remove particular plugin because they all are listed as dependencies of dependency plugin. Though developers could want to add custom plugin(s) to mobile spec for testing. Also some plugins could not be supported under particular platform and should not be installed. My proposal is to replace dependency plugin with new command line parameter for createmobilespec to specify plugin list through CLI. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8694) Replace dependency plugin with plugin list parameter in createmobilespec
[ https://issues.apache.org/jira/browse/CB-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14367638#comment-14367638 ] ASF GitHub Bot commented on CB-8694: Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/123#issuecomment-83116032 Tested on my end. LGTM. Replace dependency plugin with plugin list parameter in createmobilespec Key: CB-8694 URL: https://issues.apache.org/jira/browse/CB-8694 Project: Apache Cordova Issue Type: Improvement Components: mobile-spec Reporter: Alexander Sorokin Priority: Minor Now createmobilespec uses dependency plugin to specify the list of plugins to install. This approach has some limitations, for example after the app is created the user cannot remove particular plugin because they all are listed as dependencies of dependency plugin. Though developers could want to add custom plugin(s) to mobile spec for testing. Also some plugins could not be supported under particular platform and should not be installed. My proposal is to replace dependency plugin with new command line parameter for createmobilespec to specify plugin list through CLI. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8694) Replace dependency plugin with plugin list parameter in createmobilespec
[ https://issues.apache.org/jira/browse/CB-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14365717#comment-14365717 ] ASF GitHub Bot commented on CB-8694: Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/123#issuecomment-82510437 This fails to get tests when `--plugins` is specified. Also, this is a major breaking change to any tool or person that depends on modifying the dependencies plugin. Replace dependency plugin with plugin list parameter in createmobilespec Key: CB-8694 URL: https://issues.apache.org/jira/browse/CB-8694 Project: Apache Cordova Issue Type: Improvement Components: mobile-spec Reporter: Alexander Sorokin Priority: Minor Now createmobilespec uses dependency plugin to specify the list of plugins to install. This approach has some limitations, for example after the app is created the user cannot remove particular plugin because they all are listed as dependencies of dependency plugin. Though developers could want to add custom plugin(s) to mobile spec for testing. Also some plugins could not be supported under particular platform and should not be installed. My proposal is to replace dependency plugin with new command line parameter for createmobilespec to specify plugin list through CLI. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8694) Replace dependency plugin with plugin list parameter in createmobilespec
[ https://issues.apache.org/jira/browse/CB-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14365523#comment-14365523 ] ASF GitHub Bot commented on CB-8694: GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/123 CB-8694 Replaced dependencies plugin with command line parameter https://issues.apache.org/jira/browse/CB-8694 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-mobile-spec CB-8694 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-mobile-spec/pull/123.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #123 commit d0468fa97a545f8e5d1df5bdbe6d73b88a05f420 Author: alsorokin alexander.soro...@akvelon.com Date: 2015-03-17T16:56:38Z CB-8694 Replaced dependencies plugin with command line parameter Replace dependency plugin with plugin list parameter in createmobilespec Key: CB-8694 URL: https://issues.apache.org/jira/browse/CB-8694 Project: Apache Cordova Issue Type: Improvement Components: mobile-spec Reporter: Alexander Sorokin Priority: Minor Now createmobilespec uses dependency plugin to specify the list of plugins to install. This approach has some limitations, for example after the app is created the user cannot remove particular plugin because they all are listed as dependencies of dependency plugin. Though developers could want to add custom plugin(s) to mobile spec for testing. Also some plugins could not be supported under particular platform and should not be installed. My proposal is to replace dependency plugin with new command line parameter for createmobilespec to specify plugin list through CLI. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8694) Replace dependency plugin with plugin list parameter in createmobilespec
[ https://issues.apache.org/jira/browse/CB-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14365559#comment-14365559 ] ASF GitHub Bot commented on CB-8694: Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/123#issuecomment-82486029 LGTM Replace dependency plugin with plugin list parameter in createmobilespec Key: CB-8694 URL: https://issues.apache.org/jira/browse/CB-8694 Project: Apache Cordova Issue Type: Improvement Components: mobile-spec Reporter: Alexander Sorokin Priority: Minor Now createmobilespec uses dependency plugin to specify the list of plugins to install. This approach has some limitations, for example after the app is created the user cannot remove particular plugin because they all are listed as dependencies of dependency plugin. Though developers could want to add custom plugin(s) to mobile spec for testing. Also some plugins could not be supported under particular platform and should not be installed. My proposal is to replace dependency plugin with new command line parameter for createmobilespec to specify plugin list through CLI. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
