[jira] [Commented] (CB-8819) [WP8] FileReader readAsBinaryString doesn't read file correctly

2015-04-14 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-8819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493773#comment-14493773
 ] 

ASF GitHub Bot commented on CB-8819:


Github user alsorokin closed the pull request at:

https://github.com/apache/cordova-plugin-file/pull/108


> [WP8] FileReader readAsBinaryString doesn't read file correctly
> ---
>
> Key: CB-8819
> URL: https://issues.apache.org/jira/browse/CB-8819
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File, WP8
>Reporter: Alexander Sorokin
>Assignee: Jesse MacFadyen
>
> This issue can be seen in file.spec.86 in mobilespec.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-8819) [WP8] FileReader readAsBinaryString doesn't read file correctly

2015-04-14 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-8819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493765#comment-14493765
 ] 

ASF GitHub Bot commented on CB-8819:


Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-plugin-file/pull/108#issuecomment-92690268
  
Merged to master in 
https://github.com/apache/cordova-plugin-file/commit/6f20c19263df80b4bc5aebc1d75e7567d105b2bf
 @alsorokin, could you please close this


> [WP8] FileReader readAsBinaryString doesn't read file correctly
> ---
>
> Key: CB-8819
> URL: https://issues.apache.org/jira/browse/CB-8819
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File, WP8
>Reporter: Alexander Sorokin
>Assignee: Jesse MacFadyen
>
> This issue can be seen in file.spec.86 in mobilespec.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-8819) [WP8] FileReader readAsBinaryString doesn't read file correctly

2015-04-14 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-8819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493761#comment-14493761
 ] 

ASF subversion and git services commented on CB-8819:
-

Commit 6f20c19263df80b4bc5aebc1d75e7567d105b2bf in cordova-plugin-file's branch 
refs/heads/master from [~alsorokin]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=6f20c19 ]

CB-8819 Fixed FileReader's readAsBinaryString on wp8


> [WP8] FileReader readAsBinaryString doesn't read file correctly
> ---
>
> Key: CB-8819
> URL: https://issues.apache.org/jira/browse/CB-8819
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File, WP8
>Reporter: Alexander Sorokin
>Assignee: Jesse MacFadyen
>
> This issue can be seen in file.spec.86 in mobilespec.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-8819) [WP8] FileReader readAsBinaryString doesn't read file correctly

2015-04-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-8819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492944#comment-14492944
 ] 

ASF GitHub Bot commented on CB-8819:


Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-plugin-file/pull/108#issuecomment-92473706
  
Ran on my machine and verified that it works. LGTM.


> [WP8] FileReader readAsBinaryString doesn't read file correctly
> ---
>
> Key: CB-8819
> URL: https://issues.apache.org/jira/browse/CB-8819
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File, WP8
>Reporter: Alexander Sorokin
>Assignee: Jesse MacFadyen
>
> This issue can be seen in file.spec.86 in mobilespec.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-8819) [WP8] FileReader readAsBinaryString doesn't read file correctly

2015-04-09 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-8819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486984#comment-14486984
 ] 

ASF GitHub Bot commented on CB-8819:


GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-file/pull/108

CB-8819 Fixed FileReader's readAsBinaryString on wp8

https://issues.apache.org/jira/browse/CB-8819

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-file CB-8819

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file/pull/108.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #108


commit e7ed41d478ad71864b14c16dcfb3e534f958d08d
Author: alsorokin 
Date:   2015-04-08T15:50:58Z

CB-8819 Fixed FileReader's readAsBinaryString on wp8




> [WP8] FileReader readAsBinaryString doesn't read file correctly
> ---
>
> Key: CB-8819
> URL: https://issues.apache.org/jira/browse/CB-8819
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File, WP8
>Reporter: Alexander Sorokin
>Assignee: Jesse MacFadyen
>
> This issue can be seen in file.spec.86 in mobilespec.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org