[jira] [Commented] (CB-8940) [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI Elements (header / footer)
[
https://issues.apache.org/jira/browse/CB-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15014995#comment-15014995
]
ASF subversion and git services commented on CB-8940:
-
Commit ef5484a2aa72e63c2ad95d5533db6f25ed53e5c7 in cordova-plugin-camera's
branch refs/heads/master from [~rakatyal]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-camera.git;h=ef5484a
]
CB-8940 Setting z-index values to maximum for UI buttons. This closes #140.
> [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI
> Elements (header / footer)
> -
>
> Key: CB-8940
> URL: https://issues.apache.org/jira/browse/CB-8940
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Camera
>Affects Versions: 4.1.0
> Environment: Windows Emulator / Nokia Lumia 920
>Reporter: david marshall
>Assignee: Raghav
> Labels: windows
>
> Changing the values in CameraProxy.js to below works a treat
> // z-index style element for capturePreview and captureCancelButton elts
> // is necessary to avoid overriding by another page
> elements, -1 sometimes is not enough
> capturePreview.style.cssText = "position: fixed; left: 0;
> top: 0; width: 100%; height: 100%; z-index: ";
> // Create cancel button
> captureCancelButton = document.createElement("button");
> captureCancelButton.innerText = "Cancel";
> captureCancelButton.style.cssText = "position: fixed;
> right: 0; bottom: 0; display: block; margin: 20px; z-index: 1";
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8940) [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI Elements (header / footer)
[
https://issues.apache.org/jira/browse/CB-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15014996#comment-15014996
]
ASF GitHub Bot commented on CB-8940:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/140
> [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI
> Elements (header / footer)
> -
>
> Key: CB-8940
> URL: https://issues.apache.org/jira/browse/CB-8940
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Camera
>Affects Versions: 4.1.0
> Environment: Windows Emulator / Nokia Lumia 920
>Reporter: david marshall
>Assignee: Raghav
> Labels: windows
>
> Changing the values in CameraProxy.js to below works a treat
> // z-index style element for capturePreview and captureCancelButton elts
> // is necessary to avoid overriding by another page
> elements, -1 sometimes is not enough
> capturePreview.style.cssText = "position: fixed; left: 0;
> top: 0; width: 100%; height: 100%; z-index: ";
> // Create cancel button
> captureCancelButton = document.createElement("button");
> captureCancelButton.innerText = "Cancel";
> captureCancelButton.style.cssText = "position: fixed;
> right: 0; bottom: 0; display: block; margin: 20px; z-index: 1";
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8940) [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI Elements (header / footer)
[
https://issues.apache.org/jira/browse/CB-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15014902#comment-15014902
]
ASF GitHub Bot commented on CB-8940:
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/140#issuecomment-158245865
Agree with above. Otherwise, LGTM. Tested on an 8.1 device (and by tested I
mean I took a picture, not really sure what else to do here). I don't really
see how this can mess anything up.
> [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI
> Elements (header / footer)
> -
>
> Key: CB-8940
> URL: https://issues.apache.org/jira/browse/CB-8940
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Camera
>Affects Versions: 4.1.0
> Environment: Windows Emulator / Nokia Lumia 920
>Reporter: david marshall
>Assignee: Raghav
> Labels: windows
>
> Changing the values in CameraProxy.js to below works a treat
> // z-index style element for capturePreview and captureCancelButton elts
> // is necessary to avoid overriding by another page
> elements, -1 sometimes is not enough
> capturePreview.style.cssText = "position: fixed; left: 0;
> top: 0; width: 100%; height: 100%; z-index: ";
> // Create cancel button
> captureCancelButton = document.createElement("button");
> captureCancelButton.innerText = "Cancel";
> captureCancelButton.style.cssText = "position: fixed;
> right: 0; bottom: 0; display: block; margin: 20px; z-index: 1";
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8940) [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI Elements (header / footer)
[
https://issues.apache.org/jira/browse/CB-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15014866#comment-15014866
]
ASF GitHub Bot commented on CB-8940:
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/140#issuecomment-158243766
Good suggestion.
> [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI
> Elements (header / footer)
> -
>
> Key: CB-8940
> URL: https://issues.apache.org/jira/browse/CB-8940
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Camera
>Affects Versions: 4.1.0
> Environment: Windows Emulator / Nokia Lumia 920
>Reporter: david marshall
>Assignee: Raghav
> Labels: windows
>
> Changing the values in CameraProxy.js to below works a treat
> // z-index style element for capturePreview and captureCancelButton elts
> // is necessary to avoid overriding by another page
> elements, -1 sometimes is not enough
> capturePreview.style.cssText = "position: fixed; left: 0;
> top: 0; width: 100%; height: 100%; z-index: ";
> // Create cancel button
> captureCancelButton = document.createElement("button");
> captureCancelButton.innerText = "Cancel";
> captureCancelButton.style.cssText = "position: fixed;
> right: 0; bottom: 0; display: block; margin: 20px; z-index: 1";
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8940) [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI Elements (header / footer)
[
https://issues.apache.org/jira/browse/CB-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15014853#comment-15014853
]
ASF GitHub Bot commented on CB-8940:
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/140#issuecomment-158243037
You could place the value into a constant named `HIGHEST_POSSIBLE_Z_INDEX`,
and then it would be both documented and easier to maintain.
> [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI
> Elements (header / footer)
> -
>
> Key: CB-8940
> URL: https://issues.apache.org/jira/browse/CB-8940
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Camera
>Affects Versions: 4.1.0
> Environment: Windows Emulator / Nokia Lumia 920
>Reporter: david marshall
>Assignee: Raghav
> Labels: windows
>
> Changing the values in CameraProxy.js to below works a treat
> // z-index style element for capturePreview and captureCancelButton elts
> // is necessary to avoid overriding by another page
> elements, -1 sometimes is not enough
> capturePreview.style.cssText = "position: fixed; left: 0;
> top: 0; width: 100%; height: 100%; z-index: ";
> // Create cancel button
> captureCancelButton = document.createElement("button");
> captureCancelButton.innerText = "Cancel";
> captureCancelButton.style.cssText = "position: fixed;
> right: 0; bottom: 0; display: block; margin: 20px; z-index: 1";
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8940) [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI Elements (header / footer)
[
https://issues.apache.org/jira/browse/CB-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15012100#comment-15012100
]
ASF GitHub Bot commented on CB-8940:
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/140#issuecomment-157877274
This is the max value for signed 32 bit integer which the browsers use to
store z-index. If they use anything above this, it's changed to this value.
Do we still need to document this?
> [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI
> Elements (header / footer)
> -
>
> Key: CB-8940
> URL: https://issues.apache.org/jira/browse/CB-8940
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Camera
>Affects Versions: 4.1.0
> Environment: Windows Emulator / Nokia Lumia 920
>Reporter: david marshall
>Assignee: Raghav
> Labels: windows
>
> Changing the values in CameraProxy.js to below works a treat
> // z-index style element for capturePreview and captureCancelButton elts
> // is necessary to avoid overriding by another page
> elements, -1 sometimes is not enough
> capturePreview.style.cssText = "position: fixed; left: 0;
> top: 0; width: 100%; height: 100%; z-index: ";
> // Create cancel button
> captureCancelButton = document.createElement("button");
> captureCancelButton.innerText = "Cancel";
> captureCancelButton.style.cssText = "position: fixed;
> right: 0; bottom: 0; display: block; margin: 20px; z-index: 1";
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8940) [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI Elements (header / footer)
[
https://issues.apache.org/jira/browse/CB-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15012071#comment-15012071
]
ASF GitHub Bot commented on CB-8940:
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/140#issuecomment-157875931
What happens when someone puts something at 2147483648?
My only complaint is the seemingly random magic number use, and the fact
that it 'implies' the topmost layer depth, even though there is no guarantee of
that.
Can you add documentation of the quirk that developers should not place
content at a z-index > 2147483645 when using this plugin?
> [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI
> Elements (header / footer)
> -
>
> Key: CB-8940
> URL: https://issues.apache.org/jira/browse/CB-8940
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Camera
>Affects Versions: 4.1.0
> Environment: Windows Emulator / Nokia Lumia 920
>Reporter: david marshall
>Assignee: Raghav
> Labels: windows
>
> Changing the values in CameraProxy.js to below works a treat
> // z-index style element for capturePreview and captureCancelButton elts
> // is necessary to avoid overriding by another page
> elements, -1 sometimes is not enough
> capturePreview.style.cssText = "position: fixed; left: 0;
> top: 0; width: 100%; height: 100%; z-index: ";
> // Create cancel button
> captureCancelButton = document.createElement("button");
> captureCancelButton.innerText = "Cancel";
> captureCancelButton.style.cssText = "position: fixed;
> right: 0; bottom: 0; display: block; margin: 20px; z-index: 1";
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8940) [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI Elements (header / footer)
[
https://issues.apache.org/jira/browse/CB-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011717#comment-15011717
]
Raghav commented on CB-8940:
Okay I found certain jquery libraries which use z-index values of 1000 and 1100
for their UI elements.
Thanks for bringing this issue up.
> [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI
> Elements (header / footer)
> -
>
> Key: CB-8940
> URL: https://issues.apache.org/jira/browse/CB-8940
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Camera
>Affects Versions: 4.1.0
> Environment: Windows Emulator / Nokia Lumia 920
>Reporter: david marshall
>Assignee: Raghav
> Labels: windows
>
> Changing the values in CameraProxy.js to below works a treat
> // z-index style element for capturePreview and captureCancelButton elts
> // is necessary to avoid overriding by another page
> elements, -1 sometimes is not enough
> capturePreview.style.cssText = "position: fixed; left: 0;
> top: 0; width: 100%; height: 100%; z-index: ";
> // Create cancel button
> captureCancelButton = document.createElement("button");
> captureCancelButton.innerText = "Cancel";
> captureCancelButton.style.cssText = "position: fixed;
> right: 0; bottom: 0; display: block; margin: 20px; z-index: 1";
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8940) [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI Elements (header / footer)
[
https://issues.apache.org/jira/browse/CB-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003285#comment-15003285
]
Raghav commented on CB-8940:
I couldn't repro this with the standard libraries. Standard z-index range from
1 to early multiples of hundreds. Can you specify the framework you are using?
Also since there is practically no limit to z-index value, do you think even
bumping it further up makes this problem solvable?
> [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI
> Elements (header / footer)
> -
>
> Key: CB-8940
> URL: https://issues.apache.org/jira/browse/CB-8940
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Camera
>Affects Versions: 4.1.0
> Environment: Windows Emulator / Nokia Lumia 920
>Reporter: david marshall
>Assignee: Raghav
>
> Changing the values in CameraProxy.js to below works a treat
> // z-index style element for capturePreview and captureCancelButton elts
> // is necessary to avoid overriding by another page
> elements, -1 sometimes is not enough
> capturePreview.style.cssText = "position: fixed; left: 0;
> top: 0; width: 100%; height: 100%; z-index: ";
> // Create cancel button
> captureCancelButton = document.createElement("button");
> captureCancelButton.innerText = "Cancel";
> captureCancelButton.style.cssText = "position: fixed;
> right: 0; bottom: 0; display: block; margin: 20px; z-index: 1";
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8940) [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI Elements (header / footer)
[
https://issues.apache.org/jira/browse/CB-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14523411#comment-14523411
]
Murat Sutunc commented on CB-8940:
--
Is there a framework out there that uses values higher than 999 & 1000?
> [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI
> Elements (header / footer)
> -
>
> Key: CB-8940
> URL: https://issues.apache.org/jira/browse/CB-8940
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Camera
>Affects Versions: 4.1.0
> Environment: Windows Emulator / Nokia Lumia 920
>Reporter: david marshall
>
> Changing the values in CameraProxy.js to below works a treat
> // z-index style element for capturePreview and captureCancelButton elts
> // is necessary to avoid overriding by another page
> elements, -1 sometimes is not enough
> capturePreview.style.cssText = "position: fixed; left: 0;
> top: 0; width: 100%; height: 100%; z-index: ";
> // Create cancel button
> captureCancelButton = document.createElement("button");
> captureCancelButton.innerText = "Cancel";
> captureCancelButton.style.cssText = "position: fixed;
> right: 0; bottom: 0; display: block; margin: 20px; z-index: 1";
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
