[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968367#comment-15968367
 ] 

ASF GitHub Bot commented on CB-8978:


Github user shazron commented on the issue:

https://github.com/apache/cordova-lib/pull/468
  
@stevengill Can I assume support for this feature is out in the 
cordova@6.5.0 release?


> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968349#comment-15968349
 ] 

ASF GitHub Bot commented on CB-8978:


Github user dpogue commented on the issue:

https://github.com/apache/cordova-android/pull/321
  
It is in cordova-android@6.2.1.
No docs yet (wanted to get it supported in more platforms first), but it 
works exactly the same way that it does in plugin.xml.


> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968347#comment-15968347
 ] 

ASF GitHub Bot commented on CB-8978:


Github user shazron commented on the issue:

https://github.com/apache/cordova-android/pull/321
  
@dpogue @infil00p  is this out in the latest cordova-android? Are there 
docs for this, or is it a copy-paste from plugin.xml?


> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944552#comment-15944552
 ] 

ASF GitHub Bot commented on CB-8978:


Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/321


> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944550#comment-15944550
 ] 

ASF subversion and git services commented on CB-8978:
-

Commit 0df50c3f33e94faad04ca8133bc6d9fa753cff4d in cordova-android's branch 
refs/heads/master from [~dpogue]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=0df50c3 ]

CB-8978 Prepare copy resource-files from config.xml

 This closes #321


> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892757#comment-15892757
 ] 

ASF GitHub Bot commented on CB-8978:


Github user dpogue commented on the issue:

https://github.com/apache/cordova-android/pull/321
  
cordova-common@2.0.0 is released now, which was the prerequisite for this.
Should we bump the cordova-common dependency in package.json and merge this 
in for the next Android release?


> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15827243#comment-15827243
 ] 

ASF subversion and git services commented on CB-8978:
-

Commit 2bf351704f6a1145fa0372348a124137a9f2a287 in cordova-lib's branch 
refs/heads/fetch-1.0.x from [~dpogue]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=2bf3517 ]

CB-8978 Add resource-file parsing to config.xml

 This closes #468


> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826698#comment-15826698
 ] 

ASF GitHub Bot commented on CB-8978:


Github user dpogue commented on the issue:

https://github.com/apache/cordova-android/pull/321
  
Yeah, I'm going to try to get it set up locally with cordova-common master 
and ensure it's all working as intended


> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826696#comment-15826696
 ] 

ASF GitHub Bot commented on CB-8978:


Github user stevengill commented on the issue:

https://github.com/apache/cordova-android/pull/321
  
Needs review with master cordova-common. Aka cordova-common@2 (releasing 
soon)


> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826524#comment-15826524
 ] 

ASF GitHub Bot commented on CB-8978:


Github user ktop commented on the issue:

https://github.com/apache/cordova-lib/pull/214
  
Yep, thanks. 


> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826525#comment-15826525
 ] 

ASF GitHub Bot commented on CB-8978:


Github user ktop closed the pull request at:

https://github.com/apache/cordova-lib/pull/214


> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826510#comment-15826510
 ] 

ASF GitHub Bot commented on CB-8978:


Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/468


> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826513#comment-15826513
 ] 

ASF GitHub Bot commented on CB-8978:


Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/214
  
I've merged https://github.com/apache/cordova-lib/pull/468 in. @ktop can 
you close this PR?


> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826509#comment-15826509
 ] 

ASF subversion and git services commented on CB-8978:
-

Commit 2bf351704f6a1145fa0372348a124137a9f2a287 in cordova-lib's branch 
refs/heads/master from [~dpogue]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=2bf3517 ]

CB-8978 Add resource-file parsing to config.xml

 This closes #468


> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15824503#comment-15824503
 ] 

ASF GitHub Bot commented on CB-8978:


Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-lib/pull/468
  
LGTM 👍 


> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15706127#comment-15706127
 ] 

ASF GitHub Bot commented on CB-8978:


Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-lib/pull/468
  
Then looks good to me, I can't think any example right now where the same 
file should be needed for all platforms


> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15705968#comment-15705968
 ] 

ASF GitHub Bot commented on CB-8978:


Github user dpogue commented on the issue:

https://github.com/apache/cordova-lib/pull/468
  
For clarity, "top-level support" means allowing `resource-file` tags that 
aren't scoped to a particular platform.

i.e.,
```xml



```
This would copy `./foo.xml` to `./platforms/ios/bar.xml`, 
`./platforms/windows/bar.xml`, etc.

It's not clear if there's a use case for files that get copied into every 
platform.

---

What will definitely be supported is platform-scoped `resource-file` tags:
```xml






```
This would copy `./gservices.json` to 
`./platforms/android/google-services.json` and copy 
`./icons/notification-mdpi.png` to 
`./platforms/android/res/drawable-mdpi/ic_notification.png`

This does not require files to go under the www folder, the target can be 
anywhere in the platform directory (same as with plugin `resource-file` tags)


> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15705806#comment-15705806
 ] 

ASF GitHub Bot commented on CB-8978:


Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-lib/pull/468
  
I think top level might make sense here if it's a file that the IDE needs 
but not the app (configuration file like google-services.json/plist)

Can the launch images and icons be outside the www folder?



> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15705762#comment-15705762
 ] 

ASF GitHub Bot commented on CB-8978:


Github user ktop commented on the issue:

https://github.com/apache/cordova-lib/pull/468
  
SGTM


> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15703003#comment-15703003
 ] 

ASF GitHub Bot commented on CB-8978:


Github user dpogue commented on the issue:

https://github.com/apache/cordova-lib/pull/468
  
Any other input here? Are we in agreement to remove the top-level file 
copying?


> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15456404#comment-15456404
 ] 

ASF GitHub Bot commented on CB-8978:


Github user dpogue commented on the issue:

https://github.com/apache/cordova-android/pull/321
  
Thanks! I've corrected that function name


> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15456268#comment-15456268
 ] 

ASF GitHub Bot commented on CB-8978:


Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-android/pull/321
  
bin\templates\cordova\lib\prepare.js: line 81, col 9, 'cleanFileResources' 
is not defined.
bin\templates\cordova\lib\prepare.js: line 433, col 10, 
'cleanResourceFiles' is defined but never used.


> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431833#comment-15431833
 ] 

ASF GitHub Bot commented on CB-8978:


Github user dpogue commented on the issue:

https://github.com/apache/cordova-lib/pull/468
  
I'm happy to leave out support for top-level `resource-file` tags, since I 
agree it doesn't really make sense


> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412756#comment-15412756
 ] 

ASF GitHub Bot commented on CB-8978:


Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/468
  
So this is the first step in adding `resource-file`.  Future updates to 
platform API's will use `getFileResources` to do the copying of these files 
`src`attribute to the `target` attribute. 

I'm not sure I like `null` argument for top level `resource-file`. I agree 
with you that I don't see much value in adding this as top-level. Maybe 
developers want to copy a top level `json` file? but why not just include it in 
`www` at that point? Maybe to copy a sensitive file that isn't under version 
control? I'm reaching a bit here. 


> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398114#comment-15398114
 ] 

ASF GitHub Bot commented on CB-8978:


Github user codecov-io commented on the issue:

https://github.com/apache/cordova-android/pull/321
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-android/pull/321?src=pr) is 
33.85% (diff: 100%)
> Merging 
[#321](https://codecov.io/gh/apache/cordova-android/pull/321?src=pr) into 
[master](https://codecov.io/gh/apache/cordova-android/branch/master?src=pr) 
will not change coverage

```diff
@@ master   #321   diff @@
==
  Files11 11  
  Lines   960960  
  Methods 197197  
  Messages  0  0  
  Branches156156  
==
  Hits325325  
  Misses  635635  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[74ae665...096e3ab](https://codecov.io/gh/apache/cordova-android/compare/74ae6651c8f1752c487cd7e6461d931909305127...096e3ab36f9804981d7053ba0ab57f82d71487e4?src=pr)


> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398107#comment-15398107
 ] 

ASF GitHub Bot commented on CB-8978:


GitHub user dpogue opened a pull request:

https://github.com/apache/cordova-android/pull/321

CB-8978 Prepare copy resource-files from config.xml

See also cordova/cordova-discuss#6
Depends on https://github.com/apache/cordova-lib/pull/468

This copies files specified by `` elements in config.xml 
into the Android project when preparing. This allows providing arbitrary files 
such as special notification-sized icons, or API configuration JSON files.

/cc @jsongin @jcesarmobile

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dpogue/cordova-android config-resource-file

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/321.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #321


commit bd39a007f9f2eef3103c633280df41155d47ba6f
Author: Darryl Pogue 
Date:   2016-07-28T19:44:50Z

CB-8978 Prepare copy resource-files from config.xml




> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396772#comment-15396772
 ] 

ASF GitHub Bot commented on CB-8978:


Github user codecov-io commented on the issue:

https://github.com/apache/cordova-lib/pull/468
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-lib/pull/468?src=pr) is 80.62% 
(diff: 100%)
> Merging [#468](https://codecov.io/gh/apache/cordova-lib/pull/468?src=pr) 
into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr) 
will not change coverage

```diff
@@ master   #468   diff @@
==
  Files68 68  
  Lines  5394   5394  
  Methods 855855  
  Messages  0  0  
  Branches   1040   1040  
==
  Hits   4349   4349  
  Misses 1045   1045  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[29382ca...02c558f](https://codecov.io/gh/apache/cordova-lib/compare/29382ca2bf67e17337845feb4360980df99fe3d2...02c558f6abd09b13066740a43dc711a464dd017e?src=pr)


> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396657#comment-15396657
 ] 

ASF GitHub Bot commented on CB-8978:


GitHub user dpogue opened a pull request:

https://github.com/apache/cordova-lib/pull/468

CB-8978 Add resource-file parsing to config.xml

Original JIRA issue https://issues.apache.org/jira/browse/CB-8978
Related to/replaces https://github.com/apache/cordova-lib/pull/214
See also https://github.com/cordova/cordova-discuss/issues/6

This is just the first pass, we'll also need to update the platform API in 
each platform to actually copy the resource files around on prepare.

This returns the same data structure as the PluginInfo class. To be 
determined if we think having top-level `resource-file` elements makes sense, 
it appears that plugin.xml does not support them.

/cc @ktop @jcesarmobile

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dpogue/cordova-lib resource-file

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/468.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #468


commit 552ce1da2932ccf43b2a137c641fcb90a4bfc27b
Author: Darryl Pogue 
Date:   2016-07-27T23:28:08Z

CB-8978 Add resource-file parsing to config.xml




> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538577#comment-14538577
 ] 

ASF GitHub Bot commented on CB-8978:


Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-lib/pull/214#issuecomment-101035769
  
Thanks Karen.
You weren't doing it in the wrong spot, we are just trying out some new
ways of discussing feature additions.

@purplecabbage
risingj.com

On Mon, May 11, 2015 at 12:16 PM, Karen Tran 
wrote:

> I'll move the discussion to the right place.
>
> —
> Reply to this email directly or view it on GitHub
> .
>



> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538474#comment-14538474
 ] 

ASF GitHub Bot commented on CB-8978:


Github user ktop commented on the pull request:

https://github.com/apache/cordova-lib/pull/214#issuecomment-101021261
  
I'll move the discussion to the right place. 


> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538467#comment-14538467
 ] 

ASF GitHub Bot commented on CB-8978:


Github user jcesarmobile commented on the pull request:

https://github.com/apache/cordova-lib/pull/214#issuecomment-101019674
  
the discusion already started on the mail list
http://markmail.org/message/yx3pvydgyxpssgas
But it didnt get any conclusion

I still don't see why would a regular cordova developer use native images 
on a regular project


> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538394#comment-14538394
 ] 

ASF GitHub Bot commented on CB-8978:


Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-lib/pull/214#issuecomment-101012833
  
Please start a discussion for this here:
https://github.com/cordova/cordova-discuss/issues
This should NOT be merged without some justification of why we need it, and 
why it belongs in config.xml, ...


> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[Jesse MacFadyen (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538390#comment-14538390
 ] 

Jesse MacFadyen commented on CB-8978:
-

I would NOT consider this a work item until there is some consensus on how it 
will be used.
Personally, I don't see the need for this currently.

Please start a discussion here: 
https://github.com/cordova/cordova-discuss/issues

> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538289#comment-14538289
 ] 

ASF GitHub Bot commented on CB-8978:


GitHub user ktop opened a pull request:

https://github.com/apache/cordova-lib/pull/214

CB-8978 Added new image element tag for config.xml



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ktop/cordova-lib master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/214.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #214


commit 1d591965953ceb3273b4d36aeb6015df8805f33f
Author: Karen Tran 
Date:   2015-05-11T17:37:45Z

CB-8978 Added new image element tag for config.xml




> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org