[jira] [Commented] (CB-9347) You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3 has caused this
[
https://issues.apache.org/jira/browse/CB-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145297#comment-15145297
]
ASF GitHub Bot commented on CB-9347:
Github user tony-- commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/54#issuecomment-183488008
Thanks! I cherry-picked it into a fork; we'll let you know if it worked
for us ASAP.
> You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3
> has caused this
> ---
>
> Key: CB-9347
> URL: https://issues.apache.org/jira/browse/CB-9347
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Dialogs
>Affects Versions: 1.1.0
> Environment: Mac OS X Yosemite 10.10.4; XCode 6.4 iOS
>Reporter: Kelvin Dart
>Assignee: jcesarmobile
>Priority: Critical
>
> Previously in cordova-plugin-dialogs, you could stack alerts in Cordova like
> follows:
> {code}
> navigator.notification.alert('Notification 1', function () {}, 'Title 1');
> navigator.notification.alert('Notification 2', function () {}, 'Title 2');
> {code}
> And it would show 'Notification 2' then 'Notification 1'.
> Now you cannot, in commit: #ee3b02b3c78debe608263d847f7ac69bda1bfca0, there
> was quite a large overhaul in {{showDialogWithMessage}} in
> {{CDVNotification.m}}; this commit seems to add some code for iOS 8.3+ which
> uses {{UIAlertController}} instead of the old {{UIAlertView}}. The problem is
> here - unfortunately I do not know Obj-C too well in order to debug it.
> If you revert to a cordova-plugin-dialogs version prior to this, the stacked
> notifications work fine.
> I have created a small test harness which you can download
> [here|https://www.dropbox.com/s/62hdp3gjp2924er/CDVDialogsNotificationBug.zip?dl=0].
> Please could you implement the old behaviour as this has cause some aspects
> of my app to break - thanks!
> N.b. I have tagged the version as 1.1.0 as it would not allow me to tag 1.1.1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9347) You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3 has caused this
[
https://issues.apache.org/jira/browse/CB-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145187#comment-15145187
]
ASF GitHub Bot commented on CB-9347:
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/54#issuecomment-183466583
I've just send the PR.
https://github.com/phonegap/phonegap-plugin-barcodescanner/pull/170
> You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3
> has caused this
> ---
>
> Key: CB-9347
> URL: https://issues.apache.org/jira/browse/CB-9347
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Dialogs
>Affects Versions: 1.1.0
> Environment: Mac OS X Yosemite 10.10.4; XCode 6.4 iOS
>Reporter: Kelvin Dart
>Assignee: jcesarmobile
>Priority: Critical
>
> Previously in cordova-plugin-dialogs, you could stack alerts in Cordova like
> follows:
> {code}
> navigator.notification.alert('Notification 1', function () {}, 'Title 1');
> navigator.notification.alert('Notification 2', function () {}, 'Title 2');
> {code}
> And it would show 'Notification 2' then 'Notification 1'.
> Now you cannot, in commit: #ee3b02b3c78debe608263d847f7ac69bda1bfca0, there
> was quite a large overhaul in {{showDialogWithMessage}} in
> {{CDVNotification.m}}; this commit seems to add some code for iOS 8.3+ which
> uses {{UIAlertController}} instead of the old {{UIAlertView}}. The problem is
> here - unfortunately I do not know Obj-C too well in order to debug it.
> If you revert to a cordova-plugin-dialogs version prior to this, the stacked
> notifications work fine.
> I have created a small test harness which you can download
> [here|https://www.dropbox.com/s/62hdp3gjp2924er/CDVDialogsNotificationBug.zip?dl=0].
> Please could you implement the old behaviour as this has cause some aspects
> of my app to break - thanks!
> N.b. I have tagged the version as 1.1.0 as it would not allow me to tag 1.1.1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9347) You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3 has caused this
[
https://issues.apache.org/jira/browse/CB-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144711#comment-15144711
]
ASF GitHub Bot commented on CB-9347:
Github user tony-- commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/54#issuecomment-183376049
@jcesarmobile - thanks for explaining `presentAlertcontroller,` I see it
now.
Thanks in advance for the phonegap-plugin-barcodescanner PR!
> You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3
> has caused this
> ---
>
> Key: CB-9347
> URL: https://issues.apache.org/jira/browse/CB-9347
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Dialogs
>Affects Versions: 1.1.0
> Environment: Mac OS X Yosemite 10.10.4; XCode 6.4 iOS
>Reporter: Kelvin Dart
>Assignee: jcesarmobile
>Priority: Critical
>
> Previously in cordova-plugin-dialogs, you could stack alerts in Cordova like
> follows:
> {code}
> navigator.notification.alert('Notification 1', function () {}, 'Title 1');
> navigator.notification.alert('Notification 2', function () {}, 'Title 2');
> {code}
> And it would show 'Notification 2' then 'Notification 1'.
> Now you cannot, in commit: #ee3b02b3c78debe608263d847f7ac69bda1bfca0, there
> was quite a large overhaul in {{showDialogWithMessage}} in
> {{CDVNotification.m}}; this commit seems to add some code for iOS 8.3+ which
> uses {{UIAlertController}} instead of the old {{UIAlertView}}. The problem is
> here - unfortunately I do not know Obj-C too well in order to debug it.
> If you revert to a cordova-plugin-dialogs version prior to this, the stacked
> notifications work fine.
> I have created a small test harness which you can download
> [here|https://www.dropbox.com/s/62hdp3gjp2924er/CDVDialogsNotificationBug.zip?dl=0].
> Please could you implement the old behaviour as this has cause some aspects
> of my app to break - thanks!
> N.b. I have tagged the version as 1.1.0 as it would not allow me to tag 1.1.1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9347) You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3 has caused this
[
https://issues.apache.org/jira/browse/CB-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144222#comment-15144222
]
ASF GitHub Bot commented on CB-9347:
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/54#issuecomment-183218924
It's supposed to be recursive. If count > 1 it just stores it on the array
(line 100), then, once it's presented (line 230), removes the presented
alertController from the array (line 231), and if the array contains any other
alertController on the array (line 232), it calls presentAlertcontroller again
(line 233).
I've tested and the problem is on the barcode scanner plugin, it returns
the success or error callbacks right after calling
dismissViewControllerAnimated, and dismissViewControllerAnimated takes a while,
so the alert tries to present the dialog on the CDVbcsViewController that is
being dismissed, so you get this error:
Warning: Attempt to present on
whose view is not in the window hierarchy!
The solution should be not to return the callbacks until the
CDVbcsViewController is dismissed. Than can be done with a block like this:
`- (void)barcodeScanDone:(void (^)(void))callbackBlock {
self.capturing = NO;
[self.captureSession stopRunning];
[self.parentViewController dismissViewControllerAnimated:YES
completion:callbackBlock];
// viewcontroller holding onto a reference to us, release them so they
// will release us
self.viewController = nil;
}`
and every call to barcodeScanDone should pass the block as parameter
example:
`[self barcodeScanDone:^{
[self.plugin returnSuccess:text format:format cancelled:FALSE
flipped:FALSE callback:self.callback];
}];`
I'll try to send a pull request to the barcode scanner plugin with this fix
this afternoon.
> You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3
> has caused this
> ---
>
> Key: CB-9347
> URL: https://issues.apache.org/jira/browse/CB-9347
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Dialogs
>Affects Versions: 1.1.0
> Environment: Mac OS X Yosemite 10.10.4; XCode 6.4 iOS
>Reporter: Kelvin Dart
>Assignee: jcesarmobile
>Priority: Critical
>
> Previously in cordova-plugin-dialogs, you could stack alerts in Cordova like
> follows:
> {code}
> navigator.notification.alert('Notification 1', function () {}, 'Title 1');
> navigator.notification.alert('Notification 2', function () {}, 'Title 2');
> {code}
> And it would show 'Notification 2' then 'Notification 1'.
> Now you cannot, in commit: #ee3b02b3c78debe608263d847f7ac69bda1bfca0, there
> was quite a large overhaul in {{showDialogWithMessage}} in
> {{CDVNotification.m}}; this commit seems to add some code for iOS 8.3+ which
> uses {{UIAlertController}} instead of the old {{UIAlertView}}. The problem is
> here - unfortunately I do not know Obj-C too well in order to debug it.
> If you revert to a cordova-plugin-dialogs version prior to this, the stacked
> notifications work fine.
> I have created a small test harness which you can download
> [here|https://www.dropbox.com/s/62hdp3gjp2924er/CDVDialogsNotificationBug.zip?dl=0].
> Please could you implement the old behaviour as this has cause some aspects
> of my app to break - thanks!
> N.b. I have tagged the version as 1.1.0 as it would not allow me to tag 1.1.1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9347) You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3 has caused this
[
https://issues.apache.org/jira/browse/CB-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143915#comment-15143915
]
ASF GitHub Bot commented on CB-9347:
Github user tony-- commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/54#issuecomment-183153364
@jcesarmobile - With regard to
phonegap-plugin-barcodescanner+cordova-plugin-dialogs, I was chatting with
@imaffett about this. He found that reverting from
cordova-plugin-dialogs@1.2.0 to cordova-plugin-dialogs@1.1.1 fixed the issue he
was seeing. I was comparing the code from the 2 versions and am wondering
about
[this](https://github.com/apache/cordova-plugin-dialogs/pull/54/files#diff-b1298bd2cd777b56752fccb1b2faf4abR102).
What should happen when `[alertList count] > 1`? Maybe I am reading it
wrong, but it seems like the way it is now, it will silently fail. Is that the
intended behavior? Am I misunderstanding what will happen? Thanks in advance
for help with improving my understanding!
> You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3
> has caused this
> ---
>
> Key: CB-9347
> URL: https://issues.apache.org/jira/browse/CB-9347
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Dialogs
>Affects Versions: 1.1.0
> Environment: Mac OS X Yosemite 10.10.4; XCode 6.4 iOS
>Reporter: Kelvin Dart
>Assignee: jcesarmobile
>Priority: Critical
>
> Previously in cordova-plugin-dialogs, you could stack alerts in Cordova like
> follows:
> {code}
> navigator.notification.alert('Notification 1', function () {}, 'Title 1');
> navigator.notification.alert('Notification 2', function () {}, 'Title 2');
> {code}
> And it would show 'Notification 2' then 'Notification 1'.
> Now you cannot, in commit: #ee3b02b3c78debe608263d847f7ac69bda1bfca0, there
> was quite a large overhaul in {{showDialogWithMessage}} in
> {{CDVNotification.m}}; this commit seems to add some code for iOS 8.3+ which
> uses {{UIAlertController}} instead of the old {{UIAlertView}}. The problem is
> here - unfortunately I do not know Obj-C too well in order to debug it.
> If you revert to a cordova-plugin-dialogs version prior to this, the stacked
> notifications work fine.
> I have created a small test harness which you can download
> [here|https://www.dropbox.com/s/62hdp3gjp2924er/CDVDialogsNotificationBug.zip?dl=0].
> Please could you implement the old behaviour as this has cause some aspects
> of my app to break - thanks!
> N.b. I have tagged the version as 1.1.0 as it would not allow me to tag 1.1.1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9347) You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3 has caused this
[
https://issues.apache.org/jira/browse/CB-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139010#comment-15139010
]
ASF GitHub Bot commented on CB-9347:
Github user imaffett commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/54#issuecomment-181897670
@jcesarmobile - thanks for the prompt reply. This is the plugin
https://github.com/phonegap/phonegap-plugin-barcodescanner.git
> You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3
> has caused this
> ---
>
> Key: CB-9347
> URL: https://issues.apache.org/jira/browse/CB-9347
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Dialogs
>Affects Versions: 1.1.0
> Environment: Mac OS X Yosemite 10.10.4; XCode 6.4 iOS
>Reporter: Kelvin Dart
>Assignee: jcesarmobile
>Priority: Critical
>
> Previously in cordova-plugin-dialogs, you could stack alerts in Cordova like
> follows:
> {code}
> navigator.notification.alert('Notification 1', function () {}, 'Title 1');
> navigator.notification.alert('Notification 2', function () {}, 'Title 2');
> {code}
> And it would show 'Notification 2' then 'Notification 1'.
> Now you cannot, in commit: #ee3b02b3c78debe608263d847f7ac69bda1bfca0, there
> was quite a large overhaul in {{showDialogWithMessage}} in
> {{CDVNotification.m}}; this commit seems to add some code for iOS 8.3+ which
> uses {{UIAlertController}} instead of the old {{UIAlertView}}. The problem is
> here - unfortunately I do not know Obj-C too well in order to debug it.
> If you revert to a cordova-plugin-dialogs version prior to this, the stacked
> notifications work fine.
> I have created a small test harness which you can download
> [here|https://www.dropbox.com/s/62hdp3gjp2924er/CDVDialogsNotificationBug.zip?dl=0].
> Please could you implement the old behaviour as this has cause some aspects
> of my app to break - thanks!
> N.b. I have tagged the version as 1.1.0 as it would not allow me to tag 1.1.1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9347) You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3 has caused this
[
https://issues.apache.org/jira/browse/CB-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139008#comment-15139008
]
ASF GitHub Bot commented on CB-9347:
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/54#issuecomment-181897098
getTopPresentedViewController returns the view controller on the top, not
necessarily the mainViewController, the dialog has to be presented over the top
view controller. If you dismiss the barcode scanner and you still get the
CDVbcsViewController as the topPresentedViewController, it might be a bug on
the phonegap-barcode-scanner plugin.
Can you link the plugin you are using? I can't find anything if I search by
phonegap-barcode-scanner on npm, and there are a few on github
> You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3
> has caused this
> ---
>
> Key: CB-9347
> URL: https://issues.apache.org/jira/browse/CB-9347
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Dialogs
>Affects Versions: 1.1.0
> Environment: Mac OS X Yosemite 10.10.4; XCode 6.4 iOS
>Reporter: Kelvin Dart
>Assignee: jcesarmobile
>Priority: Critical
>
> Previously in cordova-plugin-dialogs, you could stack alerts in Cordova like
> follows:
> {code}
> navigator.notification.alert('Notification 1', function () {}, 'Title 1');
> navigator.notification.alert('Notification 2', function () {}, 'Title 2');
> {code}
> And it would show 'Notification 2' then 'Notification 1'.
> Now you cannot, in commit: #ee3b02b3c78debe608263d847f7ac69bda1bfca0, there
> was quite a large overhaul in {{showDialogWithMessage}} in
> {{CDVNotification.m}}; this commit seems to add some code for iOS 8.3+ which
> uses {{UIAlertController}} instead of the old {{UIAlertView}}. The problem is
> here - unfortunately I do not know Obj-C too well in order to debug it.
> If you revert to a cordova-plugin-dialogs version prior to this, the stacked
> notifications work fine.
> I have created a small test harness which you can download
> [here|https://www.dropbox.com/s/62hdp3gjp2924er/CDVDialogsNotificationBug.zip?dl=0].
> Please could you implement the old behaviour as this has cause some aspects
> of my app to break - thanks!
> N.b. I have tagged the version as 1.1.0 as it would not allow me to tag 1.1.1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9347) You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3 has caused this
[
https://issues.apache.org/jira/browse/CB-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138985#comment-15138985
]
ASF GitHub Bot commented on CB-9347:
Github user imaffett commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/54#issuecomment-181886490
I'm running into a similar issue where showing an alert after using the
phonegap-barcode-scanner plugin is failing. the getTopPresentedViewController
method is returning the CDVbcsViewController instead of mainViewController.
> You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3
> has caused this
> ---
>
> Key: CB-9347
> URL: https://issues.apache.org/jira/browse/CB-9347
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Dialogs
>Affects Versions: 1.1.0
> Environment: Mac OS X Yosemite 10.10.4; XCode 6.4 iOS
>Reporter: Kelvin Dart
>Assignee: jcesarmobile
>Priority: Critical
>
> Previously in cordova-plugin-dialogs, you could stack alerts in Cordova like
> follows:
> {code}
> navigator.notification.alert('Notification 1', function () {}, 'Title 1');
> navigator.notification.alert('Notification 2', function () {}, 'Title 2');
> {code}
> And it would show 'Notification 2' then 'Notification 1'.
> Now you cannot, in commit: #ee3b02b3c78debe608263d847f7ac69bda1bfca0, there
> was quite a large overhaul in {{showDialogWithMessage}} in
> {{CDVNotification.m}}; this commit seems to add some code for iOS 8.3+ which
> uses {{UIAlertController}} instead of the old {{UIAlertView}}. The problem is
> here - unfortunately I do not know Obj-C too well in order to debug it.
> If you revert to a cordova-plugin-dialogs version prior to this, the stacked
> notifications work fine.
> I have created a small test harness which you can download
> [here|https://www.dropbox.com/s/62hdp3gjp2924er/CDVDialogsNotificationBug.zip?dl=0].
> Please could you implement the old behaviour as this has cause some aspects
> of my app to break - thanks!
> N.b. I have tagged the version as 1.1.0 as it would not allow me to tag 1.1.1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9347) You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3 has caused this
[
https://issues.apache.org/jira/browse/CB-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964286#comment-14964286
]
ASF subversion and git services commented on CB-9347:
-
Commit 98d3e90cd3b4879bed06c655dc9641107037c678 in cordova-plugin-dialogs's
branch refs/heads/master from [~jcesarmobile]
[
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-dialogs.git;h=98d3e90 ]
CB-9347 - fix to allow to stack multiple UIAlertControllers
Now you can stack multiple UIAlertControllers
I had to add a 0.5s delay in case the user tries to present a new
UIAlertController while one is currently being presented (on presenting
animation)
> You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3
> has caused this
> ---
>
> Key: CB-9347
> URL: https://issues.apache.org/jira/browse/CB-9347
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Dialogs
>Affects Versions: 1.1.0
> Environment: Mac OS X Yosemite 10.10.4; XCode 6.4 iOS
>Reporter: Kelvin Dart
>Assignee: jcesarmobile
>Priority: Critical
>
> Previously in cordova-plugin-dialogs, you could stack alerts in Cordova like
> follows:
> {code}
> navigator.notification.alert('Notification 1', function () {}, 'Title 1');
> navigator.notification.alert('Notification 2', function () {}, 'Title 2');
> {code}
> And it would show 'Notification 2' then 'Notification 1'.
> Now you cannot, in commit: #ee3b02b3c78debe608263d847f7ac69bda1bfca0, there
> was quite a large overhaul in {{showDialogWithMessage}} in
> {{CDVNotification.m}}; this commit seems to add some code for iOS 8.3+ which
> uses {{UIAlertController}} instead of the old {{UIAlertView}}. The problem is
> here - unfortunately I do not know Obj-C too well in order to debug it.
> If you revert to a cordova-plugin-dialogs version prior to this, the stacked
> notifications work fine.
> I have created a small test harness which you can download
> [here|https://www.dropbox.com/s/62hdp3gjp2924er/CDVDialogsNotificationBug.zip?dl=0].
> Please could you implement the old behaviour as this has cause some aspects
> of my app to break - thanks!
> N.b. I have tagged the version as 1.1.0 as it would not allow me to tag 1.1.1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9347) You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3 has caused this
[
https://issues.apache.org/jira/browse/CB-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964289#comment-14964289
]
ASF GitHub Bot commented on CB-9347:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-dialogs/pull/54
> You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3
> has caused this
> ---
>
> Key: CB-9347
> URL: https://issues.apache.org/jira/browse/CB-9347
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Dialogs
>Affects Versions: 1.1.0
> Environment: Mac OS X Yosemite 10.10.4; XCode 6.4 iOS
>Reporter: Kelvin Dart
>Assignee: jcesarmobile
>Priority: Critical
>
> Previously in cordova-plugin-dialogs, you could stack alerts in Cordova like
> follows:
> {code}
> navigator.notification.alert('Notification 1', function () {}, 'Title 1');
> navigator.notification.alert('Notification 2', function () {}, 'Title 2');
> {code}
> And it would show 'Notification 2' then 'Notification 1'.
> Now you cannot, in commit: #ee3b02b3c78debe608263d847f7ac69bda1bfca0, there
> was quite a large overhaul in {{showDialogWithMessage}} in
> {{CDVNotification.m}}; this commit seems to add some code for iOS 8.3+ which
> uses {{UIAlertController}} instead of the old {{UIAlertView}}. The problem is
> here - unfortunately I do not know Obj-C too well in order to debug it.
> If you revert to a cordova-plugin-dialogs version prior to this, the stacked
> notifications work fine.
> I have created a small test harness which you can download
> [here|https://www.dropbox.com/s/62hdp3gjp2924er/CDVDialogsNotificationBug.zip?dl=0].
> Please could you implement the old behaviour as this has cause some aspects
> of my app to break - thanks!
> N.b. I have tagged the version as 1.1.0 as it would not allow me to tag 1.1.1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9347) You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3 has caused this
[
https://issues.apache.org/jira/browse/CB-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964287#comment-14964287
]
ASF subversion and git services commented on CB-9347:
-
Commit 7fd94a1f337433c956b9d21d57e89ee64c1be65e in cordova-plugin-dialogs's
branch refs/heads/master from [~jcesarmobile]
[
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-dialogs.git;h=7fd94a1 ]
CB-9347 - fix to allow to stack multiple UIAlertControllers
Deleted the 0,5 seconds delay, now it presents the next
UIAlertController (if any) on the presentViewController completion
block
> You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3
> has caused this
> ---
>
> Key: CB-9347
> URL: https://issues.apache.org/jira/browse/CB-9347
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Dialogs
>Affects Versions: 1.1.0
> Environment: Mac OS X Yosemite 10.10.4; XCode 6.4 iOS
>Reporter: Kelvin Dart
>Assignee: jcesarmobile
>Priority: Critical
>
> Previously in cordova-plugin-dialogs, you could stack alerts in Cordova like
> follows:
> {code}
> navigator.notification.alert('Notification 1', function () {}, 'Title 1');
> navigator.notification.alert('Notification 2', function () {}, 'Title 2');
> {code}
> And it would show 'Notification 2' then 'Notification 1'.
> Now you cannot, in commit: #ee3b02b3c78debe608263d847f7ac69bda1bfca0, there
> was quite a large overhaul in {{showDialogWithMessage}} in
> {{CDVNotification.m}}; this commit seems to add some code for iOS 8.3+ which
> uses {{UIAlertController}} instead of the old {{UIAlertView}}. The problem is
> here - unfortunately I do not know Obj-C too well in order to debug it.
> If you revert to a cordova-plugin-dialogs version prior to this, the stacked
> notifications work fine.
> I have created a small test harness which you can download
> [here|https://www.dropbox.com/s/62hdp3gjp2924er/CDVDialogsNotificationBug.zip?dl=0].
> Please could you implement the old behaviour as this has cause some aspects
> of my app to break - thanks!
> N.b. I have tagged the version as 1.1.0 as it would not allow me to tag 1.1.1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9347) You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3 has caused this
[
https://issues.apache.org/jira/browse/CB-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652193#comment-14652193
]
ASF GitHub Bot commented on CB-9347:
Github user initialxy commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/54#issuecomment-127353615
Awesome, thanks @jcesarmobile, much appreciated.
> You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3
> has caused this
> ---
>
> Key: CB-9347
> URL: https://issues.apache.org/jira/browse/CB-9347
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS, Plugin Dialogs
>Affects Versions: 1.1.0
> Environment: Mac OS X Yosemite 10.10.4; XCode 6.4
>Reporter: Kelvin Dart
>Assignee: jcesarmobile
>Priority: Critical
>
> Previously in cordova-plugin-dialogs, you could stack alerts in Cordova like
> follows:
> {code}
> navigator.notification.alert('Notification 1', function () {}, 'Title 1');
> navigator.notification.alert('Notification 2', function () {}, 'Title 2');
> {code}
> And it would show 'Notification 2' then 'Notification 1'.
> Now you cannot, in commit: #ee3b02b3c78debe608263d847f7ac69bda1bfca0, there
> was quite a large overhaul in {{showDialogWithMessage}} in
> {{CDVNotification.m}}; this commit seems to add some code for iOS 8.3+ which
> uses {{UIAlertController}} instead of the old {{UIAlertView}}. The problem is
> here - unfortunately I do not know Obj-C too well in order to debug it.
> If you revert to a cordova-plugin-dialogs version prior to this, the stacked
> notifications work fine.
> I have created a small test harness which you can download
> [here|https://www.dropbox.com/s/62hdp3gjp2924er/CDVDialogsNotificationBug.zip?dl=0].
> Please could you implement the old behaviour as this has cause some aspects
> of my app to break - thanks!
> N.b. I have tagged the version as 1.1.0 as it would not allow me to tag 1.1.1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9347) You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3 has caused this
[
https://issues.apache.org/jira/browse/CB-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635242#comment-14635242
]
Kelvin Dart commented on CB-9347:
-
Awesome - thanks!
> You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3
> has caused this
> ---
>
> Key: CB-9347
> URL: https://issues.apache.org/jira/browse/CB-9347
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS, Plugin Dialogs
>Affects Versions: 1.1.0
> Environment: Mac OS X Yosemite 10.10.4; XCode 6.4
>Reporter: Kelvin Dart
>Assignee: jcesarmobile
>Priority: Critical
>
> Previously in cordova-plugin-dialogs, you could stack alerts in Cordova like
> follows:
> {code}
> navigator.notification.alert('Notification 1', function () {}, 'Title 1');
> navigator.notification.alert('Notification 2', function () {}, 'Title 2');
> {code}
> And it would show 'Notification 2' then 'Notification 1'.
> Now you cannot, in commit: #ee3b02b3c78debe608263d847f7ac69bda1bfca0, there
> was quite a large overhaul in {{showDialogWithMessage}} in
> {{CDVNotification.m}}; this commit seems to add some code for iOS 8.3+ which
> uses {{UIAlertController}} instead of the old {{UIAlertView}}. The problem is
> here - unfortunately I do not know Obj-C too well in order to debug it.
> If you revert to a cordova-plugin-dialogs version prior to this, the stacked
> notifications work fine.
> I have created a small test harness which you can download
> [here|https://www.dropbox.com/s/62hdp3gjp2924er/CDVDialogsNotificationBug.zip?dl=0].
> Please could you implement the old behaviour as this has cause some aspects
> of my app to break - thanks!
> N.b. I have tagged the version as 1.1.0 as it would not allow me to tag 1.1.1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9347) You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3 has caused this
[
https://issues.apache.org/jira/browse/CB-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635238#comment-14635238
]
jcesarmobile commented on CB-9347:
--
I commited latest changed and they where added into my previous pull request
> You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3
> has caused this
> ---
>
> Key: CB-9347
> URL: https://issues.apache.org/jira/browse/CB-9347
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS, Plugin Dialogs
>Affects Versions: 1.1.0
> Environment: Mac OS X Yosemite 10.10.4; XCode 6.4
>Reporter: Kelvin Dart
>Assignee: jcesarmobile
>Priority: Critical
>
> Previously in cordova-plugin-dialogs, you could stack alerts in Cordova like
> follows:
> {code}
> navigator.notification.alert('Notification 1', function () {}, 'Title 1');
> navigator.notification.alert('Notification 2', function () {}, 'Title 2');
> {code}
> And it would show 'Notification 2' then 'Notification 1'.
> Now you cannot, in commit: #ee3b02b3c78debe608263d847f7ac69bda1bfca0, there
> was quite a large overhaul in {{showDialogWithMessage}} in
> {{CDVNotification.m}}; this commit seems to add some code for iOS 8.3+ which
> uses {{UIAlertController}} instead of the old {{UIAlertView}}. The problem is
> here - unfortunately I do not know Obj-C too well in order to debug it.
> If you revert to a cordova-plugin-dialogs version prior to this, the stacked
> notifications work fine.
> I have created a small test harness which you can download
> [here|https://www.dropbox.com/s/62hdp3gjp2924er/CDVDialogsNotificationBug.zip?dl=0].
> Please could you implement the old behaviour as this has cause some aspects
> of my app to break - thanks!
> N.b. I have tagged the version as 1.1.0 as it would not allow me to tag 1.1.1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9347) You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3 has caused this
[
https://issues.apache.org/jira/browse/CB-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635235#comment-14635235
]
Kelvin Dart commented on CB-9347:
-
Hi [~jcesarmobile] - did you push the latest changes and create a pull request?
> You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3
> has caused this
> ---
>
> Key: CB-9347
> URL: https://issues.apache.org/jira/browse/CB-9347
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS, Plugin Dialogs
>Affects Versions: 1.1.0
> Environment: Mac OS X Yosemite 10.10.4; XCode 6.4
>Reporter: Kelvin Dart
>Assignee: jcesarmobile
>Priority: Critical
>
> Previously in cordova-plugin-dialogs, you could stack alerts in Cordova like
> follows:
> {code}
> navigator.notification.alert('Notification 1', function () {}, 'Title 1');
> navigator.notification.alert('Notification 2', function () {}, 'Title 2');
> {code}
> And it would show 'Notification 2' then 'Notification 1'.
> Now you cannot, in commit: #ee3b02b3c78debe608263d847f7ac69bda1bfca0, there
> was quite a large overhaul in {{showDialogWithMessage}} in
> {{CDVNotification.m}}; this commit seems to add some code for iOS 8.3+ which
> uses {{UIAlertController}} instead of the old {{UIAlertView}}. The problem is
> here - unfortunately I do not know Obj-C too well in order to debug it.
> If you revert to a cordova-plugin-dialogs version prior to this, the stacked
> notifications work fine.
> I have created a small test harness which you can download
> [here|https://www.dropbox.com/s/62hdp3gjp2924er/CDVDialogsNotificationBug.zip?dl=0].
> Please could you implement the old behaviour as this has cause some aspects
> of my app to break - thanks!
> N.b. I have tagged the version as 1.1.0 as it would not allow me to tag 1.1.1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9347) You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3 has caused this
[
https://issues.apache.org/jira/browse/CB-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630848#comment-14630848
]
jcesarmobile commented on CB-9347:
--
Ok, I got it working this way, I'll send the changes later.
> You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3
> has caused this
> ---
>
> Key: CB-9347
> URL: https://issues.apache.org/jira/browse/CB-9347
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS, Plugin Dialogs
>Affects Versions: 1.1.0
> Environment: Mac OS X Yosemite 10.10.4; XCode 6.4
>Reporter: Kelvin Dart
>Assignee: jcesarmobile
>Priority: Critical
>
> Previously in cordova-plugin-dialogs, you could stack alerts in Cordova like
> follows:
> {code}
> navigator.notification.alert('Notification 1', function () {}, 'Title 1');
> navigator.notification.alert('Notification 2', function () {}, 'Title 2');
> {code}
> And it would show 'Notification 2' then 'Notification 1'.
> Now you cannot, in commit: #ee3b02b3c78debe608263d847f7ac69bda1bfca0, there
> was quite a large overhaul in {{showDialogWithMessage}} in
> {{CDVNotification.m}}; this commit seems to add some code for iOS 8.3+ which
> uses {{UIAlertController}} instead of the old {{UIAlertView}}. The problem is
> here - unfortunately I do not know Obj-C too well in order to debug it.
> If you revert to a cordova-plugin-dialogs version prior to this, the stacked
> notifications work fine.
> I have created a small test harness which you can download
> [here|https://www.dropbox.com/s/62hdp3gjp2924er/CDVDialogsNotificationBug.zip?dl=0].
> Please could you implement the old behaviour as this has cause some aspects
> of my app to break - thanks!
> N.b. I have tagged the version as 1.1.0 as it would not allow me to tag 1.1.1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9347) You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3 has caused this
[
https://issues.apache.org/jira/browse/CB-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630395#comment-14630395
]
Shazron Abdullah commented on CB-9347:
--
Well, my idea was as above -- we queue the info from the calls and dequeue when
appropriate to call the next UIAlertController. This works around any UIKit
bugs that iOS 8 has and will be pretty predictable and reliable.
> You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3
> has caused this
> ---
>
> Key: CB-9347
> URL: https://issues.apache.org/jira/browse/CB-9347
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS, Plugin Dialogs
>Affects Versions: 1.1.0
> Environment: Mac OS X Yosemite 10.10.4; XCode 6.4
>Reporter: Kelvin Dart
>Assignee: jcesarmobile
>Priority: Critical
>
> Previously in cordova-plugin-dialogs, you could stack alerts in Cordova like
> follows:
> {code}
> navigator.notification.alert('Notification 1', function () {}, 'Title 1');
> navigator.notification.alert('Notification 2', function () {}, 'Title 2');
> {code}
> And it would show 'Notification 2' then 'Notification 1'.
> Now you cannot, in commit: #ee3b02b3c78debe608263d847f7ac69bda1bfca0, there
> was quite a large overhaul in {{showDialogWithMessage}} in
> {{CDVNotification.m}}; this commit seems to add some code for iOS 8.3+ which
> uses {{UIAlertController}} instead of the old {{UIAlertView}}. The problem is
> here - unfortunately I do not know Obj-C too well in order to debug it.
> If you revert to a cordova-plugin-dialogs version prior to this, the stacked
> notifications work fine.
> I have created a small test harness which you can download
> [here|https://www.dropbox.com/s/62hdp3gjp2924er/CDVDialogsNotificationBug.zip?dl=0].
> Please could you implement the old behaviour as this has cause some aspects
> of my app to break - thanks!
> N.b. I have tagged the version as 1.1.0 as it would not allow me to tag 1.1.1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9347) You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3 has caused this
[
https://issues.apache.org/jira/browse/CB-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630037#comment-14630037
]
jcesarmobile commented on CB-9347:
--
I added the change following the stackoverflow answer, but there was another
problem, it was working fine for the 2 first UIAlertControllers stacked, but it
fails from the third because it tries present it while the presenting
animation, so I have added a 0,5 seconds delay.
I created an NSMutableArray and I add the UIAlertController, and remove it on
the presentViewController completition block and use the NSMutableArray count
to multiply, if there is only the current UIAlertController on the
NSMutableArray, there won't be a delay presenting the UIAlertController
[~shazron] let me know what do you think about this approach, or if you have a
better idea.
> You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3
> has caused this
> ---
>
> Key: CB-9347
> URL: https://issues.apache.org/jira/browse/CB-9347
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS, Plugin Dialogs
>Affects Versions: 1.1.0
> Environment: Mac OS X Yosemite 10.10.4; XCode 6.4
>Reporter: Kelvin Dart
>Assignee: jcesarmobile
>Priority: Critical
>
> Previously in cordova-plugin-dialogs, you could stack alerts in Cordova like
> follows:
> {code}
> navigator.notification.alert('Notification 1', function () {}, 'Title 1');
> navigator.notification.alert('Notification 2', function () {}, 'Title 2');
> {code}
> And it would show 'Notification 2' then 'Notification 1'.
> Now you cannot, in commit: #ee3b02b3c78debe608263d847f7ac69bda1bfca0, there
> was quite a large overhaul in {{showDialogWithMessage}} in
> {{CDVNotification.m}}; this commit seems to add some code for iOS 8.3+ which
> uses {{UIAlertController}} instead of the old {{UIAlertView}}. The problem is
> here - unfortunately I do not know Obj-C too well in order to debug it.
> If you revert to a cordova-plugin-dialogs version prior to this, the stacked
> notifications work fine.
> I have created a small test harness which you can download
> [here|https://www.dropbox.com/s/62hdp3gjp2924er/CDVDialogsNotificationBug.zip?dl=0].
> Please could you implement the old behaviour as this has cause some aspects
> of my app to break - thanks!
> N.b. I have tagged the version as 1.1.0 as it would not allow me to tag 1.1.1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9347) You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3 has caused this
[
https://issues.apache.org/jira/browse/CB-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630021#comment-14630021
]
ASF GitHub Bot commented on CB-9347:
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/54
CB-9347 - fix to allow to stack multiple UIAlertControllers
Now you can stack multiple UIAlertControllers
I had to add a 0.5s delay in case the user tries to present a new
UIAlertController while one is currently being presented (on presenting
animation)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jcesarmobile/cordova-plugin-dialogs master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-dialogs/pull/54.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #54
commit 98d3e90cd3b4879bed06c655dc9641107037c678
Author: Julio César
Date: 2015-07-16T17:10:06Z
CB-9347 - fix to allow to stack multiple UIAlertControllers
Now you can stack multiple UIAlertControllers
I had to add a 0.5s delay in case the user tries to present a new
UIAlertController while one is currently being presented (on presenting
animation)
> You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3
> has caused this
> ---
>
> Key: CB-9347
> URL: https://issues.apache.org/jira/browse/CB-9347
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS, Plugin Dialogs
>Affects Versions: 1.1.0
> Environment: Mac OS X Yosemite 10.10.4; XCode 6.4
>Reporter: Kelvin Dart
>Assignee: jcesarmobile
>Priority: Critical
>
> Previously in cordova-plugin-dialogs, you could stack alerts in Cordova like
> follows:
> {code}
> navigator.notification.alert('Notification 1', function () {}, 'Title 1');
> navigator.notification.alert('Notification 2', function () {}, 'Title 2');
> {code}
> And it would show 'Notification 2' then 'Notification 1'.
> Now you cannot, in commit: #ee3b02b3c78debe608263d847f7ac69bda1bfca0, there
> was quite a large overhaul in {{showDialogWithMessage}} in
> {{CDVNotification.m}}; this commit seems to add some code for iOS 8.3+ which
> uses {{UIAlertController}} instead of the old {{UIAlertView}}. The problem is
> here - unfortunately I do not know Obj-C too well in order to debug it.
> If you revert to a cordova-plugin-dialogs version prior to this, the stacked
> notifications work fine.
> I have created a small test harness which you can download
> [here|https://www.dropbox.com/s/62hdp3gjp2924er/CDVDialogsNotificationBug.zip?dl=0].
> Please could you implement the old behaviour as this has cause some aspects
> of my app to break - thanks!
> N.b. I have tagged the version as 1.1.0 as it would not allow me to tag 1.1.1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9347) You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3 has caused this
[
https://issues.apache.org/jira/browse/CB-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629657#comment-14629657
]
jcesarmobile commented on CB-9347:
--
The upvoted answer on stackoverflow works (presenting the UIAlertController on
the current presented view controller) on a native project. I'll add the changes
> You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3
> has caused this
> ---
>
> Key: CB-9347
> URL: https://issues.apache.org/jira/browse/CB-9347
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS, Plugin Dialogs
>Affects Versions: 1.1.0
> Environment: Mac OS X Yosemite 10.10.4; XCode 6.4
>Reporter: Kelvin Dart
>Assignee: jcesarmobile
>Priority: Critical
>
> Previously in cordova-plugin-dialogs, you could stack alerts in Cordova like
> follows:
> {code}
> navigator.notification.alert('Notification 1', function () {}, 'Title 1');
> navigator.notification.alert('Notification 2', function () {}, 'Title 2');
> {code}
> And it would show 'Notification 2' then 'Notification 1'.
> Now you cannot, in commit: #ee3b02b3c78debe608263d847f7ac69bda1bfca0, there
> was quite a large overhaul in {{showDialogWithMessage}} in
> {{CDVNotification.m}}; this commit seems to add some code for iOS 8.3+ which
> uses {{UIAlertController}} instead of the old {{UIAlertView}}. The problem is
> here - unfortunately I do not know Obj-C too well in order to debug it.
> If you revert to a cordova-plugin-dialogs version prior to this, the stacked
> notifications work fine.
> I have created a small test harness which you can download
> [here|https://www.dropbox.com/s/62hdp3gjp2924er/CDVDialogsNotificationBug.zip?dl=0].
> Please could you implement the old behaviour as this has cause some aspects
> of my app to break - thanks!
> N.b. I have tagged the version as 1.1.0 as it would not allow me to tag 1.1.1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9347) You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3 has caused this
[
https://issues.apache.org/jira/browse/CB-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627694#comment-14627694
]
Shazron Abdullah commented on CB-9347:
--
This report will do.
> You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3
> has caused this
> ---
>
> Key: CB-9347
> URL: https://issues.apache.org/jira/browse/CB-9347
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS, Plugin Dialogs
>Affects Versions: 1.1.0
> Environment: Mac OS X Yosemite 10.10.4; XCode 6.4
>Reporter: Kelvin Dart
>Priority: Critical
>
> Previously in cordova-plugin-dialogs, you could stack alerts in Cordova like
> follows:
> {code}
> navigator.notification.alert('Notification 1', function () {}, 'Title 1');
> navigator.notification.alert('Notification 2', function () {}, 'Title 2');
> {code}
> And it would show 'Notification 2' then 'Notification 1'.
> Now you cannot, in commit: #ee3b02b3c78debe608263d847f7ac69bda1bfca0, there
> was quite a large overhaul in {{showDialogWithMessage}} in
> {{CDVNotification.m}}; this commit seems to add some code for iOS 8.3+ which
> uses {{UIAlertController}} instead of the old {{UIAlertView}}. The problem is
> here - unfortunately I do not know Obj-C too well in order to debug it.
> If you revert to a cordova-plugin-dialogs version prior to this, the stacked
> notifications work fine.
> I have created a small test harness which you can download
> [here|https://www.dropbox.com/s/62hdp3gjp2924er/CDVDialogsNotificationBug.zip?dl=0].
> Please could you implement the old behaviour as this has cause some aspects
> of my app to break - thanks!
> N.b. I have tagged the version as 1.1.0 as it would not allow me to tag 1.1.1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9347) You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3 has caused this
[
https://issues.apache.org/jira/browse/CB-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627692#comment-14627692
]
Kelvin Dart commented on CB-9347:
-
Hi [~shazron],
Spot on! That SO issue is exactly as described; agreed - that sounds like a
feasible solution to the problem.
Do I need to do anything to raise it as a FR, or does this bug report act as
the FR?
> You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3
> has caused this
> ---
>
> Key: CB-9347
> URL: https://issues.apache.org/jira/browse/CB-9347
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS, Plugin Dialogs
>Affects Versions: 1.1.0
> Environment: Mac OS X Yosemite 10.10.4; XCode 6.4
>Reporter: Kelvin Dart
>Priority: Critical
>
> Previously in cordova-plugin-dialogs, you could stack alerts in Cordova like
> follows:
> {code}
> navigator.notification.alert('Notification 1', function () {}, 'Title 1');
> navigator.notification.alert('Notification 2', function () {}, 'Title 2');
> {code}
> And it would show 'Notification 2' then 'Notification 1'.
> Now you cannot, in commit: #ee3b02b3c78debe608263d847f7ac69bda1bfca0, there
> was quite a large overhaul in {{showDialogWithMessage}} in
> {{CDVNotification.m}}; this commit seems to add some code for iOS 8.3+ which
> uses {{UIAlertController}} instead of the old {{UIAlertView}}. The problem is
> here - unfortunately I do not know Obj-C too well in order to debug it.
> If you revert to a cordova-plugin-dialogs version prior to this, the stacked
> notifications work fine.
> I have created a small test harness which you can download
> [here|https://www.dropbox.com/s/62hdp3gjp2924er/CDVDialogsNotificationBug.zip?dl=0].
> Please could you implement the old behaviour as this has cause some aspects
> of my app to break - thanks!
> N.b. I have tagged the version as 1.1.0 as it would not allow me to tag 1.1.1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9347) You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3 has caused this
[
https://issues.apache.org/jira/browse/CB-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627687#comment-14627687
]
Shazron Abdullah commented on CB-9347:
--
If no solution is found, I think Cordova will just have to handle this:
1. Put the dialog info into a queue
2. If no alert is currently presenting, pop the queue, and present the alert --
else exit
3. After the alert is dismissed (in a button handler), goto (2)
> You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3
> has caused this
> ---
>
> Key: CB-9347
> URL: https://issues.apache.org/jira/browse/CB-9347
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS, Plugin Dialogs
>Affects Versions: 1.1.0
> Environment: Mac OS X Yosemite 10.10.4; XCode 6.4
>Reporter: Kelvin Dart
>Priority: Critical
>
> Previously in cordova-plugin-dialogs, you could stack alerts in Cordova like
> follows:
> {code}
> navigator.notification.alert('Notification 1', function () {}, 'Title 1');
> navigator.notification.alert('Notification 2', function () {}, 'Title 2');
> {code}
> And it would show 'Notification 2' then 'Notification 1'.
> Now you cannot, in commit: #ee3b02b3c78debe608263d847f7ac69bda1bfca0, there
> was quite a large overhaul in {{showDialogWithMessage}} in
> {{CDVNotification.m}}; this commit seems to add some code for iOS 8.3+ which
> uses {{UIAlertController}} instead of the old {{UIAlertView}}. The problem is
> here - unfortunately I do not know Obj-C too well in order to debug it.
> If you revert to a cordova-plugin-dialogs version prior to this, the stacked
> notifications work fine.
> I have created a small test harness which you can download
> [here|https://www.dropbox.com/s/62hdp3gjp2924er/CDVDialogsNotificationBug.zip?dl=0].
> Please could you implement the old behaviour as this has cause some aspects
> of my app to break - thanks!
> N.b. I have tagged the version as 1.1.0 as it would not allow me to tag 1.1.1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9347) You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3 has caused this
[
https://issues.apache.org/jira/browse/CB-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627684#comment-14627684
]
Shazron Abdullah commented on CB-9347:
--
Thank you! I think this is the same problem:
http://stackoverflow.com/questions/25932589/concurrent-uialertcontrollers
Not sure what the solution would be yet (no accepted answer to that SO question)
> You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3
> has caused this
> ---
>
> Key: CB-9347
> URL: https://issues.apache.org/jira/browse/CB-9347
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS, Plugin Dialogs
>Affects Versions: 1.1.0
> Environment: Mac OS X Yosemite 10.10.4; XCode 6.4
>Reporter: Kelvin Dart
>Priority: Critical
>
> Previously in cordova-plugin-dialogs, you could stack alerts in Cordova like
> follows:
> {code}
> navigator.notification.alert('Notification 1', function () {}, 'Title 1');
> navigator.notification.alert('Notification 2', function () {}, 'Title 2');
> {code}
> And it would show 'Notification 2' then 'Notification 1'.
> Now you cannot, in commit: #ee3b02b3c78debe608263d847f7ac69bda1bfca0, there
> was quite a large overhaul in {{showDialogWithMessage}} in
> {{CDVNotification.m}}; this commit seems to add some code for iOS 8.3+ which
> uses {{UIAlertController}} instead of the old {{UIAlertView}}. The problem is
> here - unfortunately I do not know Obj-C too well in order to debug it.
> If you revert to a cordova-plugin-dialogs version prior to this, the stacked
> notifications work fine.
> I have created a small test harness which you can download
> [here|https://www.dropbox.com/s/62hdp3gjp2924er/CDVDialogsNotificationBug.zip?dl=0].
> Please could you implement the old behaviour as this has cause some aspects
> of my app to break - thanks!
> N.b. I have tagged the version as 1.1.0 as it would not allow me to tag 1.1.1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9347) You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3 has caused this
[
https://issues.apache.org/jira/browse/CB-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14626011#comment-14626011
]
Kelvin Dart commented on CB-9347:
-
[~shazron], using the code example I posted above, it shows the first alert but
the second one does not appear at all.
*Expected*:
When calling:
{code}
navigator.notification.alert('Notification 1', function () {}, 'Title 1');
{code}
An iOS alert would show with the text Notification 1. If you did not do
anything with this alert and just leave it on the screen, then call:
{code}
navigator.notification.alert('Notification 2', function () {}, 'Title 2');
{code}
A second alert would show on top of Notification 1, which you could dismiss and
Notification 1 would be present again (and you could dismiss Notification 1 and
return to the app).
*Actual*:
Now, Notification 1 is called and is shown as expected. When you call
Notification 2 with Notification 1 still showing, no alert shows over the top
of Notification 1 and Notification 2 does not show at all. When you dismiss
Notification 1, Notification 2 still does not show. It seems to be lost and it
is not rendered on the screen despite calling it.
I hope this clarifies.
> You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3
> has caused this
> ---
>
> Key: CB-9347
> URL: https://issues.apache.org/jira/browse/CB-9347
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS, Plugin Dialogs
>Affects Versions: 1.1.0
> Environment: Mac OS X Yosemite 10.10.4; XCode 6.4
>Reporter: Kelvin Dart
>Priority: Critical
>
> Previously in cordova-plugin-dialogs, you could stack alerts in Cordova like
> follows:
> {code}
> navigator.notification.alert('Notification 1', function () {}, 'Title 1');
> navigator.notification.alert('Notification 2', function () {}, 'Title 2');
> {code}
> And it would show 'Notification 2' then 'Notification 1'.
> Now you cannot, in commit: #ee3b02b3c78debe608263d847f7ac69bda1bfca0, there
> was quite a large overhaul in {{showDialogWithMessage}} in
> {{CDVNotification.m}}; this commit seems to add some code for iOS 8.3+ which
> uses {{UIAlertController}} instead of the old {{UIAlertView}}. The problem is
> here - unfortunately I do not know Obj-C too well in order to debug it.
> If you revert to a cordova-plugin-dialogs version prior to this, the stacked
> notifications work fine.
> I have created a small test harness which you can download
> [here|https://www.dropbox.com/s/62hdp3gjp2924er/CDVDialogsNotificationBug.zip?dl=0].
> Please could you implement the old behaviour as this has cause some aspects
> of my app to break - thanks!
> N.b. I have tagged the version as 1.1.0 as it would not allow me to tag 1.1.1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9347) You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3 has caused this
[
https://issues.apache.org/jira/browse/CB-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625581#comment-14625581
]
Shazron Abdullah commented on CB-9347:
--
What happens currently? You mention "Now you cannot" but I'm not sure what
exactly happens for you. Structure your report in "Expected", "Actual" sections
for clarity (sorry for bug triage I don't have time to run every test harness,
that comes later if it is needed)
UIAlertController is for iOS 8.x, not 8.3x. We're not going back to the old
method since it is deprecated. During runtime, if you are on an iOS 7 or less
device, it will fall back to UIAlertView.
> You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3
> has caused this
> ---
>
> Key: CB-9347
> URL: https://issues.apache.org/jira/browse/CB-9347
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS, Plugin Dialogs
>Affects Versions: 1.1.0
> Environment: Mac OS X Yosemite 10.10.4; XCode 6.4
>Reporter: Kelvin Dart
>Priority: Critical
>
> Previously in cordova-plugin-dialogs, you could stack alerts in Cordova like
> follows:
> {code}
> navigator.notification.alert('Notification 1', function () {}, 'Title 1');
> navigator.notification.alert('Notification 2', function () {}, 'Title 2');
> {code}
> And it would show 'Notification 2' then 'Notification 1'.
> Now you cannot, in commit: #ee3b02b3c78debe608263d847f7ac69bda1bfca0, there
> was quite a large overhaul in {{showDialogWithMessage}} in
> {{CDVNotification.m}}; this commit seems to add some code for iOS 8.3+ which
> uses {{UIAlertController}} instead of the old {{UIAlertView}}. The problem is
> here - unfortunately I do not know Obj-C too well in order to debug it.
> If you revert to a cordova-plugin-dialogs version prior to this, the stacked
> notifications work fine.
> I have created a small test harness which you can download
> [here|https://www.dropbox.com/s/62hdp3gjp2924er/CDVDialogsNotificationBug.zip?dl=0].
> Please could you implement the old behaviour as this has cause some aspects
> of my app to break - thanks!
> N.b. I have tagged the version as 1.1.0 as it would not allow me to tag 1.1.1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
