[jira] [Commented] (CB-9506) A user's photos can be deleted if they leave a cordova application using cordova-plugin-camera
[ https://issues.apache.org/jira/browse/CB-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14965834#comment-14965834 ] Joe Bowser commented on CB-9506: I'm not fond of this feature, and if it's broken, I'm happy to kill this weird feature. > A user's photos can be deleted if they leave a cordova application using > cordova-plugin-camera > -- > > Key: CB-9506 > URL: https://issues.apache.org/jira/browse/CB-9506 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Camera > Environment: Android >Reporter: Cody Balos > Labels: Triaged, android > > Currently, the camera plugin checks the number of pictures saved to the > device before any pictures are captured using the camera started via the > plugin, and then checks the difference between the amount of photos before > and after. Relying on this method introduces the possibility of deleting > photos a user takes outside the cordova started camera. For example, consider > this scenario: > A user of a cordova application utilizes a cordova-plugin-camera backed > camera feature , and while in the camera activity, switches to a different > application. While in this different application the user takes a photo. Now > the user returns to the cordova application, and is still in the camera > activity. They take the photo, and accept it. Now the cleanup process inside > cordova-plugin-camera begins, but, because of relying on the difference > between the amount of photos before and after the activity, the photo the > user took outside of the cordova application is deleted. > This issue exists already in the checkForDuplicateImage function, does have > the ill behavior from the above example. However, it is limited by its > implementation to removing no more than 2 of the photos taken outside of the > cordova application. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9506) A user's photos can be deleted if they leave a cordova application using cordova-plugin-camera
[ https://issues.apache.org/jira/browse/CB-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14965825#comment-14965825 ] Richard B Knoll commented on CB-9506: - Yup, I can reproduce this in Android 5.1.1 with camera plugin 1.2.0. This seems like a pretty major bug. [~bowserj] what do you think? > A user's photos can be deleted if they leave a cordova application using > cordova-plugin-camera > -- > > Key: CB-9506 > URL: https://issues.apache.org/jira/browse/CB-9506 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Camera > Environment: Android >Reporter: Cody Balos > > Currently, the camera plugin checks the number of pictures saved to the > device before any pictures are captured using the camera started via the > plugin, and then checks the difference between the amount of photos before > and after. Relying on this method introduces the possibility of deleting > photos a user takes outside the cordova started camera. For example, consider > this scenario: > A user of a cordova application utilizes a cordova-plugin-camera backed > camera feature , and while in the camera activity, switches to a different > application. While in this different application the user takes a photo. Now > the user returns to the cordova application, and is still in the camera > activity. They take the photo, and accept it. Now the cleanup process inside > cordova-plugin-camera begins, but, because of relying on the difference > between the amount of photos before and after the activity, the photo the > user took outside of the cordova application is deleted. > This issue exists already in the checkForDuplicateImage function, does have > the ill behavior from the above example. However, it is limited by its > implementation to removing no more than 2 of the photos taken outside of the > cordova application. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9506) A user's photos can be deleted if they leave a cordova application using cordova-plugin-camera
[ https://issues.apache.org/jira/browse/CB-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966033#comment-14966033 ] Richard B Knoll commented on CB-9506: - Agreed I am of the opinion that avoiding a few duplicate photos is not worth the potential of deleting a user's other photos (no production app would every want to risk that side effect). A case could be made that a very specific series of events needs to happen for this to come about, but deleting photos based on numbers sounds very prone to error and I would still vote to kill this feature unless a more robust solution presents itself. > A user's photos can be deleted if they leave a cordova application using > cordova-plugin-camera > -- > > Key: CB-9506 > URL: https://issues.apache.org/jira/browse/CB-9506 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Camera > Environment: Android >Reporter: Cody Balos > Labels: Triaged, android > > Currently, the camera plugin checks the number of pictures saved to the > device before any pictures are captured using the camera started via the > plugin, and then checks the difference between the amount of photos before > and after. Relying on this method introduces the possibility of deleting > photos a user takes outside the cordova started camera. For example, consider > this scenario: > A user of a cordova application utilizes a cordova-plugin-camera backed > camera feature , and while in the camera activity, switches to a different > application. While in this different application the user takes a photo. Now > the user returns to the cordova application, and is still in the camera > activity. They take the photo, and accept it. Now the cleanup process inside > cordova-plugin-camera begins, but, because of relying on the difference > between the amount of photos before and after the activity, the photo the > user took outside of the cordova application is deleted. > This issue exists already in the checkForDuplicateImage function, does have > the ill behavior from the above example. However, it is limited by its > implementation to removing no more than 2 of the photos taken outside of the > cordova application. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9506) A user's photos can be deleted if they leave a cordova application using cordova-plugin-camera
[ https://issues.apache.org/jira/browse/CB-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705771#comment-14705771 ] Cody Balos commented on CB-9506: This will be non-trivial to fix as the usage of intents to start the camera, which will be a third party application, makes it hard, if not impossible (with the current way android works) to detect if the user took photos outside a cordova application. A user's photos can be deleted if they leave a cordova application using cordova-plugin-camera -- Key: CB-9506 URL: https://issues.apache.org/jira/browse/CB-9506 Project: Apache Cordova Issue Type: Bug Components: Plugin Camera Environment: Android Reporter: Cody Balos Currently, the camera plugin checks the number of pictures saved to the device before any pictures are captured using the camera started via the plugin, and then checks the difference between the amount of photos before and after. Relying on this method introduces the possibility of deleting photos a user takes outside the cordova started camera. For example, consider this scenario: A user of a cordova application utilizes a cordova-plugin-camera backed camera feature , and while in the camera activity, switches to a different application. While in this different application the user takes a photo. Now the user returns to the cordova application, and is still in the camera activity. They take the photo, and accept it. Now the cleanup process inside cordova-plugin-camera begins, but, because of relying on the difference between the amount of photos before and after the activity, the photo the user took outside of the cordova application is deleted. This issue exists already in the checkForDuplicateImage function, does have the ill behavior from the above example. However, it is limited by its implementation to removing no more than 2 of the photos taken outside of the cordova application. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
