[jira] [Commented] (CB-9519) Inappropriate destruction time of engine in CordovaWebViewImpl
[
https://issues.apache.org/jira/browse/CB-9519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15242479#comment-15242479
]
ASF GitHub Bot commented on CB-9519:
Github user NoLongerLazyDhl closed the pull request at:
https://github.com/apache/cordova-android/pull/207
> Inappropriate destruction time of engine in CordovaWebViewImpl
> --
>
> Key: CB-9519
> URL: https://issues.apache.org/jira/browse/CB-9519
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Reporter: Dong Hanlin
>Assignee: Vladimir Kotikov
>
> In {{CordovaWebViewImpl.java}}, one of the TODO comments in {{public void
> handleDestroy()}} method points out that the engine should not destroy
> webview until after about:blank is done loading. Actually, the engine has
> indeed been destroyed before about:blank is completely loaded, which causes
> some problems.
> I think moving a line of code may work:
> {quote}
> engine.destroy();
> {quote}
> This code can be moved into the last {{if}} block in {{public void
> onPageFinishedLoading(String url)}}, like this:
> {code}
> // Shutdown if blank loaded
> if (url.equals("about:blank")) {
> engine.destroy();
> pluginManager.postMessage("exit", null);
> }
> {code}
> Since before destroying the engine, we have set the URL to be about:blank, so
> destroying it when about:blank is completed loaded can work.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9519) Inappropriate destruction time of engine in CordovaWebViewImpl
[
https://issues.apache.org/jira/browse/CB-9519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15242478#comment-15242478
]
ASF GitHub Bot commented on CB-9519:
Github user NoLongerLazyDhl closed the pull request at:
https://github.com/apache/cordova-android/pull/208
> Inappropriate destruction time of engine in CordovaWebViewImpl
> --
>
> Key: CB-9519
> URL: https://issues.apache.org/jira/browse/CB-9519
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Reporter: Dong Hanlin
>Assignee: Vladimir Kotikov
>
> In {{CordovaWebViewImpl.java}}, one of the TODO comments in {{public void
> handleDestroy()}} method points out that the engine should not destroy
> webview until after about:blank is done loading. Actually, the engine has
> indeed been destroyed before about:blank is completely loaded, which causes
> some problems.
> I think moving a line of code may work:
> {quote}
> engine.destroy();
> {quote}
> This code can be moved into the last {{if}} block in {{public void
> onPageFinishedLoading(String url)}}, like this:
> {code}
> // Shutdown if blank loaded
> if (url.equals("about:blank")) {
> engine.destroy();
> pluginManager.postMessage("exit", null);
> }
> {code}
> Since before destroying the engine, we have set the URL to be about:blank, so
> destroying it when about:blank is completed loaded can work.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9519) Inappropriate destruction time of engine in CordovaWebViewImpl
[
https://issues.apache.org/jira/browse/CB-9519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15200427#comment-15200427
]
ASF GitHub Bot commented on CB-9519:
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/208#issuecomment-198088849
Can you please close this pull request and reformat it to be against
master? Thanks!
> Inappropriate destruction time of engine in CordovaWebViewImpl
> --
>
> Key: CB-9519
> URL: https://issues.apache.org/jira/browse/CB-9519
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Reporter: Dong Hanlin
>Assignee: Vladimir Kotikov
>
> In {{CordovaWebViewImpl.java}}, one of the TODO comments in {{public void
> handleDestroy()}} method points out that the engine should not destroy
> webview until after about:blank is done loading. Actually, the engine has
> indeed been destroyed before about:blank is completely loaded, which causes
> some problems.
> I think moving a line of code may work:
> {quote}
> engine.destroy();
> {quote}
> This code can be moved into the last {{if}} block in {{public void
> onPageFinishedLoading(String url)}}, like this:
> {code}
> // Shutdown if blank loaded
> if (url.equals("about:blank")) {
> engine.destroy();
> pluginManager.postMessage("exit", null);
> }
> {code}
> Since before destroying the engine, we have set the URL to be about:blank, so
> destroying it when about:blank is completed loaded can work.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9519) Inappropriate destruction time of engine in CordovaWebViewImpl
[
https://issues.apache.org/jira/browse/CB-9519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034456#comment-15034456
]
ASF GitHub Bot commented on CB-9519:
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/208#issuecomment-161075344
Can this be added to master and not to 4.0.x?
> Inappropriate destruction time of engine in CordovaWebViewImpl
> --
>
> Key: CB-9519
> URL: https://issues.apache.org/jira/browse/CB-9519
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Reporter: Dong Hanlin
>Assignee: Vladimir Kotikov
>
> In {{CordovaWebViewImpl.java}}, one of the TODO comments in {{public void
> handleDestroy()}} method points out that the engine should not destroy
> webview until after about:blank is done loading. Actually, the engine has
> indeed been destroyed before about:blank is completely loaded, which causes
> some problems.
> I think moving a line of code may work:
> {quote}
> engine.destroy();
> {quote}
> This code can be moved into the last {{if}} block in {{public void
> onPageFinishedLoading(String url)}}, like this:
> {code}
> // Shutdown if blank loaded
> if (url.equals("about:blank")) {
> engine.destroy();
> pluginManager.postMessage("exit", null);
> }
> {code}
> Since before destroying the engine, we have set the URL to be about:blank, so
> destroying it when about:blank is completed loaded can work.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9519) Inappropriate destruction time of engine in CordovaWebViewImpl
[
https://issues.apache.org/jira/browse/CB-9519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14970431#comment-14970431
]
ASF GitHub Bot commented on CB-9519:
Github user DILEEP-YADAV commented on the pull request:
https://github.com/apache/cordova-android/pull/208#issuecomment-150468569
ok
> Inappropriate destruction time of engine in CordovaWebViewImpl
> --
>
> Key: CB-9519
> URL: https://issues.apache.org/jira/browse/CB-9519
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Reporter: Dong Hanlin
>Assignee: Vladimir Kotikov
>
> In {{CordovaWebViewImpl.java}}, one of the TODO comments in {{public void
> handleDestroy()}} method points out that the engine should not destroy
> webview until after about:blank is done loading. Actually, the engine has
> indeed been destroyed before about:blank is completely loaded, which causes
> some problems.
> I think moving a line of code may work:
> {quote}
> engine.destroy();
> {quote}
> This code can be moved into the last {{if}} block in {{public void
> onPageFinishedLoading(String url)}}, like this:
> {code}
> // Shutdown if blank loaded
> if (url.equals("about:blank")) {
> engine.destroy();
> pluginManager.postMessage("exit", null);
> }
> {code}
> Since before destroying the engine, we have set the URL to be about:blank, so
> destroying it when about:blank is completed loaded can work.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9519) Inappropriate destruction time of engine in CordovaWebViewImpl
[
https://issues.apache.org/jira/browse/CB-9519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968315#comment-14968315
]
ASF GitHub Bot commented on CB-9519:
Github user NoLongerLazyDhl commented on the pull request:
https://github.com/apache/cordova-android/pull/208#issuecomment-150070324
@vladimir-kotikov When I want to receive the "exit" message in my activity
which extends CordovaActivity to do something, it make that I'm not able to
receive the message. That's it solves.
> Inappropriate destruction time of engine in CordovaWebViewImpl
> --
>
> Key: CB-9519
> URL: https://issues.apache.org/jira/browse/CB-9519
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Reporter: Dong Hanlin
>Assignee: Vladimir Kotikov
>
> In {{CordovaWebViewImpl.java}}, one of the TODO comments in {{public void
> handleDestroy()}} method points out that the engine should not destroy
> webview until after about:blank is done loading. Actually, the engine has
> indeed been destroyed before about:blank is completely loaded, which causes
> some problems.
> I think moving a line of code may work:
> {quote}
> engine.destroy();
> {quote}
> This code can be moved into the last {{if}} block in {{public void
> onPageFinishedLoading(String url)}}, like this:
> {code}
> // Shutdown if blank loaded
> if (url.equals("about:blank")) {
> engine.destroy();
> pluginManager.postMessage("exit", null);
> }
> {code}
> Since before destroying the engine, we have set the URL to be about:blank, so
> destroying it when about:blank is completed loaded can work.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9519) Inappropriate destruction time of engine in CordovaWebViewImpl
[
https://issues.apache.org/jira/browse/CB-9519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14966855#comment-14966855
]
ASF GitHub Bot commented on CB-9519:
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/208#issuecomment-149906885
@nikhilkh, i'm not 100% sure - according to comments in the code it might
sense to have this checked in, but looking at where this code was introduced
[`087ec11`#L625](https://github.com/apache/cordova-android/commit/087ec11e6abc61acde4e2860f8ee363f3daba578#diff-08c0ff867a9ff299017464f55684L625),
it was always working this way - we never wait for `about:blank` being loaded.
@NoLongerLazyDhl, could you please add some details about the problem,
which this change solves? Maybe repro steps?
> Inappropriate destruction time of engine in CordovaWebViewImpl
> --
>
> Key: CB-9519
> URL: https://issues.apache.org/jira/browse/CB-9519
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
>Reporter: Dong Hanlin
>Assignee: Vladimir Kotikov
>
> In {{CordovaWebViewImpl.java}}, one of the TODO comments in {{public void
> handleDestroy()}} method points out that the engine should not destroy
> webview until after about:blank is done loading. Actually, the engine has
> indeed been destroyed before about:blank is completely loaded, which causes
> some problems.
> I think moving a line of code may work:
> {quote}
> engine.destroy();
> {quote}
> This code can be moved into the last {{if}} block in {{public void
> onPageFinishedLoading(String url)}}, like this:
> {code}
> // Shutdown if blank loaded
> if (url.equals("about:blank")) {
> engine.destroy();
> pluginManager.postMessage("exit", null);
> }
> {code}
> Since before destroying the engine, we have set the URL to be about:blank, so
> destroying it when about:blank is completed loaded can work.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9519) Inappropriate destruction time of engine in CordovaWebViewImpl
[
https://issues.apache.org/jira/browse/CB-9519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965441#comment-14965441
]
ASF GitHub Bot commented on CB-9519:
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/208#issuecomment-149642770
@vladimir-kotikov Can you please review - as we look to do a new release -
does this change need to be included?
> Inappropriate destruction time of engine in CordovaWebViewImpl
> --
>
> Key: CB-9519
> URL: https://issues.apache.org/jira/browse/CB-9519
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, CordovaLib
>Reporter: Dong Hanlin
>
> In {{CordovaWebViewImpl.java}}, one of the TODO comments in {{public void
> handleDestroy()}} method points out that the engine should not destroy
> webview until after about:blank is done loading. Actually, the engine has
> indeed been destroyed before about:blank is completely loaded, which causes
> some problems.
> I think moving a line of code may work:
> {quote}
> engine.destroy();
> {quote}
> This code can be moved into the last {{if}} block in {{public void
> onPageFinishedLoading(String url)}}, like this:
> {code}
> // Shutdown if blank loaded
> if (url.equals("about:blank")) {
> engine.destroy();
> pluginManager.postMessage("exit", null);
> }
> {code}
> Since before destroying the engine, we have set the URL to be about:blank, so
> destroying it when about:blank is completed loaded can work.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9519) Inappropriate destruction time of engine in CordovaWebViewImpl
[
https://issues.apache.org/jira/browse/CB-9519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933766#comment-14933766
]
ASF GitHub Bot commented on CB-9519:
Github user DILEEP-YADAV commented on the pull request:
https://github.com/apache/cordova-android/pull/208#issuecomment-143840411
http://www.plugbunch.com/
> Inappropriate destruction time of engine in CordovaWebViewImpl
> --
>
> Key: CB-9519
> URL: https://issues.apache.org/jira/browse/CB-9519
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, CordovaLib
>Reporter: Dong Hanlin
>
> In {{CordovaWebViewImpl.java}}, one of the TODO comments in {{public void
> handleDestroy()}} method points out that the engine should not destroy
> webview until after about:blank is done loading. Actually, the engine has
> indeed been destroyed before about:blank is completely loaded, which causes
> some problems.
> I think moving a line of code may work:
> {quote}
> engine.destroy();
> {quote}
> This code can be moved into the last {{if}} block in {{public void
> onPageFinishedLoading(String url)}}, like this:
> {code}
> // Shutdown if blank loaded
> if (url.equals("about:blank")) {
> engine.destroy();
> pluginManager.postMessage("exit", null);
> }
> {code}
> Since before destroying the engine, we have set the URL to be about:blank, so
> destroying it when about:blank is completed loaded can work.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9519) Inappropriate destruction time of engine in CordovaWebViewImpl
[
https://issues.apache.org/jira/browse/CB-9519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14704369#comment-14704369
]
ASF GitHub Bot commented on CB-9519:
GitHub user NoLongerLazyDhl opened a pull request:
https://github.com/apache/cordova-android/pull/208
CB-9519 Fix the engine destruction bug
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NoLongerLazyDhl/cordova-android 4.0.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/208.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #208
commit 401de7f5499b86712c2f767d03a45b47ed9b1351
Author: Dong Hanlin <445918...@qq.com>
Date: 2015-08-20T06:20:03Z
CB-9519 Fix the engine destruction bug
> Inappropriate destruction time of engine in CordovaWebViewImpl
> --
>
> Key: CB-9519
> URL: https://issues.apache.org/jira/browse/CB-9519
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, CordovaLib
>Reporter: Dong Hanlin
>
> In {{CordovaWebViewImpl.java}}, one of the TODO comments in {{public void
> handleDestroy()}} method points out that the engine should not destroy
> webview until after about:blank is done loading. Actually, the engine has
> indeed been destroyed before about:blank is completely loaded, which causes
> some problems.
> I think moving a line of code may work:
> {quote}
> engine.destroy();
> {quote}
> This code can be moved into the last {{if}} block in {{public void
> onPageFinishedLoading(String url)}}, like this:
> {code}
> // Shutdown if blank loaded
> if (url.equals("about:blank")) {
> engine.destroy();
> pluginManager.postMessage("exit", null);
> }
> {code}
> Since before destroying the engine, we have set the URL to be about:blank, so
> destroying it when about:blank is completed loaded can work.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9519) Inappropriate destruction time of engine in CordovaWebViewImpl
[
https://issues.apache.org/jira/browse/CB-9519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14704366#comment-14704366
]
ASF GitHub Bot commented on CB-9519:
GitHub user NoLongerLazyDhl opened a pull request:
https://github.com/apache/cordova-android/pull/207
CB-9519 Fix the engine destruction bug
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NoLongerLazyDhl/cordova-android 4.1.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/207.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #207
commit 2a3eccbd3341ef6abb4bfc4365cd476e76cf8958
Author: Dong Hanlin <445918...@qq.com>
Date: 2015-08-20T06:21:50Z
CB-9519 Fix the engine destruction bug
> Inappropriate destruction time of engine in CordovaWebViewImpl
> --
>
> Key: CB-9519
> URL: https://issues.apache.org/jira/browse/CB-9519
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, CordovaLib
>Reporter: Dong Hanlin
>
> In {{CordovaWebViewImpl.java}}, one of the TODO comments in {{public void
> handleDestroy()}} method points out that the engine should not destroy
> webview until after about:blank is done loading. Actually, the engine has
> indeed been destroyed before about:blank is completely loaded, which causes
> some problems.
> I think moving a line of code may work:
> {quote}
> engine.destroy();
> {quote}
> This code can be moved into the last {{if}} block in {{public void
> onPageFinishedLoading(String url)}}, like this:
> {code}
> // Shutdown if blank loaded
> if (url.equals("about:blank")) {
> engine.destroy();
> pluginManager.postMessage("exit", null);
> }
> {code}
> Since before destroying the engine, we have set the URL to be about:blank, so
> destroying it when about:blank is completed loaded can work.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
