[jira] [Commented] (CB-9753) index out of bounds on requestFileSystem

2016-05-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15288175#comment-15288175
 ] 

ASF GitHub Bot commented on CB-9753:


Github user cordova-qa commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/164#issuecomment-219920751
  
Cordova CI Build has completed successfully. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-file/pull/164/commits/1aa3ab1669d09351d1c6cbfdcf03a3154405d7c6)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/3/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/3//label=windows-slave,platformName=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/3//label=windows-slave,platformName=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/3//label=windows-slave,platformName=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/3//label=windows-slave,platformName=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/3//label=windows-slave,platformName=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/3//label=windows-slave,platformName=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/3//label=windows-slave,platformName=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/3//label=windows-slave,platformName=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/3//label=windows-slave,platformName=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/3//label=windows-slave,platformName=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/3//label=windows-slave,platformName=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/3//label=windows-slave,platformName=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/3//label=mac-slave,platformName=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/3//label=mac-slave,platformName=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/3//label=mac-slave,platformName=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/3//label=mac-slave,platformName=ios/artifact/)
 |
| [Android Mac]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/3//label=mac-slave,platformName=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/3//label=mac-slave,platformName=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/3//label=mac-slave,platformName=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/3//label=mac-slave,platformName=android/artifact/)
 |
 



> index out of bounds on requestFileSystem
> 
>
> Key: CB-9753
> URL: https://issues.apache.org/jira/browse/CB-9753
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
> Environment: cordova 5.3.3
> cordova ios 3.9.1
> cordova-plugin-file 2.0.0
> iOS
>Reporter: Denis Babineau
>Priority: Critical
>  Labels: Triaged, easyfix, iOS
>
> CDVFile.m's requestFileSystem: incorrectly checks the bounds of an array:
> if (type > self.fileSystems.count) {
> should read:
> if (type >= self.fileSystems.count) {



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9753) index out of bounds on requestFileSystem

2016-03-07 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15183819#comment-15183819
 ] 

ASF subversion and git services commented on CB-9753:
-

Commit 68e40437f48aa648e15653d74e007f5dbf5741ec in cordova-plugin-file's branch 
refs/heads/master from Thillaiganesh, C
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=68e4043 ]

Fix for CB-9753 : index out of bounds on requestFileSystem. This closes


> index out of bounds on requestFileSystem
> 
>
> Key: CB-9753
> URL: https://issues.apache.org/jira/browse/CB-9753
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
> Environment: cordova 5.3.3
> cordova ios 3.9.1
> cordova-plugin-file 2.0.0
> iOS
>Reporter: Denis Babineau
>Priority: Critical
>  Labels: Triaged, easyfix, iOS
>
> CDVFile.m's requestFileSystem: incorrectly checks the bounds of an array:
> if (type > self.fileSystems.count) {
> should read:
> if (type >= self.fileSystems.count) {



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9753) index out of bounds on requestFileSystem

2016-03-07 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15183823#comment-15183823
 ] 

ASF GitHub Bot commented on CB-9753:


Github user rakatyal commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/164#issuecomment-19340
  
Merged 
[here](https://github.com/apache/cordova-plugin-file/commit/68e40437f48aa648e15653d74e007f5dbf5741ec).


> index out of bounds on requestFileSystem
> 
>
> Key: CB-9753
> URL: https://issues.apache.org/jira/browse/CB-9753
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
> Environment: cordova 5.3.3
> cordova ios 3.9.1
> cordova-plugin-file 2.0.0
> iOS
>Reporter: Denis Babineau
>Priority: Critical
>  Labels: Triaged, easyfix, iOS
>
> CDVFile.m's requestFileSystem: incorrectly checks the bounds of an array:
> if (type > self.fileSystems.count) {
> should read:
> if (type >= self.fileSystems.count) {



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9753) index out of bounds on requestFileSystem

2016-03-07 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15183447#comment-15183447
 ] 

ASF GitHub Bot commented on CB-9753:


Github user rakatyal commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/164#issuecomment-193391342
  
LGTM.


> index out of bounds on requestFileSystem
> 
>
> Key: CB-9753
> URL: https://issues.apache.org/jira/browse/CB-9753
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
> Environment: cordova 5.3.3
> cordova ios 3.9.1
> cordova-plugin-file 2.0.0
> iOS
>Reporter: Denis Babineau
>Priority: Critical
>  Labels: Triaged, easyfix, iOS
>
> CDVFile.m's requestFileSystem: incorrectly checks the bounds of an array:
> if (type > self.fileSystems.count) {
> should read:
> if (type >= self.fileSystems.count) {



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9753) index out of bounds on requestFileSystem

2016-02-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15150152#comment-15150152
 ] 

ASF GitHub Bot commented on CB-9753:


GitHub user ThillaiganeshChan opened a pull request:

https://github.com/apache/cordova-plugin-file/pull/164

Fix for CB-9753 : index out of bounds on requestFileSystem

This for the CB-9753, "index out of bounds on requestFileSystem".

Changed
 if (type > self.fileSystems.count) {

To
if (type >= self.fileSystems.count) {

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ThillaiganeshChan/cordova-plugin-file 
CB-9753cordova-plugin-file

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file/pull/164.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #164


commit 1aa3ab1669d09351d1c6cbfdcf03a3154405d7c6
Author: Thillaiganesh, C 
Date:   2016-02-17T08:46:55Z

Fix for CB-9753 : index out of bounds on requestFileSystem




> index out of bounds on requestFileSystem
> 
>
> Key: CB-9753
> URL: https://issues.apache.org/jira/browse/CB-9753
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
> Environment: cordova 5.3.3
> cordova ios 3.9.1
> cordova-plugin-file 2.0.0
> iOS
>Reporter: Denis Babineau
>  Labels: Triaged, easyfix, iOS
>
> CDVFile.m's requestFileSystem: incorrectly checks the bounds of an array:
> if (type > self.fileSystems.count) {
> should read:
> if (type >= self.fileSystems.count) {



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9753) index out of bounds on requestFileSystem

2016-02-12 Thread Thillaiganesh Chan (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144502#comment-15144502
 ] 

Thillaiganesh Chan commented on CB-9753:


This is a valid request, issue will be triggered when there is a request for 
Persistent file and the same is not found in the device. Shall create a pull 
request to modify > to >=.

> index out of bounds on requestFileSystem
> 
>
> Key: CB-9753
> URL: https://issues.apache.org/jira/browse/CB-9753
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
> Environment: cordova 5.3.3
> cordova ios 3.9.1
> cordova-plugin-file 2.0.0
> iOS
>Reporter: Denis Babineau
>  Labels: Triaged, easyfix, iOS
>
> CDVFile.m's requestFileSystem: incorrectly checks the bounds of an array:
> if (type > self.fileSystems.count) {
> should read:
> if (type >= self.fileSystems.count) {



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org