[jira] [Commented] (CB-9827) Implement and expose PlatformApi for iOS
[ https://issues.apache.org/jira/browse/CB-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15041427#comment-15041427 ] ASF GitHub Bot commented on CB-9827: Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/176#issuecomment-161938717 Another issue I found: https://issues.apache.org/jira/browse/CB-10063?focusedCommentId=15041424&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15041424 this.pbxproj is not defined. I have to pass in "locations" to handleBuildSettings to get pbxproj. > Implement and expose PlatformApi for iOS > > > Key: CB-9827 > URL: https://issues.apache.org/jira/browse/CB-9827 > Project: Apache Cordova > Issue Type: Sub-task > Components: iOS >Reporter: Vladimir Kotikov >Assignee: Sergey Grebnov > Labels: PlatformApi, cordova-ios-4.0.x > Fix For: 5.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9827) Implement and expose PlatformApi for iOS
[ https://issues.apache.org/jira/browse/CB-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15038547#comment-15038547 ] ASF GitHub Bot commented on CB-9827: Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/176#issuecomment-161773866 FYI there was one issue that wasn't caught, Steve fixed it: https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=b89cd71 When doing a 'cordova prepare' the version of the platform was printed to stdout. > Implement and expose PlatformApi for iOS > > > Key: CB-9827 > URL: https://issues.apache.org/jira/browse/CB-9827 > Project: Apache Cordova > Issue Type: Sub-task > Components: iOS >Reporter: Vladimir Kotikov >Assignee: Sergey Grebnov > Labels: PlatformApi, cordova-ios-4.0.x > Fix For: 5.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9827) Implement and expose PlatformApi for iOS
[ https://issues.apache.org/jira/browse/CB-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15038543#comment-15038543 ] ASF subversion and git services commented on CB-9827: - Commit b89cd7158361d033b5cc22072a9a86f6e742cef4 in cordova-ios's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=b89cd71 ] CB-9827 fixed version file to be requireable > Implement and expose PlatformApi for iOS > > > Key: CB-9827 > URL: https://issues.apache.org/jira/browse/CB-9827 > Project: Apache Cordova > Issue Type: Sub-task > Components: iOS >Reporter: Vladimir Kotikov >Assignee: Sergey Grebnov > Labels: PlatformApi, cordova-ios-4.0.x > Fix For: 5.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9827) Implement and expose PlatformApi for iOS
[ https://issues.apache.org/jira/browse/CB-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15038484#comment-15038484 ] ASF GitHub Bot commented on CB-9827: Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/176 > Implement and expose PlatformApi for iOS > > > Key: CB-9827 > URL: https://issues.apache.org/jira/browse/CB-9827 > Project: Apache Cordova > Issue Type: Sub-task > Components: iOS >Reporter: Vladimir Kotikov >Assignee: Sergey Grebnov > Labels: PlatformApi, cordova-ios-4.0.x > Fix For: 5.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9827) Implement and expose PlatformApi for iOS
[ https://issues.apache.org/jira/browse/CB-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037153#comment-15037153 ] ASF GitHub Bot commented on CB-9827: Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/176#issuecomment-161500951 I've already pulled in this change, it's in the Apache git repos and somehow it hasn't mirrored yet: https://git1-us-west.apache.org/repos/asf?p=cordova-ios.git;a=commit;h=26cca47e3c1fa85f9f06232bfe099f9d4c9c8e40 > Implement and expose PlatformApi for iOS > > > Key: CB-9827 > URL: https://issues.apache.org/jira/browse/CB-9827 > Project: Apache Cordova > Issue Type: Sub-task > Components: iOS >Reporter: Vladimir Kotikov >Assignee: Sergey Grebnov > Labels: PlatformApi, cordova-ios-4.0.x > Fix For: 5.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9827) Implement and expose PlatformApi for iOS
[ https://issues.apache.org/jira/browse/CB-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036239#comment-15036239 ] ASF GitHub Bot commented on CB-9827: Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-ios/pull/176#issuecomment-161378270 +1 > Implement and expose PlatformApi for iOS > > > Key: CB-9827 > URL: https://issues.apache.org/jira/browse/CB-9827 > Project: Apache Cordova > Issue Type: Sub-task > Components: iOS >Reporter: Vladimir Kotikov >Assignee: Sergey Grebnov > Labels: PlatformApi > Fix For: 5.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9827) Implement and expose PlatformApi for iOS
[ https://issues.apache.org/jira/browse/CB-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035955#comment-15035955 ] ASF GitHub Bot commented on CB-9827: Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-ios/pull/176#issuecomment-161331277 No objections from my side. The PR has passed internal review, all CR notes has been addressed. @sgrebnov? > Implement and expose PlatformApi for iOS > > > Key: CB-9827 > URL: https://issues.apache.org/jira/browse/CB-9827 > Project: Apache Cordova > Issue Type: Sub-task > Components: iOS >Reporter: Vladimir Kotikov >Assignee: Sergey Grebnov > Labels: PlatformApi > Fix For: 5.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9827) Implement and expose PlatformApi for iOS
[ https://issues.apache.org/jira/browse/CB-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034796#comment-15034796 ] ASF GitHub Bot commented on CB-9827: Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/176#issuecomment-161124103 What do you guys think of merging this in for cordova-ios 4.0 release? I'm still working on CB-7287 mobile-spec failures (3) for WKWebView, but the platform is almost good to go. > Implement and expose PlatformApi for iOS > > > Key: CB-9827 > URL: https://issues.apache.org/jira/browse/CB-9827 > Project: Apache Cordova > Issue Type: Sub-task > Components: iOS >Reporter: Vladimir Kotikov >Assignee: Sergey Grebnov > Labels: PlatformApi > Fix For: 5.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9827) Implement and expose PlatformApi for iOS
[ https://issues.apache.org/jira/browse/CB-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15023586#comment-15023586 ] ASF GitHub Bot commented on CB-9827: Github user omefire commented on the pull request: https://github.com/apache/cordova-ios/pull/176#issuecomment-159130245 what about the ```cli``` option? It also needs to be sent forward. > Implement and expose PlatformApi for iOS > > > Key: CB-9827 > URL: https://issues.apache.org/jira/browse/CB-9827 > Project: Apache Cordova > Issue Type: Sub-task > Components: iOS >Reporter: Vladimir Kotikov >Assignee: Sergey Grebnov > Labels: PlatformApi > Fix For: 5.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9827) Implement and expose PlatformApi for iOS
[
https://issues.apache.org/jira/browse/CB-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15023468#comment-15023468
]
ASF GitHub Bot commented on CB-9827:
Github user omefire commented on the pull request:
https://github.com/apache/cordova-ios/pull/176#issuecomment-159113086
Instead of relying on 'nopt' default value for its constructor, why don't
we explicitly use: 'process.args' here ?
Something like:
```
var argv = require('nopt') ({
'help' : Boolean,
'cli' : Boolean,
'shared': Boolean,
'link' : Boolean
}, process.argv)```
> Implement and expose PlatformApi for iOS
>
>
> Key: CB-9827
> URL: https://issues.apache.org/jira/browse/CB-9827
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: iOS
>Reporter: Vladimir Kotikov
>Assignee: Sergey Grebnov
> Labels: PlatformApi
> Fix For: 5.0.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9827) Implement and expose PlatformApi for iOS
[ https://issues.apache.org/jira/browse/CB-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15018126#comment-15018126 ] ASF GitHub Bot commented on CB-9827: Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-ios/pull/176#issuecomment-158425264 TODO: @sgrebnov to rebase on top of master, fetch latest changes from cordova-lib (preferences handling change, may be more), address Mefire notes > Implement and expose PlatformApi for iOS > > > Key: CB-9827 > URL: https://issues.apache.org/jira/browse/CB-9827 > Project: Apache Cordova > Issue Type: Sub-task > Components: iOS >Reporter: Vladimir Kotikov >Assignee: Sergey Grebnov > Labels: PlatformApi > Fix For: 5.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9827) Implement and expose PlatformApi for iOS
[ https://issues.apache.org/jira/browse/CB-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15004781#comment-15004781 ] ASF GitHub Bot commented on CB-9827: Github user omefire commented on the pull request: https://github.com/apache/cordova-ios/pull/176#issuecomment-156571123 I'll take a stab at reviewing this. > Implement and expose PlatformApi for iOS > > > Key: CB-9827 > URL: https://issues.apache.org/jira/browse/CB-9827 > Project: Apache Cordova > Issue Type: Sub-task > Components: iOS >Reporter: Vladimir Kotikov >Assignee: Sergey Grebnov > Labels: PlatformApi > Fix For: 5.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9827) Implement and expose PlatformApi for iOS
[ https://issues.apache.org/jira/browse/CB-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14996371#comment-14996371 ] ASF GitHub Bot commented on CB-9827: Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-ios/pull/176#issuecomment-155028117 Re-based work on top of master and grouped all changes into two commits: 1. 6347263c80e4257506a77cece832c4c63c353145 contains implementation/changes 2. b4dd1e0bbd5bdbca3ef0bfd1561baedf38ccedaa just adds required node modules > Implement and expose PlatformApi for iOS > > > Key: CB-9827 > URL: https://issues.apache.org/jira/browse/CB-9827 > Project: Apache Cordova > Issue Type: Sub-task > Components: iOS >Reporter: Vladimir Kotikov >Assignee: Sergey Grebnov > Labels: PlatformApi > Fix For: 5.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9827) Implement and expose PlatformApi for iOS
[ https://issues.apache.org/jira/browse/CB-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986251#comment-14986251 ] ASF GitHub Bot commented on CB-9827: GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-ios/pull/176 CB-9827 Implement and expose PlatformApi for iOS https://issues.apache.org/jira/browse/CB-9827 * Prepare and plugin management functionality has been moved from Lib to platform-ios * Includes cordova-common * Replaced console.log w/ corresponding events.emit calls * I tried to reduce changes and keep files/logic as-is to simplify code review Tested using mobile-spec (also compared generated mobilespec app w/ original one using diff tool to ensure correctness) You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-ios CB-9827-platformApi Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/176.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #176 commit 6453089fbd47ea8009fc6fa0d9f6bc9af5ad99f7 Author: sgrebnov Date: 2015-10-29T06:50:56Z CB-9827 Added cordova-common as bundled mobule commit 3dec9589c5a7eea8ae50a8f9b4e86967dc0d927a Author: sgrebnov Date: 2015-10-29T12:06:00Z CB-9827 Platform create and prepare support commit b1830c5822a91bdfad4b82e3f27ebed9e0ab23aa Author: sgrebnov Date: 2015-10-31T17:47:18Z CB-9827 Updated build scripts commit 11c1bbd474d8aa6234dc73aae71827cd25f12896 Author: sgrebnov Date: 2015-10-31T21:36:55Z CB-9827 Updated run scripts commit a5ae524894a69a310fd24ed3965f1d41676cf576 Author: sgrebnov Date: 2015-11-02T07:17:05Z CB-9827 Updated clean scripts commit 1500e4f88c47d9d3a1116446ba083671ea2c5c1d Author: sgrebnov Date: 2015-11-02T13:41:45Z CB-9827 Added plugins managment logic commit b23155db64130ef90da27c455e52c612bd2afe79 Author: sgrebnov Date: 2015-11-02T14:54:20Z CB-9827 Updated create script to correcly copy cordova.js commit ea0be14268b9e355b7ee643c8f2750fd28468119 Author: sgrebnov Date: 2015-11-02T16:42:04Z CB-9827 Minor refactoring and improvements commit f3205871ac2de998471250d30db784cce5503d36 Author: sgrebnov Date: 2015-11-02T18:45:40Z CB-9827 Cordova-common updated to 1.0.0 commit 094d3e7a14c5aa85aaa834ef24951bbed8fa8209 Author: sgrebnov Date: 2015-11-02T19:16:07Z CB-9827 Replaced console.log w/ events and Error->CordovaError commit 8d028fdfd4fd647c78168617b877712efdf07747 Author: sgrebnov Date: 2015-11-02T20:11:52Z CB-9827 Cordova-common 1.0.0 from npm commit eca7800c74120bc522ed4899baf2d25fae0472bb Author: sgrebnov Date: 2015-11-02T22:04:49Z CB-9827 Plugman implementation bugfixing > Implement and expose PlatformApi for iOS > > > Key: CB-9827 > URL: https://issues.apache.org/jira/browse/CB-9827 > Project: Apache Cordova > Issue Type: Sub-task > Components: iOS >Reporter: Vladimir Kotikov >Assignee: Sergey Grebnov > Labels: PlatformApi > Fix For: 5.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
