[jira] [Commented] (CB-9828) Implement and expose PlatformApi for Windows
[ https://issues.apache.org/jira/browse/CB-9828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15094876#comment-15094876 ] ASF subversion and git services commented on CB-9828: - Commit 1c44ff5e8ab8372d559fd0fcf535615e05bd3c88 in cordova-windows's branch refs/heads/master from [~vladimir.kotikov] [ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=1c44ff5 ] CB-9828 Adds missing semver to bundled dependencies > Implement and expose PlatformApi for Windows > > > Key: CB-9828 > URL: https://issues.apache.org/jira/browse/CB-9828 > Project: Apache Cordova > Issue Type: Sub-task > Components: Windows >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: PlatformApi > Fix For: 4.3.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9828) Implement and expose PlatformApi for Windows
[ https://issues.apache.org/jira/browse/CB-9828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15094878#comment-15094878 ] ASF subversion and git services commented on CB-9828: - Commit ecee22c4b95faf6ef49e745f3036f791f3e6c762 in cordova-windows's branch refs/heads/4.3.x from [~vladimir.kotikov] [ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=ecee22c ] CB-9828 Adds missing semver to bundled dependencies > Implement and expose PlatformApi for Windows > > > Key: CB-9828 > URL: https://issues.apache.org/jira/browse/CB-9828 > Project: Apache Cordova > Issue Type: Sub-task > Components: Windows >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: PlatformApi > Fix For: 4.3.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9828) Implement and expose PlatformApi for Windows
[ https://issues.apache.org/jira/browse/CB-9828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052484#comment-15052484 ] ASF GitHub Bot commented on CB-9828: Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/132#issuecomment-163880842 This was merged in [58047a3](https://git1-us-west.apache.org/repos/asf?p=cordova-windows.git;a=commit;h=58047a3daf21dbd046a6354bf748b83f3ae7b5b9) > Implement and expose PlatformApi for Windows > > > Key: CB-9828 > URL: https://issues.apache.org/jira/browse/CB-9828 > Project: Apache Cordova > Issue Type: Sub-task > Components: Windows >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: PlatformApi > Fix For: 5.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9828) Implement and expose PlatformApi for Windows
[ https://issues.apache.org/jira/browse/CB-9828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052478#comment-15052478 ] ASF GitHub Bot commented on CB-9828: Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-windows/pull/132 > Implement and expose PlatformApi for Windows > > > Key: CB-9828 > URL: https://issues.apache.org/jira/browse/CB-9828 > Project: Apache Cordova > Issue Type: Sub-task > Components: Windows >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: PlatformApi > Fix For: 5.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9828) Implement and expose PlatformApi for Windows
[ https://issues.apache.org/jira/browse/CB-9828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15049180#comment-15049180 ] ASF GitHub Bot commented on CB-9828: Github user jasongin commented on the pull request: https://github.com/apache/cordova-windows/pull/132#issuecomment-163355408 Refactoring logging into common sounds good, but we shouldn't block this change on it. > Implement and expose PlatformApi for Windows > > > Key: CB-9828 > URL: https://issues.apache.org/jira/browse/CB-9828 > Project: Apache Cordova > Issue Type: Sub-task > Components: Windows >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: PlatformApi > Fix For: 5.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9828) Implement and expose PlatformApi for Windows
[ https://issues.apache.org/jira/browse/CB-9828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048589#comment-15048589 ] ASF GitHub Bot commented on CB-9828: Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/132#issuecomment-163206085 Addressed notes and fixed compatibility w/Node@0.12 Regarding logging, agree, we should move it common, but i propose to follow more general way - add necessary functionality to 'common', release it and update platforms (this affects iOS and Android as well) to use released 'common'. @TimBarham, @jasongin, thoughts? > Implement and expose PlatformApi for Windows > > > Key: CB-9828 > URL: https://issues.apache.org/jira/browse/CB-9828 > Project: Apache Cordova > Issue Type: Sub-task > Components: Windows >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: PlatformApi > Fix For: 5.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9828) Implement and expose PlatformApi for Windows
[ https://issues.apache.org/jira/browse/CB-9828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15046809#comment-15046809 ] ASF GitHub Bot commented on CB-9828: Github user TimBarham commented on the pull request: https://github.com/apache/cordova-windows/pull/132#issuecomment-162867249 Generally looks fine to me apart from some misplaced "Android" references I mention inline. Also, it concerns me that `ConsoleLogger` is duplicated across each platform - isn't this something that can live in `cordova-common`? Why aren't we using the same functionality as `cordova-cli`? > Implement and expose PlatformApi for Windows > > > Key: CB-9828 > URL: https://issues.apache.org/jira/browse/CB-9828 > Project: Apache Cordova > Issue Type: Sub-task > Components: Windows >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: PlatformApi > Fix For: 5.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9828) Implement and expose PlatformApi for Windows
[ https://issues.apache.org/jira/browse/CB-9828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15004835#comment-15004835 ] ASF GitHub Bot commented on CB-9828: Github user jasongin commented on the pull request: https://github.com/apache/cordova-windows/pull/132#issuecomment-156579165 I looked through all of the PR and didn't find anything concerning other than the one thing I commented on. But it's a lot of code in an area I'm not at all familiar with. > Implement and expose PlatformApi for Windows > > > Key: CB-9828 > URL: https://issues.apache.org/jira/browse/CB-9828 > Project: Apache Cordova > Issue Type: Sub-task > Components: Windows >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: PlatformApi > Fix For: 5.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9828) Implement and expose PlatformApi for Windows
[
https://issues.apache.org/jira/browse/CB-9828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15004832#comment-15004832
]
ASF GitHub Bot commented on CB-9828:
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/132#discussion_r44842471
--- Diff: bin/lib/check_reqs.js ---
@@ -209,7 +209,7 @@ function getInstalledPhoneSdks () {
}
})
.then(function () {
-return exec('reg query "HKLM\\SOFTWARE\\Microsoft\\Microsoft
SDKs\\Windows\\v10.0" /v InstallationFolder /reg:32');
+return spawn('reg','query','HKLM\\SOFTWARE\\Microsoft\\Microsoft
SDKs\\Windows\\v10.0','/v','InstallationFolder','/reg:32');
--- End diff --
Why aren't the arguments passed as an array here as above?
> Implement and expose PlatformApi for Windows
>
>
> Key: CB-9828
> URL: https://issues.apache.org/jira/browse/CB-9828
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Windows
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
> Labels: PlatformApi
> Fix For: 5.0.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9828) Implement and expose PlatformApi for Windows
[ https://issues.apache.org/jira/browse/CB-9828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14997182#comment-14997182 ] ASF GitHub Bot commented on CB-9828: GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-windows/pull/132 CB-9828 Implements PlatformApi contract for WIndows platform You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-windows CB-9828 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/132.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #132 commit d5f75326c7df816f16aeb2d1db38aaa9624b5fd4 Author: Vladimir Kotikov Date: 2015-11-09T19:05:05Z CB-9828 Implement and expose PlatformApi for Windows commit f65f42dc3216f350e404ab5cde8d72c93a47d9a5 Author: Vladimir Kotikov Date: 2015-11-09T19:06:12Z CB-9828 Upgrade and check-in node_modules > Implement and expose PlatformApi for Windows > > > Key: CB-9828 > URL: https://issues.apache.org/jira/browse/CB-9828 > Project: Apache Cordova > Issue Type: Sub-task > Components: Windows >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: PlatformApi > Fix For: 5.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
