[jira] [Commented] (CB-9909) Android requirements provides invalid android path on Windows

[asm (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002002#comment-15002002
 ] 

asm commented on CB-9909:
-

Windows app throwing Internal server error when try to login. Cordova Ver: 
4.1.0. Is whitelist plugin is the issue?


> Android requirements provides invalid android path on Windows
> -
>
> Key: CB-9909
> URL: https://issues.apache.org/jira/browse/CB-9909
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Tim Barham
>Assignee: Tim Barham
>
> When you do {{cordova requirements}} for the android platform and "Android 
> target" is not installed, on Windows it suggests opening the SDK by running:
> {{C:\Program\ Files\ (x86)\Android\android-sdk\tools\android.bat}}
> Escaping spaces like this doesn't work on Windows. Instead, for Windows, we 
> should just wrap it in quotes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9909) Android requirements provides invalid android path on Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982449#comment-14982449
 ] 

ASF GitHub Bot commented on CB-9909:


Github user omefire commented on the pull request:

https://github.com/apache/cordova-android/pull/237#issuecomment-152505807
  
LGTM!


> Android requirements provides invalid android path on Windows
> -
>
> Key: CB-9909
> URL: https://issues.apache.org/jira/browse/CB-9909
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Tim Barham
>Assignee: Tim Barham
>
> When you do {{cordova requirements}} for the android platform and "Android 
> target" is not installed, on Windows it suggests opening the SDK by running:
> {{C:\Program\ Files\ (x86)\Android\android-sdk\tools\android.bat}}
> Escaping spaces like this doesn't work on Windows. Instead, for Windows, we 
> should just wrap it in quotes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9909) Android requirements provides invalid android path on Windows

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982453#comment-14982453
 ] 

ASF subversion and git services commented on CB-9909:
-

Commit 1c90a7732526d7d71be88d121b61c8e6dcf3769b in cordova-android's branch 
refs/heads/master from [~TimBarham]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=1c90a77 ]

CB-9909 Shouldn't escape spaces in paths on Windows.. This closes #237


> Android requirements provides invalid android path on Windows
> -
>
> Key: CB-9909
> URL: https://issues.apache.org/jira/browse/CB-9909
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Tim Barham
>Assignee: Tim Barham
>
> When you do {{cordova requirements}} for the android platform and "Android 
> target" is not installed, on Windows it suggests opening the SDK by running:
> {{C:\Program\ Files\ (x86)\Android\android-sdk\tools\android.bat}}
> Escaping spaces like this doesn't work on Windows. Instead, for Windows, we 
> should just wrap it in quotes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9909) Android requirements provides invalid android path on Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982455#comment-14982455
 ] 

ASF GitHub Bot commented on CB-9909:


Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/237


> Android requirements provides invalid android path on Windows
> -
>
> Key: CB-9909
> URL: https://issues.apache.org/jira/browse/CB-9909
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Tim Barham
>Assignee: Tim Barham
>
> When you do {{cordova requirements}} for the android platform and "Android 
> target" is not installed, on Windows it suggests opening the SDK by running:
> {{C:\Program\ Files\ (x86)\Android\android-sdk\tools\android.bat}}
> Escaping spaces like this doesn't work on Windows. Instead, for Windows, we 
> should just wrap it in quotes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9909) Android requirements provides invalid android path on Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981587#comment-14981587
 ] 

ASF GitHub Bot commented on CB-9909:


GitHub user TimBarham opened a pull request:

https://github.com/apache/cordova-android/pull/237

CB-9909 Shouldn't escape spaces in paths on Windows.

Instead on windows just wrap in quotes. Note that this value is only never 
executed directly - just displayed to the user. But this way they can copy and 
paste successfully on Windows.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-android fix-android-cmd

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/237.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #237


commit e6d835df2292be642de16eb64990dc0558f00c97
Author: Tim Barham 
Date:   2015-10-29T22:30:48Z

CB-9909 Shouldn't escape spaces in paths on Windows.




> Android requirements provides invalid android path on Windows
> -
>
> Key: CB-9909
> URL: https://issues.apache.org/jira/browse/CB-9909
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Tim Barham
>Assignee: Tim Barham
>
> When you do {{cordova requirements}} for the android platform and "Android 
> target" is not installed, on Windows it suggests opening the SDK by running:
> {{C:\Program\ Files\ (x86)\Android\android-sdk\tools\android.bat}}
> Escaping spaces like this doesn't work on Windows. Instead, for Windows, we 
> should just wrap it in quotes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9909) Android requirements provides invalid android path on Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981590#comment-14981590
 ] 

ASF GitHub Bot commented on CB-9909:


Github user TimBarham commented on the pull request:

https://github.com/apache/cordova-android/pull/237#issuecomment-152359281
  
@stevengill - can you take a look at this? Thanks!


> Android requirements provides invalid android path on Windows
> -
>
> Key: CB-9909
> URL: https://issues.apache.org/jira/browse/CB-9909
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Tim Barham
>Assignee: Tim Barham
>
> When you do {{cordova requirements}} for the android platform and "Android 
> target" is not installed, on Windows it suggests opening the SDK by running:
> {{C:\Program\ Files\ (x86)\Android\android-sdk\tools\android.bat}}
> Escaping spaces like this doesn't work on Windows. Instead, for Windows, we 
> should just wrap it in quotes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9909) Android requirements provides invalid android path on Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981890#comment-14981890
 ] 

ASF GitHub Bot commented on CB-9909:


Github user stevengill commented on the pull request:

https://github.com/apache/cordova-android/pull/237#issuecomment-152415463
  
LGTM


> Android requirements provides invalid android path on Windows
> -
>
> Key: CB-9909
> URL: https://issues.apache.org/jira/browse/CB-9909
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Tim Barham
>Assignee: Tim Barham
>
> When you do {{cordova requirements}} for the android platform and "Android 
> target" is not installed, on Windows it suggests opening the SDK by running:
> {{C:\Program\ Files\ (x86)\Android\android-sdk\tools\android.bat}}
> Escaping spaces like this doesn't work on Windows. Instead, for Windows, we 
> should just wrap it in quotes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org