[jira] [Commented] (CB-9987) cordova-lib compile arguments changed

2015-11-19 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014934#comment-15014934
 ] 

ASF subversion and git services commented on CB-9987:
-

Commit 701151d295d4c8a17ea66d5bfa0a671ceeaf5c3c in cordova-lib's branch 
refs/heads/5.4.x from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=701151d ]

CB-9987 Fixing minor jshint issues to prevent test failure


> cordova-lib compile arguments changed
> -
>
> Key: CB-9987
> URL: https://issues.apache.org/jira/browse/CB-9987
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.4.0
>Reporter: Jimmy Thomson
>Assignee: Vladimir Kotikov
>Priority: Critical
> Fix For: 5.4.1
>
>
> Prior to cordova-lib 5.4.0 cordova.raw.compile accepted an object such as { 
> options: ["list", "of", "options"]}. As of 5.4.0 it seems to want { options: 
> {argv: ["list", "of", "options"]}} instead. This causes silent failures if 
> other packages attempt to use the older approach.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9987) cordova-lib compile arguments changed

2015-11-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006776#comment-15006776
 ] 

ASF GitHub Bot commented on CB-9987:


GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-lib/pull/344

CB-9987 CB-9987 Reinstall plugins for platform if they were installed with 
cordova@<5.4.0

Fix for https://issues.apache.org/jira/browse/CB-9976

More details at JIRA

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-lib CB-9987

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/344.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #344


commit 500c53fa1086f9012bbbfb2c3c46cebe9e1a7d0f
Author: Shazron Abdullah 
Date:   2015-11-16T10:44:49Z

CB-9975 - No longer able to use "all" as orientation for ios (android 
sensorLandscape tests and fix)

commit 8921f2b39a86db156db6d8ae9dff27323ef01fcb
Author: Vladimir Kotikov 
Date:   2015-11-16T15:19:47Z

CB-9987 Reinstall plugins for platform if they were installed with 
cordova@<5.4.0




> cordova-lib compile arguments changed
> -
>
> Key: CB-9987
> URL: https://issues.apache.org/jira/browse/CB-9987
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.4.0
>Reporter: Jimmy Thomson
>Assignee: Steve Gill
>Priority: Critical
> Fix For: 5.4.1
>
>
> Prior to cordova-lib 5.4.0 cordova.raw.compile accepted an object such as { 
> options: ["list", "of", "options"]}. As of 5.4.0 it seems to want { options: 
> {argv: ["list", "of", "options"]}} instead. This causes silent failures if 
> other packages attempt to use the older approach.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9987) cordova-lib compile arguments changed

2015-11-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007592#comment-15007592
 ] 

ASF GitHub Bot commented on CB-9987:


Github user TimBarham commented on the pull request:

https://github.com/apache/cordova-lib/pull/344#issuecomment-157203021
  
Note the JIRA number in the title is incorrect.


> cordova-lib compile arguments changed
> -
>
> Key: CB-9987
> URL: https://issues.apache.org/jira/browse/CB-9987
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.4.0
>Reporter: Jimmy Thomson
>Assignee: Vladimir Kotikov
>Priority: Critical
> Fix For: 5.4.1
>
>
> Prior to cordova-lib 5.4.0 cordova.raw.compile accepted an object such as { 
> options: ["list", "of", "options"]}. As of 5.4.0 it seems to want { options: 
> {argv: ["list", "of", "options"]}} instead. This causes silent failures if 
> other packages attempt to use the older approach.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9987) cordova-lib compile arguments changed

2015-11-16 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006406#comment-15006406
 ] 

ASF subversion and git services commented on CB-9987:
-

Commit 582229378680deca62fa6d9e1ab39dc3b3da5f4d in cordova-lib's branch 
refs/heads/master from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=5822293 ]

CB-9987 Fixing minor jshint issues to prevent test failure


> cordova-lib compile arguments changed
> -
>
> Key: CB-9987
> URL: https://issues.apache.org/jira/browse/CB-9987
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.4.0
>Reporter: Jimmy Thomson
>Assignee: Steve Gill
>Priority: Critical
> Fix For: 5.4.1
>
>
> Prior to cordova-lib 5.4.0 cordova.raw.compile accepted an object such as { 
> options: ["list", "of", "options"]}. As of 5.4.0 it seems to want { options: 
> {argv: ["list", "of", "options"]}} instead. This causes silent failures if 
> other packages attempt to use the older approach.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9987) cordova-lib compile arguments changed

2015-11-15 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006130#comment-15006130
 ] 

ASF subversion and git services commented on CB-9987:
-

Commit c7399e02ba9bd96c3dcd7b49e34832148159b894 in cordova-lib's branch 
refs/heads/master from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=c7399e0 ]

CB-9987 Adds compatibility layer for cordova.raw.* methods


> cordova-lib compile arguments changed
> -
>
> Key: CB-9987
> URL: https://issues.apache.org/jira/browse/CB-9987
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.4.0
>Reporter: Jimmy Thomson
>Assignee: Steve Gill
>Priority: Critical
>
> Prior to cordova-lib 5.4.0 cordova.raw.compile accepted an object such as { 
> options: ["list", "of", "options"]}. As of 5.4.0 it seems to want { options: 
> {argv: ["list", "of", "options"]}} instead. This causes silent failures if 
> other packages attempt to use the older approach.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9987) cordova-lib compile arguments changed

2015-11-13 Thread Steve Gill (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15005003#comment-15005003
 ] 

Steve Gill commented on CB-9987:


Vlad whipped up a fix for this that seems to be working. 
https://github.com/apache/cordova-lib/compare/master...MSOpenTech:CB-9987#diff-baa056f7ed3ce7430299d69fcd744670R26

> cordova-lib compile arguments changed
> -
>
> Key: CB-9987
> URL: https://issues.apache.org/jira/browse/CB-9987
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.4.0
>Reporter: Jimmy Thomson
>Assignee: Steve Gill
>Priority: Critical
>
> Prior to cordova-lib 5.4.0 cordova.raw.compile accepted an object such as { 
> options: ["list", "of", "options"]}. As of 5.4.0 it seems to want { options: 
> {argv: ["list", "of", "options"]}} instead. This causes silent failures if 
> other packages attempt to use the older approach.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9987) cordova-lib compile arguments changed

2015-11-12 Thread Jimmy Thomson (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002965#comment-15002965
 ] 

Jimmy Thomson commented on CB-9987:
---

It looks like this impacts most of the cordova.raw functions, since they now 
use the new PlatformApi, and some things that were previously passed through as 
string arguments (e.g. options: ["--device"]) are first-class citizens in the 
options object.

> cordova-lib compile arguments changed
> -
>
> Key: CB-9987
> URL: https://issues.apache.org/jira/browse/CB-9987
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.4.0
>Reporter: Jimmy Thomson
>Priority: Minor
>
> Prior to cordova-lib 5.4.0 cordova.raw.compile accepted an object such as { 
> options: ["list", "of", "options"]}. As of 5.4.0 it seems to want { options: 
> {argv: ["list", "of", "options"]}} instead. This causes silent failures if 
> other packages attempt to use the older approach.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9987) cordova-lib compile arguments changed

2015-11-12 Thread Steve Gill (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003377#comment-15003377
 ] 

Steve Gill commented on CB-9987:


Running cordova compile --device Two outputs:

New:
{code}
{ platforms: [],
  options: { device: true, argv: [] },
  verbose: false,
  silent: false,
  browserify: false,
  searchpath: undefined }
{code}

Old:
{code}
{ platforms: [],
  options: [ '--device' ],
  verbose: false,
  silent: false,
  browserify: false,
  searchpath: undefined }
{code}

> cordova-lib compile arguments changed
> -
>
> Key: CB-9987
> URL: https://issues.apache.org/jira/browse/CB-9987
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.4.0
>Reporter: Jimmy Thomson
>Assignee: Steve Gill
>Priority: Critical
>
> Prior to cordova-lib 5.4.0 cordova.raw.compile accepted an object such as { 
> options: ["list", "of", "options"]}. As of 5.4.0 it seems to want { options: 
> {argv: ["list", "of", "options"]}} instead. This causes silent failures if 
> other packages attempt to use the older approach.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9987) cordova-lib compile arguments changed

2015-11-12 Thread Steve Gill (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003276#comment-15003276
 ] 

Steve Gill commented on CB-9987:


actually i was mistaken, I don't think we need the above code as the signatures 
seem to be the same and it is just the options object that has changed. 
Reviewing them all and seeing if there is a pattern. If so, should be a easy 
fix.

> cordova-lib compile arguments changed
> -
>
> Key: CB-9987
> URL: https://issues.apache.org/jira/browse/CB-9987
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.4.0
>Reporter: Jimmy Thomson
>Assignee: Steve Gill
>Priority: Critical
>
> Prior to cordova-lib 5.4.0 cordova.raw.compile accepted an object such as { 
> options: ["list", "of", "options"]}. As of 5.4.0 it seems to want { options: 
> {argv: ["list", "of", "options"]}} instead. This causes silent failures if 
> other packages attempt to use the older approach.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9987) cordova-lib compile arguments changed

2015-11-12 Thread Steve Gill (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003203#comment-15003203
 ] 

Steve Gill commented on CB-9987:


Currently, I am going through identifying which signatures changes and write a 
compatibility layer for them. 

Might just be as easy as adding the code below to 
cordova-lib/src/cordova/cordova.js
{code}
on:function(a,b,options) {
cordova_events.on.apply(cordova_events, options ? [options] : 
arguments);
}
{code}


> cordova-lib compile arguments changed
> -
>
> Key: CB-9987
> URL: https://issues.apache.org/jira/browse/CB-9987
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.4.0
>Reporter: Jimmy Thomson
>Assignee: Steve Gill
>Priority: Critical
>
> Prior to cordova-lib 5.4.0 cordova.raw.compile accepted an object such as { 
> options: ["list", "of", "options"]}. As of 5.4.0 it seems to want { options: 
> {argv: ["list", "of", "options"]}} instead. This causes silent failures if 
> other packages attempt to use the older approach.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9987) cordova-lib compile arguments changed

2015-11-12 Thread Steve Gill (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003429#comment-15003429
 ] 

Steve Gill commented on CB-9987:


Summary:
cordova-lib used to take arguments formed for delivery to platform scripts. Now 
it takes an object(nopt created in cli case) and transforms it to be delivered 
to platform scripts. 

Issue: People using cordova-lib and the cordova.raw api have been converting 
the arguments for their use case. 

cordova raw functions should be able to handle both cases. 

> cordova-lib compile arguments changed
> -
>
> Key: CB-9987
> URL: https://issues.apache.org/jira/browse/CB-9987
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.4.0
>Reporter: Jimmy Thomson
>Assignee: Steve Gill
>Priority: Critical
>
> Prior to cordova-lib 5.4.0 cordova.raw.compile accepted an object such as { 
> options: ["list", "of", "options"]}. As of 5.4.0 it seems to want { options: 
> {argv: ["list", "of", "options"]}} instead. This causes silent failures if 
> other packages attempt to use the older approach.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9987) cordova-lib compile arguments changed

2015-11-12 Thread Steve Gill (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003439#comment-15003439
 ] 

Steve Gill commented on CB-9987:


API.js for android doesn't have getBuildArgs method, so when cordova-android@5 
is used with cordova@5.4.0, getBuildArgs is never run since API.js is used 
instead of PlatformAPIPoly.js.

getBuildArgs: 
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/platforms/PlatformApiPoly.js#L506

> cordova-lib compile arguments changed
> -
>
> Key: CB-9987
> URL: https://issues.apache.org/jira/browse/CB-9987
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.4.0
>Reporter: Jimmy Thomson
>Assignee: Steve Gill
>Priority: Critical
>
> Prior to cordova-lib 5.4.0 cordova.raw.compile accepted an object such as { 
> options: ["list", "of", "options"]}. As of 5.4.0 it seems to want { options: 
> {argv: ["list", "of", "options"]}} instead. This causes silent failures if 
> other packages attempt to use the older approach.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org