[jira] [Updated] (CB-4071) Capture error callback (should be an object)
[ https://issues.apache.org/jira/browse/CB-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser updated CB-4071: --- Component/s: (was: Windows 8) (was: Docs) (was: Android) > Capture error callback (should be an object) > > > Key: CB-4071 > URL: https://issues.apache.org/jira/browse/CB-4071 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Media Capture >Affects Versions: 2.9.0 > Environment: All > iOS >Reporter: Jonathan Bond >Priority: Minor > > When using camera.getPicture(), the cameraError is documented as a string but > on Android & iOS, it's actually an object. > On the native side in 2.7: > Android: > private static final int CAPTURE_INTERNAL_ERR = 0; > // private static final int CAPTURE_APPLICATION_BUSY = 1; > // private static final int CAPTURE_INVALID_ARGUMENT = 2; > > private static final int CAPTURE_NO_MEDIA_FILES = 3; > iOS: > enum CDVCaptureError { > > CAPTURE_INTERNAL_ERR = 0, > > CAPTURE_APPLICATION_BUSY = 1, > > CAPTURE_INVALID_ARGUMENT = 2, > > CAPTURE_NO_MEDIA_FILES = 3, > > CAPTURE_NOT_SUPPORTED = 20 > }; > Windows 8: > only string errors > Android and iOS have the same looking api on the native side, error callback > Android returns JSON: {message: '', code: int}, iOS returns JSON: {message: > '', status: int}, > Looking at the javascript api, it looks like it should return a 'new > CaptureError()' on the errorCallback, is that the direction for 3.0? > Windows only sends a string as the callback error, it's difficult to know if > the user just cancelled taking a picture or what kind of specific error > occurred. > Should I look into creating a patch? > This probably affects other apis, overall I'd like to see the CaptureError() > returned more consistently instead of strings. > It would make sense to improve this in 3.0 and possibly break BC for those > expecting strings. > CaptureError() could implement 'toString()' to mitigate potential issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-4071) Capture error callback (should be an object)
[ https://issues.apache.org/jira/browse/CB-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-4071: - Component/s: (was: iOS) > Capture error callback (should be an object) > > > Key: CB-4071 > URL: https://issues.apache.org/jira/browse/CB-4071 > Project: Apache Cordova > Issue Type: Bug > Components: Android, Docs, Plugin Media Capture, Windows 8 >Affects Versions: 2.9.0 > Environment: All >Reporter: Jonathan Bond >Priority: Minor > > When using camera.getPicture(), the cameraError is documented as a string but > on Android & iOS, it's actually an object. > On the native side in 2.7: > Android: > private static final int CAPTURE_INTERNAL_ERR = 0; > // private static final int CAPTURE_APPLICATION_BUSY = 1; > // private static final int CAPTURE_INVALID_ARGUMENT = 2; > > private static final int CAPTURE_NO_MEDIA_FILES = 3; > iOS: > enum CDVCaptureError { > > CAPTURE_INTERNAL_ERR = 0, > > CAPTURE_APPLICATION_BUSY = 1, > > CAPTURE_INVALID_ARGUMENT = 2, > > CAPTURE_NO_MEDIA_FILES = 3, > > CAPTURE_NOT_SUPPORTED = 20 > }; > Windows 8: > only string errors > Android and iOS have the same looking api on the native side, error callback > Android returns JSON: {message: '', code: int}, iOS returns JSON: {message: > '', status: int}, > Looking at the javascript api, it looks like it should return a 'new > CaptureError()' on the errorCallback, is that the direction for 3.0? > Windows only sends a string as the callback error, it's difficult to know if > the user just cancelled taking a picture or what kind of specific error > occurred. > Should I look into creating a patch? > This probably affects other apis, overall I'd like to see the CaptureError() > returned more consistently instead of strings. > It would make sense to improve this in 3.0 and possibly break BC for those > expecting strings. > CaptureError() could implement 'toString()' to mitigate potential issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-4071) Capture error callback (should be an object)
[ https://issues.apache.org/jira/browse/CB-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-4071: - Environment: All iOS was:All > Capture error callback (should be an object) > > > Key: CB-4071 > URL: https://issues.apache.org/jira/browse/CB-4071 > Project: Apache Cordova > Issue Type: Bug > Components: Android, Docs, Plugin Media Capture, Windows 8 >Affects Versions: 2.9.0 > Environment: All > iOS >Reporter: Jonathan Bond >Priority: Minor > > When using camera.getPicture(), the cameraError is documented as a string but > on Android & iOS, it's actually an object. > On the native side in 2.7: > Android: > private static final int CAPTURE_INTERNAL_ERR = 0; > // private static final int CAPTURE_APPLICATION_BUSY = 1; > // private static final int CAPTURE_INVALID_ARGUMENT = 2; > > private static final int CAPTURE_NO_MEDIA_FILES = 3; > iOS: > enum CDVCaptureError { > > CAPTURE_INTERNAL_ERR = 0, > > CAPTURE_APPLICATION_BUSY = 1, > > CAPTURE_INVALID_ARGUMENT = 2, > > CAPTURE_NO_MEDIA_FILES = 3, > > CAPTURE_NOT_SUPPORTED = 20 > }; > Windows 8: > only string errors > Android and iOS have the same looking api on the native side, error callback > Android returns JSON: {message: '', code: int}, iOS returns JSON: {message: > '', status: int}, > Looking at the javascript api, it looks like it should return a 'new > CaptureError()' on the errorCallback, is that the direction for 3.0? > Windows only sends a string as the callback error, it's difficult to know if > the user just cancelled taking a picture or what kind of specific error > occurred. > Should I look into creating a patch? > This probably affects other apis, overall I'd like to see the CaptureError() > returned more consistently instead of strings. > It would make sense to improve this in 3.0 and possibly break BC for those > expecting strings. > CaptureError() could implement 'toString()' to mitigate potential issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-4071) Capture error callback (should be an object)
[ https://issues.apache.org/jira/browse/CB-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-4071: - Labels: (was: cordova-ios-4.0.x) > Capture error callback (should be an object) > > > Key: CB-4071 > URL: https://issues.apache.org/jira/browse/CB-4071 > Project: Apache Cordova > Issue Type: Bug > Components: Android, Docs, iOS, Plugin Media Capture, Windows 8 >Affects Versions: 2.9.0 > Environment: All >Reporter: Jonathan Bond >Priority: Minor > > When using camera.getPicture(), the cameraError is documented as a string but > on Android & iOS, it's actually an object. > On the native side in 2.7: > Android: > private static final int CAPTURE_INTERNAL_ERR = 0; > // private static final int CAPTURE_APPLICATION_BUSY = 1; > // private static final int CAPTURE_INVALID_ARGUMENT = 2; > > private static final int CAPTURE_NO_MEDIA_FILES = 3; > iOS: > enum CDVCaptureError { > > CAPTURE_INTERNAL_ERR = 0, > > CAPTURE_APPLICATION_BUSY = 1, > > CAPTURE_INVALID_ARGUMENT = 2, > > CAPTURE_NO_MEDIA_FILES = 3, > > CAPTURE_NOT_SUPPORTED = 20 > }; > Windows 8: > only string errors > Android and iOS have the same looking api on the native side, error callback > Android returns JSON: {message: '', code: int}, iOS returns JSON: {message: > '', status: int}, > Looking at the javascript api, it looks like it should return a 'new > CaptureError()' on the errorCallback, is that the direction for 3.0? > Windows only sends a string as the callback error, it's difficult to know if > the user just cancelled taking a picture or what kind of specific error > occurred. > Should I look into creating a patch? > This probably affects other apis, overall I'd like to see the CaptureError() > returned more consistently instead of strings. > It would make sense to improve this in 3.0 and possibly break BC for those > expecting strings. > CaptureError() could implement 'toString()' to mitigate potential issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-4071) Capture error callback (should be an object)
[ https://issues.apache.org/jira/browse/CB-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-4071: - Labels: cordova-ios-4.0.x (was: ) Fix Version/s: (was: 4.0.0) > Capture error callback (should be an object) > > > Key: CB-4071 > URL: https://issues.apache.org/jira/browse/CB-4071 > Project: Apache Cordova > Issue Type: Bug > Components: Android, Docs, iOS, Plugin Media Capture, Windows 8 >Affects Versions: 2.9.0 > Environment: All >Reporter: Jonathan Bond >Priority: Minor > Labels: cordova-ios-4.0.x > > When using camera.getPicture(), the cameraError is documented as a string but > on Android & iOS, it's actually an object. > On the native side in 2.7: > Android: > private static final int CAPTURE_INTERNAL_ERR = 0; > // private static final int CAPTURE_APPLICATION_BUSY = 1; > // private static final int CAPTURE_INVALID_ARGUMENT = 2; > > private static final int CAPTURE_NO_MEDIA_FILES = 3; > iOS: > enum CDVCaptureError { > > CAPTURE_INTERNAL_ERR = 0, > > CAPTURE_APPLICATION_BUSY = 1, > > CAPTURE_INVALID_ARGUMENT = 2, > > CAPTURE_NO_MEDIA_FILES = 3, > > CAPTURE_NOT_SUPPORTED = 20 > }; > Windows 8: > only string errors > Android and iOS have the same looking api on the native side, error callback > Android returns JSON: {message: '', code: int}, iOS returns JSON: {message: > '', status: int}, > Looking at the javascript api, it looks like it should return a 'new > CaptureError()' on the errorCallback, is that the direction for 3.0? > Windows only sends a string as the callback error, it's difficult to know if > the user just cancelled taking a picture or what kind of specific error > occurred. > Should I look into creating a patch? > This probably affects other apis, overall I'd like to see the CaptureError() > returned more consistently instead of strings. > It would make sense to improve this in 3.0 and possibly break BC for those > expecting strings. > CaptureError() could implement 'toString()' to mitigate potential issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-4071) Capture error callback (should be an object)
[ https://issues.apache.org/jira/browse/CB-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-4071: - Fix Version/s: (was: 3.6.0) 4.0.0 Capture error callback (should be an object) Key: CB-4071 URL: https://issues.apache.org/jira/browse/CB-4071 Project: Apache Cordova Issue Type: Bug Components: Android, Docs, iOS, Plugin Media Capture, Windows 8 Affects Versions: 2.9.0 Environment: All Reporter: Jonathan Bond Priority: Minor Fix For: 4.0.0 When using camera.getPicture(), the cameraError is documented as a string but on Android iOS, it's actually an object. On the native side in 2.7: Android: private static final int CAPTURE_INTERNAL_ERR = 0; // private static final int CAPTURE_APPLICATION_BUSY = 1; // private static final int CAPTURE_INVALID_ARGUMENT = 2; private static final int CAPTURE_NO_MEDIA_FILES = 3; iOS: enum CDVCaptureError { CAPTURE_INTERNAL_ERR = 0, CAPTURE_APPLICATION_BUSY = 1, CAPTURE_INVALID_ARGUMENT = 2, CAPTURE_NO_MEDIA_FILES = 3, CAPTURE_NOT_SUPPORTED = 20 }; Windows 8: only string errors Android and iOS have the same looking api on the native side, error callback Android returns JSON: {message: '', code: int}, iOS returns JSON: {message: '', status: int}, Looking at the javascript api, it looks like it should return a 'new CaptureError()' on the errorCallback, is that the direction for 3.0? Windows only sends a string as the callback error, it's difficult to know if the user just cancelled taking a picture or what kind of specific error occurred. Should I look into creating a patch? This probably affects other apis, overall I'd like to see the CaptureError() returned more consistently instead of strings. It would make sense to improve this in 3.0 and possibly break BC for those expecting strings. CaptureError() could implement 'toString()' to mitigate potential issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-4071) Capture error callback (should be an object)
[ https://issues.apache.org/jira/browse/CB-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-4071: - Fix Version/s: (was: 3.5.0) 3.6.0 Capture error callback (should be an object) Key: CB-4071 URL: https://issues.apache.org/jira/browse/CB-4071 Project: Apache Cordova Issue Type: Bug Components: Android, Docs, iOS, Plugin Media Capture, Windows 8 Affects Versions: 2.9.0 Environment: All Reporter: Jonathan Bond Priority: Minor Fix For: 3.6.0 When using camera.getPicture(), the cameraError is documented as a string but on Android iOS, it's actually an object. On the native side in 2.7: Android: private static final int CAPTURE_INTERNAL_ERR = 0; // private static final int CAPTURE_APPLICATION_BUSY = 1; // private static final int CAPTURE_INVALID_ARGUMENT = 2; private static final int CAPTURE_NO_MEDIA_FILES = 3; iOS: enum CDVCaptureError { CAPTURE_INTERNAL_ERR = 0, CAPTURE_APPLICATION_BUSY = 1, CAPTURE_INVALID_ARGUMENT = 2, CAPTURE_NO_MEDIA_FILES = 3, CAPTURE_NOT_SUPPORTED = 20 }; Windows 8: only string errors Android and iOS have the same looking api on the native side, error callback Android returns JSON: {message: '', code: int}, iOS returns JSON: {message: '', status: int}, Looking at the javascript api, it looks like it should return a 'new CaptureError()' on the errorCallback, is that the direction for 3.0? Windows only sends a string as the callback error, it's difficult to know if the user just cancelled taking a picture or what kind of specific error occurred. Should I look into creating a patch? This probably affects other apis, overall I'd like to see the CaptureError() returned more consistently instead of strings. It would make sense to improve this in 3.0 and possibly break BC for those expecting strings. CaptureError() could implement 'toString()' to mitigate potential issues. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-4071) Capture error callback (should be an object)
[ https://issues.apache.org/jira/browse/CB-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-4071: - Fix Version/s: (was: 3.4.0) 3.5.0 Capture error callback (should be an object) Key: CB-4071 URL: https://issues.apache.org/jira/browse/CB-4071 Project: Apache Cordova Issue Type: Bug Components: Android, Docs, iOS, Plugin Media Capture, Windows 8 Affects Versions: 2.9.0 Environment: All Reporter: Jonathan Bond Assignee: Joe Bowser Priority: Minor Fix For: 3.5.0 When using camera.getPicture(), the cameraError is documented as a string but on Android iOS, it's actually an object. On the native side in 2.7: Android: private static final int CAPTURE_INTERNAL_ERR = 0; // private static final int CAPTURE_APPLICATION_BUSY = 1; // private static final int CAPTURE_INVALID_ARGUMENT = 2; private static final int CAPTURE_NO_MEDIA_FILES = 3; iOS: enum CDVCaptureError { CAPTURE_INTERNAL_ERR = 0, CAPTURE_APPLICATION_BUSY = 1, CAPTURE_INVALID_ARGUMENT = 2, CAPTURE_NO_MEDIA_FILES = 3, CAPTURE_NOT_SUPPORTED = 20 }; Windows 8: only string errors Android and iOS have the same looking api on the native side, error callback Android returns JSON: {message: '', code: int}, iOS returns JSON: {message: '', status: int}, Looking at the javascript api, it looks like it should return a 'new CaptureError()' on the errorCallback, is that the direction for 3.0? Windows only sends a string as the callback error, it's difficult to know if the user just cancelled taking a picture or what kind of specific error occurred. Should I look into creating a patch? This probably affects other apis, overall I'd like to see the CaptureError() returned more consistently instead of strings. It would make sense to improve this in 3.0 and possibly break BC for those expecting strings. CaptureError() could implement 'toString()' to mitigate potential issues. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-4071) Capture error callback (should be an object)
[ https://issues.apache.org/jira/browse/CB-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser updated CB-4071: --- Priority: Minor (was: Major) It really should be an object, and this applies to all Cordova, but we survived 6 releases with it not being an object. Capture error callback (should be an object) Key: CB-4071 URL: https://issues.apache.org/jira/browse/CB-4071 Project: Apache Cordova Issue Type: Bug Components: Android, Docs, iOS, Plugin Media Capture, Windows 8 Affects Versions: 2.9.0 Environment: All Reporter: Jonathan Bond Assignee: Joe Bowser Priority: Minor Fix For: 3.4.0 When using camera.getPicture(), the cameraError is documented as a string but on Android iOS, it's actually an object. On the native side in 2.7: Android: private static final int CAPTURE_INTERNAL_ERR = 0; // private static final int CAPTURE_APPLICATION_BUSY = 1; // private static final int CAPTURE_INVALID_ARGUMENT = 2; private static final int CAPTURE_NO_MEDIA_FILES = 3; iOS: enum CDVCaptureError { CAPTURE_INTERNAL_ERR = 0, CAPTURE_APPLICATION_BUSY = 1, CAPTURE_INVALID_ARGUMENT = 2, CAPTURE_NO_MEDIA_FILES = 3, CAPTURE_NOT_SUPPORTED = 20 }; Windows 8: only string errors Android and iOS have the same looking api on the native side, error callback Android returns JSON: {message: '', code: int}, iOS returns JSON: {message: '', status: int}, Looking at the javascript api, it looks like it should return a 'new CaptureError()' on the errorCallback, is that the direction for 3.0? Windows only sends a string as the callback error, it's difficult to know if the user just cancelled taking a picture or what kind of specific error occurred. Should I look into creating a patch? This probably affects other apis, overall I'd like to see the CaptureError() returned more consistently instead of strings. It would make sense to improve this in 3.0 and possibly break BC for those expecting strings. CaptureError() could implement 'toString()' to mitigate potential issues. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (CB-4071) Capture error callback (should be an object)
[ https://issues.apache.org/jira/browse/CB-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser updated CB-4071: --- Fix Version/s: (was: 3.3.0) 3.4.0 Capture error callback (should be an object) Key: CB-4071 URL: https://issues.apache.org/jira/browse/CB-4071 Project: Apache Cordova Issue Type: Bug Components: Android, Docs, iOS, Plugin Media Capture, Windows 8 Affects Versions: 2.9.0 Environment: All Reporter: Jonathan Bond Assignee: Joe Bowser Fix For: 3.4.0 When using camera.getPicture(), the cameraError is documented as a string but on Android iOS, it's actually an object. On the native side in 2.7: Android: private static final int CAPTURE_INTERNAL_ERR = 0; // private static final int CAPTURE_APPLICATION_BUSY = 1; // private static final int CAPTURE_INVALID_ARGUMENT = 2; private static final int CAPTURE_NO_MEDIA_FILES = 3; iOS: enum CDVCaptureError { CAPTURE_INTERNAL_ERR = 0, CAPTURE_APPLICATION_BUSY = 1, CAPTURE_INVALID_ARGUMENT = 2, CAPTURE_NO_MEDIA_FILES = 3, CAPTURE_NOT_SUPPORTED = 20 }; Windows 8: only string errors Android and iOS have the same looking api on the native side, error callback Android returns JSON: {message: '', code: int}, iOS returns JSON: {message: '', status: int}, Looking at the javascript api, it looks like it should return a 'new CaptureError()' on the errorCallback, is that the direction for 3.0? Windows only sends a string as the callback error, it's difficult to know if the user just cancelled taking a picture or what kind of specific error occurred. Should I look into creating a patch? This probably affects other apis, overall I'd like to see the CaptureError() returned more consistently instead of strings. It would make sense to improve this in 3.0 and possibly break BC for those expecting strings. CaptureError() could implement 'toString()' to mitigate potential issues. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Updated] (CB-4071) Capture error callback (should be an object)
[ https://issues.apache.org/jira/browse/CB-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-4071: - Fix Version/s: (was: 3.2.0) 3.3.0 Capture error callback (should be an object) Key: CB-4071 URL: https://issues.apache.org/jira/browse/CB-4071 Project: Apache Cordova Issue Type: Bug Components: Android, Docs, iOS, Plugin Media Capture, Windows 8 Affects Versions: 2.9.0 Environment: All Reporter: Jonathan Bond Assignee: Joe Bowser Fix For: 3.3.0 When using camera.getPicture(), the cameraError is documented as a string but on Android iOS, it's actually an object. On the native side in 2.7: Android: private static final int CAPTURE_INTERNAL_ERR = 0; // private static final int CAPTURE_APPLICATION_BUSY = 1; // private static final int CAPTURE_INVALID_ARGUMENT = 2; private static final int CAPTURE_NO_MEDIA_FILES = 3; iOS: enum CDVCaptureError { CAPTURE_INTERNAL_ERR = 0, CAPTURE_APPLICATION_BUSY = 1, CAPTURE_INVALID_ARGUMENT = 2, CAPTURE_NO_MEDIA_FILES = 3, CAPTURE_NOT_SUPPORTED = 20 }; Windows 8: only string errors Android and iOS have the same looking api on the native side, error callback Android returns JSON: {message: '', code: int}, iOS returns JSON: {message: '', status: int}, Looking at the javascript api, it looks like it should return a 'new CaptureError()' on the errorCallback, is that the direction for 3.0? Windows only sends a string as the callback error, it's difficult to know if the user just cancelled taking a picture or what kind of specific error occurred. Should I look into creating a patch? This probably affects other apis, overall I'd like to see the CaptureError() returned more consistently instead of strings. It would make sense to improve this in 3.0 and possibly break BC for those expecting strings. CaptureError() could implement 'toString()' to mitigate potential issues. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (CB-4071) Capture error callback (should be an object)
[ https://issues.apache.org/jira/browse/CB-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Clelland updated CB-4071: - Component/s: Plugin Media Capture Capture error callback (should be an object) Key: CB-4071 URL: https://issues.apache.org/jira/browse/CB-4071 Project: Apache Cordova Issue Type: Bug Components: Android, Docs, iOS, Plugin Media Capture, Windows 8 Affects Versions: 2.9.0 Environment: All Reporter: Jonathan Bond-Caron Assignee: Joe Bowser Fix For: 3.2.0 When using camera.getPicture(), the cameraError is documented as a string but on Android iOS, it's actually an object. On the native side in 2.7: Android: private static final int CAPTURE_INTERNAL_ERR = 0; // private static final int CAPTURE_APPLICATION_BUSY = 1; // private static final int CAPTURE_INVALID_ARGUMENT = 2; private static final int CAPTURE_NO_MEDIA_FILES = 3; iOS: enum CDVCaptureError { CAPTURE_INTERNAL_ERR = 0, CAPTURE_APPLICATION_BUSY = 1, CAPTURE_INVALID_ARGUMENT = 2, CAPTURE_NO_MEDIA_FILES = 3, CAPTURE_NOT_SUPPORTED = 20 }; Windows 8: only string errors Android and iOS have the same looking api on the native side, error callback Android returns JSON: {message: '', code: int}, iOS returns JSON: {message: '', status: int}, Looking at the javascript api, it looks like it should return a 'new CaptureError()' on the errorCallback, is that the direction for 3.0? Windows only sends a string as the callback error, it's difficult to know if the user just cancelled taking a picture or what kind of specific error occurred. Should I look into creating a patch? This probably affects other apis, overall I'd like to see the CaptureError() returned more consistently instead of strings. It would make sense to improve this in 3.0 and possibly break BC for those expecting strings. CaptureError() could implement 'toString()' to mitigate potential issues. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (CB-4071) Capture error callback (should be an object)
[ https://issues.apache.org/jira/browse/CB-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser updated CB-4071: --- Fix Version/s: (was: 3.1.0) 3.2.0 What happened with this? This isn't going to land in 3.1.0. :( Capture error callback (should be an object) Key: CB-4071 URL: https://issues.apache.org/jira/browse/CB-4071 Project: Apache Cordova Issue Type: Bug Components: Android, Docs, iOS, Windows 8 Affects Versions: 2.9.0 Environment: All Reporter: Jonathan Bond-Caron Assignee: Joe Bowser Fix For: 3.2.0 When using camera.getPicture(), the cameraError is documented as a string but on Android iOS, it's actually an object. On the native side in 2.7: Android: private static final int CAPTURE_INTERNAL_ERR = 0; // private static final int CAPTURE_APPLICATION_BUSY = 1; // private static final int CAPTURE_INVALID_ARGUMENT = 2; private static final int CAPTURE_NO_MEDIA_FILES = 3; iOS: enum CDVCaptureError { CAPTURE_INTERNAL_ERR = 0, CAPTURE_APPLICATION_BUSY = 1, CAPTURE_INVALID_ARGUMENT = 2, CAPTURE_NO_MEDIA_FILES = 3, CAPTURE_NOT_SUPPORTED = 20 }; Windows 8: only string errors Android and iOS have the same looking api on the native side, error callback Android returns JSON: {message: '', code: int}, iOS returns JSON: {message: '', status: int}, Looking at the javascript api, it looks like it should return a 'new CaptureError()' on the errorCallback, is that the direction for 3.0? Windows only sends a string as the callback error, it's difficult to know if the user just cancelled taking a picture or what kind of specific error occurred. Should I look into creating a patch? This probably affects other apis, overall I'd like to see the CaptureError() returned more consistently instead of strings. It would make sense to improve this in 3.0 and possibly break BC for those expecting strings. CaptureError() could implement 'toString()' to mitigate potential issues. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-4071) Capture error callback (should be an object)
[ https://issues.apache.org/jira/browse/CB-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-4071: - Fix Version/s: 3.1.0 Capture error callback (should be an object) Key: CB-4071 URL: https://issues.apache.org/jira/browse/CB-4071 Project: Apache Cordova Issue Type: Bug Components: Android, Docs, iOS, Windows 8 Affects Versions: 2.9.0 Environment: All Reporter: Jonathan Bond-Caron Assignee: Joe Bowser Fix For: 3.1.0 When using camera.getPicture(), the cameraError is documented as a string but on Android iOS, it's actually an object. On the native side in 2.7: Android: private static final int CAPTURE_INTERNAL_ERR = 0; // private static final int CAPTURE_APPLICATION_BUSY = 1; // private static final int CAPTURE_INVALID_ARGUMENT = 2; private static final int CAPTURE_NO_MEDIA_FILES = 3; iOS: enum CDVCaptureError { CAPTURE_INTERNAL_ERR = 0, CAPTURE_APPLICATION_BUSY = 1, CAPTURE_INVALID_ARGUMENT = 2, CAPTURE_NO_MEDIA_FILES = 3, CAPTURE_NOT_SUPPORTED = 20 }; Windows 8: only string errors Android and iOS have the same looking api on the native side, error callback Android returns JSON: {message: '', code: int}, iOS returns JSON: {message: '', status: int}, Looking at the javascript api, it looks like it should return a 'new CaptureError()' on the errorCallback, is that the direction for 3.0? Windows only sends a string as the callback error, it's difficult to know if the user just cancelled taking a picture or what kind of specific error occurred. Should I look into creating a patch? This probably affects other apis, overall I'd like to see the CaptureError() returned more consistently instead of strings. It would make sense to improve this in 3.0 and possibly break BC for those expecting strings. CaptureError() could implement 'toString()' to mitigate potential issues. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-4071) Capture error callback (should be an object)
[ https://issues.apache.org/jira/browse/CB-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Bond-Caron updated CB-4071: Description: When using camera.getPicture(), the cameraError is documented as a string but on Android iOS, it's actually an object. On the native side in 2.7: Android: private static final int CAPTURE_INTERNAL_ERR = 0; // private static final int CAPTURE_APPLICATION_BUSY = 1; // private static final int CAPTURE_INVALID_ARGUMENT = 2; private static final int CAPTURE_NO_MEDIA_FILES = 3; iOS: enum CDVCaptureError { CAPTURE_INTERNAL_ERR = 0, CAPTURE_APPLICATION_BUSY = 1, CAPTURE_INVALID_ARGUMENT = 2, CAPTURE_NO_MEDIA_FILES = 3, CAPTURE_NOT_SUPPORTED = 20 }; Windows 8: only string errors Android and iOS have the same looking api on the native side, error callback Android returns JSON: {message: '', code: int}, iOS returns JSON: {message: '', status: int}, Looking at the javascript api, it looks like it should return a 'new CaptureError()' on the errorCallback, is that the direction for 3.0? Windows only sends a string as the callback error, it's difficult to know if the user just cancelled taking a picture or what kind of specific error occurred. Should I look into creating a patch? This probably affects other apis, overall I'd like to see the CaptureError() returned more consistently instead of strings. It would make sense to improve this in 3.0 and possibly break BC for those expecting strings. CaptureError() could implement 'toString()' to mitigate potential issues. was: When using camera.getPicture(), the cameraError is documented as a string but on Android iOS, it's actually an object. On the native side in 2.7: Android: private static final int CAPTURE_INTERNAL_ERR = 0; // private static final int CAPTURE_APPLICATION_BUSY = 1; // private static final int CAPTURE_INVALID_ARGUMENT = 2; private static final int CAPTURE_NO_MEDIA_FILES = 3; iOS: enum CDVCaptureError { CAPTURE_INTERNAL_ERR = 0, CAPTURE_APPLICATION_BUSY = 1, CAPTURE_INVALID_ARGUMENT = 2, CAPTURE_NO_MEDIA_FILES = 3, CAPTURE_NOT_SUPPORTED = 20 }; Windows 8: only string errors Android and iOS have the same looking api on the native side, error callback Android returns JSON: {message: '', code: int}, iOS returns JSON: {message: '', status: int}, Looking at the javascript api, it looks like it should return a 'new CaptureError()' on the errorCallback, is that the direction for 3.0? Windows only sends a string as the callback error, it's difficult to know if the user just cancelled taking a picture or what kind of specific error occurred. Should I look into creating a patch? This probably affects other apis, overall I'd like to see the CaptureError() returned more consistently instead of strings. It would make sense to improve this in 3.0 and possibly break BC for those expecting strings. CaptureError() could implemented a 'toString()' to mitigate potential issues. Capture error callback (should be an object) Key: CB-4071 URL: https://issues.apache.org/jira/browse/CB-4071 Project: Apache Cordova Issue Type: Bug Components: Android, Docs, iOS, Windows 8 Affects Versions: 2.9.0 Environment: All Reporter: Jonathan Bond-Caron Assignee: Joe Bowser When using camera.getPicture(), the cameraError is documented as a string but on Android iOS, it's actually an object. On the native side in 2.7: Android: private static final int CAPTURE_INTERNAL_ERR = 0; // private static final int CAPTURE_APPLICATION_BUSY = 1; // private static final int CAPTURE_INVALID_ARGUMENT = 2; private static final int CAPTURE_NO_MEDIA_FILES = 3; iOS: enum CDVCaptureError { CAPTURE_INTERNAL_ERR = 0, CAPTURE_APPLICATION_BUSY = 1, CAPTURE_INVALID_ARGUMENT = 2, CAPTURE_NO_MEDIA_FILES = 3, CAPTURE_NOT_SUPPORTED = 20 }; Windows 8: only string errors Android and iOS have the same looking api on the native side, error callback Android returns JSON: {message: '', code: int}, iOS returns JSON: {message: '', status: int}, Looking at the javascript api, it looks like it should return a 'new CaptureError()' on the errorCallback, is that the direction for 3.0? Windows only sends a string as the callback error, it's difficult to know if the user just cancelled taking a picture or what kind of specific error occurred. Should I look into creating a patch? This probably affects other apis, overall I'd like to see the CaptureError() returned more consistently instead of strings. It would make sense to improve this in 3.0 and possibly break BC for those expecting strings. CaptureError() could implement