[jira] [Updated] (CB-4603) InAppBrowser parseFeature doesn't strip whitespace from supplied options
[ https://issues.apache.org/jira/browse/CB-4603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-4603: - Assignee: (was: Joe Bowser) Component/s: (was: Android) (was: iOS) > InAppBrowser parseFeature doesn't strip whitespace from supplied options > > > Key: CB-4603 > URL: https://issues.apache.org/jira/browse/CB-4603 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin InAppBrowser >Affects Versions: 3.0.0 > Environment: Android, iOS >Reporter: Jon Whitlock >Priority: Minor > Labels: Triaged > > Short story: > window.open('/', '_blank', 'location=no,hidden=yes'); > ... works, > window.open('/', '_blank', 'location=no, hidden=yes'); > ... doesn't. > parseFeature does > StringTokenizer features = new StringTokenizer(optString, ","); > ... where optString is that third parameter. Then in the case of deciding if > a window should be hidden on launch, in showWebPage tries; > Boolean hidden = features.get(HIDDEN); > where > private static final String HIDDEN = "hidden"; > "hidden" != " hidden" ;) > 'location = no,hidden = yes' etc also breaks it. > It's a one-line fix, around line 248 in InAppBrowser.java; > {code:title=InAppBrowser.java|borderStyle=solid} > private HashMap parseFeature(String optString) { > if (optString.equals(NULL)) { > return null; > } else { > HashMap map = new HashMap(); > optString = optString.replaceAll("\\s",""); /* this line fixes > it*/ > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-4603) InAppBrowser parseFeature doesn't strip whitespace from supplied options
[ https://issues.apache.org/jira/browse/CB-4603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile updated CB-4603: - Component/s: iOS > InAppBrowser parseFeature doesn't strip whitespace from supplied options > > > Key: CB-4603 > URL: https://issues.apache.org/jira/browse/CB-4603 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, iOS, Plugin InAppBrowser >Affects Versions: 3.0.0 > Environment: Android, iOS >Reporter: Jon Whitlock >Assignee: Joe Bowser >Priority: Minor > Labels: Triaged > > Short story: > window.open('/', '_blank', 'location=no,hidden=yes'); > ... works, > window.open('/', '_blank', 'location=no, hidden=yes'); > ... doesn't. > parseFeature does > StringTokenizer features = new StringTokenizer(optString, ","); > ... where optString is that third parameter. Then in the case of deciding if > a window should be hidden on launch, in showWebPage tries; > Boolean hidden = features.get(HIDDEN); > where > private static final String HIDDEN = "hidden"; > "hidden" != " hidden" ;) > 'location = no,hidden = yes' etc also breaks it. > It's a one-line fix, around line 248 in InAppBrowser.java; > {code:title=InAppBrowser.java|borderStyle=solid} > private HashMap parseFeature(String optString) { > if (optString.equals(NULL)) { > return null; > } else { > HashMap map = new HashMap(); > optString = optString.replaceAll("\\s",""); /* this line fixes > it*/ > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-4603) InAppBrowser parseFeature doesn't strip whitespace from supplied options
[ https://issues.apache.org/jira/browse/CB-4603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile updated CB-4603: - Environment: Android, iOS was:Android > InAppBrowser parseFeature doesn't strip whitespace from supplied options > > > Key: CB-4603 > URL: https://issues.apache.org/jira/browse/CB-4603 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, iOS, Plugin InAppBrowser >Affects Versions: 3.0.0 > Environment: Android, iOS >Reporter: Jon Whitlock >Assignee: Joe Bowser >Priority: Minor > Labels: Triaged > > Short story: > window.open('/', '_blank', 'location=no,hidden=yes'); > ... works, > window.open('/', '_blank', 'location=no, hidden=yes'); > ... doesn't. > parseFeature does > StringTokenizer features = new StringTokenizer(optString, ","); > ... where optString is that third parameter. Then in the case of deciding if > a window should be hidden on launch, in showWebPage tries; > Boolean hidden = features.get(HIDDEN); > where > private static final String HIDDEN = "hidden"; > "hidden" != " hidden" ;) > 'location = no,hidden = yes' etc also breaks it. > It's a one-line fix, around line 248 in InAppBrowser.java; > {code:title=InAppBrowser.java|borderStyle=solid} > private HashMap parseFeature(String optString) { > if (optString.equals(NULL)) { > return null; > } else { > HashMap map = new HashMap(); > optString = optString.replaceAll("\\s",""); /* this line fixes > it*/ > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-4603) InAppBrowser parseFeature doesn't strip whitespace from supplied options
[ https://issues.apache.org/jira/browse/CB-4603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Grebnov updated CB-4603: --- Issue Type: Improvement (was: Bug) > InAppBrowser parseFeature doesn't strip whitespace from supplied options > > > Key: CB-4603 > URL: https://issues.apache.org/jira/browse/CB-4603 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, Plugin InAppBrowser >Affects Versions: 3.0.0 > Environment: Android >Reporter: Jon Whitlock >Assignee: Joe Bowser >Priority: Minor > Labels: Triaged > > Short story: > window.open('/', '_blank', 'location=no,hidden=yes'); > ... works, > window.open('/', '_blank', 'location=no, hidden=yes'); > ... doesn't. > parseFeature does > StringTokenizer features = new StringTokenizer(optString, ","); > ... where optString is that third parameter. Then in the case of deciding if > a window should be hidden on launch, in showWebPage tries; > Boolean hidden = features.get(HIDDEN); > where > private static final String HIDDEN = "hidden"; > "hidden" != " hidden" ;) > 'location = no,hidden = yes' etc also breaks it. > It's a one-line fix, around line 248 in InAppBrowser.java; > {code:title=InAppBrowser.java|borderStyle=solid} > private HashMap parseFeature(String optString) { > if (optString.equals(NULL)) { > return null; > } else { > HashMap map = new HashMap(); > optString = optString.replaceAll("\\s",""); /* this line fixes > it*/ > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-4603) InAppBrowser parseFeature doesn't strip whitespace from supplied options
[ https://issues.apache.org/jira/browse/CB-4603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Grebnov updated CB-4603: --- Labels: Triaged (was: ) > InAppBrowser parseFeature doesn't strip whitespace from supplied options > > > Key: CB-4603 > URL: https://issues.apache.org/jira/browse/CB-4603 > Project: Apache Cordova > Issue Type: Bug > Components: Android, Plugin InAppBrowser >Affects Versions: 3.0.0 > Environment: Android >Reporter: Jon Whitlock >Assignee: Joe Bowser >Priority: Minor > Labels: Triaged > > Short story: > window.open('/', '_blank', 'location=no,hidden=yes'); > ... works, > window.open('/', '_blank', 'location=no, hidden=yes'); > ... doesn't. > parseFeature does > StringTokenizer features = new StringTokenizer(optString, ","); > ... where optString is that third parameter. Then in the case of deciding if > a window should be hidden on launch, in showWebPage tries; > Boolean hidden = features.get(HIDDEN); > where > private static final String HIDDEN = "hidden"; > "hidden" != " hidden" ;) > 'location = no,hidden = yes' etc also breaks it. > It's a one-line fix, around line 248 in InAppBrowser.java; > {code:title=InAppBrowser.java|borderStyle=solid} > private HashMap parseFeature(String optString) { > if (optString.equals(NULL)) { > return null; > } else { > HashMap map = new HashMap(); > optString = optString.replaceAll("\\s",""); /* this line fixes > it*/ > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-4603) InAppBrowser parseFeature doesn't strip whitespace from supplied options
[ https://issues.apache.org/jira/browse/CB-4603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Whitlock updated CB-4603: - Description: Short story: window.open('/', '_blank', 'location=no,hidden=yes'); ... works, window.open('/', '_blank', 'location=no, hidden=yes'); ... doesn't. parseFeature does StringTokenizer features = new StringTokenizer(optString, ","); ... where optString is that third parameter. Then in the case of deciding if a window should be hidden on launch, in showWebPage tries; Boolean hidden = features.get(HIDDEN); where private static final String HIDDEN = "hidden"; "hidden" != " hidden" ;) 'location = no,hidden = yes' etc also breaks it. It's a one-line fix, around line 248 in InAppBrowser.java; {code:title=InAppBrowser.java|borderStyle=solid} private HashMap parseFeature(String optString) { if (optString.equals(NULL)) { return null; } else { HashMap map = new HashMap(); optString = optString.replaceAll("\\s",""); /* this line fixes it*/ {code} was: Short story: window.open('/', '_blank', 'location=no,hidden=yes'); ... works, window.open('/', '_blank', 'location=no, hidden=yes'); ... doesn't. parseFeature does StringTokenizer features = new StringTokenizer(optString, ","); ... where optString is that third parameter. Then in the case of deciding if a window should be hidden on launch, in showWebPage tries; Boolean hidden = features.get(HIDDEN); where private static final String HIDDEN = "hidden"; "hidden" != " hidden" ;) 'location = no,hidden = yes' etc also breaks it. It's a one-line fix, around line 248 in InAppBrowser.java; {code:title=Bar.java|borderStyle=solid} private HashMap parseFeature(String optString) { if (optString.equals(NULL)) { return null; } else { HashMap map = new HashMap(); optString = optString.replaceAll("\\s",""); /* this line fixes it*/ {code} > InAppBrowser parseFeature doesn't strip whitespace from supplied options > > > Key: CB-4603 > URL: https://issues.apache.org/jira/browse/CB-4603 > Project: Apache Cordova > Issue Type: Bug > Components: Android, Plugin InAppBrowser >Affects Versions: 3.0.0 > Environment: Android >Reporter: Jon Whitlock >Assignee: Joe Bowser >Priority: Minor > > Short story: > window.open('/', '_blank', 'location=no,hidden=yes'); > ... works, > window.open('/', '_blank', 'location=no, hidden=yes'); > ... doesn't. > parseFeature does > StringTokenizer features = new StringTokenizer(optString, ","); > ... where optString is that third parameter. Then in the case of deciding if > a window should be hidden on launch, in showWebPage tries; > Boolean hidden = features.get(HIDDEN); > where > private static final String HIDDEN = "hidden"; > "hidden" != " hidden" ;) > 'location = no,hidden = yes' etc also breaks it. > It's a one-line fix, around line 248 in InAppBrowser.java; > {code:title=InAppBrowser.java|borderStyle=solid} > private HashMap parseFeature(String optString) { > if (optString.equals(NULL)) { > return null; > } else { > HashMap map = new HashMap(); > optString = optString.replaceAll("\\s",""); /* this line fixes > it*/ > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-4603) InAppBrowser parseFeature doesn't strip whitespace from supplied options
[ https://issues.apache.org/jira/browse/CB-4603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Whitlock updated CB-4603: - Description: Short story: window.open('/', '_blank', 'location=no,hidden=yes'); ... works, window.open('/', '_blank', 'location=no, hidden=yes'); ... doesn't. parseFeature does StringTokenizer features = new StringTokenizer(optString, ","); ... where optString is that third parameter. Then in the case of deciding if a window should be hidden on launch, in showWebPage tries; Boolean hidden = features.get(HIDDEN); where private static final String HIDDEN = "hidden"; "hidden" != " hidden" ;) 'location = no,hidden = yes' etc also breaks it. It's a one-line fix, around line 248 in InAppBrowser.java; {code:title=Bar.java|borderStyle=solid} private HashMap parseFeature(String optString) { if (optString.equals(NULL)) { return null; } else { HashMap map = new HashMap(); optString = optString.replaceAll("\\s",""); /* this line fixes it*/ {code} was: Short story: window.open('/', '_blank', 'location=no,hidden=yes'); ... works, window.open('/', '_blank', 'location=no, hidden=yes'); ... doesn't. parseFeature does StringTokenizer features = new StringTokenizer(optString, ","); ... where optString is that third parameter. Then in the case of deciding if a window should be hidden on launch, in showWebPage tries; Boolean hidden = features.get(HIDDEN); where private static final String HIDDEN = "hidden"; "hidden" != " hidden" ;) 'location = no,hidden = yes' etc also breaks it. It's a one-line fix, around line 248 in InAppBrowser.java; private HashMap parseFeature(String optString) { if (optString.equals(NULL)) { return null; } else { HashMap map = new HashMap(); optString = optString.replaceAll("\\s",""); /* this line fixes it*/ > InAppBrowser parseFeature doesn't strip whitespace from supplied options > > > Key: CB-4603 > URL: https://issues.apache.org/jira/browse/CB-4603 > Project: Apache Cordova > Issue Type: Bug > Components: Android, Plugin InAppBrowser >Affects Versions: 3.0.0 > Environment: Android >Reporter: Jon Whitlock >Assignee: Joe Bowser >Priority: Minor > > Short story: > window.open('/', '_blank', 'location=no,hidden=yes'); > ... works, > window.open('/', '_blank', 'location=no, hidden=yes'); > ... doesn't. > parseFeature does > StringTokenizer features = new StringTokenizer(optString, ","); > ... where optString is that third parameter. Then in the case of deciding if > a window should be hidden on launch, in showWebPage tries; > Boolean hidden = features.get(HIDDEN); > where > private static final String HIDDEN = "hidden"; > "hidden" != " hidden" ;) > 'location = no,hidden = yes' etc also breaks it. > It's a one-line fix, around line 248 in InAppBrowser.java; > {code:title=Bar.java|borderStyle=solid} > private HashMap parseFeature(String optString) { > if (optString.equals(NULL)) { > return null; > } else { > HashMap map = new HashMap(); > optString = optString.replaceAll("\\s",""); /* this line fixes > it*/ > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira