[jira] [Updated] (CB-8292) notification.prompt has invisible white text for user input

2016-03-11 Thread Victor Valdez-Hidalgo (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Victor Valdez-Hidalgo updated CB-8292:
--
Attachment: Screenshot_2016-03-11-13-21-39.png

> notification.prompt has invisible white text for user input
> ---
>
> Key: CB-8292
> URL: https://issues.apache.org/jira/browse/CB-8292
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Dialogs
>Affects Versions: 3.5.0
> Environment: build.phonegap.com, with core plugins from source= 
> "plugins.cordova.io" .
> (Sorry I can't verify if this is just a build.phonegap.com problem or an 
> issue with the plugin, but from the code diffs, seems it is the plugin.)
>Reporter: Steve Bohrer
>Priority: Minor
> Attachments: Screenshot_2016-03-11-13-21-39.png, 
> Screenshot_2016-03-11-13-21-39.png
>
>
> In 0.2.9 of the core dialogs plugin, the change note says: "When you don't 
> specify a theme the platform defaults back to gingerbread styling. By 
> applying the device default theme it will change it to the new (and much 
> nicer looking) styles on newer devices."
> However, the EditText item is not changed, so user-entered text is still in 
> the gingerbread styling, which results in white text on the new white dialog 
> background. This issue persists through dialogs plugin 0.2.11. (Note that the 
> default prompt string is drawn with the proper font, but when the user enters 
> text, it is white.)
> From the diffs at  
> https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-dialogs.git;a=commitdiff;h=90ad94c3309619b9e629ccf416d1a787df7c3d0e
> It is clear that AlertDialog.Builder is called with the new default style, 
> but the EditText item is unchanged.
> Here's the excerpt of the relevant diffs:
> @@ -270,7 +270,7 @@ public class Notification extends CordovaPlugin {
>  public void run() {
>  final EditText promptInput =  new 
> EditText(cordova.getActivity());
>  promptInput.setHint(defaultText);
> -AlertDialog.Builder dlg = new 
> AlertDialog.Builder(cordova.getActivity());
> +AlertDialog.Builder dlg = new 
> AlertDialog.Builder(cordova.getActivity(), 
> AlertDialog.THEME_DEVICE_DEFAULT_LIGHT);



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-8292) notification.prompt has invisible white text for user input

2016-03-11 Thread Victor Valdez-Hidalgo (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Victor Valdez-Hidalgo updated CB-8292:
--
Attachment: Screenshot_2016-03-11-13-21-39.png

> notification.prompt has invisible white text for user input
> ---
>
> Key: CB-8292
> URL: https://issues.apache.org/jira/browse/CB-8292
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Dialogs
>Affects Versions: 3.5.0
> Environment: build.phonegap.com, with core plugins from source= 
> "plugins.cordova.io" .
> (Sorry I can't verify if this is just a build.phonegap.com problem or an 
> issue with the plugin, but from the code diffs, seems it is the plugin.)
>Reporter: Steve Bohrer
>Priority: Minor
> Attachments: Screenshot_2016-03-11-13-21-39.png, 
> Screenshot_2016-03-11-13-21-39.png
>
>
> In 0.2.9 of the core dialogs plugin, the change note says: "When you don't 
> specify a theme the platform defaults back to gingerbread styling. By 
> applying the device default theme it will change it to the new (and much 
> nicer looking) styles on newer devices."
> However, the EditText item is not changed, so user-entered text is still in 
> the gingerbread styling, which results in white text on the new white dialog 
> background. This issue persists through dialogs plugin 0.2.11. (Note that the 
> default prompt string is drawn with the proper font, but when the user enters 
> text, it is white.)
> From the diffs at  
> https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-dialogs.git;a=commitdiff;h=90ad94c3309619b9e629ccf416d1a787df7c3d0e
> It is clear that AlertDialog.Builder is called with the new default style, 
> but the EditText item is unchanged.
> Here's the excerpt of the relevant diffs:
> @@ -270,7 +270,7 @@ public class Notification extends CordovaPlugin {
>  public void run() {
>  final EditText promptInput =  new 
> EditText(cordova.getActivity());
>  promptInput.setHint(defaultText);
> -AlertDialog.Builder dlg = new 
> AlertDialog.Builder(cordova.getActivity());
> +AlertDialog.Builder dlg = new 
> AlertDialog.Builder(cordova.getActivity(), 
> AlertDialog.THEME_DEVICE_DEFAULT_LIGHT);



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org