[jira] [Commented] (CXF-8233) [JAX-RS][OneWay]: Wrong response code in case of error

2020-03-31 Thread Krisztian Kurucz (Jira)


[ 
https://issues.apache.org/jira/browse/CXF-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071661#comment-17071661
 ] 

Krisztian Kurucz commented on CXF-8233:
---

Dear Alexey,

Please let me know where the test should be moved.

Thanks in advance!

-Krisz

 

> [JAX-RS][OneWay]: Wrong response code in case of error
> --
>
> Key: CXF-8233
> URL: https://issues.apache.org/jira/browse/CXF-8233
> Project: CXF
>  Issue Type: Bug
>  Components: JAX-RS
>Affects Versions: 3.3.3
>Reporter: Krisztian Kurucz
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> If there is an error during request handling "200-OK" response code is sent 
> back instead of the proper error code and reason.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (CXF-8233) [JAX-RS][OneWay]: Wrong response code in case of error

2020-03-13 Thread Krisztian Kurucz (Jira)


[ 
https://issues.apache.org/jira/browse/CXF-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058498#comment-17058498
 ] 

Krisztian Kurucz edited comment on CXF-8233 at 3/13/20, 8:10 AM:
-

Dear Alexey,

In case of JAX-WS the one-way invocation will get error code 500 if there are 
any errors during message processing before invocation of 
OneWayProcessorInterceptor.

Based on that the JAX-RS case should work the same way.

Let me know if you need more details.

-Krisz


was (Author: kkurucz):
Dear Alexey,

In case of JAX-WS the one-way invocation will get error code 500 if there are 
any errors during message processing.

Based on that the JAX-RS case should work the same way.

Let me know if you need more details.

-Krisz

> [JAX-RS][OneWay]: Wrong response code in case of error
> --
>
> Key: CXF-8233
> URL: https://issues.apache.org/jira/browse/CXF-8233
> Project: CXF
>  Issue Type: Bug
>  Components: JAX-RS
>Affects Versions: 3.3.3
>Reporter: Krisztian Kurucz
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> If there is an error during request handling "200-OK" response code is sent 
> back instead of the proper error code and reason.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (CXF-8233) [JAX-RS][OneWay]: Wrong response code in case of error

2020-03-13 Thread Krisztian Kurucz (Jira)


[ 
https://issues.apache.org/jira/browse/CXF-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058498#comment-17058498
 ] 

Krisztian Kurucz commented on CXF-8233:
---

Dear Alexey,

In case of JAX-WS the one-way invocation will get error code 500 if there are 
any errors during message processing.

Based on that the JAX-RS case should work the same way.

Let me know if you need more details.

-Krisz

> [JAX-RS][OneWay]: Wrong response code in case of error
> --
>
> Key: CXF-8233
> URL: https://issues.apache.org/jira/browse/CXF-8233
> Project: CXF
>  Issue Type: Bug
>  Components: JAX-RS
>Affects Versions: 3.3.3
>Reporter: Krisztian Kurucz
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> If there is an error during request handling "200-OK" response code is sent 
> back instead of the proper error code and reason.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (CXF-8233) [JAX-RS][OneWay]: Wrong response code in case of error

2020-03-07 Thread Krisztian Kurucz (Jira)


 [ 
https://issues.apache.org/jira/browse/CXF-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krisztian Kurucz updated CXF-8233:
--
Description: If there is an error during request handling "200-OK" response 
code is sent back instead of the proper error code and message.  (was: If here 
is an error during request handling "200-OK" response code is sent back instead 
of the proper error code and message.)

> [JAX-RS][OneWay]: Wrong response code in case of error
> --
>
> Key: CXF-8233
> URL: https://issues.apache.org/jira/browse/CXF-8233
> Project: CXF
>  Issue Type: Bug
>  Components: JAX-RS
>Affects Versions: 3.3.3
>Reporter: Krisztian Kurucz
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> If there is an error during request handling "200-OK" response code is sent 
> back instead of the proper error code and message.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (CXF-8233) [JAX-RS][OneWay]: Wrong response code in case of error

2020-03-07 Thread Krisztian Kurucz (Jira)


 [ 
https://issues.apache.org/jira/browse/CXF-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krisztian Kurucz updated CXF-8233:
--
Description: If there is an error during request handling "200-OK" response 
code is sent back instead of the proper error code and reason.  (was: If there 
is an error during request handling "200-OK" response code is sent back instead 
of the proper error code and message.)

> [JAX-RS][OneWay]: Wrong response code in case of error
> --
>
> Key: CXF-8233
> URL: https://issues.apache.org/jira/browse/CXF-8233
> Project: CXF
>  Issue Type: Bug
>  Components: JAX-RS
>Affects Versions: 3.3.3
>Reporter: Krisztian Kurucz
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> If there is an error during request handling "200-OK" response code is sent 
> back instead of the proper error code and reason.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (CXF-8233) [JAX-RS][OneWay]: Wrong response code in case of error

2020-03-06 Thread Krisztian Kurucz (Jira)
Krisztian Kurucz created CXF-8233:
-

 Summary: [JAX-RS][OneWay]: Wrong response code in case of error
 Key: CXF-8233
 URL: https://issues.apache.org/jira/browse/CXF-8233
 Project: CXF
  Issue Type: Bug
  Components: JAX-RS
Affects Versions: 3.3.3
Reporter: Krisztian Kurucz


If here is an error during request handling "200-OK" response code is sent back 
instead of the proper error code and message.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (CXF-8128) Fill address field in case of responses

2019-10-01 Thread Krisztian Kurucz (Jira)


[ 
https://issues.apache.org/jira/browse/CXF-8128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942218#comment-16942218
 ] 

Krisztian Kurucz commented on CXF-8128:
---

Hi [~ffang]

 

Thank you for you comment.
Test is fixed.

 

-Krisz

> Fill address field in case of responses
> ---
>
> Key: CXF-8128
> URL: https://issues.apache.org/jira/browse/CXF-8128
> Project: CXF
>  Issue Type: Bug
>  Components: logging
>Affects Versions: 3.3.3
>Reporter: Krisztian Kurucz
>Assignee: Freeman Yue Fang
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Fill address in case of responses to be able to find out which URI does 
> belong to the logged response.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (CXF-8128) Fill address field in case of responses

2019-10-01 Thread Krisztian Kurucz (Jira)
Krisztian Kurucz created CXF-8128:
-

 Summary: Fill address field in case of responses
 Key: CXF-8128
 URL: https://issues.apache.org/jira/browse/CXF-8128
 Project: CXF
  Issue Type: Bug
  Components: logging
Affects Versions: 3.3.3
Reporter: Krisztian Kurucz


Fill address in case of responses to be able to find out which URI does belong 
to the logged response.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (CXF-8127) LoggingFeature - Wrong address concatenation

2019-09-30 Thread Krisztian Kurucz (Jira)
Krisztian Kurucz created CXF-8127:
-

 Summary: LoggingFeature - Wrong address concatenation
 Key: CXF-8127
 URL: https://issues.apache.org/jira/browse/CXF-8127
 Project: CXF
  Issue Type: Bug
  Components: logging
Affects Versions: 3.3.3
Reporter: Krisztian Kurucz






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (CXF-8120) JAX-RS 2.1 SSE client: forbidden response without WebApplicationException

2019-09-20 Thread Krisztian Kurucz (Jira)


 [ 
https://issues.apache.org/jira/browse/CXF-8120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krisztian Kurucz updated CXF-8120:
--
Summary: JAX-RS 2.1 SSE client: forbidden response without 
WebApplicationException  (was: AX-RS 2.1 SSE client: forbidden response without 
WebApplicationException)

> JAX-RS 2.1 SSE client: forbidden response without WebApplicationException
> -
>
> Key: CXF-8120
> URL: https://issues.apache.org/jira/browse/CXF-8120
> Project: CXF
>  Issue Type: Bug
>  Components: JAX-RS
>Affects Versions: 3.3.3
>Reporter: Krisztian Kurucz
>Priority: Major
>
> SSE client is trying to process the events even if the response was not OK 
> (200).
> E.g.: when response status code is 403
> {quote}4.5.2 Client Runtime
> [...] Note that the client runtime will only throw an instance of 
> WebApplicationException (or any of its subclasses) as a result of a response 
> from the server with status codes 3xx, 4xx or 5xx.
> {quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (CXF-8120) AX-RS 2.1 SSE client: forbidden response without WebApplicationException

2019-09-20 Thread Krisztian Kurucz (Jira)
Krisztian Kurucz created CXF-8120:
-

 Summary: AX-RS 2.1 SSE client: forbidden response without 
WebApplicationException
 Key: CXF-8120
 URL: https://issues.apache.org/jira/browse/CXF-8120
 Project: CXF
  Issue Type: Bug
  Components: JAX-RS
Affects Versions: 3.3.3
Reporter: Krisztian Kurucz


SSE client is trying to process the events even if the response was not OK 
(200).

E.g.: when response status code is 403
{quote}4.5.2 Client Runtime
[...] Note that the client runtime will only throw an instance of 
WebApplicationException (or any of its subclasses) as a result of a response 
from the server with status codes 3xx, 4xx or 5xx.
{quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (CXF-8096) Adding LoggingFeature causes blocking read

2019-09-17 Thread Krisztian Kurucz (Jira)


[ 
https://issues.apache.org/jira/browse/CXF-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931535#comment-16931535
 ] 

Krisztian Kurucz edited comment on CXF-8096 at 9/17/19 2:47 PM:


Hi [~ffang]

Thank you for your answer!

Is it possible to fix that bad design (e.g.: fix with FilterInputStreams)?

I think it is a bug instead of a feature.

-Krisz


was (Author: kkurucz):
Hi [~ffang]

Thank you for your answer!

Is it possible to fix that bad design?

I think it is a bug instead of a feature.

-Krisz

> Adding LoggingFeature causes blocking read
> --
>
> Key: CXF-8096
> URL: https://issues.apache.org/jira/browse/CXF-8096
> Project: CXF
>  Issue Type: Bug
>  Components: logging
>Affects Versions: 3.3.3
>Reporter: Krisztian Kurucz
>Assignee: Freeman Fang
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Adding org.apache.cxf.feature.LoggingFeature to WebClient feature affects the 
> reading of the response is blocked until the stream will be closed.
> Without LoggingFeature the response's input stream can be get immediately for 
> further processing.
> error-prone line in WireTapIn::handleInputStream(Message, 
> InputStream)::Line92: 
>  
> {code:java}
> IOUtils.copyAtLeast(bis, bos, limit == -1 ? Integer.MAX_VALUE : limit);{code}
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (CXF-8096) Adding LoggingFeature causes blocking read

2019-09-17 Thread Krisztian Kurucz (Jira)


[ 
https://issues.apache.org/jira/browse/CXF-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931535#comment-16931535
 ] 

Krisztian Kurucz commented on CXF-8096:
---

Hi [~ffang]

Thank you for your answer!

Is it possible to fix that bad design?

I think it is a bug instead of a feature.

-Krisz

> Adding LoggingFeature causes blocking read
> --
>
> Key: CXF-8096
> URL: https://issues.apache.org/jira/browse/CXF-8096
> Project: CXF
>  Issue Type: Bug
>  Components: logging
>Affects Versions: 3.3.3
>Reporter: Krisztian Kurucz
>Assignee: Freeman Fang
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Adding org.apache.cxf.feature.LoggingFeature to WebClient feature affects the 
> reading of the response is blocked until the stream will be closed.
> Without LoggingFeature the response's input stream can be get immediately for 
> further processing.
> error-prone line in WireTapIn::handleInputStream(Message, 
> InputStream)::Line92: 
>  
> {code:java}
> IOUtils.copyAtLeast(bis, bos, limit == -1 ? Integer.MAX_VALUE : limit);{code}
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (CXF-8096) Adding LoggingFeature causes blocking read

2019-09-10 Thread Krisztian Kurucz (Jira)


[ 
https://issues.apache.org/jira/browse/CXF-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926858#comment-16926858
 ] 

Krisztian Kurucz commented on CXF-8096:
---

Any news/updates?

> Adding LoggingFeature causes blocking read
> --
>
> Key: CXF-8096
> URL: https://issues.apache.org/jira/browse/CXF-8096
> Project: CXF
>  Issue Type: Bug
>  Components: logging
>Affects Versions: 3.3.3
>Reporter: Krisztian Kurucz
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Adding org.apache.cxf.feature.LoggingFeature to WebClient feature affects the 
> reading of the response is blocked until the stream will be closed.
> Without LoggingFeature the response's input stream can be get immediately for 
> further processing.
> error-prone line in WireTapIn::handleInputStream(Message, 
> InputStream)::Line92: 
>  
> {code:java}
> IOUtils.copyAtLeast(bis, bos, limit == -1 ? Integer.MAX_VALUE : limit);{code}
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (CXF-8103) OpenApiFeature - cannot use useContextBasedConfig

2019-09-04 Thread Krisztian Kurucz (Jira)


[ 
https://issues.apache.org/jira/browse/CXF-8103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922433#comment-16922433
 ] 

Krisztian Kurucz commented on CXF-8103:
---

Perfect! Thanks! :)

> OpenApiFeature - cannot use useContextBasedConfig
> -
>
> Key: CXF-8103
> URL: https://issues.apache.org/jira/browse/CXF-8103
> Project: CXF
>  Issue Type: Bug
>  Components: JAX-RS, Services
>Affects Versions: 3.3.3
>Reporter: Krisztian Kurucz
>Assignee: Andriy Redko
>Priority: Major
> Attachments: description_openapi_v3_spring_boot.7z
>
>
> In case of Using Multiple Server Endpoints all openapi.json will contain all 
> resource descriptions



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (CXF-8103) OpenApiFeature - cannot use useContextBasedConfig

2019-09-04 Thread Krisztian Kurucz (Jira)


[ 
https://issues.apache.org/jira/browse/CXF-8103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922422#comment-16922422
 ] 

Krisztian Kurucz commented on CXF-8103:
---

would it be better to close after the fix will be released?

-krisz

> OpenApiFeature - cannot use useContextBasedConfig
> -
>
> Key: CXF-8103
> URL: https://issues.apache.org/jira/browse/CXF-8103
> Project: CXF
>  Issue Type: Bug
>  Components: JAX-RS, Services
>Affects Versions: 3.3.3
>Reporter: Krisztian Kurucz
>Assignee: Andriy Redko
>Priority: Major
> Attachments: description_openapi_v3_spring_boot.7z
>
>
> In case of Using Multiple Server Endpoints all openapi.json will contain all 
> resource descriptions



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (CXF-8103) OpenApiFeature - cannot use useContextBasedConfig

2019-09-04 Thread Krisztian Kurucz (Jira)


[ 
https://issues.apache.org/jira/browse/CXF-8103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922276#comment-16922276
 ] 

Krisztian Kurucz commented on CXF-8103:
---

Thank you for your help!

I choose Option1 :)

> OpenApiFeature - cannot use useContextBasedConfig
> -
>
> Key: CXF-8103
> URL: https://issues.apache.org/jira/browse/CXF-8103
> Project: CXF
>  Issue Type: Bug
>  Components: JAX-RS, Services
>Affects Versions: 3.3.3
>Reporter: Krisztian Kurucz
>Assignee: Andriy Redko
>Priority: Major
> Attachments: description_openapi_v3_spring_boot.7z
>
>
> In case of Using Multiple Server Endpoints all openapi.json will contain all 
> resource descriptions



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (CXF-8103) OpenApiFeature - cannot use useContextBasedConfig

2019-09-02 Thread Krisztian Kurucz (Jira)


[ 
https://issues.apache.org/jira/browse/CXF-8103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16920782#comment-16920782
 ] 

Krisztian Kurucz commented on CXF-8103:
---

hi,

thanks, i will give it a try

-krisz

> OpenApiFeature - cannot use useContextBasedConfig
> -
>
> Key: CXF-8103
> URL: https://issues.apache.org/jira/browse/CXF-8103
> Project: CXF
>  Issue Type: Bug
>  Components: JAX-RS, Services
>Affects Versions: 3.3.3
>Reporter: Krisztian Kurucz
>Assignee: Andriy Redko
>Priority: Major
> Attachments: description_openapi_v3_spring_boot.7z
>
>
> In case of Using Multiple Server Endpoints all openapi.json will contain all 
> resource descriptions



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (CXF-8103) OpenApiFeature - cannot use useContextBasedConfig

2019-08-30 Thread Krisztian Kurucz (Jira)


[ 
https://issues.apache.org/jira/browse/CXF-8103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16919386#comment-16919386
 ] 

Krisztian Kurucz commented on CXF-8103:
---

Hi [~reta],

Attached the SpringBoot Demo application.

[http://localhost:8080/services/api/api-docs?url=openapi.json]

[http://localhost:8080/services/api2/api-docs?url=openapi.json|http://localhost:8080/services/api/api-docs?url=openapi.json]

Please try it with the below CXF versions:
 * 3.3.2
 ** "/api" openapi.json will contain only "/api" endpoint-related descriptions
 ** "/api2" openapi.json will contain only "/api2" endpoint-related descriptions
 * 3.3.3
 ** "/api" openapi.json will contain "/api" and "/api2" endpoint-related 
descriptions
 ** "/api2" openapi.json will contain "/api" and "/api2" endpoint-related 
descriptions

-Krisz

> OpenApiFeature - cannot use useContextBasedConfig
> -
>
> Key: CXF-8103
> URL: https://issues.apache.org/jira/browse/CXF-8103
> Project: CXF
>  Issue Type: Bug
>  Components: JAX-RS, Services
>Affects Versions: 3.3.3
>Reporter: Krisztian Kurucz
>Priority: Major
> Attachments: description_openapi_v3_spring_boot.7z
>
>
> In case of Using Multiple Server Endpoints all openapi.json will contain all 
> resource descriptions



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (CXF-8103) OpenApiFeature - cannot use useContextBasedConfig

2019-08-30 Thread Krisztian Kurucz (Jira)


 [ 
https://issues.apache.org/jira/browse/CXF-8103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krisztian Kurucz updated CXF-8103:
--
Attachment: description_openapi_v3_spring_boot.7z

> OpenApiFeature - cannot use useContextBasedConfig
> -
>
> Key: CXF-8103
> URL: https://issues.apache.org/jira/browse/CXF-8103
> Project: CXF
>  Issue Type: Bug
>  Components: JAX-RS, Services
>Affects Versions: 3.3.3
>Reporter: Krisztian Kurucz
>Priority: Major
> Attachments: description_openapi_v3_spring_boot.7z
>
>
> In case of Using Multiple Server Endpoints all openapi.json will contain all 
> resource descriptions



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Created] (CXF-8103) OpenApiFeature - cannot use useContextBasedConfig

2019-08-29 Thread Krisztian Kurucz (Jira)
Krisztian Kurucz created CXF-8103:
-

 Summary: OpenApiFeature - cannot use useContextBasedConfig
 Key: CXF-8103
 URL: https://issues.apache.org/jira/browse/CXF-8103
 Project: CXF
  Issue Type: Bug
  Components: JAX-RS, Services
Affects Versions: 3.3.3
Reporter: Krisztian Kurucz


In case of Using Multiple Server Endpoints all openapi.json will contain all 
resource descriptions



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (CXF-8096) Adding LoggingFeature causes blocking read

2019-08-22 Thread Krisztian Kurucz (Jira)


[ 
https://issues.apache.org/jira/browse/CXF-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913644#comment-16913644
 ] 

Krisztian Kurucz commented on CXF-8096:
---

Created a test for that case in the PR

> Adding LoggingFeature causes blocking read
> --
>
> Key: CXF-8096
> URL: https://issues.apache.org/jira/browse/CXF-8096
> Project: CXF
>  Issue Type: Bug
>  Components: logging
>Affects Versions: 3.3.3
>Reporter: Krisztian Kurucz
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Adding org.apache.cxf.feature.LoggingFeature to WebClient feature affects the 
> reading of the response is blocked until the stream will be closed.
> Without LoggingFeature the response's input stream can be get immediately for 
> further processing.
> error-prone line in WireTapIn::handleInputStream(Message, 
> InputStream)::Line92: 
>  
> {code:java}
> IOUtils.copyAtLeast(bis, bos, limit == -1 ? Integer.MAX_VALUE : limit);{code}
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Created] (CXF-8096) Adding LoggingFeature causes blocking read

2019-08-22 Thread Krisztian Kurucz (Jira)
Krisztian Kurucz created CXF-8096:
-

 Summary: Adding LoggingFeature causes blocking read
 Key: CXF-8096
 URL: https://issues.apache.org/jira/browse/CXF-8096
 Project: CXF
  Issue Type: Bug
  Components: logging
Affects Versions: 3.3.3
Reporter: Krisztian Kurucz


Adding org.apache.cxf.feature.LoggingFeature to WebClient feature affects the 
reading of the response is blocked until the stream will be closed.

Without LoggingFeature the response's input stream can be get immediately for 
further processing.

error-prone line in WireTapIn::handleInputStream(Message, InputStream)::Line92: 

 
{code:java}
IOUtils.copyAtLeast(bis, bos, limit == -1 ? Integer.MAX_VALUE : limit);{code}
 



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (CXF-8032) Adding LoggingFeature enables chunking response

2019-07-24 Thread Krisztian Kurucz (JIRA)


[ 
https://issues.apache.org/jira/browse/CXF-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16891646#comment-16891646
 ] 

Krisztian Kurucz commented on CXF-8032:
---

Created a PR, but the build is not run.

PR contains the a JAX-RS test.

Could anyone check it?

> Adding LoggingFeature enables chunking response
> ---
>
> Key: CXF-8032
> URL: https://issues.apache.org/jira/browse/CXF-8032
> Project: CXF
>  Issue Type: Bug
>  Components: logging
>Affects Versions: 3.3.1
> Environment: OS - Windows 10
> Java  - 1.8.0_181
> Tomcat - 8.5
> CXF - 3.3.1
>Reporter: karthic
>Priority: Major
>  Labels: triaged
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Adding org.apache.cxf.feature.LoggingFeature to Bus feature affects the 
> response header, it adds transfer encoding as chunked, where as without 
> LoggingFeature the content length is set and no transfer encoding set.
> 
>  
>  
> Response header when LoggingFeature is added,
> HTTP/1.1 200 
>  Content-Type: text/xml;charset=UTF-8
>  Transfer-Encoding: chunked
>  Date: Wed, 01 May 2019 05:43:46 GMT
> Response header when LoggingFeature is removed,
> HTTP/1.1 200 
>  Content-Type: text/xml;charset=UTF-8
>  Content-Length: 496
>  Date: Wed, 01 May 2019 06:30:04 GMT
> Possible issue may be because converting the original OutputStream to 
> CacheAndWriteOutputStream, I am not able look into further



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (CXF-8032) Adding LoggingFeature enables chunking response

2019-06-16 Thread Krisztian Kurucz (JIRA)


[ 
https://issues.apache.org/jira/browse/CXF-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16865031#comment-16865031
 ] 

Krisztian Kurucz commented on CXF-8032:
---

Dear Team,

I derived a class from CacheAndWriteOutputStream and overrode the proper 
method, Content-Length was appeared properly.

Could you check the below, please?
{code:java}
public class MyCacheAndWriteOutputStream extends CacheAndWriteOutputStream {
public MyCacheAndWriteOutputStream(OutputStream stream) {
super(stream);
}

/**
 * Override, because there is no need to flush the flow-through stream.
 * Flushing will be done by the underlying OutputStream.
 *
 * @see org.apache.cxf.io.AbstractThresholdOutputStream#close()
 */
@Override
public void closeFlowthroughStream() throws IOException {
getFlowThroughStream().close();
}

/**
 * Override, because there is no need to flush the flow-through stream.
 * Flushing will be done by the underlying OutputStream.
 *
 * @see org.apache.cxf.io.AbstractThresholdOutputStream#close()
 */
@Override
protected void postClose() throws IOException {
getFlowThroughStream().close();
}
}
{code}
-Krisz
  

> Adding LoggingFeature enables chunking response
> ---
>
> Key: CXF-8032
> URL: https://issues.apache.org/jira/browse/CXF-8032
> Project: CXF
>  Issue Type: Bug
>  Components: logging
>Affects Versions: 3.3.1
> Environment: OS - Windows 10
> Java  - 1.8.0_181
> Tomcat - 8.5
> CXF - 3.3.1
>Reporter: karthic
>Priority: Major
>  Labels: triaged
>
> Adding org.apache.cxf.feature.LoggingFeature to Bus feature affects the 
> response header, it adds transfer encoding as chunked, where as without 
> LoggingFeature the content length is set and no transfer encoding set.
> 
>  
>  
> Response header when LoggingFeature is added,
> HTTP/1.1 200 
>  Content-Type: text/xml;charset=UTF-8
>  Transfer-Encoding: chunked
>  Date: Wed, 01 May 2019 05:43:46 GMT
> Response header when LoggingFeature is removed,
> HTTP/1.1 200 
>  Content-Type: text/xml;charset=UTF-8
>  Content-Length: 496
>  Date: Wed, 01 May 2019 06:30:04 GMT
> Possible issue may be because converting the original OutputStream to 
> CacheAndWriteOutputStream, I am not able look into further



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)