[jira] [Commented] (CXF-6038) Repeatedly invoking setHandlerChain() can cause a build up of handler interceptors on the chain
[
https://issues.apache.org/jira/browse/CXF-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14191803#comment-14191803
]
ASF GitHub Bot commented on CXF-6038:
-
Github user asoldano commented on the pull request:
https://github.com/apache/cxf/pull/25#issuecomment-61260523
@kylape just for the record... I fixed JBossWS to avoid calling
setHandlerChain(..) at every invocation :-) see
https://source.jboss.org/changelog/JBossWS?cs=19036
Repeatedly invoking setHandlerChain() can cause a build up of handler
interceptors on the chain
---
Key: CXF-6038
URL: https://issues.apache.org/jira/browse/CXF-6038
Project: CXF
Issue Type: Bug
Components: JAX-WS Runtime
Affects Versions: 3.0.1
Reporter: Kyle Lape
Assignee: Daniel Kulp
Fix For: 3.1.0, 3.0.3, 2.7.14
If an interceptor chain is cached between invocations and a user calls
{{setHandlerChain()}} before every invocation, the handler chain interceptors
get added to the interceptor chain over and over indefinitely.
I'm guessing that {{JaxWsEndpointImpl.addHandlerInterceptors()}} would need
to check for the presence of the handler interceptors on the chain already.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CXF-6038) Repeatedly invoking setHandlerChain() can cause a build up of handler interceptors on the chain
[
https://issues.apache.org/jira/browse/CXF-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14191965#comment-14191965
]
ASF GitHub Bot commented on CXF-6038:
-
Github user kylape commented on the pull request:
https://github.com/apache/cxf/pull/25#issuecomment-61281462
Ah, nice. Thanks, Alessio!
Repeatedly invoking setHandlerChain() can cause a build up of handler
interceptors on the chain
---
Key: CXF-6038
URL: https://issues.apache.org/jira/browse/CXF-6038
Project: CXF
Issue Type: Bug
Components: JAX-WS Runtime
Affects Versions: 3.0.1
Reporter: Kyle Lape
Assignee: Daniel Kulp
Fix For: 3.1.0, 3.0.3, 2.7.14
If an interceptor chain is cached between invocations and a user calls
{{setHandlerChain()}} before every invocation, the handler chain interceptors
get added to the interceptor chain over and over indefinitely.
I'm guessing that {{JaxWsEndpointImpl.addHandlerInterceptors()}} would need
to check for the presence of the handler interceptors on the chain already.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CXF-6038) Repeatedly invoking setHandlerChain() can cause a build up of handler interceptors on the chain
[
https://issues.apache.org/jira/browse/CXF-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14190881#comment-14190881
]
ASF GitHub Bot commented on CXF-6038:
-
Github user kylape commented on the pull request:
https://github.com/apache/cxf/pull/25#issuecomment-61172618
I've verified the fix on CXF 2.7.12 (the version in JBoss EAP) already, but
I'll work to verify on CXF master.
Repeatedly invoking setHandlerChain() can cause a build up of handler
interceptors on the chain
---
Key: CXF-6038
URL: https://issues.apache.org/jira/browse/CXF-6038
Project: CXF
Issue Type: Bug
Components: JAX-WS Runtime
Affects Versions: 3.0.1
Reporter: Kyle Lape
Assignee: Daniel Kulp
Fix For: 3.1.0, 3.0.3, 2.7.14
If an interceptor chain is cached between invocations and a user calls
{{setHandlerChain()}} before every invocation, the handler chain interceptors
get added to the interceptor chain over and over indefinitely.
I'm guessing that {{JaxWsEndpointImpl.addHandlerInterceptors()}} would need
to check for the presence of the handler interceptors on the chain already.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CXF-6038) Repeatedly invoking setHandlerChain() can cause a build up of handler interceptors on the chain
[
https://issues.apache.org/jira/browse/CXF-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14191390#comment-14191390
]
ASF GitHub Bot commented on CXF-6038:
-
Github user kylape commented on the pull request:
https://github.com/apache/cxf/pull/25#issuecomment-61220541
Okay, I reproduced the issue with CXF 3.0.2 and verified it is resolved in
my build of the master branch today.
Just FYI -- in JBoss I only had to add this code:
```
final Service service = Service.create(wsdl, ns);
service.setHandlerResolver(new HandlerResolver() {
public ListHandler getHandlerChain(PortInfo info) {
return handlerChain;
}
});
```
because the JBossWS integration calls `setHandlerChain` for every
invocation to ensure handler order (perhaps that could be improved upon as
well?). When using CXF without JBossWS integration, I had to call
`((BindingProvider)port).getBinding().setHandlerChain(handlerChain)` for every
invocation to reproduce the issue.
Repeatedly invoking setHandlerChain() can cause a build up of handler
interceptors on the chain
---
Key: CXF-6038
URL: https://issues.apache.org/jira/browse/CXF-6038
Project: CXF
Issue Type: Bug
Components: JAX-WS Runtime
Affects Versions: 3.0.1
Reporter: Kyle Lape
Assignee: Daniel Kulp
Fix For: 3.1.0, 3.0.3, 2.7.14
If an interceptor chain is cached between invocations and a user calls
{{setHandlerChain()}} before every invocation, the handler chain interceptors
get added to the interceptor chain over and over indefinitely.
I'm guessing that {{JaxWsEndpointImpl.addHandlerInterceptors()}} would need
to check for the presence of the handler interceptors on the chain already.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CXF-6038) Repeatedly invoking setHandlerChain() can cause a build up of handler interceptors on the chain
[
https://issues.apache.org/jira/browse/CXF-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14191391#comment-14191391
]
ASF GitHub Bot commented on CXF-6038:
-
Github user kylape closed the pull request at:
https://github.com/apache/cxf/pull/25
Repeatedly invoking setHandlerChain() can cause a build up of handler
interceptors on the chain
---
Key: CXF-6038
URL: https://issues.apache.org/jira/browse/CXF-6038
Project: CXF
Issue Type: Bug
Components: JAX-WS Runtime
Affects Versions: 3.0.1
Reporter: Kyle Lape
Assignee: Daniel Kulp
Fix For: 3.1.0, 3.0.3, 2.7.14
If an interceptor chain is cached between invocations and a user calls
{{setHandlerChain()}} before every invocation, the handler chain interceptors
get added to the interceptor chain over and over indefinitely.
I'm guessing that {{JaxWsEndpointImpl.addHandlerInterceptors()}} would need
to check for the presence of the handler interceptors on the chain already.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CXF-6038) Repeatedly invoking setHandlerChain() can cause a build up of handler interceptors on the chain
[
https://issues.apache.org/jira/browse/CXF-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14188984#comment-14188984
]
ASF GitHub Bot commented on CXF-6038:
-
Github user dkulp commented on the pull request:
https://github.com/apache/cxf/pull/25#issuecomment-61003841
This has been merged. Can you please verify and close? Thanks!
Repeatedly invoking setHandlerChain() can cause a build up of handler
interceptors on the chain
---
Key: CXF-6038
URL: https://issues.apache.org/jira/browse/CXF-6038
Project: CXF
Issue Type: Bug
Components: JAX-WS Runtime
Affects Versions: 3.0.1
Reporter: Kyle Lape
Assignee: Daniel Kulp
Fix For: 3.1.0, 3.0.3, 2.7.14
If an interceptor chain is cached between invocations and a user calls
{{setHandlerChain()}} before every invocation, the handler chain interceptors
get added to the interceptor chain over and over indefinitely.
I'm guessing that {{JaxWsEndpointImpl.addHandlerInterceptors()}} would need
to check for the presence of the handler interceptors on the chain already.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CXF-6038) Repeatedly invoking setHandlerChain() can cause a build up of handler interceptors on the chain
[
https://issues.apache.org/jira/browse/CXF-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178999#comment-14178999
]
ASF GitHub Bot commented on CXF-6038:
-
Github user asfgit closed the pull request at:
https://github.com/apache/cxf/pull/26
Repeatedly invoking setHandlerChain() can cause a build up of handler
interceptors on the chain
---
Key: CXF-6038
URL: https://issues.apache.org/jira/browse/CXF-6038
Project: CXF
Issue Type: Bug
Components: JAX-WS Runtime
Affects Versions: 3.0.1
Reporter: Kyle Lape
If an interceptor chain is cached between invocations and a user calls
{{setHandlerChain()}} before every invocation, the handler chain interceptors
get added to the interceptor chain over and over indefinitely.
I'm guessing that {{JaxWsEndpointImpl.addHandlerInterceptors()}} would need
to check for the presence of the handler interceptors on the chain already.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CXF-6038) Repeatedly invoking setHandlerChain() can cause a build up of handler interceptors on the chain
[
https://issues.apache.org/jira/browse/CXF-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14167558#comment-14167558
]
ASF GitHub Bot commented on CXF-6038:
-
GitHub user kylape opened a pull request:
https://github.com/apache/cxf/pull/25
[CXF-6038] Only add the handler interceptors once
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kylape/cxf cxf-6038
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cxf/pull/25.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #25
commit a4d64d349832bcd413222fddd37d613eb7e78112
Author: Kyle Lape kyle.l...@redhat.com
Date: 2014-10-10T21:34:07Z
[CXF-6038] Only add the handler interceptors once
Repeatedly invoking setHandlerChain() can cause a build up of handler
interceptors on the chain
---
Key: CXF-6038
URL: https://issues.apache.org/jira/browse/CXF-6038
Project: CXF
Issue Type: Bug
Components: JAX-WS Runtime
Affects Versions: 3.0.1
Reporter: Kyle Lape
If an interceptor chain is cached between invocations and a user calls
{{setHandlerChain()}} before every invocation, the handler chain interceptors
get added to the interceptor chain over and over indefinitely.
I'm guessing that {{JaxWsEndpointImpl.addHandlerInterceptors()}} would need
to check for the presence of the handler interceptors on the chain already.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CXF-6038) Repeatedly invoking setHandlerChain() can cause a build up of handler interceptors on the chain
[
https://issues.apache.org/jira/browse/CXF-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14167599#comment-14167599
]
ASF GitHub Bot commented on CXF-6038:
-
GitHub user kylape opened a pull request:
https://github.com/apache/cxf/pull/26
[CXF-6038] Only add the handler interceptors once
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kylape/cxf cxf-6038--2.7-fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cxf/pull/26.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #26
commit 69c001d075fa819622600897d057168e65a1d330
Author: Kyle Lape kyle.l...@redhat.com
Date: 2014-10-10T21:34:07Z
[CXF-6038] Only add the handler interceptors once
Repeatedly invoking setHandlerChain() can cause a build up of handler
interceptors on the chain
---
Key: CXF-6038
URL: https://issues.apache.org/jira/browse/CXF-6038
Project: CXF
Issue Type: Bug
Components: JAX-WS Runtime
Affects Versions: 3.0.1
Reporter: Kyle Lape
If an interceptor chain is cached between invocations and a user calls
{{setHandlerChain()}} before every invocation, the handler chain interceptors
get added to the interceptor chain over and over indefinitely.
I'm guessing that {{JaxWsEndpointImpl.addHandlerInterceptors()}} would need
to check for the presence of the handler interceptors on the chain already.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CXF-6038) Repeatedly invoking setHandlerChain() can cause a build up of handler interceptors on the chain
[
https://issues.apache.org/jira/browse/CXF-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14167602#comment-14167602
]
Kyle Lape commented on CXF-6038:
Submitted pull requests on github:
master: https://github.com/apache/cxf/pull/25
2.7-fixes: https://github.com/apache/cxf/pull/26
Repeatedly invoking setHandlerChain() can cause a build up of handler
interceptors on the chain
---
Key: CXF-6038
URL: https://issues.apache.org/jira/browse/CXF-6038
Project: CXF
Issue Type: Bug
Components: JAX-WS Runtime
Affects Versions: 3.0.1
Reporter: Kyle Lape
If an interceptor chain is cached between invocations and a user calls
{{setHandlerChain()}} before every invocation, the handler chain interceptors
get added to the interceptor chain over and over indefinitely.
I'm guessing that {{JaxWsEndpointImpl.addHandlerInterceptors()}} would need
to check for the presence of the handler interceptors on the chain already.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
