[jira] [Commented] (DRILL-5316) C++ Client Crashes When drillbitsVector.count is 0 after zoo_get_children completed with ZOK
[
https://issues.apache.org/jira/browse/DRILL-5316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15898798#comment-15898798
]
ASF GitHub Bot commented on DRILL-5316:
---
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/772#discussion_r104594602
--- Diff: contrib/native/client/src/clientlib/zookeeperClient.cpp ---
@@ -138,6 +138,11 @@ int ZookeeperClient::getAllDrillbits(const
std::string& connectStr, std::vector<
DRILL_MT_LOG(DRILL_LOG(LOG_TRACE) << "\t Unshuffled Drillbit
id: " << drillbits[i] << std::endl;)
}
}
+else{
--- End diff --
I'm not sure the check should be in the zookeeper client, but instead in
the drill client: the zookeeper client is just returning the content of the
zookeeper tree, and there's no error from the zookeeper client point of view
(so no need to disconnect/reconnect).
> C++ Client Crashes When drillbitsVector.count is 0 after zoo_get_children
> completed with ZOK
>
>
> Key: DRILL-5316
> URL: https://issues.apache.org/jira/browse/DRILL-5316
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - C++
>Reporter: Rob Wu
>Priority: Critical
>
> When connecting to drillbit with Zookeeper, occasionally the C++ client would
> crash without any reason.
> A further look into the code revealed that during this call
> rc=zoo_get_children(p_zh.get(), m_path.c_str(), 0, &drillbitsVector);
> zoo_get_children returns ZOK (0) but drillbitsVector.count is 0.
> This causes drillbits to stay empty and thus
> causes err = zook.getEndPoint(drillbits[drillbits.size() -1], endpoint); to
> crash
> Size check should be done to prevent this from happening
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Assigned] (DRILL-4335) Apache Drill should support network encryption
[ https://issues.apache.org/jira/browse/DRILL-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sorabh Hamirwasia reassigned DRILL-4335: Assignee: Sorabh Hamirwasia > Apache Drill should support network encryption > -- > > Key: DRILL-4335 > URL: https://issues.apache.org/jira/browse/DRILL-4335 > Project: Apache Drill > Issue Type: New Feature >Reporter: Keys Botzum >Assignee: Sorabh Hamirwasia > Labels: security > > This is clearly related to Drill-291 but wanted to make explicit that this > needs to include network level encryption and not just authentication. This > is particularly important for the client connection to Drill which will often > be sending passwords in the clear until there is encryption. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DRILL-4335) Apache Drill should support network encryption
[ https://issues.apache.org/jira/browse/DRILL-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15898781#comment-15898781 ] ASF GitHub Bot commented on DRILL-4335: --- GitHub user sohami opened a pull request: https://github.com/apache/drill/pull/773 DRILL-4335: Apache Drill should support network encryption. DRILL-4335: Apache Drill should support network encryption. This pull request add's network encryption capability between Java Drill Client and Drillbit channel and also between Drillbit to Drillbit channel. It is extending SASL Authentication framework to support encryption. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sohami/drill DRILL-4335-Java-02282017 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/drill/pull/773.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #773 commit 8d34bc669ac06cdf1cab12169cfc604d3b503ce3 Author: Sorabh Hamirwasia Date: 2017-02-02T02:44:21Z DRILL-4335: Encryption Protocol changes commit 5d0c10efe5142fec1aa256b6c61ff09196c6ca0f Author: Sorabh Hamirwasia Date: 2017-02-15T23:14:41Z DRILL-4335: Remove support to allow older clients to connect to a secure cluster with encryption enabled. commit 93e133a4c1998a0718134f75596c702f593a2fe1 Author: Sorabh Hamirwasia Date: 2017-02-27T22:54:22Z DRILL-4335: Adding handlers for chunking/encrypting/decrypting RPC msgs commit 4ca982ed36c6fd95201b80d8e89c7b4202479d35 Author: Sorabh Hamirwasia Date: 2017-02-27T23:04:19Z DRILL-4335: Adding configs and constants commit fc91cf98f1b9814931a8f751249edad695e4ccd7 Author: Sorabh Hamirwasia Date: 2017-02-27T23:21:01Z DRILL-4335: Adding encryption support for client->bit channel commit b3af9eb021095a1f05fbc89d941d6c9530933b40 Author: Sorabh Hamirwasia Date: 2017-02-27T23:24:32Z DRILL-4335: Adding test for client->bit channel encryption commit e66b40765ad2793155b9ccfcff0af17344a0af7a Author: Sorabh Hamirwasia Date: 2017-02-27T23:25:27Z DRILL-4335: Adding encryption support for bit->bit channel commit bad6ccd569762af1146f152f8bb757625bf6bb17 Author: Sorabh Hamirwasia Date: 2017-02-27T23:29:31Z DRILL-4335: UI changes for counters, encryption status commit e983d1a1d3537212b00616df3b46fbd52f8512c3 Author: Sorabh Hamirwasia Date: 2017-02-28T07:27:23Z DRILL-4335: Add test for bit->bit encryption and failure case for old clients commit b0cbbbd9312b67352c9117cd5e15f727faaa2cfb Author: Sorabh Hamirwasia Date: 2017-02-28T07:28:14Z DRILL-4335: Bug fix for missing config exception commit 9d5dc7e364e7a3baf18c58b1fe56399c98f9041b Author: Sorabh Hamirwasia Date: 2017-02-28T08:43:49Z DRILL-4335: Add client connection parameter for encryption. Add new and fix old test for client->bit encryption commit c8e6b8a27aea28a04a73e00c960868b461382ba3 Author: Sorabh Hamirwasia Date: 2017-03-01T23:26:30Z DRILL-4335: Improve logic for connection counter commit 9b7b38f624bd42100316adf4fde7256783bcf183 Author: Sorabh Hamirwasia Date: 2017-03-02T19:24:29Z DRILL-4335: Improving saslClient/saslServer cleanup to handle all the cases > Apache Drill should support network encryption > -- > > Key: DRILL-4335 > URL: https://issues.apache.org/jira/browse/DRILL-4335 > Project: Apache Drill > Issue Type: New Feature >Reporter: Keys Botzum > Labels: security > > This is clearly related to Drill-291 but wanted to make explicit that this > needs to include network level encryption and not just authentication. This > is particularly important for the client connection to Drill which will often > be sending passwords in the clear until there is encryption. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (DRILL-5316) C++ Client Crashes When drillbitsVector.count is 0 after zoo_get_children completed with ZOK
[ https://issues.apache.org/jira/browse/DRILL-5316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zelaine Fong updated DRILL-5316: Reviewer: Sorabh Hamirwasia Assigned Reviewer to [~shamirwasia] > C++ Client Crashes When drillbitsVector.count is 0 after zoo_get_children > completed with ZOK > > > Key: DRILL-5316 > URL: https://issues.apache.org/jira/browse/DRILL-5316 > Project: Apache Drill > Issue Type: Bug > Components: Client - C++ >Reporter: Rob Wu >Priority: Critical > > When connecting to drillbit with Zookeeper, occasionally the C++ client would > crash without any reason. > A further look into the code revealed that during this call > rc=zoo_get_children(p_zh.get(), m_path.c_str(), 0, &drillbitsVector); > zoo_get_children returns ZOK (0) but drillbitsVector.count is 0. > This causes drillbits to stay empty and thus > causes err = zook.getEndPoint(drillbits[drillbits.size() -1], endpoint); to > crash > Size check should be done to prevent this from happening -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DRILL-5316) C++ Client Crashes When drillbitsVector.count is 0 after zoo_get_children completed with ZOK
[ https://issues.apache.org/jira/browse/DRILL-5316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15898612#comment-15898612 ] ASF GitHub Bot commented on DRILL-5316: --- GitHub user superbstreak opened a pull request: https://github.com/apache/drill/pull/772 DRILL-5316: Check drillbitsVector count from zoo_get_children before … …we attempt to access the vector element You can merge this pull request into a Git repository by running: $ git pull https://github.com/superbstreak/drill DRILL-5316 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/drill/pull/772.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #772 commit c9ca5a35aa684992d58d93e50a7a9ff7ce16ead8 Author: Rob Wu Date: 2017-03-07T02:17:25Z DRILL-5316: Check drillbitsVector count from zoo_get_children before we attempt to access the vector element > C++ Client Crashes When drillbitsVector.count is 0 after zoo_get_children > completed with ZOK > > > Key: DRILL-5316 > URL: https://issues.apache.org/jira/browse/DRILL-5316 > Project: Apache Drill > Issue Type: Bug > Components: Client - C++ >Reporter: Rob Wu >Priority: Critical > > When connecting to drillbit with Zookeeper, occasionally the C++ client would > crash without any reason. > A further look into the code revealed that during this call > rc=zoo_get_children(p_zh.get(), m_path.c_str(), 0, &drillbitsVector); > zoo_get_children returns ZOK (0) but drillbitsVector.count is 0. > This causes drillbits to stay empty and thus > causes err = zook.getEndPoint(drillbits[drillbits.size() -1], endpoint); to > crash > Size check should be done to prevent this from happening -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (DRILL-5316) C++ Client Crashes When drillbitsVector.count is 0 after zoo_get_children completed with ZOK
Rob Wu created DRILL-5316: - Summary: C++ Client Crashes When drillbitsVector.count is 0 after zoo_get_children completed with ZOK Key: DRILL-5316 URL: https://issues.apache.org/jira/browse/DRILL-5316 Project: Apache Drill Issue Type: Bug Components: Client - C++ Reporter: Rob Wu Priority: Critical When connecting to drillbit with Zookeeper, occasionally the C++ client would crash without any reason. A further look into the code revealed that during this call rc=zoo_get_children(p_zh.get(), m_path.c_str(), 0, &drillbitsVector); zoo_get_children returns ZOK (0) but drillbitsVector.count is 0. This causes drillbits to stay empty and thus causes err = zook.getEndPoint(drillbits[drillbits.size() -1], endpoint); to crash Size check should be done to prevent this from happening -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DRILL-5315) Small Comment Typo in drillClient.hpp
[ https://issues.apache.org/jira/browse/DRILL-5315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15898329#comment-15898329 ] ASF GitHub Bot commented on DRILL-5315: --- GitHub user superbstreak opened a pull request: https://github.com/apache/drill/pull/771 DRILL-5315: Address small typo in the comment You can merge this pull request into a Git repository by running: $ git pull https://github.com/superbstreak/drill DRILL-5315 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/drill/pull/771.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #771 commit cc23c729edfba5571ad542945dd64e5ca2055d75 Author: Rob Wu Date: 2017-03-06T22:56:14Z DRILL-5315: Address small typo in the comment > Small Comment Typo in drillClient.hpp > - > > Key: DRILL-5315 > URL: https://issues.apache.org/jira/browse/DRILL-5315 > Project: Apache Drill > Issue Type: Improvement > Components: Client - C++ >Affects Versions: 1.7.0 >Reporter: Rob Wu >Priority: Trivial > > Small typo of the word "properties" at: > https://github.com/apache/drill/blob/master/contrib/native/client/src/include/drill/drillClient.hpp#L1280 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (DRILL-5315) Small Comment Typo in drillClient.hpp
Rob Wu created DRILL-5315: - Summary: Small Comment Typo in drillClient.hpp Key: DRILL-5315 URL: https://issues.apache.org/jira/browse/DRILL-5315 Project: Apache Drill Issue Type: Improvement Components: Client - C++ Affects Versions: 1.7.0 Reporter: Rob Wu Priority: Trivial Small typo of the word "properties" at: https://github.com/apache/drill/blob/master/contrib/native/client/src/include/drill/drillClient.hpp#L1280 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (DRILL-5208) Finding path to java executable should be deterministic
[ https://issues.apache.org/jira/browse/DRILL-5208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krystal closed DRILL-5208. -- commit id: 3dfb497293a177164a158b246000ee8291ef258c On my two nodes where the order of the paths to the java executable are different: find -L $JAVA_HOME -name java -type f /usr/local/java/jdk1.7.0_67/jre/bin/java /usr/local/java/jdk1.7.0_67/bin/java find -L $JAVA_HOME -name java -type f /usr/local/java/jdk1.7.0_67/bin/java /usr/local/java/jdk1.7.0_67/jre/bin/java Now, the paths of the java executable on the two nodes are pointing to the same location: /usr/local/java/jdk1.7.0_67//bin/java > Finding path to java executable should be deterministic > --- > > Key: DRILL-5208 > URL: https://issues.apache.org/jira/browse/DRILL-5208 > Project: Apache Drill > Issue Type: Bug > Components: Tools, Build & Test >Affects Versions: 1.10.0 >Reporter: Krystal >Assignee: Paul Rogers >Priority: Minor > Labels: ready-to-commit > Fix For: 1.10.0 > > > Command to find JAVA in drill-config.sh is not deterministic. > drill-config.sh uses the following command to find JAVA: > JAVA=`find -L "$JAVA_HOME" -name $JAVA_BIN -type f | head -n 1` > On one of my node the following command returned 2 entries: > find -L $JAVA_HOME -name java -type f > /usr/local/java/jdk1.7.0_67/jre/bin/java > /usr/local/java/jdk1.7.0_67/bin/java > On another node, the same command returned entries in different order: > find -L $JAVA_HOME -name java -type f > /usr/local/java/jdk1.7.0_67/bin/java > /usr/local/java/jdk1.7.0_67/jre/bin/java > The complete command picks the first one returned which may not be the same > on each node: > find -L $JAVA_HOME -name java -type f | head -n 1 > /usr/local/java/jdk1.7.0_67/jre/bin/java > If JAVA_HOME is found, we should just append the "bin/java" to the path" > JAVA=$JAVA_HOME/bin/java -- This message was sent by Atlassian JIRA (v6.3.15#6346)
