[jira] [Updated] (DRILL-6373) Refactor the Result Set Loader to prepare for Union, List support

[Boaz Ben-Zvi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DRILL-6373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Boaz Ben-Zvi updated DRILL-6373:

Labels:   (was: ready-to-commit)

> Refactor the Result Set Loader to prepare for Union, List support
> -
>
> Key: DRILL-6373
> URL: https://issues.apache.org/jira/browse/DRILL-6373
> Project: Apache Drill
>  Issue Type: Improvement
>Affects Versions: 1.13.0
>Reporter: Paul Rogers
>Assignee: Paul Rogers
>Priority: Major
> Fix For: 1.14.0
>
>
> As the next step in merging the "batch sizing" enhancements, refactor the 
> {{ResultSetLoader}} and related classes to prepare for Union and List 
> support. This fix follows the refactoring of the column accessors for the 
> same purpose. Actual Union and List support is to follow in a separate PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6373) Refactor the Result Set Loader to prepare for Union, List support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-6373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492155#comment-16492155
 ] 

ASF GitHub Bot commented on DRILL-6373:
---

Ben-Zvi commented on issue #1244: DRILL-6373: Refactor Result Set Loader for 
Union, List support
URL: https://github.com/apache/drill/pull/1244#issuecomment-392364222
 
 
   There was a failure (after rebasing on the latest master), in the functional 
test emptyHbaseLeftJoin.sql :
   ```
   select t.data.partkey, t1.data.ps_partkey 
 from schema_change_empty_batch_empty as t 
 LEFT JOIN schema_change_empty_batch_partsupp as t1 
 ON t.data.partkey = t1.data.ps_partkey
   
   Exception:
   
   java.sql.SQLException: SYSTEM ERROR: ConcurrentModificationException
   
   Fragment 2:0
   
   [Error Id: bfb0598f-e598-453b-93f2-699bd87a0061 on drill194:31010]
   
 (java.util.ConcurrentModificationException) null
   java.util.LinkedHashMap$LinkedHashIterator.nextNode():719
   java.util.LinkedHashMap$LinkedKeyIterator.next():742
   org.apache.drill.exec.record.MaterializedField.withPathAndType():144
   org.apache.drill.exec.record.MaterializedField.clone():125
   org.apache.drill.exec.record.MaterializedField.withPathAndType():145
   org.apache.drill.exec.record.MaterializedField.clone():125
   org.apache.drill.exec.vector.complex.AbstractMapVector.():49
   org.apache.drill.exec.vector.complex.MapVector.():65
   org.apache.drill.exec.expr.BasicTypeHelper.getNewVector():1275
   org.apache.drill.exec.expr.BasicTypeHelper.getNewVector():1261
   
org.apache.drill.exec.test.generated.PartitionerGen84661$OutgoingRecordBatch.initializeBatch():381
   
org.apache.drill.exec.test.generated.PartitionerGen84661.flushOutgoingBatches():173
   
org.apache.drill.exec.physical.impl.partitionsender.PartitionerDecorator$FlushBatchesHandlingClass.execute():285
   
org.apache.drill.exec.physical.impl.partitionsender.PartitionerDecorator$PartitionerTask.run():340
   java.util.concurrent.ThreadPoolExecutor.runWorker():1149
   java.util.concurrent.ThreadPoolExecutor$Worker.run():624
   java.lang.Thread.run():748
   
at 
org.apache.drill.jdbc.impl.DrillCursor.nextRowInternally(DrillCursor.java:528)
at 
org.apache.drill.jdbc.impl.DrillCursor.loadInitialSchema(DrillCursor.java:600)
at 
org.apache.drill.jdbc.impl.DrillResultSetImpl.execute(DrillResultSetImpl.java:1904)
at 
org.apache.drill.jdbc.impl.DrillResultSetImpl.execute(DrillResultSetImpl.java:64)
at 
oadd.org.apache.calcite.avatica.AvaticaConnection$1.execute(AvaticaConnection.java:630)
at 
org.apache.drill.jdbc.impl.DrillMetaImpl.prepareAndExecute(DrillMetaImpl.java:1109)
at 
org.apache.drill.jdbc.impl.DrillMetaImpl.prepareAndExecute(DrillMetaImpl.java:1120)
at 
oadd.org.apache.calcite.avatica.AvaticaConnection.prepareAndExecuteInternal(AvaticaConnection.java:638)
at 
org.apache.drill.jdbc.impl.DrillConnectionImpl.prepareAndExecuteInternal(DrillConnectionImpl.java:200)
at 
oadd.org.apache.calcite.avatica.AvaticaStatement.executeInternal(AvaticaStatement.java:149)
at 
oadd.org.apache.calcite.avatica.AvaticaStatement.executeQuery(AvaticaStatement.java:218)
at 
org.apache.drill.jdbc.impl.DrillStatementImpl.executeQuery(DrillStatementImpl.java:110)
at 
org.apache.drill.test.framework.DrillTestJdbc.executeQuery(DrillTestJdbc.java:210)
at 
org.apache.drill.test.framework.DrillTestJdbc.run(DrillTestJdbc.java:115)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
   Caused by: oadd.org.apache.drill.common.exceptions.UserRemoteException: 
SYSTEM ERROR: ConcurrentModificationException
   
   Fragment 2:0
   
   [Error Id: bfb0598f-e598-453b-93f2-699bd87a0061 on drill194:31010]
   
 (java.util.ConcurrentModificationException) null
   java.util.LinkedHashMap$LinkedHashIterator.nextNode():719
   java.util.LinkedHashMap$LinkedKeyIterator.next():742
   org.apache.drill.exec.record.MaterializedField.withPathAndType():144
   org.apache.drill.exec.record.MaterializedField.clone():125
   org.apache.drill.exec.record.MaterializedField.withPathAndType():145
   org.apache.drill.exec.record.MaterializedField.clone():125
   org.apache.drill.exec.vector.complex.AbstractMapVector.():49
   org.apache.drill.exec.vector.complex.MapVector.():65
   org.apache.drill.exec.expr.BasicTypeHelper.getNewVector():1275
   org.apache.drill.exec.expr.BasicTypeHelper.getNewVector():1261