[jira] [Commented] (DRILL-3610) TimestampAdd/Diff (SQL_TSI_) functions

2018-12-28 Thread Volodymyr Vysotskyi (JIRA)


[ 
https://issues.apache.org/jira/browse/DRILL-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730094#comment-16730094
 ] 

Volodymyr Vysotskyi commented on DRILL-3610:


Hi, [~bbevens],

There are some inaccuracies in docs. 
 {{TIMESTAMPADD(time_unit,interval, keyword date_expression)}} is not quite 
right. {{TIMESTAMPADD}} require the last argument value (or a column) of date, 
time or timestamp type. In the case of literal, {{date '2003-01-02'}} gives us 
date literal, it is not connected with UDF itself.
The more general use case is
 {{TIMESTAMPADD(time_unit,interval, date_time_col)}}, where date_time_col has 
one the following types: date, time, or timestamp. The same for 
{{TIMESTAMPDIFF}} function.

Could you please correct docs to clarify that?

> TimestampAdd/Diff (SQL_TSI_) functions
> --
>
> Key: DRILL-3610
> URL: https://issues.apache.org/jira/browse/DRILL-3610
> Project: Apache Drill
>  Issue Type: Improvement
>  Components: Functions - Drill
>Reporter: Andries Engelbrecht
>Assignee: Volodymyr Vysotskyi
>Priority: Major
>  Labels: doc-complete, ready-to-commit
> Fix For: 1.15.0
>
>
> Add TimestampAdd and TimestampDiff (SQL_TSI) functions for year, quarter, 
> month, week, day, hour, minute, second.
> Examples
> SELECT CAST(TIMESTAMPADD(SQL_TSI_QUARTER,1,Date('2013-03-31'), SQL_DATE) AS 
> `column_quarter`
> FROM `table_in`
> HAVING (COUNT(1) > 0)
> SELECT `table_in`.`datetime` AS `column1`,
>   `table`.`Key` AS `column_Key`,
>   TIMESTAMPDIFF(SQL_TSI_MINUTE,to_timestamp('2004-07-04', 
> '-MM-dd'),`table_in`.`datetime`) AS `sum_datediff_minute`
> FROM `calcs`



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (DRILL-6865) Query returns wrong result when filter pruning happens

2018-12-28 Thread Anton Gozhiy (JIRA)


 [ 
https://issues.apache.org/jira/browse/DRILL-6865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anton Gozhiy closed DRILL-6865.
---

Verified with Drill version 1.15.0-SNAPSHOT (commit 
2dbd60984bef724e6ae1918fa4b31509ca7a986b)
Cases checked:
- Direct case
- Several filters
- Different types
- Casting in filters
- Subqueries
A bug was reported during the verification: DRILL-6905.

> Query returns wrong result when filter pruning happens
> --
>
> Key: DRILL-6865
> URL: https://issues.apache.org/jira/browse/DRILL-6865
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Storage - Parquet
>Affects Versions: 1.14.0
>Reporter: Volodymyr Vysotskyi
>Assignee: Volodymyr Vysotskyi
>Priority: Critical
>  Labels: ready-to-commit
> Fix For: 1.15.0
>
>
> In DRILL-5796 was implemented removing the filter from the plan when some (or 
> all) row groups of parquet table fully match the filter.
> For the case when filter has some predicates which parquet filter predicate 
> does not support, they can be omitted for some cases from the resulting 
> filter predicate. When row groups fully match predicates which left in the 
> filter, the whole filter is removed from the plan and the wrong result is 
> returned.
> Example of the query for reproducing this bug:
> {code:sql}
> create table dfs.tmp.`multi/t1` as select * from cp.`tpch/nation.parquet` 
> where n_nationkey > 5;
> create table dfs.tmp.`multi/t2` as select * from cp.`tpch/nation.parquet` 
> where n_nationkey < 5;
> select * from dfs.tmp.`multi` where n_nationkey > 5 and n_nationkey like 
> '%10%';
> {code}
> returns
> {noformat}
> +---+--+-+--+-+
> | dir0  | n_nationkey  | n_name  | n_regionkey  | 
>  n_comment
>   |
> +---+--+-+--+-+
> | t1| 6| FRANCE  | 3| refully final 
> requests. regular, ironi  
> |
> | t1| 7| GERMANY | 3| l platelets. 
> regular accounts x-ray: unusual, regular acco 
>  |
> | t1| 8| INDIA   | 2| ss excuses cajole 
> slyly across the packages. deposits print aroun   
> |
> | t1| 9| INDONESIA   | 2|  slyly express 
> asymptotes. regular deposits haggle slyly. carefully ironic hockey players 
> sleep blithely. carefull  |
> | t1| 10   | IRAN| 4| efully alongside of 
> the slyly final dependencies. 
>   |
> | t1| 11   | IRAQ| 4| nic deposits boost 
> atop the quickly final requests? quickly regula   
>|
> | t1| 12   | JAPAN   | 2| ously. final, 
> express gifts cajole a
> |
> | t1| 13   | JORDAN  | 4| ic deposits are 
> blithely about the carefully regular pa   
>   |
> | t1| 14   | KENYA   | 0|  pending excuses 
> haggle furiously deposits. pending, express pinto beans wake fluffily past t  
>  |
> | t1| 15   | MOROCCO | 0| rns. blithely bold 
> courts among the closely regular packages use furiously bold platelets?   
>|
> | t1| 16   | MOZAMBIQUE  | 0| s. ironic, unusual 
> asymptotes wake blithely r
>|
> | t1| 17   | PERU| 1| platelets. blithely 
> pending dependencies use fluffily across the even pinto beans. carefully 
> silent accoun  |
> | t1| 18   | CHINA   | 2| c dependencies. 
> furiously express notornis sleep slyly regular accounts. ideas sleep. depos   
>   |
> | t1| 19   | ROMANIA | 3| ular asymptotes are 
> about the furious multipliers. express dependencies nag above the ironically 
> ironic account |
> | t1| 20   | SAUDI ARABIA| 4

[jira] [Commented] (DRILL-3933) Error execute select command line sqlline -u -q

2018-12-28 Thread Vitalii Diravka (JIRA)


[ 
https://issues.apache.org/jira/browse/DRILL-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730298#comment-16730298
 ] 

Vitalii Diravka commented on DRILL-3933:


Hi [~bbevens],

Yes, it means it is possible to pass the query in SqlLine connection process, 
execute it and exit from the SqlLine:
{code:java}
vitalii@vitalii-pc:~/drill/bin$ ./sqlline -u 'jdbc:drill:drillbit=localhost' -q 
'select * from cp.`employee.json` limit 2;'
Dec 28, 2018 4:28:57 PM org.jline.utils.Log logr
WARNING: Unable to create a system terminal, creating a dumb terminal (enable 
debug logging for more information)
Apache Drill 1.15.0-SNAPSHOT
"Let's Drill something more solid than concrete."
0: jdbc:drill:drillbit=localhost> 
+--+---+-++--+-+---++-++--++--+-+-++
| employee_id  |   full_name   | first_name  | last_name  | position_id  | 
position_title  | store_id  | department_id  | birth_date  |   hire_date
|  salary  | supervisor_id  | education_level  | marital_status  | gender  
|  management_role   |
+--+---+-++--+-+---++-++--++--+-+-++
| 1| Sheri Nowmer  | Sheri   | Nowmer | 1| 
President   | 0 | 1  | 1961-08-26  | 1994-12-01 
00:00:00.0  | 8.0  | 0  | Graduate Degree  | S   | 
F   | Senior Management  |
+--+---+-++--+-+---++-++--++--+-+-++
1 row selected (0.286 seconds)
0: jdbc:drill:drillbit=localhost> Closing: 
org.apache.drill.jdbc.impl.DrillConnectionImpl
vitalii@vitalii-pc:~/drill/bin$
{code}
It can be useful for scripts, for instance.

> Error execute select command line sqlline -u -q
> ---
>
> Key: DRILL-3933
> URL: https://issues.apache.org/jira/browse/DRILL-3933
> Project: Apache Drill
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Jon
>Assignee: Arina Ielchiieva
>Priority: Major
>  Labels: doc-impacting, ready-to-commit
> Fix For: 1.15.0
>
>
> I'm newbie with Drill and Jira, so sorry if this is not the correct site.
> When I query : "sqlline -u 'jdbc:drill:drillbit=localhost' -q 'select * from 
> hive.database.table;' " return: 
> "select anaconda-ks.cfg build.out install.log install.log.syslog 
> ranger_tutorial sandbox.info start_ambari.sh start_hbase.sh start_solr.sh 
> stop_solr.sh from hive.database.table;"
> Error: PARSE ERROR: Encountered "." at line 1, column 29.
> Was expecting one of:
> "FROM" ...
> "," ...
> So, to fix this, i should type all columns to do this one work.
> But, if I used UI, in localhost:8047/query, the query works. Drill is 
> connected to Hive with plugin of course. Is this a bug or something? Bad 
> conf.?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (DRILL-6936) TestGracefulShutdown.gracefulShutdownThreadShouldBeInitializedBeforeClosingDrillbit fails if loopback address is set in hosts

2018-12-28 Thread Anton Gozhiy (JIRA)
Anton Gozhiy created DRILL-6936:
---

 Summary: 
TestGracefulShutdown.gracefulShutdownThreadShouldBeInitializedBeforeClosingDrillbit
 fails if loopback address is set in hosts
 Key: DRILL-6936
 URL: https://issues.apache.org/jira/browse/DRILL-6936
 Project: Apache Drill
  Issue Type: Bug
Affects Versions: 1.15.0
Reporter: Anton Gozhiy


*Prerequisites:*
- Loopback address is set for the host at /etc/hosts

*Steps:*
# Run the test 
*TestGracefulShutdown.gracefulShutdownThreadShouldBeInitializedBeforeClosingDrillbit*

*Expected result:*
The test should ignore loopback address setting and pass.

*Actual result:*
The test fails:
{noformat}
16:06:51.921 [main] ERROR org.apache.drill.TestReporter - Test Failed (d: 64.2 
KiB(242.8 KiB), h: 71.1 MiB(336.2 MiB), nh: 91.9 KiB(164.3 MiB)): 
gracefulShutdownThreadShouldBeInitializedBeforeClosingDrillbit(org.apache.drill.test.TestGracefulShutdown)
java.lang.AssertionError: null
at 
org.apache.drill.test.TestGracefulShutdown.gracefulShutdownThreadShouldBeInitializedBeforeClosingDrillbit(TestGracefulShutdown.java:207)
 ~[test-classes/:na]
at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_181]
{noformat}




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (DRILL-6936) TestGracefulShutdown.gracefulShutdownThreadShouldBeInitializedBeforeClosingDrillbit fails if loopback address is set in hosts

2018-12-28 Thread Arina Ielchiieva (JIRA)


 [ 
https://issues.apache.org/jira/browse/DRILL-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arina Ielchiieva reassigned DRILL-6936:
---

Assignee: Igor Guzenko

> TestGracefulShutdown.gracefulShutdownThreadShouldBeInitializedBeforeClosingDrillbit
>  fails if loopback address is set in hosts
> -
>
> Key: DRILL-6936
> URL: https://issues.apache.org/jira/browse/DRILL-6936
> Project: Apache Drill
>  Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Anton Gozhiy
>Assignee: Igor Guzenko
>Priority: Major
> Fix For: 1.16.0
>
>
> *Prerequisites:*
> - Loopback address is set for the host at /etc/hosts
> *Steps:*
> # Run the test 
> *TestGracefulShutdown.gracefulShutdownThreadShouldBeInitializedBeforeClosingDrillbit*
> *Expected result:*
> The test should ignore loopback address setting and pass.
> *Actual result:*
> The test fails:
> {noformat}
> 16:06:51.921 [main] ERROR org.apache.drill.TestReporter - Test Failed (d: 
> 64.2 KiB(242.8 KiB), h: 71.1 MiB(336.2 MiB), nh: 91.9 KiB(164.3 MiB)): 
> gracefulShutdownThreadShouldBeInitializedBeforeClosingDrillbit(org.apache.drill.test.TestGracefulShutdown)
> java.lang.AssertionError: null
>   at 
> org.apache.drill.test.TestGracefulShutdown.gracefulShutdownThreadShouldBeInitializedBeforeClosingDrillbit(TestGracefulShutdown.java:207)
>  ~[test-classes/:na]
>   at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_181]
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (DRILL-6936) TestGracefulShutdown.gracefulShutdownThreadShouldBeInitializedBeforeClosingDrillbit fails if loopback address is set in hosts

2018-12-28 Thread Arina Ielchiieva (JIRA)


 [ 
https://issues.apache.org/jira/browse/DRILL-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arina Ielchiieva updated DRILL-6936:

Fix Version/s: 1.16.0

> TestGracefulShutdown.gracefulShutdownThreadShouldBeInitializedBeforeClosingDrillbit
>  fails if loopback address is set in hosts
> -
>
> Key: DRILL-6936
> URL: https://issues.apache.org/jira/browse/DRILL-6936
> Project: Apache Drill
>  Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Anton Gozhiy
>Assignee: Igor Guzenko
>Priority: Major
> Fix For: 1.16.0
>
>
> *Prerequisites:*
> - Loopback address is set for the host at /etc/hosts
> *Steps:*
> # Run the test 
> *TestGracefulShutdown.gracefulShutdownThreadShouldBeInitializedBeforeClosingDrillbit*
> *Expected result:*
> The test should ignore loopback address setting and pass.
> *Actual result:*
> The test fails:
> {noformat}
> 16:06:51.921 [main] ERROR org.apache.drill.TestReporter - Test Failed (d: 
> 64.2 KiB(242.8 KiB), h: 71.1 MiB(336.2 MiB), nh: 91.9 KiB(164.3 MiB)): 
> gracefulShutdownThreadShouldBeInitializedBeforeClosingDrillbit(org.apache.drill.test.TestGracefulShutdown)
> java.lang.AssertionError: null
>   at 
> org.apache.drill.test.TestGracefulShutdown.gracefulShutdownThreadShouldBeInitializedBeforeClosingDrillbit(TestGracefulShutdown.java:207)
>  ~[test-classes/:na]
>   at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_181]
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (DRILL-2597) Sqlline fails when script contains comments

2018-12-28 Thread Vitalii Diravka (JIRA)


 [ 
https://issues.apache.org/jira/browse/DRILL-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vitalii Diravka reassigned DRILL-2597:
--

Assignee: Vitalii Diravka

> Sqlline fails when script contains comments
> ---
>
> Key: DRILL-2597
> URL: https://issues.apache.org/jira/browse/DRILL-2597
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Client - CLI
>Affects Versions: 0.8.0
>Reporter: Abhishek Girish
>Assignee: Vitalii Diravka
>Priority: Major
> Fix For: Future
>
>
> Sqlline fails if option -f or - -run= is used, and the DDL file contains a 
> comment. 
> *File contents:*
> {code}
> -- comments
> drop view abc;
> create view abc;
> {code}
> *Fails to recognize comments starting with - - *
> {code}
> ${DRILL_HOME}/bin/sqlline -u "jdbc:drill:schema=dfs.tmp"  --run=abc.sql
> Drill log directory: /opt/mapr/drill/drill-0.8.0/logs
> 1/50 -- comments
> Aborting command set because "force" is false and command failed: "-- 
> comments "
> Closing: org.apache.drill.jdbc.DrillJdbc41Factory$DrillJdbc41Connection
> sqlline version 1.1.6
> # ${DRILL_HOME}/bin/sqlline -u "jdbc:drill:schema=dfs.tmp"  -f abc.sql
> Drill log directory: /opt/mapr/drill/drill-0.8.0/logs
> 1/50 -- comments
> Aborting command set because "force" is false and command failed: "-- comment"
> Closing: org.apache.drill.jdbc.DrillJdbc41Factory$DrillJdbc41Connection
> sqlline version 1.1.6
> {code}
> However, it does recognizes comments enclosed within /* ... */



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (DRILL-6931) Drill "SHOW FILES" command duplicates empty S3 folders as subfolders

2018-12-28 Thread Arina Ielchiieva (JIRA)


 [ 
https://issues.apache.org/jira/browse/DRILL-6931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arina Ielchiieva updated DRILL-6931:

Reviewer: Volodymyr Vysotskyi

> Drill "SHOW FILES" command duplicates empty S3 folders as subfolders
> 
>
> Key: DRILL-6931
> URL: https://issues.apache.org/jira/browse/DRILL-6931
> Project: Apache Drill
>  Issue Type: Bug
>Affects Versions: 1.14.0
>Reporter: Denys Ordynskiy
>Assignee: Arina Ielchiieva
>Priority: Major
> Fix For: 1.16.0
>
>
> *Description:*
>  If folder was created by pressing "+ Create folder" button on the S3 
> management console,
>  Drill "SHOW FILES" command showing in this folder another subfolder with the 
> same name.
>  But this subfolder doesn't exist.
> *Example:*
>  - login to the S3 management console;
>  - open your bucket `some_bucket`;
>  - create an empty folder `my_test_folder` by pressing "+ Create folder" 
> button;
>  - run Drill and open sqlline client;
>  - exec query "show files in s3.tmp.`my_test_folder`;"
> *Actual result:*
> |name|isDirectory|isFile|length|owner|group|permissions|accessTime|modificationTime|
> |my_test_folder|true|false|0| | |rwxrwxrwx|1970-01-01 03:00:00.0|1970-01-01 
> 03:00:00.0|
> 1 row selected (1.318 seconds)
> *Expected result:*
>  an empty result set.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (DRILL-6931) Drill "SHOW FILES" command duplicates empty S3 folders as subfolders

2018-12-28 Thread Arina Ielchiieva (JIRA)


 [ 
https://issues.apache.org/jira/browse/DRILL-6931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arina Ielchiieva updated DRILL-6931:

Fix Version/s: 1.16.0

> Drill "SHOW FILES" command duplicates empty S3 folders as subfolders
> 
>
> Key: DRILL-6931
> URL: https://issues.apache.org/jira/browse/DRILL-6931
> Project: Apache Drill
>  Issue Type: Bug
>Affects Versions: 1.14.0
>Reporter: Denys Ordynskiy
>Assignee: Arina Ielchiieva
>Priority: Major
> Fix For: 1.16.0
>
>
> *Description:*
>  If folder was created by pressing "+ Create folder" button on the S3 
> management console,
>  Drill "SHOW FILES" command showing in this folder another subfolder with the 
> same name.
>  But this subfolder doesn't exist.
> *Example:*
>  - login to the S3 management console;
>  - open your bucket `some_bucket`;
>  - create an empty folder `my_test_folder` by pressing "+ Create folder" 
> button;
>  - run Drill and open sqlline client;
>  - exec query "show files in s3.tmp.`my_test_folder`;"
> *Actual result:*
> |name|isDirectory|isFile|length|owner|group|permissions|accessTime|modificationTime|
> |my_test_folder|true|false|0| | |rwxrwxrwx|1970-01-01 03:00:00.0|1970-01-01 
> 03:00:00.0|
> 1 row selected (1.318 seconds)
> *Expected result:*
>  an empty result set.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (DRILL-6921) Add button to reset Options filter

2018-12-28 Thread Kunal Khatua (JIRA)


 [ 
https://issues.apache.org/jira/browse/DRILL-6921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kunal Khatua updated DRILL-6921:

Labels: doc-impacting user-experience  (was: user-experience)

> Add button to reset Options filter
> --
>
> Key: DRILL-6921
> URL: https://issues.apache.org/jira/browse/DRILL-6921
> Project: Apache Drill
>  Issue Type: Improvement
>  Components: Web Server
>Affects Versions: 1.15.0
>Reporter: Arina Ielchiieva
>Assignee: Kunal Khatua
>Priority: Major
>  Labels: doc-impacting, user-experience
> Fix For: 1.16.0
>
>
> Currently we have ability to search options or use quick filter on Web UI. To 
> reset the filter, user needs to delete input from the search pane manually. 
> It would be nice if we had Reset button.
>  Also we can consider leaving filter after option update / reset rather then 
> reloading page without filtering.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (DRILL-2597) Sqlline fails when script contains comments

2018-12-28 Thread Arina Ielchiieva (JIRA)


 [ 
https://issues.apache.org/jira/browse/DRILL-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arina Ielchiieva reopened DRILL-2597:
-

> Sqlline fails when script contains comments
> ---
>
> Key: DRILL-2597
> URL: https://issues.apache.org/jira/browse/DRILL-2597
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Client - CLI
>Affects Versions: 0.8.0
>Reporter: Abhishek Girish
>Assignee: Vitalii Diravka
>Priority: Major
> Fix For: 1.15.0
>
>
> Sqlline fails if option -f or - -run= is used, and the DDL file contains a 
> comment. 
> *File contents:*
> {code}
> -- comments
> drop view abc;
> create view abc;
> {code}
> *Fails to recognize comments starting with - - *
> {code}
> ${DRILL_HOME}/bin/sqlline -u "jdbc:drill:schema=dfs.tmp"  --run=abc.sql
> Drill log directory: /opt/mapr/drill/drill-0.8.0/logs
> 1/50 -- comments
> Aborting command set because "force" is false and command failed: "-- 
> comments "
> Closing: org.apache.drill.jdbc.DrillJdbc41Factory$DrillJdbc41Connection
> sqlline version 1.1.6
> # ${DRILL_HOME}/bin/sqlline -u "jdbc:drill:schema=dfs.tmp"  -f abc.sql
> Drill log directory: /opt/mapr/drill/drill-0.8.0/logs
> 1/50 -- comments
> Aborting command set because "force" is false and command failed: "-- comment"
> Closing: org.apache.drill.jdbc.DrillJdbc41Factory$DrillJdbc41Connection
> sqlline version 1.1.6
> {code}
> However, it does recognizes comments enclosed within /* ... */



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (DRILL-6931) Drill "SHOW FILES" command duplicates empty S3 folders as subfolders

2018-12-28 Thread Arina Ielchiieva (JIRA)


 [ 
https://issues.apache.org/jira/browse/DRILL-6931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arina Ielchiieva reassigned DRILL-6931:
---

Assignee: Arina Ielchiieva

> Drill "SHOW FILES" command duplicates empty S3 folders as subfolders
> 
>
> Key: DRILL-6931
> URL: https://issues.apache.org/jira/browse/DRILL-6931
> Project: Apache Drill
>  Issue Type: Bug
>Affects Versions: 1.14.0
>Reporter: Denys Ordynskiy
>Assignee: Arina Ielchiieva
>Priority: Major
> Fix For: 1.16.0
>
>
> *Description:*
>  If folder was created by pressing "+ Create folder" button on the S3 
> management console,
>  Drill "SHOW FILES" command showing in this folder another subfolder with the 
> same name.
>  But this subfolder doesn't exist.
> *Example:*
>  - login to the S3 management console;
>  - open your bucket `some_bucket`;
>  - create an empty folder `my_test_folder` by pressing "+ Create folder" 
> button;
>  - run Drill and open sqlline client;
>  - exec query "show files in s3.tmp.`my_test_folder`;"
> *Actual result:*
> |name|isDirectory|isFile|length|owner|group|permissions|accessTime|modificationTime|
> |my_test_folder|true|false|0| | |rwxrwxrwx|1970-01-01 03:00:00.0|1970-01-01 
> 03:00:00.0|
> 1 row selected (1.318 seconds)
> *Expected result:*
>  an empty result set.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (DRILL-2597) Sqlline fails when script contains comments

2018-12-28 Thread Vitalii Diravka (JIRA)


 [ 
https://issues.apache.org/jira/browse/DRILL-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vitalii Diravka resolved DRILL-2597.

   Resolution: Won't Fix
Fix Version/s: (was: Future)
   1.15.0

Looks like it is no more an issue with the SqlLine 1.6.0 version:
{code}
vitalii@vitalii-pc:/tmp/drill/bin$ ./sqlline -u 'jdbc:drill:drillbit=localhost' 
--run="/tmp/DDL.sql"
1/5  -- comment
2/5  use dfs.tmp;
+---+--+
|  ok   |   summary|
+---+--+
| true  | Default schema changed to [dfs.tmp]  |
+---+--+
1 row selected (0.154 seconds)
3/5  drop view if exists abc;
+---+-+
|  ok   | summary |
+---+-+
| true  | View [abc] deleted successfully from schema [dfs.tmp].  |
+---+-+
1 row selected (0.098 seconds)
4/5  create view abc as select * from cp.`employee.json` limit 2;
+---+--+
|  ok   |   summary|
+---+--+
| true  | View 'abc' created successfully in 'dfs.tmp' schema  |
+---+--+
1 row selected (0.101 seconds)
5/5  select * from abc;
+--+--+-++--+-+---++-++--++--+-+-++
| employee_id  |full_name | first_name  | last_name  | position_id  |   
position_title| store_id  | department_id  | birth_date  |   hire_date  
  |  salary  | supervisor_id  | education_level  | marital_status  | gender 
 |  management_role   |
+--+--+-++--+-+---++-++--++--+-+-++
| 1| Sheri Nowmer | Sheri   | Nowmer | 1| 
President   | 0 | 1  | 1961-08-26  | 1994-12-01 
00:00:00.0  | 8.0  | 0  | Graduate Degree  | S   | 
F   | Senior Management  |
| 2| Derrick Whelply  | Derrick | Whelply| 2| 
VP Country Manager  | 0 | 1  | 1915-07-03  | 1994-12-01 
00:00:00.0  | 4.0  | 1  | Graduate Degree  | M   | 
M   | Senior Management  |
+--+--+-++--+-+---++-++--++--+-+-++
2 rows selected (0.11 seconds)
Closing: org.apache.drill.jdbc.impl.DrillConnectionImpl
Apache Drill 1.15.0-SNAPSHOT
"A Drill in the hand is better than two in the bush."
{code}
The similar result for 
{code}
vitalii@vitalii-pc:/tmp/drill/bin$ ./sqlline -u 'jdbc:drill:drillbit=localhost' 
-f ="/tmp/DDL.sql"
{code}

> Sqlline fails when script contains comments
> ---
>
> Key: DRILL-2597
> URL: https://issues.apache.org/jira/browse/DRILL-2597
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Client - CLI
>Affects Versions: 0.8.0
>Reporter: Abhishek Girish
>Assignee: Vitalii Diravka
>Priority: Major
> Fix For: 1.15.0
>
>
> Sqlline fails if option -f or - -run= is used, and the DDL file contains a 
> comment. 
> *File contents:*
> {code}
> -- comments
> drop view abc;
> create view abc;
> {code}
> *Fails to recognize comments starting with - - *
> {code}
> ${DRILL_HOME}/bin/sqlline -u "jdbc:drill:schema=dfs.tmp"  --run=abc.sql
> Drill log directory: /opt/mapr/drill/drill-0.8.0/logs
> 1/50 -- comments
> Aborting command set because "force" is false and command failed: "-- 
> comments "
> Closing: org.apache.drill.jdbc.DrillJdbc41Factory$DrillJdbc41Connection
> sqlline version 1.1.6
> # ${DRILL_HOME}/bin/sqlline -u "jdbc:drill:schema=dfs.tmp"  -f abc.sql
> Drill log directory: /opt/mapr/drill/drill-0.8.0/logs
> 1/50 -- comments
> Aborting command set because "force" is false and command failed: "-- comment"
> Closing: org.apache.drill.jdbc.DrillJdbc41Factory$DrillJdbc41Connection
> sqlline version 1.1.6
> {code}
> However, it does recognizes c

[jira] [Commented] (DRILL-3090) sqlline : save SQL to script file and replay from script, results in error

2018-12-28 Thread Vitalii Diravka (JIRA)


[ 
https://issues.apache.org/jira/browse/DRILL-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730409#comment-16730409
 ] 

Vitalii Diravka commented on DRILL-3090:


I confirm that the issue is still the same on Drill 1.15.0 version wtih SqlLine 
1.6.0 version.
{code}
0: jdbc:drill:zk=local> !script file3
Saving command script to " /tmp/drill/bin/file3". Enter "script" with no 
arguments to stop it.
0: jdbc:drill:zk=local> select * from sys.drillbits;
+-++---+++--+--+-+
|  hostname   | user_port  | control_port  | data_port  | http_port  | current  
| version  |  state  |
+-++---+++--+--+-+
| vitalii-pc  | 31010  | 31011 | 31012  | 8047   | true 
| 1.15.0-SNAPSHOT  | ONLINE  |
+-++---+++--+--+-+
1 row selected (0.076 seconds)
0: jdbc:drill:zk=local> !script
Script closed. Enter "run  /tmp/drill/bin/file3" to replay it.
{code}
{code}
vitalii@vitalii-pc:/tmp$ cat /tmp/drill/bin/file3 
select * from sys.drillbits;
!script
{code}
{code}
0: jdbc:drill:zk=local> !run /tmp/drill/bin/file3
1/2  select * from sys.drillbits;
+-++---+++--+--+-+
|  hostname   | user_port  | control_port  | data_port  | http_port  | current  
| version  |  state  |
+-++---+++--+--+-+
| vitalii-pc  | 31010  | 31011 | 31012  | 8047   | true 
| 1.15.0-SNAPSHOT  | ONLINE  |
+-++---+++--+--+-+
1 row selected (0.085 seconds)
2/2  !script
Usage: script 
Aborting command set because "force" is false and command failed: "!script"
{code}

> sqlline : save SQL to script file and replay from script, results in error
> --
>
> Key: DRILL-3090
> URL: https://issues.apache.org/jira/browse/DRILL-3090
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Client - CLI
>Affects Versions: 1.0.0
> Environment: ffbb9c7adc6360744bee186e1f69d47dc743f73e
>Reporter: Khurram Faraaz
>Priority: Minor
> Fix For: Future
>
>
> Save a SQL query to a script file and replay the SQL from the script file 
> using !run, on sqlline prompt throws error. We should not see the error when 
> we replay the SQL from the script file.
> {code}
> 0: jdbc:drill:schema=dfs.tmp> !script file3
> Saving command script to "/opt/mapr/drill/drill-1.0.0/bin/file3". Enter 
> "script" with no arguments to stop it.
> 0: jdbc:drill:schema=dfs.tmp> select * from sys.drillbits;
> +++--+++
> |  hostname  | user_port  | control_port | data_port  |  current   |
> +++--+++
> | centos-04.qa.lab | 31010  | 31011| 31012  | false  |
> | centos-02.qa.lab | 31010  | 31011| 31012  | false  |
> | centos-01.qa.lab | 31010  | 31011| 31012  | false  |
> | centos-03.qa.lab | 31010  | 31011| 31012  | true   |
> +++--+++
> 4 rows selected (0.176 seconds)
> 0: jdbc:drill:schema=dfs.tmp> !script
> Script closed. Enter "run /opt/mapr/drill/drill-1.0.0/bin/file3" to replay it.
> 0: jdbc:drill:schema=dfs.tmp> !run /opt/mapr/drill/drill-1.0.0/bin/file3
> 1/2  select * from sys.drillbits;
> +++--+++
> |  hostname  | user_port  | control_port | data_port  |  current   |
> +++--+++
> | centos-04 | 31010  | 31011| 31012  | false  |
> | centos-02 | 31010  | 31011| 31012  | false  |
> | centos-01 | 31010  | 31011| 31012  | false  |
> | centos-03 | 31010  | 31011| 31012  | true   |
> +++--+++
> 4 rows selected (0.178 seconds)
> 2/2  !script
> Usage: script 
> Aborting command set because "force" is false and command failed: "!script"
> {code}
> I looked at the contents of file3 under /opt/mapr/drill/drill-1.0.0/bin
> There seems to be an additional/extra "!script" in the file.
> {code}
> [root@centos-01 bin]# cat file3
> select * from sys.drillbits;
> !script
> [root@centos-01 bin]# 
> {code}



--
This message 

[jira] [Resolved] (DRILL-2597) Sqlline fails when script contains comments

2018-12-28 Thread Arina Ielchiieva (JIRA)


 [ 
https://issues.apache.org/jira/browse/DRILL-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arina Ielchiieva resolved DRILL-2597.
-
Resolution: Fixed

> Sqlline fails when script contains comments
> ---
>
> Key: DRILL-2597
> URL: https://issues.apache.org/jira/browse/DRILL-2597
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Client - CLI
>Affects Versions: 0.8.0
>Reporter: Abhishek Girish
>Assignee: Vitalii Diravka
>Priority: Major
> Fix For: 1.15.0
>
>
> Sqlline fails if option -f or - -run= is used, and the DDL file contains a 
> comment. 
> *File contents:*
> {code}
> -- comments
> drop view abc;
> create view abc;
> {code}
> *Fails to recognize comments starting with - - *
> {code}
> ${DRILL_HOME}/bin/sqlline -u "jdbc:drill:schema=dfs.tmp"  --run=abc.sql
> Drill log directory: /opt/mapr/drill/drill-0.8.0/logs
> 1/50 -- comments
> Aborting command set because "force" is false and command failed: "-- 
> comments "
> Closing: org.apache.drill.jdbc.DrillJdbc41Factory$DrillJdbc41Connection
> sqlline version 1.1.6
> # ${DRILL_HOME}/bin/sqlline -u "jdbc:drill:schema=dfs.tmp"  -f abc.sql
> Drill log directory: /opt/mapr/drill/drill-0.8.0/logs
> 1/50 -- comments
> Aborting command set because "force" is false and command failed: "-- comment"
> Closing: org.apache.drill.jdbc.DrillJdbc41Factory$DrillJdbc41Connection
> sqlline version 1.1.6
> {code}
> However, it does recognizes comments enclosed within /* ... */



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (DRILL-3090) sqlline : save SQL to script file and replay from script, results in error

2018-12-28 Thread Vitalii Diravka (JIRA)


[ 
https://issues.apache.org/jira/browse/DRILL-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730414#comment-16730414
 ] 

Vitalii Diravka commented on DRILL-3090:


I have created SqlLine ticket for it:
https://github.com/julianhyde/sqlline/issues/242

> sqlline : save SQL to script file and replay from script, results in error
> --
>
> Key: DRILL-3090
> URL: https://issues.apache.org/jira/browse/DRILL-3090
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Client - CLI
>Affects Versions: 1.0.0
> Environment: ffbb9c7adc6360744bee186e1f69d47dc743f73e
>Reporter: Khurram Faraaz
>Priority: Minor
> Fix For: Future
>
>
> Save a SQL query to a script file and replay the SQL from the script file 
> using !run, on sqlline prompt throws error. We should not see the error when 
> we replay the SQL from the script file.
> {code}
> 0: jdbc:drill:schema=dfs.tmp> !script file3
> Saving command script to "/opt/mapr/drill/drill-1.0.0/bin/file3". Enter 
> "script" with no arguments to stop it.
> 0: jdbc:drill:schema=dfs.tmp> select * from sys.drillbits;
> +++--+++
> |  hostname  | user_port  | control_port | data_port  |  current   |
> +++--+++
> | centos-04.qa.lab | 31010  | 31011| 31012  | false  |
> | centos-02.qa.lab | 31010  | 31011| 31012  | false  |
> | centos-01.qa.lab | 31010  | 31011| 31012  | false  |
> | centos-03.qa.lab | 31010  | 31011| 31012  | true   |
> +++--+++
> 4 rows selected (0.176 seconds)
> 0: jdbc:drill:schema=dfs.tmp> !script
> Script closed. Enter "run /opt/mapr/drill/drill-1.0.0/bin/file3" to replay it.
> 0: jdbc:drill:schema=dfs.tmp> !run /opt/mapr/drill/drill-1.0.0/bin/file3
> 1/2  select * from sys.drillbits;
> +++--+++
> |  hostname  | user_port  | control_port | data_port  |  current   |
> +++--+++
> | centos-04 | 31010  | 31011| 31012  | false  |
> | centos-02 | 31010  | 31011| 31012  | false  |
> | centos-01 | 31010  | 31011| 31012  | false  |
> | centos-03 | 31010  | 31011| 31012  | true   |
> +++--+++
> 4 rows selected (0.178 seconds)
> 2/2  !script
> Usage: script 
> Aborting command set because "force" is false and command failed: "!script"
> {code}
> I looked at the contents of file3 under /opt/mapr/drill/drill-1.0.0/bin
> There seems to be an additional/extra "!script" in the file.
> {code}
> [root@centos-01 bin]# cat file3
> select * from sys.drillbits;
> !script
> [root@centos-01 bin]# 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (DRILL-3933) Error execute select command line sqlline -u -q

2018-12-28 Thread Vitalii Diravka (JIRA)


[ 
https://issues.apache.org/jira/browse/DRILL-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730437#comment-16730437
 ] 

Vitalii Diravka commented on DRILL-3933:


[~bbevens] Currently there is Command Variables which can be specified in the 
Drill shell (when the user is already in shell):
 
[https://drill.apache.org/docs/configuring-the-drill-shell/#set-command-variables]

I think it will be good to add additional paragraph with all SqlLine 
[Command-line 
arguments|https://github.com/julianhyde/sqlline/blob/e2c67fe36aeb74fb727628bbb2a8d7d28b2df6dd/src/main/resources/sqlline/SqlLine.properties#L250]
 which can be specified in the process of connecting to drillbit:
{code:java}
vitalii@vitalii-pc:/tmp/drill/bin$ ./sqlline -u 'jdbc:drill:drillbit=localhost' 
--help
Usage: java sqlline.SqlLine 
 -u  the JDBC URL to connect to
 -n  the username to connect as
 -p  the password to connect as
 -d  the command to execute
 -nn  nickname for the connection
 -ch [,]* a custom command handler to use
 -f  script file to execute (same as --run)
 -log  file to write output
 -ac  application configuration class name
 --color=[true/false] control whether color is used for display
 --colorScheme=[chester/dark/dracula/light/obsidian/solarized/vs2010] Syntax 
highlight schema
 --csvDelimiter=[delimiter] Delimiter in csv outputFormat
 --csvQuoteCharacter=[char] Quote character in csv outputFormat
 --escapeOutput=[true/false] escape control symbols in output
 --showHeader=[true/false] show column names in query results
 --headerInterval=ROWS the interval between which headers are displayed
 --fastConnect=[true/false] skip building table/column list for tab-completion
 --autoCommit=[true/false] enable/disable automatic transaction commit
 --verbose=[true/false] show verbose error messages and debug info
 --showTime=[true/false] display execution time when verbose
 --showWarnings=[true/false] display connection warnings
 --showNestedErrs=[true/false] display nested errors
 --strictJdbc=[true/false] use strict JDBC
 --nullValue=[string] use string in place of NULL values
 --numberFormat=[pattern] format numbers using DecimalFormat pattern
 --dateFormat=[pattern] format dates using SimpleDateFormat pattern
 --timeFormat=[pattern] format times using SimpleDateFormat pattern
 --timestampFormat=[pattern] format timestamps using SimpleDateFormat pattern
 --force=[true/false] continue running script even after errors
 --maxWidth=MAXWIDTH the maximum width of the terminal
 --maxColumnWidth=MAXCOLWIDTH the maximum width to use when displaying columns
 --maxHistoryFileRows=ROWS the maximum number of history rows to store in 
history file
 --maxHistoryRows=ROWS the maximum number of history rows to store in memory
 --mode=[emacs/vi] the editing mode
 --silent=[true/false] be more silent
 --autosave=[true/false] automatically save preferences
 --outputformat=[table/vertical/csv/tsv/xmlattrs/xmlelements/json]
 format mode for result display
 --isolation=LEVEL set the transaction isolation level
 --run=/path/to/file run one script and then exit
 --historyfile=/path/to/file use or create history file in specified path
 --useLineContinuation=[true/false] Use line continuation
 --help display this message
{code}
Note. There are several additional parameters in Drill:
 * -q works similar to -e in Drill.
 * --jvm to specify JVM specific parameters (see more with example in 
DRILL-6270)

> Error execute select command line sqlline -u -q
> ---
>
> Key: DRILL-3933
> URL: https://issues.apache.org/jira/browse/DRILL-3933
> Project: Apache Drill
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Jon
>Assignee: Arina Ielchiieva
>Priority: Major
>  Labels: doc-impacting, ready-to-commit
> Fix For: 1.15.0
>
>
> I'm newbie with Drill and Jira, so sorry if this is not the correct site.
> When I query : "sqlline -u 'jdbc:drill:drillbit=localhost' -q 'select * from 
> hive.database.table;' " return: 
> "select anaconda-ks.cfg build.out install.log install.log.syslog 
> ranger_tutorial sandbox.info start_ambari.sh start_hbase.sh start_solr.sh 
> stop_solr.sh from hive.database.table;"
> Error: PARSE ERROR: Encountered "." at line 1, column 29.
> Was expecting one of:
> "FROM" ...
> "," ...
> So, to fix this, i should type all columns to do this one work.
> But, if I used UI, in localhost:8047/query, the query works. Drill is 
> connected to Hive with plugin of course. Is this a bug or something? Bad 
> conf.?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (DRILL-6270) Add debug startup option flag for drill in embedded and server mode

2018-12-28 Thread Vitalii Diravka (JIRA)


 [ 
https://issues.apache.org/jira/browse/DRILL-6270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vitalii Diravka updated DRILL-6270:
---
Labels: doc-impacting ready-to-commit  (was: ready-to-commit)

> Add debug startup option flag for drill in embedded and server mode
> ---
>
> Key: DRILL-6270
> URL: https://issues.apache.org/jira/browse/DRILL-6270
> Project: Apache Drill
>  Issue Type: Task
>Reporter: Volodymyr Tkach
>Assignee: Anton Gozhiy
>Priority: Major
>  Labels: doc-impacting, ready-to-commit
> Fix For: 1.14.0
>
>
> Add possibility to run sqlline.sh and drillbit.sh scripts with -- 
> with standard java remote debug options with the ability to override port.
> It was decided to make a general flag (--jvm) to pass JVM options to the 
> script to avoid hard coding the options that may change in future.
> Usage examples:
> {noformat}
> bin/drill-embedded --jvm "-Xdebug -Xnoagent 
> -Xrunjdwp:transport=dt_socket,address=5,server=y,suspend=n"
> bin/sqlline -u "jdbc:drill:zk=zkaddr:port" --jvm "-Xdebug -Xnoagent 
> -Xrunjdwp:transport=dt_socket,address=5,server=y,suspend=n"
> sqlline.bat -u "jdbc:drill:zk=local" --jvm "-Xdebug -Xnoagent 
> -Xrunjdwp:transport=dt_socket,address=5,server=y,suspend=n"
> {noformat}
> The --jvm flag is not needed for drillbit startup, you can set the jvm 
> properties directly after the start command:
> {noformat}
> bin/drillbit.sh start -Xdebug -Xnoagent 
> -Xrunjdwp:transport=dt_socket,address=5,server=y,suspend=n
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (DRILL-6270) Add debug startup option flag for drill in embedded and server mode

2018-12-28 Thread Vitalii Diravka (JIRA)


 [ 
https://issues.apache.org/jira/browse/DRILL-6270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vitalii Diravka updated DRILL-6270:
---
Labels: ready-to-commit  (was: doc-impacting ready-to-commit)

> Add debug startup option flag for drill in embedded and server mode
> ---
>
> Key: DRILL-6270
> URL: https://issues.apache.org/jira/browse/DRILL-6270
> Project: Apache Drill
>  Issue Type: Task
>Reporter: Volodymyr Tkach
>Assignee: Anton Gozhiy
>Priority: Major
>  Labels: ready-to-commit
> Fix For: 1.14.0
>
>
> Add possibility to run sqlline.sh and drillbit.sh scripts with -- 
> with standard java remote debug options with the ability to override port.
> It was decided to make a general flag (--jvm) to pass JVM options to the 
> script to avoid hard coding the options that may change in future.
> Usage examples:
> {noformat}
> bin/drill-embedded --jvm "-Xdebug -Xnoagent 
> -Xrunjdwp:transport=dt_socket,address=5,server=y,suspend=n"
> bin/sqlline -u "jdbc:drill:zk=zkaddr:port" --jvm "-Xdebug -Xnoagent 
> -Xrunjdwp:transport=dt_socket,address=5,server=y,suspend=n"
> sqlline.bat -u "jdbc:drill:zk=local" --jvm "-Xdebug -Xnoagent 
> -Xrunjdwp:transport=dt_socket,address=5,server=y,suspend=n"
> {noformat}
> The --jvm flag is not needed for drillbit startup, you can set the jvm 
> properties directly after the start command:
> {noformat}
> bin/drillbit.sh start -Xdebug -Xnoagent 
> -Xrunjdwp:transport=dt_socket,address=5,server=y,suspend=n
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (DRILL-3933) Error execute select command line sqlline -u -q

2018-12-28 Thread Vitalii Diravka (JIRA)


[ 
https://issues.apache.org/jira/browse/DRILL-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730437#comment-16730437
 ] 

Vitalii Diravka edited comment on DRILL-3933 at 12/28/18 7:10 PM:
--

[~bbevens] Currently there is Command Variables which can be specified in the 
Drill shell (when the user is already in shell):
 
[https://drill.apache.org/docs/configuring-the-drill-shell/#set-command-variables]

I think it will be good to add additional paragraph with all SqlLine 
[Command-line 
arguments|https://github.com/julianhyde/sqlline/blob/e2c67fe36aeb74fb727628bbb2a8d7d28b2df6dd/src/main/resources/sqlline/SqlLine.properties#L250]
 which can be specified in the process of connecting to drillbit:
{code:java}
vitalii@vitalii-pc:/tmp/drill/bin$ ./sqlline -u 'jdbc:drill:drillbit=localhost' 
--help
Usage: java sqlline.SqlLine 
 -u  the JDBC URL to connect to
 -n  the username to connect as
 -p  the password to connect as
 -d  the command to execute
 -nn  nickname for the connection
 -ch [,]* a custom command handler to use
 -f  script file to execute (same as --run)
 -log  file to write output
 -ac  application configuration class name
 --color=[true/false] control whether color is used for display
 --colorScheme=[chester/dark/dracula/light/obsidian/solarized/vs2010] Syntax 
highlight schema
 --csvDelimiter=[delimiter] Delimiter in csv outputFormat
 --csvQuoteCharacter=[char] Quote character in csv outputFormat
 --escapeOutput=[true/false] escape control symbols in output
 --showHeader=[true/false] show column names in query results
 --headerInterval=ROWS the interval between which headers are displayed
 --fastConnect=[true/false] skip building table/column list for tab-completion
 --autoCommit=[true/false] enable/disable automatic transaction commit
 --verbose=[true/false] show verbose error messages and debug info
 --showTime=[true/false] display execution time when verbose
 --showWarnings=[true/false] display connection warnings
 --showNestedErrs=[true/false] display nested errors
 --strictJdbc=[true/false] use strict JDBC
 --nullValue=[string] use string in place of NULL values
 --numberFormat=[pattern] format numbers using DecimalFormat pattern
 --dateFormat=[pattern] format dates using SimpleDateFormat pattern
 --timeFormat=[pattern] format times using SimpleDateFormat pattern
 --timestampFormat=[pattern] format timestamps using SimpleDateFormat pattern
 --force=[true/false] continue running script even after errors
 --maxWidth=MAXWIDTH the maximum width of the terminal
 --maxColumnWidth=MAXCOLWIDTH the maximum width to use when displaying columns
 --maxHistoryFileRows=ROWS the maximum number of history rows to store in 
history file
 --maxHistoryRows=ROWS the maximum number of history rows to store in memory
 --mode=[emacs/vi] the editing mode
 --silent=[true/false] be more silent
 --autosave=[true/false] automatically save preferences
 --outputformat=[table/vertical/csv/tsv/xmlattrs/xmlelements/json]
 format mode for result display
 --isolation=LEVEL set the transaction isolation level
 --run=/path/to/file run one script and then exit
 --historyfile=/path/to/file use or create history file in specified path
 --useLineContinuation=[true/false] Use line continuation
 --help display this message
{code}
Note: -q works similar to -e in Drill


was (Author: vitalii):
[~bbevens] Currently there is Command Variables which can be specified in the 
Drill shell (when the user is already in shell):
 
[https://drill.apache.org/docs/configuring-the-drill-shell/#set-command-variables]

I think it will be good to add additional paragraph with all SqlLine 
[Command-line 
arguments|https://github.com/julianhyde/sqlline/blob/e2c67fe36aeb74fb727628bbb2a8d7d28b2df6dd/src/main/resources/sqlline/SqlLine.properties#L250]
 which can be specified in the process of connecting to drillbit:
{code:java}
vitalii@vitalii-pc:/tmp/drill/bin$ ./sqlline -u 'jdbc:drill:drillbit=localhost' 
--help
Usage: java sqlline.SqlLine 
 -u  the JDBC URL to connect to
 -n  the username to connect as
 -p  the password to connect as
 -d  the command to execute
 -nn  nickname for the connection
 -ch [,]* a custom command handler to use
 -f  script file to execute (same as --run)
 -log  file to write output
 -ac  application configuration class name
 --color=[true/false] control whether color is used for display
 --colorScheme=[chester/dark/dracula/light/obsidian/solarized/vs2010] Syntax 
highlight schema
 --csvDelimiter=[delimiter] Delimiter in csv outputFormat
 --csvQuoteCharacter=[char] Quote character in csv outputFormat
 --escapeOutput=[true/false] escape control symbols in output
 --showHeader=[true/false] show column names in query results
 --headerInterval=ROWS the interval between which headers are displayed
 --fastConnect=[true/false] skip building table/column list for tab-completion
 --autoCommit=[true/false] enable/disable autom

[jira] [Commented] (DRILL-6933) Ctrl+Enter meta combo not working on Windows & mac OS

2018-12-28 Thread Khurram Faraaz (JIRA)


[ 
https://issues.apache.org/jira/browse/DRILL-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730443#comment-16730443
 ] 

Khurram Faraaz commented on DRILL-6933:
---

[~kkhatua] yes that is correct, impersonation is not enabled on my setup.

> Ctrl+Enter meta combo not working on Windows & mac OS
> -
>
> Key: DRILL-6933
> URL: https://issues.apache.org/jira/browse/DRILL-6933
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Web Server
>Affects Versions: 1.15.0
> Environment: Windows 10 Pro
>Reporter: Bridget Bevens
>Assignee: Kunal Khatua
>Priority: Major
> Fix For: 1.16.0
>
>
> On my Windows machine, when I enter query text (in the query editor on the 
> Query page in the Drill Web UI) and then press Ctrl+Enter, the query is not 
> submitted. However, when I click Submit, the query is submitted and runs okay.
> I've tried for all radio buttons, SQL, Logical, Physical and Ctrl+Enter does 
> not work for me.
> I've also tried from the query profile, where you can edit and resubmit a 
> query and that did not work for me either.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (DRILL-6933) Ctrl+Enter meta combo not working on Windows & mac OS

2018-12-28 Thread Kunal Khatua (JIRA)


[ 
https://issues.apache.org/jira/browse/DRILL-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730453#comment-16730453
 ] 

Kunal Khatua commented on DRILL-6933:
-

Ok. I think it should work with Impersonation enabled for you. I already have 
an unintended fix as part of DRILL-6050. 

> Ctrl+Enter meta combo not working on Windows & mac OS
> -
>
> Key: DRILL-6933
> URL: https://issues.apache.org/jira/browse/DRILL-6933
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Web Server
>Affects Versions: 1.15.0
> Environment: Windows 10 Pro
>Reporter: Bridget Bevens
>Assignee: Kunal Khatua
>Priority: Major
> Fix For: 1.16.0
>
>
> On my Windows machine, when I enter query text (in the query editor on the 
> Query page in the Drill Web UI) and then press Ctrl+Enter, the query is not 
> submitted. However, when I click Submit, the query is submitted and runs okay.
> I've tried for all radio buttons, SQL, Logical, Physical and Ctrl+Enter does 
> not work for me.
> I've also tried from the query profile, where you can edit and resubmit a 
> query and that did not work for me either.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (DRILL-6933) Ctrl+Enter meta combo not working on Windows & mac OS

2018-12-28 Thread Kunal Khatua (JIRA)


 [ 
https://issues.apache.org/jira/browse/DRILL-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kunal Khatua updated DRILL-6933:

Reviewer: Sorabh Hamirwasia

> Ctrl+Enter meta combo not working on Windows & mac OS
> -
>
> Key: DRILL-6933
> URL: https://issues.apache.org/jira/browse/DRILL-6933
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Web Server
>Affects Versions: 1.15.0
> Environment: Windows 10 Pro
>Reporter: Bridget Bevens
>Assignee: Kunal Khatua
>Priority: Major
> Fix For: 1.16.0
>
>
> On my Windows machine, when I enter query text (in the query editor on the 
> Query page in the Drill Web UI) and then press Ctrl+Enter, the query is not 
> submitted. However, when I click Submit, the query is submitted and runs okay.
> I've tried for all radio buttons, SQL, Logical, Physical and Ctrl+Enter does 
> not work for me.
> I've also tried from the query profile, where you can edit and resubmit a 
> query and that did not work for me either.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (DRILL-6880) Hash-Join: Many null keys on the build side form a long linked chain in the Hash Table

2018-12-28 Thread Kunal Khatua (JIRA)


 [ 
https://issues.apache.org/jira/browse/DRILL-6880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kunal Khatua updated DRILL-6880:

Priority: Critical  (was: Major)

> Hash-Join: Many null keys on the build side form a long linked chain in the 
> Hash Table
> --
>
> Key: DRILL-6880
> URL: https://issues.apache.org/jira/browse/DRILL-6880
> Project: Apache Drill
>  Issue Type: Improvement
>  Components: Execution - Relational Operators
>Affects Versions: 1.14.0
>Reporter: Boaz Ben-Zvi
>Assignee: Boaz Ben-Zvi
>Priority: Critical
> Fix For: 1.16.0
>
>
> When building the Hash Table for the Hash-Join, each new key is matched with 
> an existing key (same bucket) by calling the generated method 
> `isKeyMatchInternalBuild`, which compares the two. However when both keys are 
> null, the method returns *false* (meaning not-equal; i.e. it is a new key), 
> thus the new key is added into the list following the old key. When a third 
> null key is found, it would be matched with the prior two, and added as well. 
> Etc etc ...
> This way many null values would perform checks at order N^2 / 2.
> Suggested improvement: The generated code should return a third result, 
> meaning "two null keys". Then in case of Inner or Left joins all the 
> duplicate nulls can be discarded.
> Below is a simple example, note the time difference between non-null and the 
> all-nulls tables (also instrumentation showed that for nulls, the method 
> above was called 1249975000 times!!)
> {code:java}
> 0: jdbc:drill:zk=local> use dfs.tmp;
> 0: jdbc:drill:zk=local> create table test as (select cast(null as int) mycol 
> from 
>  dfs.`/data/test128M.tbl` limit 5);
> 0: jdbc:drill:zk=local> create table test1 as (select cast(1 as int) mycol1 
> from 
>  dfs.`/data/test128M.tbl` limit 6);
> 0: jdbc:drill:zk=local> create table test2 as (select cast(2 as int) mycol2 
> from dfs.`/data/test128M.tbl` limit 5);
> 0: jdbc:drill:zk=local> select count(*) from test1 join test2 on test1.mycol1 
> = test2.mycol2;
> +-+
> | EXPR$0  |
> +-+
> | 0   |
> +-+
> 1 row selected (0.443 seconds)
> 0: jdbc:drill:zk=local> create table test1 as (select cast(1 as int) mycol1 
> from dfs.`/data/test128M.tbl` limit 6);
> +---++
> | Fragment  | Number of records written  |
> +---++
> | 0_0   | 6  |
> +---++
> 1 row selected (0.517 seconds)
> 0: jdbc:drill:zk=local> select count(*) from test1 join test on test1.mycol1 
> = test.mycol;
> +-+
> | EXPR$0  |
> +-+
> | 0   |
> +-+
> 1 row selected (140.098 seconds)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (DRILL-6050) Provide a limit to the number of rows to be fetched for a query submitted via the WebUI

2018-12-28 Thread Kunal Khatua (JIRA)


 [ 
https://issues.apache.org/jira/browse/DRILL-6050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kunal Khatua updated DRILL-6050:

Reviewer: Sorabh Hamirwasia

> Provide a limit to the number of rows to be fetched for a query submitted via 
> the WebUI
> ---
>
> Key: DRILL-6050
> URL: https://issues.apache.org/jira/browse/DRILL-6050
> Project: Apache Drill
>  Issue Type: Improvement
>Reporter: Kunal Khatua
>Assignee: Kunal Khatua
>Priority: Minor
> Fix For: 1.16.0
>
>
> Currently, the WebServer side needs to process the entire set of results and 
> stream it back to the WebClient. 
> Since the WebUI does paginate results, we can load a larger set for 
> pagination on the browser client and relieve pressure off the WebServer to 
> host all the data.
> e.g. Fetching all rows from a 1Billion records table is impractical and can 
> be capped at 10K. Currently, the user has to explicitly specify LIMIT in the 
> submitted query. 
> An option can be provided in the field to allow for this entry.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (DRILL-6880) Hash-Join: Many null keys on the build side form a long linked chain in the Hash Table

2018-12-28 Thread Boaz Ben-Zvi (JIRA)


 [ 
https://issues.apache.org/jira/browse/DRILL-6880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Boaz Ben-Zvi updated DRILL-6880:

Description: 
When building the Hash Table for the Hash-Join, each new key is matched with an 
existing key (same bucket) by calling the generated method 
`isKeyMatchInternalBuild`, which compares the two. However when both keys are 
null, the method returns *false* (meaning not-equal; i.e. it is a new key), 
thus the new key is added into the list following the old key. When a third 
null key is found, it would be matched with the prior two, and added as well. 
Etc etc ...

This way many null values would perform checks at order N^2 / 2.

_Suggested improvement_: The generated code should return a third result, 
meaning "two null keys". Then in case of Inner or Left joins all the duplicate 
nulls can be discarded.

Below is a simple example, note the time difference between non-null and the 
all-nulls tables (also instrumentation showed that for nulls, the method above 
was called 1249975000 times!!)
{code:java}
0: jdbc:drill:zk=local> use dfs.tmp;
0: jdbc:drill:zk=local> create table testNull as (select cast(null as int) 
mycol from 
 dfs.`/data/test128M.tbl` limit 5);
0: jdbc:drill:zk=local> create table test1 as (select cast(1 as int) mycol1 
from 
 dfs.`/data/test128M.tbl` limit 6);
0: jdbc:drill:zk=local> create table test2 as (select cast(2 as int) mycol2 
from dfs.`/data/test128M.tbl` limit 5);
0: jdbc:drill:zk=local> select count(*) from test1 join test2 on test1.mycol1 = 
test2.mycol2;
+-+
| EXPR$0  |
+-+
| 0   |
+-+
1 row selected (0.443 seconds)
0: jdbc:drill:zk=local> select count(*) from test1 join testNull on 
test1.mycol1 = testNull.mycol;
+-+
| EXPR$0  |
+-+
| 0   |
+-+
1 row selected (140.098 seconds)
{code}

  was:
When building the Hash Table for the Hash-Join, each new key is matched with an 
existing key (same bucket) by calling the generated method 
`isKeyMatchInternalBuild`, which compares the two. However when both keys are 
null, the method returns *false* (meaning not-equal; i.e. it is a new key), 
thus the new key is added into the list following the old key. When a third 
null key is found, it would be matched with the prior two, and added as well. 
Etc etc ...

This way many null values would perform checks at order N^2 / 2.

Suggested improvement: The generated code should return a third result, meaning 
"two null keys". Then in case of Inner or Left joins all the duplicate nulls 
can be discarded.

Below is a simple example, note the time difference between non-null and the 
all-nulls tables (also instrumentation showed that for nulls, the method above 
was called 1249975000 times!!)
{code:java}
0: jdbc:drill:zk=local> use dfs.tmp;
0: jdbc:drill:zk=local> create table test as (select cast(null as int) mycol 
from 
 dfs.`/data/test128M.tbl` limit 5);
0: jdbc:drill:zk=local> create table test1 as (select cast(1 as int) mycol1 
from 
 dfs.`/data/test128M.tbl` limit 6);
0: jdbc:drill:zk=local> create table test2 as (select cast(2 as int) mycol2 
from dfs.`/data/test128M.tbl` limit 5);
0: jdbc:drill:zk=local> select count(*) from test1 join test2 on test1.mycol1 = 
test2.mycol2;
+-+
| EXPR$0  |
+-+
| 0   |
+-+
1 row selected (0.443 seconds)
0: jdbc:drill:zk=local> create table test1 as (select cast(1 as int) mycol1 
from dfs.`/data/test128M.tbl` limit 6);
+---++
| Fragment  | Number of records written  |
+---++
| 0_0   | 6  |
+---++
1 row selected (0.517 seconds)
0: jdbc:drill:zk=local> select count(*) from test1 join test on test1.mycol1 = 
test.mycol;
+-+
| EXPR$0  |
+-+
| 0   |
+-+
1 row selected (140.098 seconds)
{code}


> Hash-Join: Many null keys on the build side form a long linked chain in the 
> Hash Table
> --
>
> Key: DRILL-6880
> URL: https://issues.apache.org/jira/browse/DRILL-6880
> Project: Apache Drill
>  Issue Type: Improvement
>  Components: Execution - Relational Operators
>Affects Versions: 1.14.0
>Reporter: Boaz Ben-Zvi
>Assignee: Boaz Ben-Zvi
>Priority: Critical
> Fix For: 1.16.0
>
>
> When building the Hash Table for the Hash-Join, each new key is matched with 
> an existing key (same bucket) by calling the generated method 
> `isKeyMatchInternalBuild`, which compares the two. However when both keys are 
> null, the method returns *false* (meaning not-equal; i.e. it is a new key), 
> thus the new key is added into the list following the old key. When a third 
> null key is found, it would be matche

[jira] [Assigned] (DRILL-6937) sys.functions table needs a fix in the names column

2018-12-28 Thread Khurram Faraaz (JIRA)


 [ 
https://issues.apache.org/jira/browse/DRILL-6937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Khurram Faraaz reassigned DRILL-6937:
-

Assignee: Kunal Khatua

> sys.functions table needs a fix in the names column
> ---
>
> Key: DRILL-6937
> URL: https://issues.apache.org/jira/browse/DRILL-6937
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Execution - Flow
>Affects Versions: 1.15.0
>Reporter: Khurram Faraaz
>Assignee: Kunal Khatua
>Priority: Major
>
> The function names in the name column of sys.functions in some cases, are the 
> operators, this is not the expected behavior, the name column should have 
> actual names and not the operators.
> I am on Drill 1.15.0 commit : 8743e8f1e8d5bca4d67c94d07a8560ad356ff2b6
> {noformat}
> Apache Drill 1.15.0
> "Data is the new oil. Ready to Drill some?"
> 0: jdbc:drill:schema=dfs.tmp> select count(*) from sys.functions;
> +-+
> | EXPR$0 |
> +-+
> | 2846 |
> +-+
> 1 row selected (0.327 seconds)
> 0: jdbc:drill:schema=dfs.tmp>
> {noformat}
> {noformat}
> 0: jdbc:drill:schema=dfs.tmp> select distinct name from sys.functions limit 
> 12;
> ++
> | name |
> ++
> | != |
> | $sum0 |
> | && |
> | - |
> | /int |
> | < |
> | <= |
> | <> |
> | = |
> | == |
> | > |
> | >= |
> ++
> 12 rows selected (0.175 seconds)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (DRILL-6937) sys.functions table needs a fix in the names column

2018-12-28 Thread Khurram Faraaz (JIRA)
Khurram Faraaz created DRILL-6937:
-

 Summary: sys.functions table needs a fix in the names column
 Key: DRILL-6937
 URL: https://issues.apache.org/jira/browse/DRILL-6937
 Project: Apache Drill
  Issue Type: Bug
  Components: Execution - Flow
Affects Versions: 1.15.0
Reporter: Khurram Faraaz


The function names in the name column of sys.functions in some cases, are the 
operators, this is not the expected behavior, the name column should have 
actual names and not the operators.

I am on Drill 1.15.0 commit : 8743e8f1e8d5bca4d67c94d07a8560ad356ff2b6

{noformat}
Apache Drill 1.15.0
"Data is the new oil. Ready to Drill some?"
0: jdbc:drill:schema=dfs.tmp> select count(*) from sys.functions;
+-+
| EXPR$0 |
+-+
| 2846 |
+-+
1 row selected (0.327 seconds)
0: jdbc:drill:schema=dfs.tmp>
{noformat}

{noformat}
0: jdbc:drill:schema=dfs.tmp> select distinct name from sys.functions limit 12;
++
| name |
++
| != |
| $sum0 |
| && |
| - |
| /int |
| < |
| <= |
| <> |
| = |
| == |
| > |
| >= |
++
12 rows selected (0.175 seconds)
{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (DRILL-3933) Error execute select command line sqlline -u -q

2018-12-28 Thread Bridget Bevens (JIRA)


 [ 
https://issues.apache.org/jira/browse/DRILL-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bridget Bevens updated DRILL-3933:
--
Labels: doc-complete ready-to-commit  (was: doc-impacting ready-to-commit)

> Error execute select command line sqlline -u -q
> ---
>
> Key: DRILL-3933
> URL: https://issues.apache.org/jira/browse/DRILL-3933
> Project: Apache Drill
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Jon
>Assignee: Arina Ielchiieva
>Priority: Major
>  Labels: doc-complete, ready-to-commit
> Fix For: 1.15.0
>
>
> I'm newbie with Drill and Jira, so sorry if this is not the correct site.
> When I query : "sqlline -u 'jdbc:drill:drillbit=localhost' -q 'select * from 
> hive.database.table;' " return: 
> "select anaconda-ks.cfg build.out install.log install.log.syslog 
> ranger_tutorial sandbox.info start_ambari.sh start_hbase.sh start_solr.sh 
> stop_solr.sh from hive.database.table;"
> Error: PARSE ERROR: Encountered "." at line 1, column 29.
> Was expecting one of:
> "FROM" ...
> "," ...
> So, to fix this, i should type all columns to do this one work.
> But, if I used UI, in localhost:8047/query, the query works. Drill is 
> connected to Hive with plugin of course. Is this a bug or something? Bad 
> conf.?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (DRILL-3933) Error execute select command line sqlline -u -q

2018-12-28 Thread Bridget Bevens (JIRA)


[ 
https://issues.apache.org/jira/browse/DRILL-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730488#comment-16730488
 ] 

Bridget Bevens commented on DRILL-3933:
---

Hi [~vitalii],

Thanks for the info. I've updated the page with the following section:
https://drill.apache.org/docs/configuring-the-drill-shell/#sqlline-connection-parameters
 

Please have a look and let me know if I need to change anything.

Thanks,
Bridget

> Error execute select command line sqlline -u -q
> ---
>
> Key: DRILL-3933
> URL: https://issues.apache.org/jira/browse/DRILL-3933
> Project: Apache Drill
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Jon
>Assignee: Arina Ielchiieva
>Priority: Major
>  Labels: doc-impacting, ready-to-commit
> Fix For: 1.15.0
>
>
> I'm newbie with Drill and Jira, so sorry if this is not the correct site.
> When I query : "sqlline -u 'jdbc:drill:drillbit=localhost' -q 'select * from 
> hive.database.table;' " return: 
> "select anaconda-ks.cfg build.out install.log install.log.syslog 
> ranger_tutorial sandbox.info start_ambari.sh start_hbase.sh start_solr.sh 
> stop_solr.sh from hive.database.table;"
> Error: PARSE ERROR: Encountered "." at line 1, column 29.
> Was expecting one of:
> "FROM" ...
> "," ...
> So, to fix this, i should type all columns to do this one work.
> But, if I used UI, in localhost:8047/query, the query works. Drill is 
> connected to Hive with plugin of course. Is this a bug or something? Bad 
> conf.?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (DRILL-5735) UI options grouping and filtering & Metrics hints

2018-12-28 Thread Bridget Bevens (JIRA)


[ 
https://issues.apache.org/jira/browse/DRILL-5735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730492#comment-16730492
 ] 

Bridget Bevens commented on DRILL-5735:
---

hi [~kkhatua],

I've added this section to the docs based on info in this JIRA: 
https://drill.apache.org/docs/planning-and-execution-options/#setting-options-from-the-drill-web-ui
 

Let me know if I need to change anything.

Thanks,
Bridget

> UI options grouping and filtering & Metrics hints
> -
>
> Key: DRILL-5735
> URL: https://issues.apache.org/jira/browse/DRILL-5735
> Project: Apache Drill
>  Issue Type: Improvement
>  Components: Web Server
>Affects Versions: 1.9.0, 1.10.0, 1.11.0
>Reporter: Muhammad Gelbana
>Assignee: Kunal Khatua
>Priority: Major
>  Labels: doc-complete, ready-to-commit
> Fix For: 1.15.0
>
>
> I'm thinking of some UI improvements that could make all the difference for 
> users trying to optimize low-performing queries.
> h2. Options
> h3. Grouping
> We can organize the options to be grouped by their scope of effect, this will 
> help users easily locate the options they may need to tune.
> h3. Filtering
> Since the options are a lot, we can add a filtering mechanism (i.e. string 
> search or group\scope filtering) so the user can filter out the options he's 
> not interested in. To provide more benefit than the grouping idea mentioned 
> above, filtering may include keywords also and not just the option name, 
> since the user may not be aware of the name of the option he's looking for.
> h2. Metrics
> I'm referring here to the metrics page and the query execution plan page that 
> displays the overview section and major\minor fragments metrics. We can show 
> hints for each metric such as:
> # What does it represent in more details.
> # What option\scope-of-options to tune (increase ? decrease ?) to improve the 
> performance reported by this metric.
> # May be even provide a small dialog to quickly allow the modification of the 
> related option(s) to that metric



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (DRILL-5735) UI options grouping and filtering & Metrics hints

2018-12-28 Thread Bridget Bevens (JIRA)


 [ 
https://issues.apache.org/jira/browse/DRILL-5735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bridget Bevens updated DRILL-5735:
--
Labels: doc-complete ready-to-commit  (was: doc-impacting ready-to-commit)

> UI options grouping and filtering & Metrics hints
> -
>
> Key: DRILL-5735
> URL: https://issues.apache.org/jira/browse/DRILL-5735
> Project: Apache Drill
>  Issue Type: Improvement
>  Components: Web Server
>Affects Versions: 1.9.0, 1.10.0, 1.11.0
>Reporter: Muhammad Gelbana
>Assignee: Kunal Khatua
>Priority: Major
>  Labels: doc-complete, ready-to-commit
> Fix For: 1.15.0
>
>
> I'm thinking of some UI improvements that could make all the difference for 
> users trying to optimize low-performing queries.
> h2. Options
> h3. Grouping
> We can organize the options to be grouped by their scope of effect, this will 
> help users easily locate the options they may need to tune.
> h3. Filtering
> Since the options are a lot, we can add a filtering mechanism (i.e. string 
> search or group\scope filtering) so the user can filter out the options he's 
> not interested in. To provide more benefit than the grouping idea mentioned 
> above, filtering may include keywords also and not just the option name, 
> since the user may not be aware of the name of the option he's looking for.
> h2. Metrics
> I'm referring here to the metrics page and the query execution plan page that 
> displays the overview section and major\minor fragments metrics. We can show 
> hints for each metric such as:
> # What does it represent in more details.
> # What option\scope-of-options to tune (increase ? decrease ?) to improve the 
> performance reported by this metric.
> # May be even provide a small dialog to quickly allow the modification of the 
> related option(s) to that metric



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (DRILL-6937) sys.functions table needs a fix in the names column

2018-12-28 Thread Kunal Khatua (JIRA)


[ 
https://issues.apache.org/jira/browse/DRILL-6937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730499#comment-16730499
 ] 

Kunal Khatua commented on DRILL-6937:
-

[~khfaraaz] Drill operators are also implicitly functions, which is why they 
appear in the listing. That is how Drill is able to enforce data type 
compatibility, because those operators get translated to functions with valid 
arguments.

That said, some functions are internal in nature, e.g.
{code}
0: jdbc:drill:drillbit=10.10.100.127> select distinct name from sys.functions 
where internal limit 3;
+---+
| name |
+---+
| castEmptyStringNullableVar16CharToNULLABLEBIGINT |
| castEmptyStringNullableVar16CharToNULLABLEDATE |
| castEmptyStringNullableVar16CharToNULLABLEFLOAT4 |
+---+
3 rows selected (0.408 seconds)
{code}
 
However, the {{$sum0}} and {{/int}} are operators I've not seen before and 
might be part of some new UDFs. I'll take a look at it and update the JIRA with 
the appropriate resolution.
 

> sys.functions table needs a fix in the names column
> ---
>
> Key: DRILL-6937
> URL: https://issues.apache.org/jira/browse/DRILL-6937
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Execution - Flow
>Affects Versions: 1.15.0
>Reporter: Khurram Faraaz
>Assignee: Kunal Khatua
>Priority: Major
> Fix For: 1.16.0
>
>
> The function names in the name column of sys.functions in some cases, are the 
> operators, this is not the expected behavior, the name column should have 
> actual names and not the operators.
> I am on Drill 1.15.0 commit : 8743e8f1e8d5bca4d67c94d07a8560ad356ff2b6
> {noformat}
> Apache Drill 1.15.0
> "Data is the new oil. Ready to Drill some?"
> 0: jdbc:drill:schema=dfs.tmp> select count(*) from sys.functions;
> +-+
> | EXPR$0 |
> +-+
> | 2846 |
> +-+
> 1 row selected (0.327 seconds)
> 0: jdbc:drill:schema=dfs.tmp>
> {noformat}
> {noformat}
> 0: jdbc:drill:schema=dfs.tmp> select distinct name from sys.functions limit 
> 12;
> ++
> | name |
> ++
> | != |
> | $sum0 |
> | && |
> | - |
> | /int |
> | < |
> | <= |
> | <> |
> | = |
> | == |
> | > |
> | >= |
> ++
> 12 rows selected (0.175 seconds)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (DRILL-6937) sys.functions table needs a fix in the names column

2018-12-28 Thread Kunal Khatua (JIRA)


 [ 
https://issues.apache.org/jira/browse/DRILL-6937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kunal Khatua updated DRILL-6937:

Fix Version/s: 1.16.0

> sys.functions table needs a fix in the names column
> ---
>
> Key: DRILL-6937
> URL: https://issues.apache.org/jira/browse/DRILL-6937
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Execution - Flow
>Affects Versions: 1.15.0
>Reporter: Khurram Faraaz
>Assignee: Kunal Khatua
>Priority: Major
> Fix For: 1.16.0
>
>
> The function names in the name column of sys.functions in some cases, are the 
> operators, this is not the expected behavior, the name column should have 
> actual names and not the operators.
> I am on Drill 1.15.0 commit : 8743e8f1e8d5bca4d67c94d07a8560ad356ff2b6
> {noformat}
> Apache Drill 1.15.0
> "Data is the new oil. Ready to Drill some?"
> 0: jdbc:drill:schema=dfs.tmp> select count(*) from sys.functions;
> +-+
> | EXPR$0 |
> +-+
> | 2846 |
> +-+
> 1 row selected (0.327 seconds)
> 0: jdbc:drill:schema=dfs.tmp>
> {noformat}
> {noformat}
> 0: jdbc:drill:schema=dfs.tmp> select distinct name from sys.functions limit 
> 12;
> ++
> | name |
> ++
> | != |
> | $sum0 |
> | && |
> | - |
> | /int |
> | < |
> | <= |
> | <> |
> | = |
> | == |
> | > |
> | >= |
> ++
> 12 rows selected (0.175 seconds)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (DRILL-5735) UI options grouping and filtering & Metrics hints

2018-12-28 Thread Kunal Khatua (JIRA)


[ 
https://issues.apache.org/jira/browse/DRILL-5735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730497#comment-16730497
 ] 

Kunal Khatua commented on DRILL-5735:
-

LGTM. Thanks! 

> UI options grouping and filtering & Metrics hints
> -
>
> Key: DRILL-5735
> URL: https://issues.apache.org/jira/browse/DRILL-5735
> Project: Apache Drill
>  Issue Type: Improvement
>  Components: Web Server
>Affects Versions: 1.9.0, 1.10.0, 1.11.0
>Reporter: Muhammad Gelbana
>Assignee: Kunal Khatua
>Priority: Major
>  Labels: doc-complete, ready-to-commit
> Fix For: 1.15.0
>
>
> I'm thinking of some UI improvements that could make all the difference for 
> users trying to optimize low-performing queries.
> h2. Options
> h3. Grouping
> We can organize the options to be grouped by their scope of effect, this will 
> help users easily locate the options they may need to tune.
> h3. Filtering
> Since the options are a lot, we can add a filtering mechanism (i.e. string 
> search or group\scope filtering) so the user can filter out the options he's 
> not interested in. To provide more benefit than the grouping idea mentioned 
> above, filtering may include keywords also and not just the option name, 
> since the user may not be aware of the name of the option he's looking for.
> h2. Metrics
> I'm referring here to the metrics page and the query execution plan page that 
> displays the overview section and major\minor fragments metrics. We can show 
> hints for each metric such as:
> # What does it represent in more details.
> # What option\scope-of-options to tune (increase ? decrease ?) to improve the 
> performance reported by this metric.
> # May be even provide a small dialog to quickly allow the modification of the 
> related option(s) to that metric



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (DRILL-6937) sys.functions table needs a fix in the names column

2018-12-28 Thread Kunal Khatua (JIRA)


[ 
https://issues.apache.org/jira/browse/DRILL-6937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730499#comment-16730499
 ] 

Kunal Khatua edited comment on DRILL-6937 at 12/28/18 11:28 PM:


[~khfaraaz] Drill operators are also implicitly functions, which is why they 
appear in the listing. That is how Drill is able to enforce data type 
compatibility, because those operators get translated to functions with valid 
arguments.

That said, some functions are internal in nature, e.g.
{code}
0: jdbc:drill:drillbit=10.10.100.127> select distinct name from sys.functions 
where internal limit 3;
+---+
| name |
+---+
| castEmptyStringNullableVar16CharToNULLABLEBIGINT |
| castEmptyStringNullableVar16CharToNULLABLEDATE |
| castEmptyStringNullableVar16CharToNULLABLEFLOAT4 |
+---+
3 rows selected (0.408 seconds)
{code}
 
However, the {{$sum0}} and {{/int}} are operators I've not seen before and 
might be part of some new UDFs. 

Looking at the signatures, it seems that {{$sum0}} is a duplicate of the 
{{sum}} function.
{code}
0: jdbc:drill:drillbit=10.10.100.127> select $sum0(1.2) from (values(1));
+-+
| EXPR$0  |
+-+
| 1.2 |
+-+
1 row selected (0.191 seconds)
{code}

As for {{/int}}, it appears to be part of the time/timestamp class of 
functions. There have been recent commits related to timestamp intervals, so 
this might have come from there. 
{code}
0: jdbc:drill:drillbit=10.10.100.127> select * from sys.functions where name 
like '/int' limit 20;
+---+-+-+---+---+
| name  |  signature  | returnType  |  source   | 
internal  |
+---+-+-+---+---+
| /int  | INTERVAL-REQUIRED,INT-REQUIRED  | INTERVAL| built-in  | false 
|
| /int  | INTERVALDAY-REQUIRED,INT-REQUIRED   | INTERVAL| built-in  | false 
|
| /int  | INTERVALYEAR-REQUIRED,INT-REQUIRED  | INTERVAL| built-in  | false 
|
+---+-+-+---+---+
3 rows selected (0.222 seconds)
{code}

I'll take a look at it and update the JIRA with the appropriate resolution.
 


was (Author: kkhatua):
[~khfaraaz] Drill operators are also implicitly functions, which is why they 
appear in the listing. That is how Drill is able to enforce data type 
compatibility, because those operators get translated to functions with valid 
arguments.

That said, some functions are internal in nature, e.g.
{code}
0: jdbc:drill:drillbit=10.10.100.127> select distinct name from sys.functions 
where internal limit 3;
+---+
| name |
+---+
| castEmptyStringNullableVar16CharToNULLABLEBIGINT |
| castEmptyStringNullableVar16CharToNULLABLEDATE |
| castEmptyStringNullableVar16CharToNULLABLEFLOAT4 |
+---+
3 rows selected (0.408 seconds)
{code}
 
However, the {{$sum0}} and {{/int}} are operators I've not seen before and 
might be part of some new UDFs. I'll take a look at it and update the JIRA with 
the appropriate resolution.
 

> sys.functions table needs a fix in the names column
> ---
>
> Key: DRILL-6937
> URL: https://issues.apache.org/jira/browse/DRILL-6937
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Execution - Flow
>Affects Versions: 1.15.0
>Reporter: Khurram Faraaz
>Assignee: Kunal Khatua
>Priority: Major
> Fix For: 1.16.0
>
>
> The function names in the name column of sys.functions in some cases, are the 
> operators, this is not the expected behavior, the name column should have 
> actual names and not the operators.
> I am on Drill 1.15.0 commit : 8743e8f1e8d5bca4d67c94d07a8560ad356ff2b6
> {noformat}
> Apache Drill 1.15.0
> "Data is the new oil. Ready to Drill some?"
> 0: jdbc:drill:schema=dfs.tmp> select count(*) from sys.functions;
> +-+
> | EXPR$0 |
> +-+
> | 2846 |
> +-+
> 1 row selected (0.327 seconds)
> 0: jdbc:drill:schema=dfs.tmp>
> {noformat}
> {noformat}
> 0: jdbc:drill:schema=dfs.tmp> select distinct name from sys.functions limit 
> 12;
> ++
> | name |
> ++
> | != |
> | $sum0 |
> | && |
> | - |
> | /int |
> | < |
> | <= |
> | <> |
> | = |
> | == |
> | > |
> | >= |
> ++
> 12 rows selected (0.175 seconds)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (DRILL-6937) sys.functions table needs a fix in the names column

2018-12-28 Thread Kunal Khatua (JIRA)


 [ 
https://issues.apache.org/jira/browse/DRILL-6937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kunal Khatua updated DRILL-6937:

Priority: Minor  (was: Major)

> sys.functions table needs a fix in the names column
> ---
>
> Key: DRILL-6937
> URL: https://issues.apache.org/jira/browse/DRILL-6937
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Execution - Flow
>Affects Versions: 1.15.0
>Reporter: Khurram Faraaz
>Assignee: Kunal Khatua
>Priority: Minor
> Fix For: 1.16.0
>
>
> The function names in the name column of sys.functions in some cases, are the 
> operators, this is not the expected behavior, the name column should have 
> actual names and not the operators.
> I am on Drill 1.15.0 commit : 8743e8f1e8d5bca4d67c94d07a8560ad356ff2b6
> {noformat}
> Apache Drill 1.15.0
> "Data is the new oil. Ready to Drill some?"
> 0: jdbc:drill:schema=dfs.tmp> select count(*) from sys.functions;
> +-+
> | EXPR$0 |
> +-+
> | 2846 |
> +-+
> 1 row selected (0.327 seconds)
> 0: jdbc:drill:schema=dfs.tmp>
> {noformat}
> {noformat}
> 0: jdbc:drill:schema=dfs.tmp> select distinct name from sys.functions limit 
> 12;
> ++
> | name |
> ++
> | != |
> | $sum0 |
> | && |
> | - |
> | /int |
> | < |
> | <= |
> | <> |
> | = |
> | == |
> | > |
> | >= |
> ++
> 12 rows selected (0.175 seconds)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)