[jira] [Updated] (DRILL-7253) Read Hive struct w/o nulls
[ https://issues.apache.org/jira/browse/DRILL-7253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva updated DRILL-7253: Fix Version/s: 1.17.0 > Read Hive struct w/o nulls > -- > > Key: DRILL-7253 > URL: https://issues.apache.org/jira/browse/DRILL-7253 > Project: Apache Drill > Issue Type: Sub-task >Reporter: Igor Guzenko >Assignee: Igor Guzenko >Priority: Major > Fix For: 1.17.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (DRILL-7200) Update Calcite to 1.19.0 / 1.20.0
[ https://issues.apache.org/jira/browse/DRILL-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva updated DRILL-7200: Summary: Update Calcite to 1.19.0 / 1.20.0 (was: Update Calcite to 1.19.0) > Update Calcite to 1.19.0 / 1.20.0 > - > > Key: DRILL-7200 > URL: https://issues.apache.org/jira/browse/DRILL-7200 > Project: Apache Drill > Issue Type: Task >Affects Versions: 1.16.0 >Reporter: Bohdan Kazydub >Assignee: Bohdan Kazydub >Priority: Major > Fix For: 1.17.0 > > > Calcite has released the 1.19.0 version. Upgrade Calcite dependency in Drill > to the newest version. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (DRILL-7268) Read Hive array with parquet native reader
[ https://issues.apache.org/jira/browse/DRILL-7268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Guzenko updated DRILL-7268: Description: When Hive stores array data in parquet format, it creates schema for such columns, like: arr_n_0 ARRAY {code} optional group arr_n_0 (LIST) { repeated group bag { optional int32 array_element; } } {code} Sample result before the changes was: {code}\{"bag":[{"array_element":1},\{"array_element":2}]} \{code} After the changes Drill reads only array elements data without additional keys like "bag" or "array_element": {code} [1,2] \{code} . Please read Design Doc linked to parent task for more details. > Read Hive array with parquet native reader > -- > > Key: DRILL-7268 > URL: https://issues.apache.org/jira/browse/DRILL-7268 > Project: Apache Drill > Issue Type: Sub-task >Reporter: Igor Guzenko >Assignee: Igor Guzenko >Priority: Major > Labels: ready-to-commit > Fix For: 1.17.0 > > > When Hive stores array data in parquet format, it creates schema for such > columns, like: > arr_n_0 ARRAY > {code} > optional group arr_n_0 (LIST) { > repeated group bag { > optional int32 array_element; > } > } > {code} > Sample result before the changes was: > {code}\{"bag":[{"array_element":1},\{"array_element":2}]} \{code} > After the changes Drill reads only array elements data without additional > keys like "bag" or "array_element": > {code} [1,2] \{code} . > > Please read Design Doc linked to parent task for more details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (DRILL-7268) Read Hive array with parquet native reader
[ https://issues.apache.org/jira/browse/DRILL-7268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Guzenko updated DRILL-7268: Description: When Hive stores array data in parquet format, it creates schema for such columns, like: arr_n_0 ARRAY {code:java} optional group arr_n_0 (LIST) { repeated group bag { optional int32 array_element; } } {code} Sample result before the changes was: {code:java} {"bag":[{"array_element":1},\{"array_element":2}]} {code} After the changes Drill reads only array elements data without additional keys like "bag" or "array_element": {code}[1,2] \{code} . Please read Design Doc linked to parent task for more details. was: When Hive stores array data in parquet format, it creates schema for such columns, like: arr_n_0 ARRAY {code} optional group arr_n_0 (LIST) { repeated group bag { optional int32 array_element; } } {code} Sample result before the changes was: {code}\{"bag":[{"array_element":1},\{"array_element":2}]} \{code} After the changes Drill reads only array elements data without additional keys like "bag" or "array_element": {code} [1,2] \{code} . Please read Design Doc linked to parent task for more details. > Read Hive array with parquet native reader > -- > > Key: DRILL-7268 > URL: https://issues.apache.org/jira/browse/DRILL-7268 > Project: Apache Drill > Issue Type: Sub-task >Reporter: Igor Guzenko >Assignee: Igor Guzenko >Priority: Major > Labels: ready-to-commit > Fix For: 1.17.0 > > > When Hive stores array data in parquet format, it creates schema for such > columns, like: > arr_n_0 ARRAY > {code:java} > optional group arr_n_0 (LIST) { > repeated group bag { > optional int32 array_element; > } > } > {code} > Sample result before the changes was: > {code:java} > {"bag":[{"array_element":1},\{"array_element":2}]} > {code} > After the changes Drill reads only array elements data without additional > keys like "bag" or "array_element": > {code}[1,2] \{code} . > > Please read Design Doc linked to parent task for more details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (DRILL-7268) Read Hive array with parquet native reader
[ https://issues.apache.org/jira/browse/DRILL-7268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Guzenko updated DRILL-7268: Description: When Hive stores array data in parquet format, it creates schema for such columns, like: arr_n_0 ARRAY {code:java} optional group arr_n_0 (LIST) { repeated group bag { optional int32 array_element; } } {code} Sample result before the changes was: {code:java} {"bag":[{"array_element":1},{"array_element":2}]} {code} After the changes Drill reads only array elements data without additional keys like "bag" or "array_element": {code:java} [1,2]{code} Please read Design Doc linked to parent task for more details. was: When Hive stores array data in parquet format, it creates schema for such columns, like: arr_n_0 ARRAY {code:java} optional group arr_n_0 (LIST) { repeated group bag { optional int32 array_element; } } {code} Sample result before the changes was: {code:java} {"bag":[{"array_element":1},\{"array_element":2}]} {code} After the changes Drill reads only array elements data without additional keys like "bag" or "array_element": {code}[1,2] \{code} . Please read Design Doc linked to parent task for more details. > Read Hive array with parquet native reader > -- > > Key: DRILL-7268 > URL: https://issues.apache.org/jira/browse/DRILL-7268 > Project: Apache Drill > Issue Type: Sub-task >Reporter: Igor Guzenko >Assignee: Igor Guzenko >Priority: Major > Labels: ready-to-commit > Fix For: 1.17.0 > > > When Hive stores array data in parquet format, it creates schema for such > columns, like: > arr_n_0 ARRAY > {code:java} > optional group arr_n_0 (LIST) { >repeated group bag { > optional int32 array_element; >} > } > {code} > Sample result before the changes was: > {code:java} > {"bag":[{"array_element":1},{"array_element":2}]} > {code} > After the changes Drill reads only array elements data without additional > keys like "bag" or "array_element": > {code:java} > [1,2]{code} > > > Please read Design Doc linked to parent task for more details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (DRILL-6711) Publish Drill Calcite project artifacts to Apache maven repository
[ https://issues.apache.org/jira/browse/DRILL-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volodymyr Vysotskyi reopened DRILL-6711: Reopened due to discussion in [https://lists.apache.org/thread.html/7a05ad9031f1f3155d0ff0701091efdb079ee328ef0299d80fd6f140@%3Cdev.drill.apache.org%3E] > Publish Drill Calcite project artifacts to Apache maven repository > --- > > Key: DRILL-6711 > URL: https://issues.apache.org/jira/browse/DRILL-6711 > Project: Apache Drill > Issue Type: Task >Reporter: Arina Ielchiieva >Assignee: Volodymyr Vysotskyi >Priority: Major > > Publish Drill Calcite project artifacts to Apache maven repository instead of > a proprietary one. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (DRILL-6711) Publish Drill Calcite project artifacts to Apache maven repository
[ https://issues.apache.org/jira/browse/DRILL-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volodymyr Vysotskyi updated DRILL-6711: --- Fix Version/s: 1.17.0 > Publish Drill Calcite project artifacts to Apache maven repository > --- > > Key: DRILL-6711 > URL: https://issues.apache.org/jira/browse/DRILL-6711 > Project: Apache Drill > Issue Type: Task >Reporter: Arina Ielchiieva >Assignee: Volodymyr Vysotskyi >Priority: Major > Fix For: 1.17.0 > > > Publish Drill Calcite project artifacts to Apache maven repository instead of > a proprietary one. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (DRILL-6711) Use jitpack repository for Drill Calcite project artifacts instead of repository.mapr.com
[ https://issues.apache.org/jira/browse/DRILL-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volodymyr Vysotskyi updated DRILL-6711: --- Summary: Use jitpack repository for Drill Calcite project artifacts instead of repository.mapr.com (was: Publish Drill Calcite project artifacts to Apache maven repository ) > Use jitpack repository for Drill Calcite project artifacts instead of > repository.mapr.com > - > > Key: DRILL-6711 > URL: https://issues.apache.org/jira/browse/DRILL-6711 > Project: Apache Drill > Issue Type: Task >Reporter: Arina Ielchiieva >Assignee: Volodymyr Vysotskyi >Priority: Major > Fix For: 1.17.0 > > > Publish Drill Calcite project artifacts to Apache maven repository instead of > a proprietary one. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (DRILL-6711) Use jitpack repository for Drill Calcite project artifacts instead of repository.mapr.com
[ https://issues.apache.org/jira/browse/DRILL-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volodymyr Vysotskyi updated DRILL-6711: --- Description: Simplify deployment of Drill Calcite project artifacts by using [https://jitpack.io/]. (was: Publish Drill Calcite project artifacts to Apache maven repository instead of a proprietary one.) > Use jitpack repository for Drill Calcite project artifacts instead of > repository.mapr.com > - > > Key: DRILL-6711 > URL: https://issues.apache.org/jira/browse/DRILL-6711 > Project: Apache Drill > Issue Type: Task >Reporter: Arina Ielchiieva >Assignee: Volodymyr Vysotskyi >Priority: Major > Fix For: 1.17.0 > > > Simplify deployment of Drill Calcite project artifacts by using > [https://jitpack.io/]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6711) Use jitpack repository for Drill Calcite project artifacts instead of repository.mapr.com
[ https://issues.apache.org/jira/browse/DRILL-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873196#comment-16873196 ] ASF GitHub Bot commented on DRILL-6711: --- vvysotskyi commented on pull request #1815: DRILL-6711: Use jitpack repository for Drill Calcite project artifacts instead of repository.mapr.com URL: https://github.com/apache/drill/pull/1815 For details please see [DRILL-6711](https://issues.apache.org/jira/browse/DRILL-6711). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use jitpack repository for Drill Calcite project artifacts instead of > repository.mapr.com > - > > Key: DRILL-6711 > URL: https://issues.apache.org/jira/browse/DRILL-6711 > Project: Apache Drill > Issue Type: Task >Reporter: Arina Ielchiieva >Assignee: Volodymyr Vysotskyi >Priority: Major > Fix For: 1.17.0 > > > Simplify deployment of Drill Calcite project artifacts by using > [https://jitpack.io/]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (DRILL-6711) Use jitpack repository for Drill Calcite project artifacts instead of repository.mapr.com
[ https://issues.apache.org/jira/browse/DRILL-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volodymyr Vysotskyi updated DRILL-6711: --- Reviewer: Arina Ielchiieva > Use jitpack repository for Drill Calcite project artifacts instead of > repository.mapr.com > - > > Key: DRILL-6711 > URL: https://issues.apache.org/jira/browse/DRILL-6711 > Project: Apache Drill > Issue Type: Task >Reporter: Arina Ielchiieva >Assignee: Volodymyr Vysotskyi >Priority: Major > Fix For: 1.17.0 > > > Simplify deployment of Drill Calcite project artifacts by using > [https://jitpack.io/]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6711) Use jitpack repository for Drill Calcite project artifacts instead of repository.mapr.com
[ https://issues.apache.org/jira/browse/DRILL-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873224#comment-16873224 ] ASF GitHub Bot commented on DRILL-6711: --- arina-ielchiieva commented on pull request #1815: DRILL-6711: Use jitpack repository for Drill Calcite project artifacts instead of repository.mapr.com URL: https://github.com/apache/drill/pull/1815#discussion_r297602798 ## File path: docs/dev/Calcite.md ## @@ -0,0 +1,26 @@ +# Drill-specific commits in Apache Calcite + +Currently, Drill uses Apache Calcite with additional changes, required for Drill. All the commits were left after +update from Calcite `1.4.0` to Calcite `1.15.0` and weren't merged to the Calcite's master yet. + +List of Jiras with Drill-specific commits: + +|Jira|Summary|The reason why it wasn't merged| +||---|---| +|[CALCITE-2018](https://issues.apache.org/jira/browse/CALCITE-2018)|Queries failed with AssertionError: rel has lower cost than best cost of subset|Pull request with the fix was created ([PR-552](https://github.com/apache/calcite/pull/552)), but an issue which blocks it was found and wasn't resolved yet: [CALCITE-2166](https://issues.apache.org/jira/browse/CALCITE-2166).| +|[CALCITE-2087](https://issues.apache.org/jira/browse/CALCITE-2087)|Add new method to ViewExpander interface to allow passing SchemaPlus.|Pull request into Apache Calcite was created, but it was declined. See conversation in Jira.| +|[CALCITE-1178](https://issues.apache.org/jira/browse/CALCITE-1178)|Allow SqlBetweenOperator to compare DATE and TIMESTAMP|SQL spec does not allow to compare datetime types if they have different s. Therefore Calcite community won’t accept these changes. Similar issues were reported in [CALCITE-2829](https://issues.apache.org/jira/browse/CALCITE-2829) and in [CALCITE-2745](https://issues.apache.org/jira/browse/CALCITE-2745)| + +# Drill-Calcite repository + +Repository with source code is placed [here](https://github.com/vvysotskyi/drill-calcite). For backward +compatibility, some previously used by Drill branches were pushed to this repo. Review comment: ```suggestion compatibility, a couple of previous Drill Calcite branches were pushed into this repo. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use jitpack repository for Drill Calcite project artifacts instead of > repository.mapr.com > - > > Key: DRILL-6711 > URL: https://issues.apache.org/jira/browse/DRILL-6711 > Project: Apache Drill > Issue Type: Task >Reporter: Arina Ielchiieva >Assignee: Volodymyr Vysotskyi >Priority: Major > Fix For: 1.17.0 > > > Simplify deployment of Drill Calcite project artifacts by using > [https://jitpack.io/]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6711) Use jitpack repository for Drill Calcite project artifacts instead of repository.mapr.com
[ https://issues.apache.org/jira/browse/DRILL-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873217#comment-16873217 ] ASF GitHub Bot commented on DRILL-6711: --- arina-ielchiieva commented on pull request #1815: DRILL-6711: Use jitpack repository for Drill Calcite project artifacts instead of repository.mapr.com URL: https://github.com/apache/drill/pull/1815#discussion_r297602056 ## File path: docs/dev/Calcite.md ## @@ -0,0 +1,26 @@ +# Drill-specific commits in Apache Calcite + +Currently, Drill uses Apache Calcite with additional changes, required for Drill. All the commits were left after +update from Calcite `1.4.0` to Calcite `1.15.0` and weren't merged to the Calcite's master yet. + +List of Jiras with Drill-specific commits: + +|Jira|Summary|The reason why it wasn't merged| +||---|---| +|[CALCITE-2018](https://issues.apache.org/jira/browse/CALCITE-2018)|Queries failed with AssertionError: rel has lower cost than best cost of subset|Pull request with the fix was created ([PR-552](https://github.com/apache/calcite/pull/552)), but an issue which blocks it was found and wasn't resolved yet: [CALCITE-2166](https://issues.apache.org/jira/browse/CALCITE-2166).| Review comment: ```suggestion |[CALCITE-2018](https://issues.apache.org/jira/browse/CALCITE-2018)|Queries failed with AssertionError: rel has lower cost than best cost of subset|Pull request with the fix was created ([PR-552](https://github.com/apache/calcite/pull/552)), but [CALCITE-2166](https://issues.apache.org/jira/browse/CALCITE-2166) which blocks it was found and is not resolved yet.| ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use jitpack repository for Drill Calcite project artifacts instead of > repository.mapr.com > - > > Key: DRILL-6711 > URL: https://issues.apache.org/jira/browse/DRILL-6711 > Project: Apache Drill > Issue Type: Task >Reporter: Arina Ielchiieva >Assignee: Volodymyr Vysotskyi >Priority: Major > Fix For: 1.17.0 > > > Simplify deployment of Drill Calcite project artifacts by using > [https://jitpack.io/]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6711) Use jitpack repository for Drill Calcite project artifacts instead of repository.mapr.com
[ https://issues.apache.org/jira/browse/DRILL-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873215#comment-16873215 ] ASF GitHub Bot commented on DRILL-6711: --- arina-ielchiieva commented on pull request #1815: DRILL-6711: Use jitpack repository for Drill Calcite project artifacts instead of repository.mapr.com URL: https://github.com/apache/drill/pull/1815#discussion_r297604863 ## File path: docs/dev/Calcite.md ## @@ -0,0 +1,26 @@ +# Drill-specific commits in Apache Calcite + +Currently, Drill uses Apache Calcite with additional changes, required for Drill. All the commits were left after +update from Calcite `1.4.0` to Calcite `1.15.0` and weren't merged to the Calcite's master yet. + +List of Jiras with Drill-specific commits: + +|Jira|Summary|The reason why it wasn't merged| +||---|---| +|[CALCITE-2018](https://issues.apache.org/jira/browse/CALCITE-2018)|Queries failed with AssertionError: rel has lower cost than best cost of subset|Pull request with the fix was created ([PR-552](https://github.com/apache/calcite/pull/552)), but an issue which blocks it was found and wasn't resolved yet: [CALCITE-2166](https://issues.apache.org/jira/browse/CALCITE-2166).| +|[CALCITE-2087](https://issues.apache.org/jira/browse/CALCITE-2087)|Add new method to ViewExpander interface to allow passing SchemaPlus.|Pull request into Apache Calcite was created, but it was declined. See conversation in Jira.| +|[CALCITE-1178](https://issues.apache.org/jira/browse/CALCITE-1178)|Allow SqlBetweenOperator to compare DATE and TIMESTAMP|SQL spec does not allow to compare datetime types if they have different s. Therefore Calcite community won’t accept these changes. Similar issues were reported in [CALCITE-2829](https://issues.apache.org/jira/browse/CALCITE-2829) and in [CALCITE-2745](https://issues.apache.org/jira/browse/CALCITE-2745)| + +# Drill-Calcite repository + +Repository with source code is placed [here](https://github.com/vvysotskyi/drill-calcite). For backward +compatibility, some previously used by Drill branches were pushed to this repo. + +For the case when committer should be provided with required rights, please notify repository owner about that. Review comment: ```suggestion Drill committers who need write permissions to the repository, should notify its owner. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use jitpack repository for Drill Calcite project artifacts instead of > repository.mapr.com > - > > Key: DRILL-6711 > URL: https://issues.apache.org/jira/browse/DRILL-6711 > Project: Apache Drill > Issue Type: Task >Reporter: Arina Ielchiieva >Assignee: Volodymyr Vysotskyi >Priority: Major > Fix For: 1.17.0 > > > Simplify deployment of Drill Calcite project artifacts by using > [https://jitpack.io/]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6711) Use jitpack repository for Drill Calcite project artifacts instead of repository.mapr.com
[ https://issues.apache.org/jira/browse/DRILL-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873223#comment-16873223 ] ASF GitHub Bot commented on DRILL-6711: --- arina-ielchiieva commented on pull request #1815: DRILL-6711: Use jitpack repository for Drill Calcite project artifacts instead of repository.mapr.com URL: https://github.com/apache/drill/pull/1815#discussion_r297603032 ## File path: docs/dev/Calcite.md ## @@ -0,0 +1,26 @@ +# Drill-specific commits in Apache Calcite + +Currently, Drill uses Apache Calcite with additional changes, required for Drill. All the commits were left after +update from Calcite `1.4.0` to Calcite `1.15.0` and weren't merged to the Calcite's master yet. + +List of Jiras with Drill-specific commits: + +|Jira|Summary|The reason why it wasn't merged| +||---|---| +|[CALCITE-2018](https://issues.apache.org/jira/browse/CALCITE-2018)|Queries failed with AssertionError: rel has lower cost than best cost of subset|Pull request with the fix was created ([PR-552](https://github.com/apache/calcite/pull/552)), but an issue which blocks it was found and wasn't resolved yet: [CALCITE-2166](https://issues.apache.org/jira/browse/CALCITE-2166).| +|[CALCITE-2087](https://issues.apache.org/jira/browse/CALCITE-2087)|Add new method to ViewExpander interface to allow passing SchemaPlus.|Pull request into Apache Calcite was created, but it was declined. See conversation in Jira.| +|[CALCITE-1178](https://issues.apache.org/jira/browse/CALCITE-1178)|Allow SqlBetweenOperator to compare DATE and TIMESTAMP|SQL spec does not allow to compare datetime types if they have different s. Therefore Calcite community won’t accept these changes. Similar issues were reported in [CALCITE-2829](https://issues.apache.org/jira/browse/CALCITE-2829) and in [CALCITE-2745](https://issues.apache.org/jira/browse/CALCITE-2745)| + +# Drill-Calcite repository + +Repository with source code is placed [here](https://github.com/vvysotskyi/drill-calcite). For backward +compatibility, some previously used by Drill branches were pushed to this repo. + +For the case when committer should be provided with required rights, please notify repository owner about that. + +# Process of updating Calcite version + +- Push required changes to the branch, or create required a branch. *Though this repository contains Drill specific commits, it is forbidden to add additional specific commits which weren't merged to Apache Calcite master if it wasn't discussed broadly.* Review comment: ```suggestion - Push required changes to the existing branch, or create new branch. *Though this repository contains Drill specific commits, it is forbidden to add additional specific commits which were not merged to Apache Calcite master if it wasn't discussed in Drill community first.* ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use jitpack repository for Drill Calcite project artifacts instead of > repository.mapr.com > - > > Key: DRILL-6711 > URL: https://issues.apache.org/jira/browse/DRILL-6711 > Project: Apache Drill > Issue Type: Task >Reporter: Arina Ielchiieva >Assignee: Volodymyr Vysotskyi >Priority: Major > Fix For: 1.17.0 > > > Simplify deployment of Drill Calcite project artifacts by using > [https://jitpack.io/]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6711) Use jitpack repository for Drill Calcite project artifacts instead of repository.mapr.com
[ https://issues.apache.org/jira/browse/DRILL-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873220#comment-16873220 ] ASF GitHub Bot commented on DRILL-6711: --- arina-ielchiieva commented on pull request #1815: DRILL-6711: Use jitpack repository for Drill Calcite project artifacts instead of repository.mapr.com URL: https://github.com/apache/drill/pull/1815#discussion_r297602242 ## File path: docs/dev/Calcite.md ## @@ -0,0 +1,26 @@ +# Drill-specific commits in Apache Calcite + +Currently, Drill uses Apache Calcite with additional changes, required for Drill. All the commits were left after +update from Calcite `1.4.0` to Calcite `1.15.0` and weren't merged to the Calcite's master yet. + +List of Jiras with Drill-specific commits: + +|Jira|Summary|The reason why it wasn't merged| +||---|---| +|[CALCITE-2018](https://issues.apache.org/jira/browse/CALCITE-2018)|Queries failed with AssertionError: rel has lower cost than best cost of subset|Pull request with the fix was created ([PR-552](https://github.com/apache/calcite/pull/552)), but an issue which blocks it was found and wasn't resolved yet: [CALCITE-2166](https://issues.apache.org/jira/browse/CALCITE-2166).| +|[CALCITE-2087](https://issues.apache.org/jira/browse/CALCITE-2087)|Add new method to ViewExpander interface to allow passing SchemaPlus.|Pull request into Apache Calcite was created, but it was declined. See conversation in Jira.| +|[CALCITE-1178](https://issues.apache.org/jira/browse/CALCITE-1178)|Allow SqlBetweenOperator to compare DATE and TIMESTAMP|SQL spec does not allow to compare datetime types if they have different s. Therefore Calcite community won’t accept these changes. Similar issues were reported in [CALCITE-2829](https://issues.apache.org/jira/browse/CALCITE-2829) and in [CALCITE-2745](https://issues.apache.org/jira/browse/CALCITE-2745)| Review comment: ```suggestion |[CALCITE-1178](https://issues.apache.org/jira/browse/CALCITE-1178)|Allow SqlBetweenOperator to compare DATE and TIMESTAMP|SQL spec does not allow to compare datetime types if they have different s. Therefore Calcite community won’t accept these changes. Similar issues were reported in [CALCITE-2829](https://issues.apache.org/jira/browse/CALCITE-2829) and in [CALCITE-2745](https://issues.apache.org/jira/browse/CALCITE-2745).| ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use jitpack repository for Drill Calcite project artifacts instead of > repository.mapr.com > - > > Key: DRILL-6711 > URL: https://issues.apache.org/jira/browse/DRILL-6711 > Project: Apache Drill > Issue Type: Task >Reporter: Arina Ielchiieva >Assignee: Volodymyr Vysotskyi >Priority: Major > Fix For: 1.17.0 > > > Simplify deployment of Drill Calcite project artifacts by using > [https://jitpack.io/]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6711) Use jitpack repository for Drill Calcite project artifacts instead of repository.mapr.com
[ https://issues.apache.org/jira/browse/DRILL-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873221#comment-16873221 ] ASF GitHub Bot commented on DRILL-6711: --- arina-ielchiieva commented on pull request #1815: DRILL-6711: Use jitpack repository for Drill Calcite project artifacts instead of repository.mapr.com URL: https://github.com/apache/drill/pull/1815#discussion_r297601491 ## File path: docs/dev/Calcite.md ## @@ -0,0 +1,26 @@ +# Drill-specific commits in Apache Calcite + +Currently, Drill uses Apache Calcite with additional changes, required for Drill. All the commits were left after +update from Calcite `1.4.0` to Calcite `1.15.0` and weren't merged to the Calcite's master yet. Review comment: ```suggestion update from Calcite `1.4.0` to Calcite `1.15.0` and weren't merged to the Calcite's master yet since there is no consensus on them in Calcite community. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use jitpack repository for Drill Calcite project artifacts instead of > repository.mapr.com > - > > Key: DRILL-6711 > URL: https://issues.apache.org/jira/browse/DRILL-6711 > Project: Apache Drill > Issue Type: Task >Reporter: Arina Ielchiieva >Assignee: Volodymyr Vysotskyi >Priority: Major > Fix For: 1.17.0 > > > Simplify deployment of Drill Calcite project artifacts by using > [https://jitpack.io/]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6711) Use jitpack repository for Drill Calcite project artifacts instead of repository.mapr.com
[ https://issues.apache.org/jira/browse/DRILL-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873216#comment-16873216 ] ASF GitHub Bot commented on DRILL-6711: --- arina-ielchiieva commented on pull request #1815: DRILL-6711: Use jitpack repository for Drill Calcite project artifacts instead of repository.mapr.com URL: https://github.com/apache/drill/pull/1815#discussion_r297603409 ## File path: docs/dev/Calcite.md ## @@ -0,0 +1,26 @@ +# Drill-specific commits in Apache Calcite + +Currently, Drill uses Apache Calcite with additional changes, required for Drill. All the commits were left after +update from Calcite `1.4.0` to Calcite `1.15.0` and weren't merged to the Calcite's master yet. + +List of Jiras with Drill-specific commits: + +|Jira|Summary|The reason why it wasn't merged| +||---|---| +|[CALCITE-2018](https://issues.apache.org/jira/browse/CALCITE-2018)|Queries failed with AssertionError: rel has lower cost than best cost of subset|Pull request with the fix was created ([PR-552](https://github.com/apache/calcite/pull/552)), but an issue which blocks it was found and wasn't resolved yet: [CALCITE-2166](https://issues.apache.org/jira/browse/CALCITE-2166).| +|[CALCITE-2087](https://issues.apache.org/jira/browse/CALCITE-2087)|Add new method to ViewExpander interface to allow passing SchemaPlus.|Pull request into Apache Calcite was created, but it was declined. See conversation in Jira.| +|[CALCITE-1178](https://issues.apache.org/jira/browse/CALCITE-1178)|Allow SqlBetweenOperator to compare DATE and TIMESTAMP|SQL spec does not allow to compare datetime types if they have different s. Therefore Calcite community won’t accept these changes. Similar issues were reported in [CALCITE-2829](https://issues.apache.org/jira/browse/CALCITE-2829) and in [CALCITE-2745](https://issues.apache.org/jira/browse/CALCITE-2745)| + +# Drill-Calcite repository + +Repository with source code is placed [here](https://github.com/vvysotskyi/drill-calcite). For backward +compatibility, some previously used by Drill branches were pushed to this repo. + +For the case when committer should be provided with required rights, please notify repository owner about that. + +# Process of updating Calcite version + +- Push required changes to the branch, or create required a branch. *Though this repository contains Drill specific commits, it is forbidden to add additional specific commits which weren't merged to Apache Calcite master if it wasn't discussed broadly.* +- The last commit should be a commit with updating the version number. +- Create and push tag for commit with a version update. Tag name should match the version, for example, `1.18.0-drill-r2`. Review comment: ```suggestion - Create and push tag for commit with the version update. Tag name should match the version, for example, `1.18.0-drill-r0`, `1.18.0-drill-r1`, `1.18.0-drill-r2` and so on. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use jitpack repository for Drill Calcite project artifacts instead of > repository.mapr.com > - > > Key: DRILL-6711 > URL: https://issues.apache.org/jira/browse/DRILL-6711 > Project: Apache Drill > Issue Type: Task >Reporter: Arina Ielchiieva >Assignee: Volodymyr Vysotskyi >Priority: Major > Fix For: 1.17.0 > > > Simplify deployment of Drill Calcite project artifacts by using > [https://jitpack.io/]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6711) Use jitpack repository for Drill Calcite project artifacts instead of repository.mapr.com
[ https://issues.apache.org/jira/browse/DRILL-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873222#comment-16873222 ] ASF GitHub Bot commented on DRILL-6711: --- arina-ielchiieva commented on pull request #1815: DRILL-6711: Use jitpack repository for Drill Calcite project artifacts instead of repository.mapr.com URL: https://github.com/apache/drill/pull/1815#discussion_r297603821 ## File path: docs/dev/Calcite.md ## @@ -0,0 +1,26 @@ +# Drill-specific commits in Apache Calcite + +Currently, Drill uses Apache Calcite with additional changes, required for Drill. All the commits were left after +update from Calcite `1.4.0` to Calcite `1.15.0` and weren't merged to the Calcite's master yet. + +List of Jiras with Drill-specific commits: + +|Jira|Summary|The reason why it wasn't merged| +||---|---| +|[CALCITE-2018](https://issues.apache.org/jira/browse/CALCITE-2018)|Queries failed with AssertionError: rel has lower cost than best cost of subset|Pull request with the fix was created ([PR-552](https://github.com/apache/calcite/pull/552)), but an issue which blocks it was found and wasn't resolved yet: [CALCITE-2166](https://issues.apache.org/jira/browse/CALCITE-2166).| +|[CALCITE-2087](https://issues.apache.org/jira/browse/CALCITE-2087)|Add new method to ViewExpander interface to allow passing SchemaPlus.|Pull request into Apache Calcite was created, but it was declined. See conversation in Jira.| +|[CALCITE-1178](https://issues.apache.org/jira/browse/CALCITE-1178)|Allow SqlBetweenOperator to compare DATE and TIMESTAMP|SQL spec does not allow to compare datetime types if they have different s. Therefore Calcite community won’t accept these changes. Similar issues were reported in [CALCITE-2829](https://issues.apache.org/jira/browse/CALCITE-2829) and in [CALCITE-2745](https://issues.apache.org/jira/browse/CALCITE-2745)| + +# Drill-Calcite repository + +Repository with source code is placed [here](https://github.com/vvysotskyi/drill-calcite). For backward +compatibility, some previously used by Drill branches were pushed to this repo. + +For the case when committer should be provided with required rights, please notify repository owner about that. + +# Process of updating Calcite version + +- Push required changes to the branch, or create required a branch. *Though this repository contains Drill specific commits, it is forbidden to add additional specific commits which weren't merged to Apache Calcite master if it wasn't discussed broadly.* +- The last commit should be a commit with updating the version number. +- Create and push tag for commit with a version update. Tag name should match the version, for example, `1.18.0-drill-r2`. +- Bump-up Calcite version in Drill. Review comment: ```suggestion - Bump-up Drill Calcite version in Drill pom.xml file. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use jitpack repository for Drill Calcite project artifacts instead of > repository.mapr.com > - > > Key: DRILL-6711 > URL: https://issues.apache.org/jira/browse/DRILL-6711 > Project: Apache Drill > Issue Type: Task >Reporter: Arina Ielchiieva >Assignee: Volodymyr Vysotskyi >Priority: Major > Fix For: 1.17.0 > > > Simplify deployment of Drill Calcite project artifacts by using > [https://jitpack.io/]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6711) Use jitpack repository for Drill Calcite project artifacts instead of repository.mapr.com
[ https://issues.apache.org/jira/browse/DRILL-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873218#comment-16873218 ] ASF GitHub Bot commented on DRILL-6711: --- arina-ielchiieva commented on pull request #1815: DRILL-6711: Use jitpack repository for Drill Calcite project artifacts instead of repository.mapr.com URL: https://github.com/apache/drill/pull/1815#discussion_r297603198 ## File path: docs/dev/Calcite.md ## @@ -0,0 +1,26 @@ +# Drill-specific commits in Apache Calcite + +Currently, Drill uses Apache Calcite with additional changes, required for Drill. All the commits were left after +update from Calcite `1.4.0` to Calcite `1.15.0` and weren't merged to the Calcite's master yet. + +List of Jiras with Drill-specific commits: + +|Jira|Summary|The reason why it wasn't merged| +||---|---| +|[CALCITE-2018](https://issues.apache.org/jira/browse/CALCITE-2018)|Queries failed with AssertionError: rel has lower cost than best cost of subset|Pull request with the fix was created ([PR-552](https://github.com/apache/calcite/pull/552)), but an issue which blocks it was found and wasn't resolved yet: [CALCITE-2166](https://issues.apache.org/jira/browse/CALCITE-2166).| +|[CALCITE-2087](https://issues.apache.org/jira/browse/CALCITE-2087)|Add new method to ViewExpander interface to allow passing SchemaPlus.|Pull request into Apache Calcite was created, but it was declined. See conversation in Jira.| +|[CALCITE-1178](https://issues.apache.org/jira/browse/CALCITE-1178)|Allow SqlBetweenOperator to compare DATE and TIMESTAMP|SQL spec does not allow to compare datetime types if they have different s. Therefore Calcite community won’t accept these changes. Similar issues were reported in [CALCITE-2829](https://issues.apache.org/jira/browse/CALCITE-2829) and in [CALCITE-2745](https://issues.apache.org/jira/browse/CALCITE-2745)| + +# Drill-Calcite repository + +Repository with source code is placed [here](https://github.com/vvysotskyi/drill-calcite). For backward +compatibility, some previously used by Drill branches were pushed to this repo. + +For the case when committer should be provided with required rights, please notify repository owner about that. + +# Process of updating Calcite version + +- Push required changes to the branch, or create required a branch. *Though this repository contains Drill specific commits, it is forbidden to add additional specific commits which weren't merged to Apache Calcite master if it wasn't discussed broadly.* +- The last commit should be a commit with updating the version number. Review comment: ```suggestion - The last commit must be a commit which updates the version number. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use jitpack repository for Drill Calcite project artifacts instead of > repository.mapr.com > - > > Key: DRILL-6711 > URL: https://issues.apache.org/jira/browse/DRILL-6711 > Project: Apache Drill > Issue Type: Task >Reporter: Arina Ielchiieva >Assignee: Volodymyr Vysotskyi >Priority: Major > Fix For: 1.17.0 > > > Simplify deployment of Drill Calcite project artifacts by using > [https://jitpack.io/]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-7293) Convert the regex ("log") plugin to use EVF
[ https://issues.apache.org/jira/browse/DRILL-7293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873852#comment-16873852 ] ASF GitHub Bot commented on DRILL-7293: --- paul-rogers commented on issue #1807: DRILL-7293: Convert the regex ("log") plugin to use EVF URL: https://github.com/apache/drill/pull/1807#issuecomment-506209593 @arina-ielchiieva, added a unit test to show that the schema-only table function works. Tried to create a test that combined a "plugin" table function with the "schema" attribute. This failed due to the unfortunate use of "schema" as plugin property name. You've pointed out this issue all along, I finally understood why it was a problem. Still, I'm reluctant to change the config property name for fear of breaking compatibility. As it turns out, this limitation is only a minor nuisance since the only reason to combine the two kinds of table functions is to specify the regex property. A unit test shows that the regex can be specified as a table property instead. Also, went ahead and added support for the `columns` column. If no schema is provided (not in the plugin config, not in a table function, not in a provided schema), then rather than creating a set of dummy fields `field_0`, `field_1`, etc., the plugin how follows the text format plugin and puts the fields into the `columns` array. The dummy fields are still used if the user specifies at least one column schema, but the regex has more groups than specified columns. This means that, if the user uses a table function to specify just the regex, the user gets a reasonable result: the fields come back in the `columns` array. Unit tests show the new `columns` array support. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Convert the regex ("log") plugin to use EVF > --- > > Key: DRILL-7293 > URL: https://issues.apache.org/jira/browse/DRILL-7293 > Project: Apache Drill > Issue Type: Improvement >Affects Versions: 1.16.0 >Reporter: Paul Rogers >Assignee: Paul Rogers >Priority: Major > Fix For: 1.17.0 > > > The "log" plugin (which uses a regex to define the row format) is the subject > of Chapter 12 of the Learning Apache Drill book (though the version in the > book is simpler than the one in the master branch.) > The recently-completed "Enhanced Vector Framework" (EVF, AKA the "row set > framework") gives Drill control over the size of batches created by readers, > and allows readers to use the recently-added provided schema mechanism. > We wish to use the log reader as an example for how to convert a Drill format > plugin to use the EVF so that other developers can convert their own plugins. > This PR provides the first set of log plugin changes to enable us to publish > a tutorial on the EVF. -- This message was sent by Atlassian JIRA (v7.6.3#76005)