[jira] [Commented] (DRILL-7529) Building depends on poorly configured uncommon maven repositories

2020-01-17 Thread Arina Ielchiieva (Jira)


[ 
https://issues.apache.org/jira/browse/DRILL-7529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018194#comment-17018194
 ] 

Arina Ielchiieva commented on DRILL-7529:
-

https://github.com/vvysotskyi/drill-calcite/wiki contains description why Drill 
needs to maintain its own Calcite fork.

> Building depends on poorly configured uncommon maven repositories
> -
>
> Key: DRILL-7529
> URL: https://issues.apache.org/jira/browse/DRILL-7529
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Tools, Build  Test
>Affects Versions: 1.17.0
>Reporter: Niels Basjes
>Priority: Blocker
>
> *Summary: Apache Drill depends on modified copies of open software that is 
> hosted on non-standard (company owned) maven repositories. In addition due to 
> poor security configuration maven simply refuses to download the artifacts 
> from one of those.* 
> That is why I tagged this a blocker.
>  
> I have an open source project where I include a Drill UDF so other can use 
> this in Drill. ( [https://yauaa.basjes.nl/UDF-ApacheDrill.html] ).
> Today I tried to update the drill dependency from 1.16 to 1.17
> Resulting in 
> {{[ERROR] Failed to execute goal on project yauaa-drill: Could not resolve 
> dependencies for project 
> nl.basjes.parse.useragent:yauaa-drill:jar:5.15-SNAPSHOT: The following 
> artifacts could not be resolved: 
> com.github.vvysotskyi.drill-calcite:calcite-core:jar:1.20.0-drill-r2, 
> org.kohsuke:libpam4j:jar:1.8-rev2: Failure to find 
> com.github.vvysotskyi.drill-calcite:calcite-core:jar:1.20.0-drill-r2 in 
> https://oss.sonatype.org/content/repositories/snapshots/ was cached in the 
> local repository, resolution will not be reattempted until the update 
> interval of Sonatype snapshots has elapsed or updates are forced -> [Help 1]}}
> Turns out that 
> {{com.github.vvysotskyi.drill-calcite:calcite-core:jar:1.20.0-drill-r2}} is 
> (most likely) based here [https://github.com/vvysotskyi/drill-calcite/]
> Apparently this is a patched version of Calcite that is hosted under a 
> personal account but IS an important dependency of a released version of 
> Drill. (Side question: Why not simply improve calcite with these changes?)
> It took some digging and I found this one on this non standard maven 
> repository operated by a commercial company:
> [https://repository.mulesoft.org/nexus/content/repositories/public/]
>  
> The second dependency it failed over was even worse. 
>  {{org.kohsuke:libpam4j:jar:1.8-rev2}}
> This project IS present in maven central but NOT this specific version.
> [https://search.maven.org/artifact/org.kohsuke/libpam4j]
> The only place I have found this is here
> [https://repository.mapr.com/nexus/content/groups/mapr-public/]
> I did not encounter the sourcecode "github" for this modified version yet.
> So effectively I was forced to include two "company" repos in my project to 
> get it to build ... so you would think.
>  
> With these two in my pom.xml I got a new error which was much more 
> disturbing...
> {{[ERROR] Failed to execute goal on project yauaa-drill: Could not resolve 
> dependencies for project 
> nl.basjes.parse.useragent:yauaa-drill:jar:5.15-SNAPSHOT: Failed to collect 
> dependencies at org.apache.drill.exec:drill-java-exec:jar:1.17.0 -> 
> org.kohsuke:libpam4j:jar:1.8-rev2: Failed to read artifact descriptor for 
> org.kohsuke:libpam4j:jar:1.8-rev2: Could not transfer artifact 
> org.kohsuke:libpam4j:pom:1.8-rev2 from/to MapR 
> (https://repository.mapr.com/nexus/content/groups/mapr-public/): 
> sun.security.validator.ValidatorException: PKIX path building failed: 
> sun.security.provider.certpath.SunCertPathBuilderException: unable to find 
> valid certification path to requested target -> [Help 1]}}
> This error essentially means: Maven does not trust the certificate path of 
> the provided HTTPS so it refused to download the artifact.
> Why? This MapR site uses a wildcard certificate issues by GoDaddy.
> Apparently this is a "well known" problem with these GoDaddy certificates: 
> [https://tozny.com/blog/godaddys-ssl-certs-dont-work-in-java-the-right-solution/]
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (DRILL-7467) Jdbc plugin enhancements and fixes

2020-01-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DRILL-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018167#comment-17018167
 ] 

ASF GitHub Bot commented on DRILL-7467:
---

arina-ielchiieva commented on pull request #1956: DRILL-7467: Jdbc plugin 
enhancements and fixes
URL: https://github.com/apache/drill/pull/1956
 
 
   [DRILL-7467](https://issues.apache.org/jira/browse/DRILL-7467): Jdbc plugin 
enhancements and fixes
   
   ## Description
   
   1. Added logic to close data source when plugin is closed.
   2. Added disabled jdbc plugin template to the bootstrap storage plugins.
   3. Added new jdbc storage plugin configuration property sourceParameters 
which would allow setting data source parameters described in BasicDataSource 
Configuration Parameters.
   4. Upgraded commons-dbcp2 version and added it to the dependency management 
section in common pom.xml.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Jdbc plugin enhancements and fixes
> --
>
> Key: DRILL-7467
> URL: https://issues.apache.org/jira/browse/DRILL-7467
> Project: Apache Drill
>  Issue Type: Improvement
>  Components: Storage - JDBC
>Affects Versions: 1.17.0
>Reporter: Priyanka Bhoir
>Assignee: Arina Ielchiieva
>Priority: Major
> Fix For: 1.18.0
>
>
> This Jira incorporates several JDBC plugin enhancements and fixes:
> 1. Drill does not close DB connection when JDBC storage plugin is disabled: 
> JdbcStoragePlugin does not implement the 'close' method, leaving all 
> connections open even after the plugin is disabled. This could be monitored 
> through 'lsof' command. Restarting a JDBC plugin adds to existing connections 
> and Drill restart is required to release all TCP connections.
> 2.  Add disabled jdbc plugin template to the boostrap storage plugins.
> 3. Add new jdbc storage plugin configuration property {{sourceParameters}} 
> which will allow setting data source parameters described in [BasicDataSource 
> Configuration 
> Parameters|https://commons.apache.org/proper/commons-dbcp/configuration.html].
>  Parameters names with incorrect naming will be ignored during plugin 
> configuration,
> parameter value which are of incorrect data type or illegal will fail storage 
> plugin to start up.
> Example: of {{sourceParameters}}  section in storage plugin configuration:
> {noformat}
>   "sourceParameters" : {
> "maxIdle" : 8,
> "cacheState": true,
> "validationQuery": "select * from information_schema.collations"
>   },
> {noformat}
> 4. Upgraded {{commons-dbcp2}} version and added it to the dependency 
> management section in common pom.xml.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (DRILL-7449) memory leak parse_url function

2020-01-17 Thread Igor Guzenko (Jira)


[ 
https://issues.apache.org/jira/browse/DRILL-7449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018156#comment-17018156
 ] 

Igor Guzenko commented on DRILL-7449:
-

Hello [~benj641], from the attached log I found that thread for fragment 3.0 
failed while closing allocator for HashPartitionSender. I quess it's something 
between second project and sort operator in your physical plan (maybe 
HashToRandomExchange...). 
{code}
2020-01-16 10:34:11,457 [21dfc400-1fab-4eca-ce7d-babb333b1ce6:frag:3:0] DEBUG 
o.a.d.exec.ops.OperatorContextImpl - Closing context for 
org.apache.drill.exec.physical.config.Project
2020-01-16 10:34:11,457 [21dfc400-1fab-4eca-ce7d-babb333b1ce6:frag:3:0] DEBUG 
o.a.d.exec.ops.OperatorContextImpl - Closing context for 
org.apache.drill.exec.physical.config.Project
2020-01-16 10:34:11,457 [21dfc400-1fab-4eca-ce7d-babb333b1ce6:frag:3:0] DEBUG 
o.a.d.exec.ops.OperatorContextImpl - Closing context for 
org.apache.drill.exec.physical.config.HashPartitionSender

2020-01-16 10:34:11,457 [21dfc400-1fab-4eca-ce7d-babb333b1ce6:frag:3:0] INFO  
o.a.d.e.w.fragment.FragmentExecutor - 21dfc400-1fab-4eca-ce7d-babb333b1ce6:3:0: 
State change requested RUNNING --> FAILED
{code}

Since I'm not an expert in Drill's custom memory management (aka 
BufferAllocator and related things) I won't guarantee that I'll fix the issue 
in a short time without repro on my machine.  I hope I'll have some time to 
spend on the issue and find potential reasons causing the problem. 

> memory leak parse_url function
> --
>
> Key: DRILL-7449
> URL: https://issues.apache.org/jira/browse/DRILL-7449
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Functions - Drill
>Affects Versions: 1.16.0
>Reporter: benj
>Assignee: Igor Guzenko
>Priority: Major
> Attachments: embedded_FullJsonProfile.txt, embedded_sqlline.log.txt, 
> embedded_sqlline_with_enable_debug_logging.log.txt
>
>
> Requests with *parse_url* works well when the number of treated rows is low 
> but produce memory leak when number of rows grows (~ between 500 000 and 1 
> million) (and for certain number of row sometimes the request works and 
> sometimes it failed with memory leaks)
> Extract from dataset tested:
> {noformat}
> {"Attributable":true,"Description":"Website has been identified as malicious 
> by 
> Bing","FirstReportedDateTime":"2018-03-12T18:49:38Z","IndicatorExpirationDateTime":"2018-04-11T23:33:13Z","IndicatorProvider":"Bing","IndicatorThreatType":"MaliciousUrl","IsPartnerShareable":true,"IsProductLicensed":true,"LastReportedDateTime":"2018-03-12T18:49:38Z","NetworkDestinationAsn":15169,"NetworkDestinationIPv4":"172.217.8.193","NetworkDestinationPort":80,"Tags":["us"],"ThreatDetectionProduct":"ES","TLPLevel":"Amber","Url":"http://pasuruanbloggers.blogspot.ru/2012/12/beginilah-cara-orang-jepang-berpacaran.html","Version":1.5}
> {"Attributable":true,"Description":"Website has been identified as malicious 
> by 
> Bing","FirstReportedDateTime":"2018-03-12T18:14:51Z","IndicatorExpirationDateTime":"2018-04-11T23:33:13Z","IndicatorProvider":"Bing","IndicatorThreatType":"MaliciousUrl","IsPartnerShareable":true,"IsProductLicensed":true,"LastReportedDateTime":"2018-03-12T18:14:51Z","NetworkDestinationAsn":15169,"NetworkDestinationIPv4":"216.58.192.193","NetworkDestinationPort":80,"Tags":["us"],"ThreatDetectionProduct":"ES","TLPLevel":"Amber","Url":"http://pasuruanbloggers.blogspot.ru/2012/12/cara-membuat-widget-slideshow-postingan.html","Version":1.5}
> {noformat}
> Request tested:
> {code:sql}
> ALTER SESSION SET `store.format`='parquet';
> ALTER SESSION SET `store.parquet.use_new_reader` = true;
> ALTER SESSION SET `store.parquet.compression` = 'snappy';
> ALTER SESSION SET `drill.exec.functions.cast_empty_string_to_null`= true;
> ALTER SESSION SET `store.json.all_text_mode` = true;
> ALTER SESSION SET `exec.enable_union_type` = true;
> ALTER SESSION SET `store.json.all_text_mode` = true;
> CREATE TABLE dfs.test.`output_pqt` AS
> (
> SELECT R.parsed.host AS Domain
> FROM ( 
>   SELECT parse_url(T.Url) AS parsed
>   FROM dfs.test.`file.json` AS T
> ) AS R 
> ORDER BY Domain
> );
> {code}
>  
>  Result when memory leak:
> {noformat}
> Error: SYSTEM ERROR: IllegalStateException: Memory was leaked by query. 
> Memory leaked: (256)
> Allocator(frag:3:0) 300/256/9337280/300 (res/actual/peak/limit)
> Fragment 3:0
> Please, refer to logs for more information.
> [Error Id: 3ffa5b43-0dde-4518-bb5a-ea3aab97f3d4 on servor01:31010]
>   (java.lang.IllegalStateException) Memory was leaked by query. Memory 
> leaked: (256)
> Allocator(frag:3:0) 300/256/9337280/300 (res/actual/peak/limit)
> org.apache.drill.exec.memory.BaseAllocator.close():520
> org.apache.drill.exec.ops.FragmentContextImpl.suppressingClose():552
> 

[jira] [Updated] (DRILL-7530) Fix class names in loggers

2020-01-17 Thread Arina Ielchiieva (Jira)


 [ 
https://issues.apache.org/jira/browse/DRILL-7530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arina Ielchiieva updated DRILL-7530:

Description: 
Some loggers have incorrect class names which leads to incorrect information in 
logs.
This Jira aims to fix all occurrences of incorrect class names in loggers.

Preliminary list (some occurrences will be excluded): 
{noformat}
Name: MapRDBTableCache.java. Expected: MapRDBTableCache. Got: 
MapRDBFormatPlugin.
Name: HiveFuncHolderExpr.java. Expected: HiveFuncHolderExpr. Got: 
DrillFuncHolderExpr.
Name: HiveFuncHolder.java. Expected: HiveFuncHolder. Got: 
FunctionImplementationRegistry.
Name: HiveMetadataProvider.java. Expected: HiveMetadataProvider. Got: HiveStats.
Name: TableEntryCacheLoader.java. Expected: TableEntryCacheLoader. Got: 
TableNameCacheLoader.
Name: TestKafkaSuit.java. Expected: TestKafkaSuit. Got: LoggerFactory.
Name: DrillTestWrapper.java. Expected: DrillTestWrapper. Got: BaseTestQuery.
Name: TestDisabledFunctionality.java. Expected: TestDisabledFunctionality. Got: 
TestExampleQueries.
Name: TestMergeJoin.java. Expected: TestMergeJoin. Got: HashAggBatch.
Name: TestLateralJoinCorrectnessBatchProcessing.java. Expected: 
TestLateralJoinCorrectnessBatchProcessing. Got: TestNewLateralJoinCorrectness.
Name: TestOperatorRecordBatch.java. Expected: TestOperatorRecordBatch. Got: 
SubOperatorTest.
Name: TestPauseInjection.java. Expected: TestPauseInjection. Got: DummyClass.
Name: TestComplexTypeWriter.java. Expected: TestComplexTypeWriter. Got: 
TestComplexTypeReader.
Name: AvgIntervalTypeFunctions.java. Expected: AvgIntervalTypeFunctions. Got: 
AvgFunctions.
Name: SSLConfigBuilder.java. Expected: SSLConfigBuilder. Got: 
org.apache.drill.exec.ssl.SSLConfigBuilder.
Name: PlannerPhase.java. Expected: PlannerPhase. Got: DrillRuleSets.
Name: AbstractIndexDescriptor.java. Expected: AbstractIndexDescriptor. Got: 
AbstractIndexDescriptor .
Name: CoveringPlanNoFilterGenerator.java. Expected: 
CoveringPlanNoFilterGenerator. Got: CoveringIndexPlanGenerator.
Name: AbstractSqlSetHandler.java. Expected: AbstractSqlSetHandler. Got: 
AbstractSqlHandler.
Name: HashJoinMemoryCalculatorImpl.java. Expected: 
HashJoinMemoryCalculatorImpl. Got: BuildSidePartitioning.
Name: HashJoinMemoryCalculatorImpl.java. Expected: 
HashJoinMemoryCalculatorImpl. Got: PostBuildCalculationsImpl.
Name: HashJoinMemoryCalculator.java. Expected: HashJoinMemoryCalculator. Got: 
PartitionStatSet.
Name: NestedLoopJoinTemplate.java. Expected: NestedLoopJoinTemplate. Got: 
NestedLoopJoinBatch.
Name: PartitionLimitRecordBatch.java. Expected: PartitionLimitRecordBatch. Got: 
LimitRecordBatch.
Name: HashAggTemplate.java. Expected: HashAggTemplate. Got: HashAggregator.
Name: SpilledRecordbatch.java. Expected: SpilledRecordbatch. Got: 
SimpleRecordBatch.
Name: StreamingAggTemplate.java. Expected: StreamingAggTemplate. Got: 
StreamingAggregator.
Name: SortMemoryManager.java. Expected: SortMemoryManager. Got: 
ExternalSortBatch.
Name: SortConfig.java. Expected: SortConfig. Got: ExternalSortBatch.
Name: SortImpl.java. Expected: SortImpl. Got: ExternalSortBatch.
Name: SingleSenderCreator.java. Expected: SingleSenderCreator. Got: 
SingleSenderRootExec.
Name: HashTableTemplate.java. Expected: HashTableTemplate. Got: HashTable.
Name: FrameSupportTemplate.java. Expected: FrameSupportTemplate. Got: 
NoFrameSupportTemplate.
Name: ScreenCreator.java. Expected: ScreenCreator. Got: ScreenRoot.
Name: UnionAll.java. Expected: UnionAll. Got: Filter.
Name: AvgIntervalTypeFunctions.java. Expected: AvgIntervalTypeFunctions. Got: 
AvgFunctions.
Name: PersistedOptionValue.java. Expected: PersistedOptionValue. Got: 
Deserializer.
Name: ThreadsResources.java. Expected: ThreadsResources. Got: MetricsResources.
Name: RepeatedVarCharOutput.java. Expected: RepeatedVarCharOutput. Got: 
BaseFieldOutput.
Name: MockSubScanPOP.java. Expected: MockSubScanPOP. Got: MockGroupScanPOP.
Name: InMemoryStore.java. Expected: InMemoryStore. Got: InMemoryPersistentStore.
Name: ParquetColumnChunkPageWriteStore.java. Expected: 
ParquetColumnChunkPageWriteStore. Got: ParquetDirectByteBufferAllocator.
Name: CorrelationTypeFunctions.java. Expected: CorrelationTypeFunctions. Got: 
${aggrtype.className}Functions.
Name: MathFunctionTemplates.java. Expected: MathFunctionTemplates. Got: 
${inputType.className}Functions.
Name: CastHigh.java. Expected: CastHigh. Got: CastHighFunctions.
Name: IntervalAggrFunctions2.java. Expected: IntervalAggrFunctions2. Got: 
${aggrtype.className}Functions.
Name: SumZeroAggr.java. Expected: SumZeroAggr. Got: SumZeroFunctions.
Name: NumericFunctionsTemplates.java. Expected: NumericFunctionsTemplates. Got: 
${numericFunc.className}Functions.
Name: CovarTypeFunctions.java. Expected: CovarTypeFunctions. Got: 
${aggrtype.className}Functions.
Name: AggrTypeFunctions3.java. Expected: AggrTypeFunctions3. Got: 
${aggrtype.className}Functions.
Name: 

[jira] [Created] (DRILL-7530) Fix class names in loggers

2020-01-17 Thread Arina Ielchiieva (Jira)
Arina Ielchiieva created DRILL-7530:
---

 Summary: Fix class names in loggers
 Key: DRILL-7530
 URL: https://issues.apache.org/jira/browse/DRILL-7530
 Project: Apache Drill
  Issue Type: Task
Affects Versions: 1.17.0
Reporter: Arina Ielchiieva
Assignee: Arina Ielchiieva
 Fix For: 1.18.0


Some loggers have incorrect class names which leads to incorrect information in 
logs.
This Jira aims to fix all occurrences of incorrect class names in loggers.

Preliminary list (some occurrences will be excluded): 
{noformat}
Name: MapRDBTableCache.java. Expected: MapRDBTableCache. Got: 
MapRDBFormatPlugin.
Name: MapRDBTableCache.java. Expected: MapRDBTableCache. Got: 
MapRDBFormatPlugin.
Name: HiveFuncHolderExpr.java. Expected: HiveFuncHolderExpr. Got: 
DrillFuncHolderExpr.
Name: HiveFuncHolder.java. Expected: HiveFuncHolder. Got: 
FunctionImplementationRegistry.
Name: HiveMetadataProvider.java. Expected: HiveMetadataProvider. Got: HiveStats.
Name: TableEntryCacheLoader.java. Expected: TableEntryCacheLoader. Got: 
TableNameCacheLoader.
Name: TestKafkaSuit.java. Expected: TestKafkaSuit. Got: LoggerFactory.
Name: DrillTestWrapper.java. Expected: DrillTestWrapper. Got: BaseTestQuery.
Name: TestDisabledFunctionality.java. Expected: TestDisabledFunctionality. Got: 
TestExampleQueries.
Name: TestMergeJoin.java. Expected: TestMergeJoin. Got: HashAggBatch.
Name: TestLateralJoinCorrectnessBatchProcessing.java. Expected: 
TestLateralJoinCorrectnessBatchProcessing. Got: TestNewLateralJoinCorrectness.
Name: TestOperatorRecordBatch.java. Expected: TestOperatorRecordBatch. Got: 
SubOperatorTest.
Name: TestPauseInjection.java. Expected: TestPauseInjection. Got: DummyClass.
Name: TestComplexTypeWriter.java. Expected: TestComplexTypeWriter. Got: 
TestComplexTypeReader.
Name: AvgIntervalTypeFunctions.java. Expected: AvgIntervalTypeFunctions. Got: 
AvgFunctions.
Name: SSLConfigBuilder.java. Expected: SSLConfigBuilder. Got: 
org.apache.drill.exec.ssl.SSLConfigBuilder.
Name: PlannerPhase.java. Expected: PlannerPhase. Got: DrillRuleSets.
Name: AbstractIndexDescriptor.java. Expected: AbstractIndexDescriptor. Got: 
AbstractIndexDescriptor .
Name: CoveringPlanNoFilterGenerator.java. Expected: 
CoveringPlanNoFilterGenerator. Got: CoveringIndexPlanGenerator.
Name: AbstractSqlSetHandler.java. Expected: AbstractSqlSetHandler. Got: 
AbstractSqlHandler.
Name: HashJoinMemoryCalculatorImpl.java. Expected: 
HashJoinMemoryCalculatorImpl. Got: BuildSidePartitioning.
Name: HashJoinMemoryCalculatorImpl.java. Expected: 
HashJoinMemoryCalculatorImpl. Got: PostBuildCalculationsImpl.
Name: HashJoinMemoryCalculator.java. Expected: HashJoinMemoryCalculator. Got: 
PartitionStatSet.
Name: NestedLoopJoinTemplate.java. Expected: NestedLoopJoinTemplate. Got: 
NestedLoopJoinBatch.
Name: PartitionLimitRecordBatch.java. Expected: PartitionLimitRecordBatch. Got: 
LimitRecordBatch.
Name: HashAggTemplate.java. Expected: HashAggTemplate. Got: HashAggregator.
Name: SpilledRecordbatch.java. Expected: SpilledRecordbatch. Got: 
SimpleRecordBatch.
Name: StreamingAggTemplate.java. Expected: StreamingAggTemplate. Got: 
StreamingAggregator.
Name: SortMemoryManager.java. Expected: SortMemoryManager. Got: 
ExternalSortBatch.
Name: SortConfig.java. Expected: SortConfig. Got: ExternalSortBatch.
Name: SortImpl.java. Expected: SortImpl. Got: ExternalSortBatch.
Name: SingleSenderCreator.java. Expected: SingleSenderCreator. Got: 
SingleSenderRootExec.
Name: HashTableTemplate.java. Expected: HashTableTemplate. Got: HashTable.
Name: FrameSupportTemplate.java. Expected: FrameSupportTemplate. Got: 
NoFrameSupportTemplate.
Name: ScreenCreator.java. Expected: ScreenCreator. Got: ScreenRoot.
Name: UnionAll.java. Expected: UnionAll. Got: Filter.
Name: AvgIntervalTypeFunctions.java. Expected: AvgIntervalTypeFunctions. Got: 
AvgFunctions.
Name: PersistedOptionValue.java. Expected: PersistedOptionValue. Got: 
Deserializer.
Name: ThreadsResources.java. Expected: ThreadsResources. Got: MetricsResources.
Name: RepeatedVarCharOutput.java. Expected: RepeatedVarCharOutput. Got: 
BaseFieldOutput.
Name: MockSubScanPOP.java. Expected: MockSubScanPOP. Got: MockGroupScanPOP.
Name: InMemoryStore.java. Expected: InMemoryStore. Got: InMemoryPersistentStore.
Name: ParquetColumnChunkPageWriteStore.java. Expected: 
ParquetColumnChunkPageWriteStore. Got: ParquetDirectByteBufferAllocator.
Name: CorrelationTypeFunctions.java. Expected: CorrelationTypeFunctions. Got: 
${aggrtype.className}Functions.
Name: MathFunctionTemplates.java. Expected: MathFunctionTemplates. Got: 
${inputType.className}Functions.
Name: CastHigh.java. Expected: CastHigh. Got: CastHighFunctions.
Name: IntervalAggrFunctions2.java. Expected: IntervalAggrFunctions2. Got: 
${aggrtype.className}Functions.
Name: SumZeroAggr.java. Expected: SumZeroAggr. Got: SumZeroFunctions.
Name: NumericFunctionsTemplates.java. 

[jira] [Commented] (DRILL-7491) Incorrect count() returned for complex types in parquet

2020-01-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DRILL-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017911#comment-17017911
 ] 

ASF GitHub Bot commented on DRILL-7491:
---

arina-ielchiieva commented on issue #1955: DRILL-7491: Incorrect count() 
returned for complex types in parquet
URL: https://github.com/apache/drill/pull/1955#issuecomment-575580335
 
 
   @paul-rogers Igor had addressed code review comments and left one comment 
explaining the background of the issue 
(https://github.com/apache/drill/pull/1955#discussion_r366812967). Could you 
take a look one more time? Thanks.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Incorrect count() returned for complex types in parquet
> ---
>
> Key: DRILL-7491
> URL: https://issues.apache.org/jira/browse/DRILL-7491
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Functions - Drill, Functions - Hive, Storage - Parquet
>Affects Versions: 1.16.0, 1.17.0
>Reporter: Igor Guzenko
>Assignee: Igor Guzenko
>Priority: Major
>  Labels: ready-to-commit
> Fix For: 1.18.0
>
> Attachments: hive_alltypes.parquet
>
>
> To reproduce use the attached file for {{hive_alltypes.parquet}} (this is 
> parquet file generated by Hive) and try count on columns *c13 - c15.*  For 
> example, 
> {code:sql}
> SELECT count(c13) FROM dfs.tmp.`hive_alltypes.parquet`
> {code}
> *Expected result:* {color:green}3 {color}
> *Actual result:* {color:red}0{color}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)