[jira] [Commented] (DRILL-8357) Add new config options to the Splunk storage plugin
[ https://issues.apache.org/jira/browse/DRILL-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17633675#comment-17633675 ] ASF GitHub Bot commented on DRILL-8357: --- jnturton opened a new pull request, #2705: URL: https://github.com/apache/drill/pull/2705 [DRILL-8357](https://issues.apache.org/jira/browse/DRILL-8357): Add new config options to the Splunk storage plugin ## Description The Splunk SDK and testcontainer are upgraded to 1.9.1 and 9 respectively. New config options supported by the Splunk SDK are added. None are required and none are present in the Splunk config template. |Name|Description| |app|The application context of the service.| |owner|The owner context of the service.| |token|A Splunk authentication token to use for the session.| |cookie|A valid login cookie.| |validateCertificates|Whether the Splunk client will validates the server's SSL cert.| In an accompanying commit the storage.plugin_auto_disable SYSTEM option default is changed from true to false so that users must explictly choose to have the auto disabler active. ## Documentation Add new options to the Splunk plugin doc page. ## Testing Set the config options and check that they are passed through to the Splunk SDK in SplunkConnection. > Add new config options to the Splunk storage plugin > --- > > Key: DRILL-8357 > URL: https://issues.apache.org/jira/browse/DRILL-8357 > Project: Apache Drill > Issue Type: Improvement > Components: Storage - Other >Affects Versions: 1.20.2 >Reporter: James Turton >Assignee: James Turton >Priority: Minor > Fix For: 2.0.0 > > > The following five new options can be added to the Splunk storage config. > {code:java} > // Whether the Splunk client will validates the server's SSL cert. > private final boolean validateCertificates; > // The application context of the service. > private final String app; > // The owner context of the service. > private final String owner; > // A Splunk authentication token to use for the session. > private final String token; > // A valid login cookie. > private final String cookie;{code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DRILL-8357) Add new config options to the Splunk storage plugin
[ https://issues.apache.org/jira/browse/DRILL-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17633868#comment-17633868 ] ASF GitHub Bot commented on DRILL-8357: --- cgivre commented on PR #2705: URL: https://github.com/apache/drill/pull/2705#issuecomment-1313908517 @jnturton The PR looks good. I had a few questions: 1. Could you please document what types of input would be expected in these fields and what they do? I'm not really clear myself what the `owner` field actually does. If you're not sure, then let's leave it, but if you had some additional info, that would be helpful. 2. I had question about the `token` and `cookie`? Are these fields something that we'd expect to be set in a config, or are they something that should be somehow populated dynamically? This seemed strange to me. > Add new config options to the Splunk storage plugin > --- > > Key: DRILL-8357 > URL: https://issues.apache.org/jira/browse/DRILL-8357 > Project: Apache Drill > Issue Type: Improvement > Components: Storage - Other >Affects Versions: 1.20.2 >Reporter: James Turton >Assignee: James Turton >Priority: Minor > Fix For: 2.0.0 > > > The following five new options can be added to the Splunk storage config. > {code:java} > // Whether the Splunk client will validates the server's SSL cert. > private final boolean validateCertificates; > // The application context of the service. > private final String app; > // The owner context of the service. > private final String owner; > // A Splunk authentication token to use for the session. > private final String token; > // A valid login cookie. > private final String cookie;{code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DRILL-8357) Add new config options to the Splunk storage plugin
[ https://issues.apache.org/jira/browse/DRILL-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17634155#comment-17634155 ] ASF GitHub Bot commented on DRILL-8357: --- jnturton commented on PR #2705: URL: https://github.com/apache/drill/pull/2705#issuecomment-1314766932 > I had question about the token and cookie? Are these fields something that we'd expect to be set in a config, or are they something that should be somehow populated dynamically? This seemed strange to me. I thought they might be set in the config _and_ dynamic i.e. the user's application obtains a token or cookie from Splunk and then updates the Drill config with it using the Drill REST API. Or in the config and static if the user [has gone to Splunk Web for a token](https://docs.splunk.com/Documentation/Splunk/latest/Security/CreateAuthTokens#Use_Splunk_Web_to_create_authentication_tokens) that lives for a long enough time that doing this would make sense. > Add new config options to the Splunk storage plugin > --- > > Key: DRILL-8357 > URL: https://issues.apache.org/jira/browse/DRILL-8357 > Project: Apache Drill > Issue Type: Improvement > Components: Storage - Other >Affects Versions: 1.20.2 >Reporter: James Turton >Assignee: James Turton >Priority: Minor > Fix For: 2.0.0 > > > The following five new options can be added to the Splunk storage config. > {code:java} > // Whether the Splunk client will validates the server's SSL cert. > private final boolean validateCertificates; > // The application context of the service. > private final String app; > // The owner context of the service. > private final String owner; > // A Splunk authentication token to use for the session. > private final String token; > // A valid login cookie. > private final String cookie;{code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DRILL-8357) Add new config options to the Splunk storage plugin
[ https://issues.apache.org/jira/browse/DRILL-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17634157#comment-17634157 ] ASF GitHub Bot commented on DRILL-8357: --- cgivre merged PR #2705: URL: https://github.com/apache/drill/pull/2705 > Add new config options to the Splunk storage plugin > --- > > Key: DRILL-8357 > URL: https://issues.apache.org/jira/browse/DRILL-8357 > Project: Apache Drill > Issue Type: Improvement > Components: Storage - Other >Affects Versions: 1.20.2 >Reporter: James Turton >Assignee: James Turton >Priority: Minor > Fix For: 2.0.0 > > > The following five new options can be added to the Splunk storage config. > {code:java} > // Whether the Splunk client will validates the server's SSL cert. > private final boolean validateCertificates; > // The application context of the service. > private final String app; > // The owner context of the service. > private final String owner; > // A Splunk authentication token to use for the session. > private final String token; > // A valid login cookie. > private final String cookie;{code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DRILL-8357) Add new config options to the Splunk storage plugin
[ https://issues.apache.org/jira/browse/DRILL-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17634163#comment-17634163 ] ASF GitHub Bot commented on DRILL-8357: --- jnturton commented on PR #2705: URL: https://github.com/apache/drill/pull/2705#issuecomment-1314778295 Busy updating README.md (which I'd forgotten about) and the website doc page with more information about Apps and Owners. > Add new config options to the Splunk storage plugin > --- > > Key: DRILL-8357 > URL: https://issues.apache.org/jira/browse/DRILL-8357 > Project: Apache Drill > Issue Type: Improvement > Components: Storage - Other >Affects Versions: 1.20.2 >Reporter: James Turton >Assignee: James Turton >Priority: Minor > Fix For: 2.0.0 > > > The following five new options can be added to the Splunk storage config. > {code:java} > // Whether the Splunk client will validates the server's SSL cert. > private final boolean validateCertificates; > // The application context of the service. > private final String app; > // The owner context of the service. > private final String owner; > // A Splunk authentication token to use for the session. > private final String token; > // A valid login cookie. > private final String cookie;{code} -- This message was sent by Atlassian Jira (v8.20.10#820010)