[jira] [Commented] (DRILL-8369) Add support for querying DeltaLake snapshots by version
[
https://issues.apache.org/jira/browse/DRILL-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646423#comment-17646423
]
ASF GitHub Bot commented on DRILL-8369:
---
cgivre commented on code in PR #2718:
URL: https://github.com/apache/drill/pull/2718#discussion_r1046647612
##
contrib/format-deltalake/src/main/java/org/apache/drill/exec/store/delta/format/DeltaFormatPluginConfig.java:
##
@@ -18,15 +18,55 @@
package org.apache.drill.exec.store.delta.format;
import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.annotation.JsonTypeName;
+import org.apache.drill.common.PlanStringBuilder;
import org.apache.drill.common.logical.FormatPluginConfig;
+import java.util.Objects;
+
@JsonTypeName(DeltaFormatPluginConfig.NAME)
public class DeltaFormatPluginConfig implements FormatPluginConfig {
public static final String NAME = "delta";
+ private final Long version;
+ private final Long timestamp;
+
@JsonCreator
- public DeltaFormatPluginConfig() {
+ public DeltaFormatPluginConfig(@JsonProperty("version") Long version,
Review Comment:
I don't remember the annotation, but do you think it would be a good idea to
hide these in the config so people don't set them accidentally?
> Add support for querying DeltaLake snapshots by version
> ---
>
> Key: DRILL-8369
> URL: https://issues.apache.org/jira/browse/DRILL-8369
> Project: Apache Drill
> Issue Type: Improvement
>Reporter: Vova Vysotskyi
>Assignee: Vova Vysotskyi
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DRILL-8358) Storage plugin for querying other Apache Drill clusters
[
https://issues.apache.org/jira/browse/DRILL-8358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646331#comment-17646331
]
ASF GitHub Bot commented on DRILL-8358:
---
vvysotskyi commented on code in PR #2709:
URL: https://github.com/apache/drill/pull/2709#discussion_r1046390848
##
contrib/storage-drill/src/test/java/org/apache/drill/exec/store/drill/plugin/DrillPluginQueriesTest.java:
##
@@ -0,0 +1,312 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.store.drill.plugin;
+
+import org.apache.drill.common.AutoCloseables;
+import org.apache.drill.common.types.TypeProtos;
+import org.apache.drill.exec.physical.rowSet.RowSet;
+import org.apache.drill.exec.physical.rowSet.RowSetBuilder;
+import org.apache.drill.exec.record.metadata.SchemaBuilder;
+import org.apache.drill.exec.record.metadata.TupleMetadata;
+import org.apache.drill.test.ClientFixture;
+import org.apache.drill.test.ClusterFixture;
+import org.apache.drill.test.ClusterTest;
+import org.apache.drill.test.rowSet.RowSetComparison;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.Test;
+
+import java.util.Properties;
+
+import static org.junit.Assert.assertEquals;
+
+public class DrillPluginQueriesTest extends ClusterTest {
+
+ private static final String TABLE_NAME = "dfs.tmp.test_table";
+
+ private static ClusterFixture drill;
+ private static ClientFixture drillClient;
+
+ @BeforeClass
+ public static void setUpBeforeClass() throws Exception {
+initPlugin();
+ }
+
+ @AfterClass
+ public static void shutdown() throws Exception {
+AutoCloseables.close(drill, drillClient);
+ }
+
+ private static void initPlugin() throws Exception {
+startCluster(ClusterFixture.builder(dirTestWatcher));
+drill = ClusterFixture.builder(dirTestWatcher).build();
+
+DrillStoragePluginConfig config = new DrillStoragePluginConfig(
+ "jdbc:drill:drillbit=localhost:" + drill.drillbit().getUserPort(),
+ new Properties(), null);
+config.setEnabled(true);
+cluster.defineStoragePlugin("drill", config);
+cluster.defineStoragePlugin("drill2", config);
+drillClient = drill.clientFixture();
+
+drillClient.queryBuilder()
+ .sql("create table %s as select * from cp.`tpch/nation.parquet`",
TABLE_NAME)
+ .run();
+ }
+
+ @Test
+ public void testSerDe() throws Exception {
+String plan = queryBuilder().sql("select * from drill.%s",
TABLE_NAME).explainJson();
+long count = queryBuilder().physical(plan).run().recordCount();
+assertEquals(25, count);
+ }
+
+ @Test
+ public void testShowDatabases() throws Exception {
+testBuilder()
+ .sqlQuery("show databases where SCHEMA_NAME='drill.dfs.tmp'")
+ .unOrdered()
+ .baselineColumns("SCHEMA_NAME")
+ .baselineValues("drill.dfs.tmp")
+ .go();
+ }
+
+ @Test
+ public void testShowTables() throws Exception {
+testBuilder()
+ .sqlQuery("show tables IN drill.INFORMATION_SCHEMA")
+ .unOrdered()
+ .baselineColumns("TABLE_SCHEMA", "TABLE_NAME")
+ .baselineValues("drill.information_schema", "VIEWS")
+ .baselineValues("drill.information_schema", "CATALOGS")
+ .baselineValues("drill.information_schema", "COLUMNS")
+ .baselineValues("drill.information_schema", "PARTITIONS")
+ .baselineValues("drill.information_schema", "FILES")
+ .baselineValues("drill.information_schema", "SCHEMATA")
+ .baselineValues("drill.information_schema", "TABLES")
+ .go();
+ }
+
+ @Test
+ public void testProjectPushDown() throws Exception {
+String query = "select n_nationkey, n_regionkey, n_name from drill.%s";
+
+queryBuilder()
+.sql(query, TABLE_NAME)
+.planMatcher()
+.include("query=\"SELECT `n_nationkey`, `n_regionkey`, `n_name`")
+.exclude("\\*")
+.match();
+
+RowSet sets = queryBuilder()
+ .sql(query, TABLE_NAME)
+ .rowSet();
+
+TupleMetadata schema = new SchemaBuilder()
+ .add("n_nationkey", TypeProtos.MinorType.INT)
+ .add("n_regionkey", TypeProtos.MinorType.INT)
+ .add("n_name", TypeProtos.Minor
[jira] [Commented] (DRILL-8358) Storage plugin for querying other Apache Drill clusters
[ https://issues.apache.org/jira/browse/DRILL-8358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646234#comment-17646234 ] ASF GitHub Bot commented on DRILL-8358: --- cgivre merged PR #2709: URL: https://github.com/apache/drill/pull/2709 > Storage plugin for querying other Apache Drill clusters > --- > > Key: DRILL-8358 > URL: https://issues.apache.org/jira/browse/DRILL-8358 > Project: Apache Drill > Issue Type: New Feature >Reporter: Vova Vysotskyi >Assignee: Vova Vysotskyi >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DRILL-8370) Upgrade splunk-sdk-java to 1.9.3
[
https://issues.apache.org/jira/browse/DRILL-8370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646196#comment-17646196
]
ASF GitHub Bot commented on DRILL-8370:
---
github-code-scanning[bot] commented on code in PR #2719:
URL: https://github.com/apache/drill/pull/2719#discussion_r1046056001
##
contrib/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkConnection.java:
##
@@ -152,4 +172,45 @@
public EntityCollection getIndexes() {
return service.getIndexes();
}
+
+ /**
+ * As of version 1.8, Splunk's SDK introduced a boolean parameter which
+ * is supposed to control whether the SDK will validate SSL certificates
+ * or not. Unfortunately the parameter does not actually seem to have
+ * any effect and the end result is that when making Splunk calls,
+ * Splunk will always attempt to verify the SSL certificates, even when
+ * the parameter is set to false. This method does what the parameter
+ * is supposed to do in the SDK and adds and all trusting SSL Socket
+ * Factory to the HTTP client in Splunk's SDK. In the event Splunk
+ * fixes this issue, we can remove this method.
+ *
+ * @return A {@link SSLSocketFactory} which trusts any SSL certificate,
+ * even ones from Splunk
+ * @throws KeyManagementException Thros
+ */
+ private SSLSocketFactory createAllTrustingSSLFactory() throws
KeyManagementException {
+SSLContext context;
+try {
+ context = SSLContext.getInstance("TLS");
+} catch (NoSuchAlgorithmException e) {
+ throw UserException.validationError(e)
+.message("Error establishing SSL connection: Invalid scheme: " +
e.getMessage())
+.build(logger);
+}
+TrustManager[] trustAll = new TrustManager[]{
+new X509TrustManager() {
+ public X509Certificate[] getAcceptedIssuers() {
+return null;
+ }
+ public void checkClientTrusted(X509Certificate[] certs, String
authType) {
+// No op
+ }
+ public void checkServerTrusted(X509Certificate[] certs, String
authType) {
+// No op
+ }
+}
+};
+context.init(null, trustAll, null);
Review Comment:
## `TrustManager` that accepts all certificates
This uses [TrustManager](1), which is defined in [SplunkConnection$](2) and
trusts any certificate.
[Show more
details](https://github.com/apache/drill/security/code-scanning/42)
> Upgrade splunk-sdk-java to 1.9.3
>
>
> Key: DRILL-8370
> URL: https://issues.apache.org/jira/browse/DRILL-8370
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Other
>Affects Versions: 1.20.2
>Reporter: James Turton
>Assignee: James Turton
>Priority: Minor
> Fix For: 1.20.3
>
>
> Changes in splunk-sdk-java since 1.9.1.
> {quote}
> h3. Minor Changes
> * Re-fetch logic for instancetype and version fields if not set within
> Service instance to avoid NPE (GitHub PR
> [#202|https://github.com/splunk/splunk-sdk-java/pull/202])
> * Check for local IP as alternative to _localhost_ within HostnameVerifier,
> addressing issue with certain local workflows
> * Added null check for child to handle error when no value is passed for a
> parameter in modular-inputs (Ref issue
> [#198|https://github.com/splunk/splunk-sdk-java/issues/198] & GitHub PR
> [#199|https://github.com/splunk/splunk-sdk-java/pull/199])
> h3. New Features and APIs
> {quote} *
> {quote}Added feature that allows to update ACL properties of an entity
> (GitHub PR [#196|https://github.com/splunk/splunk-sdk-java/pull/196]){quote}
>
> Also removes the execution order dependence in the Splunk unit tests created
> by their expecting a certain number of records in the _audit index. I believe
> this order dependence is behind recent, apparently random CI run failures in
> the Splunk unit tests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DRILL-8370) Upgrade splunk-sdk-java to 1.9.3
[
https://issues.apache.org/jira/browse/DRILL-8370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646163#comment-17646163
]
ASF GitHub Bot commented on DRILL-8370:
---
jnturton commented on PR #2719:
URL: https://github.com/apache/drill/pull/2719#issuecomment-1346704255
The latest commit adds a patch for Splunk's broken validateCertificates
toggle by @cgivre.
> Upgrade splunk-sdk-java to 1.9.3
>
>
> Key: DRILL-8370
> URL: https://issues.apache.org/jira/browse/DRILL-8370
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Other
>Affects Versions: 1.20.2
>Reporter: James Turton
>Assignee: James Turton
>Priority: Minor
> Fix For: 1.20.3
>
>
> Changes in splunk-sdk-java since 1.9.1.
> {quote}
> h3. Minor Changes
> * Re-fetch logic for instancetype and version fields if not set within
> Service instance to avoid NPE (GitHub PR
> [#202|https://github.com/splunk/splunk-sdk-java/pull/202])
> * Check for local IP as alternative to _localhost_ within HostnameVerifier,
> addressing issue with certain local workflows
> * Added null check for child to handle error when no value is passed for a
> parameter in modular-inputs (Ref issue
> [#198|https://github.com/splunk/splunk-sdk-java/issues/198] & GitHub PR
> [#199|https://github.com/splunk/splunk-sdk-java/pull/199])
> h3. New Features and APIs
> {quote} *
> {quote}Added feature that allows to update ACL properties of an entity
> (GitHub PR [#196|https://github.com/splunk/splunk-sdk-java/pull/196]){quote}
>
> Also removes the execution order dependence in the Splunk unit tests created
> by their expecting a certain number of records in the _audit index. I believe
> this order dependence is behind recent, apparently random CI run failures in
> the Splunk unit tests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DRILL-8370) Upgrade splunk-sdk-java to 1.9.3
[
https://issues.apache.org/jira/browse/DRILL-8370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646164#comment-17646164
]
ASF GitHub Bot commented on DRILL-8370:
---
cgivre commented on PR #2719:
URL: https://github.com/apache/drill/pull/2719#issuecomment-1346705339
Just noting here for future reference, but here is the issue on Splunk's SDK
that references the SSL issue:
https://github.com/splunk/splunk-sdk-java/issues/204
> Upgrade splunk-sdk-java to 1.9.3
>
>
> Key: DRILL-8370
> URL: https://issues.apache.org/jira/browse/DRILL-8370
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Other
>Affects Versions: 1.20.2
>Reporter: James Turton
>Assignee: James Turton
>Priority: Minor
> Fix For: 1.20.3
>
>
> Changes in splunk-sdk-java since 1.9.1.
> {quote}
> h3. Minor Changes
> * Re-fetch logic for instancetype and version fields if not set within
> Service instance to avoid NPE (GitHub PR
> [#202|https://github.com/splunk/splunk-sdk-java/pull/202])
> * Check for local IP as alternative to _localhost_ within HostnameVerifier,
> addressing issue with certain local workflows
> * Added null check for child to handle error when no value is passed for a
> parameter in modular-inputs (Ref issue
> [#198|https://github.com/splunk/splunk-sdk-java/issues/198] & GitHub PR
> [#199|https://github.com/splunk/splunk-sdk-java/pull/199])
> h3. New Features and APIs
> {quote} *
> {quote}Added feature that allows to update ACL properties of an entity
> (GitHub PR [#196|https://github.com/splunk/splunk-sdk-java/pull/196]){quote}
>
> Also removes the execution order dependence in the Splunk unit tests created
> by their expecting a certain number of records in the _audit index. I believe
> this order dependence is behind recent, apparently random CI run failures in
> the Splunk unit tests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DRILL-8358) Storage plugin for querying other Apache Drill clusters
[
https://issues.apache.org/jira/browse/DRILL-8358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646104#comment-17646104
]
ASF GitHub Bot commented on DRILL-8358:
---
jnturton commented on code in PR #2709:
URL: https://github.com/apache/drill/pull/2709#discussion_r1039337680
##
contrib/storage-drill/src/test/java/org/apache/drill/exec/store/drill/plugin/DrillPluginQueriesTest.java:
##
@@ -0,0 +1,312 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.store.drill.plugin;
+
+import org.apache.drill.common.AutoCloseables;
+import org.apache.drill.common.types.TypeProtos;
+import org.apache.drill.exec.physical.rowSet.RowSet;
+import org.apache.drill.exec.physical.rowSet.RowSetBuilder;
+import org.apache.drill.exec.record.metadata.SchemaBuilder;
+import org.apache.drill.exec.record.metadata.TupleMetadata;
+import org.apache.drill.test.ClientFixture;
+import org.apache.drill.test.ClusterFixture;
+import org.apache.drill.test.ClusterTest;
+import org.apache.drill.test.rowSet.RowSetComparison;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.Test;
+
+import java.util.Properties;
+
+import static org.junit.Assert.assertEquals;
+
+public class DrillPluginQueriesTest extends ClusterTest {
+
+ private static final String TABLE_NAME = "dfs.tmp.test_table";
+
+ private static ClusterFixture drill;
+ private static ClientFixture drillClient;
+
+ @BeforeClass
+ public static void setUpBeforeClass() throws Exception {
+initPlugin();
+ }
+
+ @AfterClass
+ public static void shutdown() throws Exception {
+AutoCloseables.close(drill, drillClient);
+ }
+
+ private static void initPlugin() throws Exception {
+startCluster(ClusterFixture.builder(dirTestWatcher));
+drill = ClusterFixture.builder(dirTestWatcher).build();
+
+DrillStoragePluginConfig config = new DrillStoragePluginConfig(
+ "jdbc:drill:drillbit=localhost:" + drill.drillbit().getUserPort(),
+ new Properties(), null);
+config.setEnabled(true);
+cluster.defineStoragePlugin("drill", config);
+cluster.defineStoragePlugin("drill2", config);
+drillClient = drill.clientFixture();
+
+drillClient.queryBuilder()
+ .sql("create table %s as select * from cp.`tpch/nation.parquet`",
TABLE_NAME)
+ .run();
+ }
+
+ @Test
+ public void testSerDe() throws Exception {
+String plan = queryBuilder().sql("select * from drill.%s",
TABLE_NAME).explainJson();
+long count = queryBuilder().physical(plan).run().recordCount();
+assertEquals(25, count);
+ }
+
+ @Test
+ public void testShowDatabases() throws Exception {
+testBuilder()
+ .sqlQuery("show databases where SCHEMA_NAME='drill.dfs.tmp'")
+ .unOrdered()
+ .baselineColumns("SCHEMA_NAME")
+ .baselineValues("drill.dfs.tmp")
+ .go();
+ }
+
+ @Test
+ public void testShowTables() throws Exception {
+testBuilder()
+ .sqlQuery("show tables IN drill.INFORMATION_SCHEMA")
+ .unOrdered()
+ .baselineColumns("TABLE_SCHEMA", "TABLE_NAME")
+ .baselineValues("drill.information_schema", "VIEWS")
+ .baselineValues("drill.information_schema", "CATALOGS")
+ .baselineValues("drill.information_schema", "COLUMNS")
+ .baselineValues("drill.information_schema", "PARTITIONS")
+ .baselineValues("drill.information_schema", "FILES")
+ .baselineValues("drill.information_schema", "SCHEMATA")
+ .baselineValues("drill.information_schema", "TABLES")
+ .go();
+ }
+
+ @Test
+ public void testProjectPushDown() throws Exception {
+String query = "select n_nationkey, n_regionkey, n_name from drill.%s";
+
+queryBuilder()
+.sql(query, TABLE_NAME)
+.planMatcher()
+.include("query=\"SELECT `n_nationkey`, `n_regionkey`, `n_name`")
+.exclude("\\*")
+.match();
+
+RowSet sets = queryBuilder()
+ .sql(query, TABLE_NAME)
+ .rowSet();
+
+TupleMetadata schema = new SchemaBuilder()
+ .add("n_nationkey", TypeProtos.MinorType.INT)
+ .add("n_regionkey", TypeProtos.MinorType.INT)
+ .add("n_name", TypeProtos.MinorTy
[jira] [Commented] (DRILL-8370) Upgrade splunk-sdk-java to 1.9.3
[
https://issues.apache.org/jira/browse/DRILL-8370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646088#comment-17646088
]
ASF GitHub Bot commented on DRILL-8370:
---
jnturton opened a new pull request, #2719:
URL: https://github.com/apache/drill/pull/2719
# [DRILL-8370](https://issues.apache.org/jira/browse/DRILL-8370): Upgrade
splunk-sdk-java to 1.9.3
## Description
Changes in splunk-sdk-java since 1.9.1.
> Minor Changes
>
> - Re-fetch logic for instancetype and version fields if not set within
Service instance to avoid NPE (GitHub PR
[#202](https://github.com/splunk/splunk-sdk-java/pull/202))
> - Check for local IP as alternative to localhost within HostnameVerifier,
addressing issue with certain local workflows
> - Added null check for child to handle error when no value is passed for a
parameter in modular-inputs (Ref issue
[#198](https://github.com/splunk/splunk-sdk-java/issues/198) & GitHub PR
[#199](https://github.com/splunk/splunk-sdk-java/pull/199))
>
> New Features and APIs
>
> - Added feature that allows to update ACL properties of an entity (GitHub
PR [#196](https://github.com/splunk/splunk-sdk-java/pull/196))
Also removes the execution order dependence in the Splunk unit tests created
by their expecting a certain number of records in the _audit index. I believe
this order dependence is behind recent, apparently random CI run failures in
the Splunk unit tests.
## Documentation
N/A
## Testing
Splunk unit tests.
> Upgrade splunk-sdk-java to 1.9.3
>
>
> Key: DRILL-8370
> URL: https://issues.apache.org/jira/browse/DRILL-8370
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Other
>Affects Versions: 1.20.2
>Reporter: James Turton
>Assignee: James Turton
>Priority: Minor
> Fix For: 1.20.3
>
>
> Changes in splunk-sdk-java since 1.9.1.
> {quote}
> h3. Minor Changes
> * Re-fetch logic for instancetype and version fields if not set within
> Service instance to avoid NPE (GitHub PR
> [#202|https://github.com/splunk/splunk-sdk-java/pull/202])
> * Check for local IP as alternative to _localhost_ within HostnameVerifier,
> addressing issue with certain local workflows
> * Added null check for child to handle error when no value is passed for a
> parameter in modular-inputs (Ref issue
> [#198|https://github.com/splunk/splunk-sdk-java/issues/198] & GitHub PR
> [#199|https://github.com/splunk/splunk-sdk-java/pull/199])
> h3. New Features and APIs
> {quote} *
> {quote}Added feature that allows to update ACL properties of an entity
> (GitHub PR [#196|https://github.com/splunk/splunk-sdk-java/pull/196]){quote}
>
> Also removes the execution order dependence in the Splunk unit tests created
> by their expecting a certain number of records in the _audit index. I believe
> this order dependence is behind recent, apparently random CI run failures in
> the Splunk unit tests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DRILL-8357) Add new config options to the Splunk storage plugin
[
https://issues.apache.org/jira/browse/DRILL-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646082#comment-17646082
]
ASF GitHub Bot commented on DRILL-8357:
---
jnturton commented on PR #2705:
URL: https://github.com/apache/drill/pull/2705#issuecomment-1346461462
@kingswanwho please note the backport label I just added to this merged PR
and also to #2706.
> Add new config options to the Splunk storage plugin
> ---
>
> Key: DRILL-8357
> URL: https://issues.apache.org/jira/browse/DRILL-8357
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Other
>Affects Versions: 1.20.2
>Reporter: James Turton
>Assignee: James Turton
>Priority: Minor
> Fix For: 2.0.0
>
>
> The following five new options can be added to the Splunk storage config.
> {code:java}
> // Whether the Splunk client will validates the server's SSL cert.
> private final boolean validateCertificates;
> // The application context of the service.
> private final String app;
> // The owner context of the service.
> private final String owner;
> // A Splunk authentication token to use for the session.
> private final String token;
> // A valid login cookie.
> private final String cookie;{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (DRILL-8370) Upgrade splunk-sdk-java to 1.9.3
[
https://issues.apache.org/jira/browse/DRILL-8370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Turton reassigned DRILL-8370:
---
Component/s: Storage - Other
Fix Version/s: 1.20.3
Affects Version/s: 1.20.2
Assignee: James Turton
Description:
Changes in splunk-sdk-java since 1.9.1.
{quote}
h3. Minor Changes
* Re-fetch logic for instancetype and version fields if not set within Service
instance to avoid NPE (GitHub PR
[#202|https://github.com/splunk/splunk-sdk-java/pull/202])
* Check for local IP as alternative to _localhost_ within HostnameVerifier,
addressing issue with certain local workflows
* Added null check for child to handle error when no value is passed for a
parameter in modular-inputs (Ref issue
[#198|https://github.com/splunk/splunk-sdk-java/issues/198] & GitHub PR
[#199|https://github.com/splunk/splunk-sdk-java/pull/199])
h3. New Features and APIs
{quote} *
{quote}Added feature that allows to update ACL properties of an entity (GitHub
PR [#196|https://github.com/splunk/splunk-sdk-java/pull/196]){quote}
Also removes the execution order dependence in the Splunk unit tests created by
their expecting a certain number of records in the _audit index. I believe this
order dependence is behind recent, apparently random CI run failures in the
Splunk unit tests.
was:Also removes the execution order dependence in the Splunk unit tests
created by their expecting a certain number of records in the _audit index. I
believe this order dependence is behind recent, apparently random CI run
failures in the Splunk unit tests.
> Upgrade splunk-sdk-java to 1.9.3
>
>
> Key: DRILL-8370
> URL: https://issues.apache.org/jira/browse/DRILL-8370
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Other
>Affects Versions: 1.20.2
>Reporter: James Turton
>Assignee: James Turton
>Priority: Minor
> Fix For: 1.20.3
>
>
> Changes in splunk-sdk-java since 1.9.1.
> {quote}
> h3. Minor Changes
> * Re-fetch logic for instancetype and version fields if not set within
> Service instance to avoid NPE (GitHub PR
> [#202|https://github.com/splunk/splunk-sdk-java/pull/202])
> * Check for local IP as alternative to _localhost_ within HostnameVerifier,
> addressing issue with certain local workflows
> * Added null check for child to handle error when no value is passed for a
> parameter in modular-inputs (Ref issue
> [#198|https://github.com/splunk/splunk-sdk-java/issues/198] & GitHub PR
> [#199|https://github.com/splunk/splunk-sdk-java/pull/199])
> h3. New Features and APIs
> {quote} *
> {quote}Added feature that allows to update ACL properties of an entity
> (GitHub PR [#196|https://github.com/splunk/splunk-sdk-java/pull/196]){quote}
>
> Also removes the execution order dependence in the Splunk unit tests created
> by their expecting a certain number of records in the _audit index. I believe
> this order dependence is behind recent, apparently random CI run failures in
> the Splunk unit tests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (DRILL-8370) Upgrade splunk-sdk-java to 1.9.3
James Turton created DRILL-8370: --- Summary: Upgrade splunk-sdk-java to 1.9.3 Key: DRILL-8370 URL: https://issues.apache.org/jira/browse/DRILL-8370 Project: Apache Drill Issue Type: Improvement Reporter: James Turton Also removes the execution order dependence in the Splunk unit tests created by their expecting a certain number of records in the _audit index. I believe this order dependence is behind recent, apparently random CI run failures in the Splunk unit tests. -- This message was sent by Atlassian Jira (v8.20.10#820010)
