[jira] [Commented] (DRILL-8380) Remove customised SqlValidatorImpl.deriveAlias

2023-01-11 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DRILL-8380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17675816#comment-17675816
 ] 

ASF GitHub Bot commented on DRILL-8380:
---

jnturton commented on code in PR #2733:
URL: https://github.com/apache/drill/pull/2733#discussion_r1067718395


##
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java:
##
@@ -403,8 +404,24 @@ private View getView(DotDrillFile f) throws IOException {
   return f.getView(mapper);
 }
 
+private String getTemporaryName(String name) {
+  if (isTemporaryWorkspace()) {
+String tableName = DrillStringUtils.removeLeadingSlash(name);
+return schemaConfig.getTemporaryTableName(tableName);
+  }
+  return null;
+}
+
+private boolean isTemporaryWorkspace() {

Review Comment:
   Could this utility method move to SchemaConfig or SchemaUtilities so that 
it's available for reuse elsewhere or is that unlikely?





> Remove customised SqlValidatorImpl.deriveAlias
> --
>
> Key: DRILL-8380
> URL: https://issues.apache.org/jira/browse/DRILL-8380
> Project: Apache Drill
>  Issue Type: Sub-task
>Reporter: Vova Vysotskyi
>Assignee: Vova Vysotskyi
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (DRILL-8380) Remove customised SqlValidatorImpl.deriveAlias

2023-01-11 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DRILL-8380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17675815#comment-17675815
 ] 

ASF GitHub Bot commented on DRILL-8380:
---

jnturton commented on code in PR #2733:
URL: https://github.com/apache/drill/pull/2733#discussion_r1067718395


##
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java:
##
@@ -403,8 +404,24 @@ private View getView(DotDrillFile f) throws IOException {
   return f.getView(mapper);
 }
 
+private String getTemporaryName(String name) {
+  if (isTemporaryWorkspace()) {
+String tableName = DrillStringUtils.removeLeadingSlash(name);
+return schemaConfig.getTemporaryTableName(tableName);
+  }
+  return null;
+}
+
+private boolean isTemporaryWorkspace() {

Review Comment:
   Could this utiltiy method move to SchemaConfig or SchemaUtilities so that 
it's available for reuse elsewhere or is that unlikely?





> Remove customised SqlValidatorImpl.deriveAlias
> --
>
> Key: DRILL-8380
> URL: https://issues.apache.org/jira/browse/DRILL-8380
> Project: Apache Drill
>  Issue Type: Sub-task
>Reporter: Vova Vysotskyi
>Assignee: Vova Vysotskyi
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (DRILL-8386) Add Support for User Translation for Cassandra

2023-01-11 Thread Charles Givre (Jira)
Charles Givre created DRILL-8386:


 Summary: Add Support for User Translation for Cassandra
 Key: DRILL-8386
 URL: https://issues.apache.org/jira/browse/DRILL-8386
 Project: Apache Drill
  Issue Type: Improvement
  Components: Storage - Cassandra
Affects Versions: 1.20.3
Reporter: Charles Givre
Assignee: Charles Givre
 Fix For: 1.21.0


Adds support for user translation to the Cassandra plugin. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (DRILL-8386) Add Support for User Translation for Cassandra

2023-01-11 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DRILL-8386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17675753#comment-17675753
 ] 

ASF GitHub Bot commented on DRILL-8386:
---

cgivre opened a new pull request, #2738:
URL: https://github.com/apache/drill/pull/2738

   # [DRILL-8386](https://issues.apache.org/jira/browse/DRILL-8386): Add 
Support for User Translation for Cassandra
   
   ## Description
   Adds support for user translation for Apache Cassandra.
   
   ## Documentation
   Updated README.
   
   ## Testing
   Added unit tests.




> Add Support for User Translation for Cassandra
> --
>
> Key: DRILL-8386
> URL: https://issues.apache.org/jira/browse/DRILL-8386
> Project: Apache Drill
>  Issue Type: Improvement
>  Components: Storage - Cassandra
>Affects Versions: 1.20.3
>Reporter: Charles Givre
>Assignee: Charles Givre
>Priority: Major
> Fix For: 1.21.0
>
>
> Adds support for user translation to the Cassandra plugin. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (DRILL-8385) Add support for disabling SSL certificate verification in the ES plugin

2023-01-11 Thread James Turton (Jira)
James Turton created DRILL-8385:
---

 Summary: Add support for disabling SSL certificate verification in 
the ES plugin
 Key: DRILL-8385
 URL: https://issues.apache.org/jira/browse/DRILL-8385
 Project: Apache Drill
  Issue Type: Improvement
  Components: Storage - ElasticSearch
Affects Versions: 1.20.3
Reporter: James Turton
 Fix For: Future


In Calcite, provide a custom TrustManager that trusts every certificate to the 
ES RestClient builder in ElasticsearchSchemaFactory if a corresponding config 
option has been set by application code.

In Drill, add a config option to the ES plugin allowing certificate 
verification to be toggled and pass it through to the Calcite option mentioned 
above.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)