[jira] [Commented] (DRILL-2508) Add new column to sys.options table that exposes whether or not the current system value is the default

2015-05-12 Thread Victoria Markman (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14541006#comment-14541006
 ] 

Victoria Markman commented on DRILL-2508:
-

Verified fixed in: 1.0.0

#Tue May 12 12:29:50 EDT 2015
git.commit.id.abbrev=d10769f



> Add new column to sys.options table that exposes whether or not the current 
> system value is the default
> ---
>
> Key: DRILL-2508
> URL: https://issues.apache.org/jira/browse/DRILL-2508
> Project: Apache Drill
>  Issue Type: Improvement
>  Components: Storage - Other
>Reporter: Victoria Markman
>Assignee: Jason Altekruse
>  Labels: doc-impacting
> Fix For: 1.0.0
>
> Attachments: DRILL-2508.1.patch.txt, DRILL-2508.2.patch.txt
>
>
> Need to be able to see system parameters that I changed.
> There is an enhancement already to reset them to default values: drill-1065
> I don't necessarily want to do that, I just want to see only things that I 
> changed : default value vs. my change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DRILL-2508) Add new column to sys.options table that exposes whether or not the current system value is the default

2015-05-12 Thread Victoria Markman (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14541004#comment-14541004
 ] 

Victoria Markman commented on DRILL-2508:
-

Thank you ! My sanity is restored.

{code}
0: jdbc:drill:schema=dfs> select * from sys.options where status <> 'DEFAULT' 
and status <> 'BOOT';
+++++++++
|name|kind|type|   status   |  num_val   | string_val | 
 bool_val  | float_val  |
+++++++++
| planner.enable_hashjoin_swap | BOOLEAN| SYSTEM | CHANGED| null
   | null   | false  | null   |
| planner.enable_mergejoin | BOOLEAN| SYSTEM | CHANGED| null   
| null   | false  | null   |
| planner.enable_broadcast_join | BOOLEAN| SYSTEM | CHANGED| null   
| null   | false  | null   |
| planner.enable_decimal_data_type | BOOLEAN| SYSTEM | CHANGED| 
null   | null   | true   | null   |
| planner.slice_target | LONG   | SYSTEM | CHANGED| 1  | 
null   | null   | null   |
+++++++++
5 rows selected (0.118 seconds)
{code}

Changed it all back to defaults and:
{code}
0: jdbc:drill:schema=dfs> alter system set `planner.enable_hashjoin_swap` = 
true;
+++
| ok |  summary   |
+++
| true   | planner.enable_hashjoin_swap updated. |
+++
1 row selected (0.099 seconds)

0: jdbc:drill:schema=dfs> alter system set `planner.enable_mergejoin` = true;
+++
| ok |  summary   |
+++
| true   | planner.enable_mergejoin updated. |
+++
1 row selected (0.092 seconds)

0: jdbc:drill:schema=dfs> alter system set `planner.enable_broadcast_join` = 
true;
+++
| ok |  summary   |
+++
| true   | planner.enable_broadcast_join updated. |
+++
1 row selected (0.104 seconds)

0: jdbc:drill:schema=dfs> alter system set `planner.slice_target` = 10
. . . . . . . . . . . . > ;
+++
| ok |  summary   |
+++
| true   | planner.slice_target updated. |
+++
1 row selected (0.097 seconds)

0: jdbc:drill:schema=dfs> alter system set `planner.enable_decimal_data_type` = 
false;
+++
| ok |  summary   |
+++
| true   | planner.enable_decimal_data_type updated. |
+++
1 row selected (0.099 seconds)

0: jdbc:drill:schema=dfs> select * from sys.options where status <> 'DEFAULT' 
and status <> 'BOOT';
+++++++++
|name|kind|type|   status   |  num_val   | string_val | 
 bool_val  | float_val  |
+++++++++
+++++++++
No rows selected (0.121 seconds)
{code}

> Add new column to sys.options table that exposes whether or not the current 
> system value is the default
> ---
>
> Key: DRILL-2508
> URL: https://issues.apache.org/jira/browse/DRILL-2508
> Project: Apache Drill
>  Issue Type: Improvement
>  Components: Storage - Other
>Reporter: Victoria Markman
>Assignee: Jason Altekruse
>  Labels: doc-impacting
> Fix For: 1.0.0
>
> Attachments: DRILL-2508.1.patch.txt, DRILL-2508.2.patch.txt
>
>
> Need to be able to see system parameters that I changed.
> There is an enhancement already to reset them to default values: drill-1065
> I don't necessarily want to do that, I just want to see only things that I 
> changed : default value vs. my change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DRILL-2508) Add new column to sys.options table that exposes whether or not the current system value is the default

2015-03-20 Thread Jacques Nadeau (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372093#comment-14372093
 ] 

Jacques Nadeau commented on DRILL-2508:
---

Alternative could be to add default value columns as well.

> Add new column to sys.options table that exposes whether or not the current 
> system value is the default
> ---
>
> Key: DRILL-2508
> URL: https://issues.apache.org/jira/browse/DRILL-2508
> Project: Apache Drill
>  Issue Type: Improvement
>  Components: Storage - Other
>Reporter: Victoria Markman
> Fix For: 0.9.0
>
>
> Need to be able to see system parameters that I changed.
> There is an enhancement already to reset them to default values: drill-1065
> I don't necessarily want to do that, I just want to see only things that I 
> changed : default value vs. my change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DRILL-2508) Add new column to sys.options table that exposes whether or not the current system value is the default

2015-04-14 Thread Sudheesh Katkam (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494504#comment-14494504
 ] 

Sudheesh Katkam commented on DRILL-2508:


Review board: https://reviews.apache.org/r/33177/

> Add new column to sys.options table that exposes whether or not the current 
> system value is the default
> ---
>
> Key: DRILL-2508
> URL: https://issues.apache.org/jira/browse/DRILL-2508
> Project: Apache Drill
>  Issue Type: Improvement
>  Components: Storage - Other
>Reporter: Victoria Markman
>Assignee: Sudheesh Katkam
> Fix For: 0.9.0
>
> Attachments: DRILL-2508.1.patch.txt, DRILL-2508.2.patch.txt
>
>
> Need to be able to see system parameters that I changed.
> There is an enhancement already to reset them to default values: drill-1065
> I don't necessarily want to do that, I just want to see only things that I 
> changed : default value vs. my change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)