[jira] [Commented] (DRILL-3596) Allow only (expression) or (expression, 1) for LEAD and LAG window functions as input parameters

2015-08-24 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/DRILL-3596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14710125#comment-14710125
 ] 

ASF GitHub Bot commented on DRILL-3596:
---

GitHub user adeneche opened a pull request:

https://github.com/apache/drill/pull/128

DRILL-3596: Allow only (expression) or (expression, 1) for LEAD a…

…nd LAG window functions as input parameters

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/adeneche/incubator-drill DRILL-3596

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/128.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #128


commit 87e411f38665c3c4cdf4313516862505a4cfdf0c
Author: adeneche adene...@gmail.com
Date:   2015-08-24T20:37:25Z

DRILL-3596: Allow only (expression) or (expression, 1) for LEAD and LAG 
window functions as input parameters




 Allow only (expression) or (expression, 1) for LEAD and LAG window 
 functions as input parameters
 

 Key: DRILL-3596
 URL: https://issues.apache.org/jira/browse/DRILL-3596
 Project: Apache Drill
  Issue Type: Bug
  Components: Execution - Relational Operators
Affects Versions: 1.2.0
Reporter: Khurram Faraaz
Assignee: Deneche A. Hakim
  Labels: window_function
 Fix For: 1.2.0


 We need to disable the third input parameter in LEAD and LAG window 
 functions. We should support this syntax.
 LEAD(expression) ,or LEAD(expression,1)
 LAG(expression), or LAG(expression,1)
 In both the functions above, the second parameter is the default offset 
 value, use of any other value must he handled and reported to user as error.
 Use of a third input parameter to both the functions must be disallowed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DRILL-3596) Allow only (expression) or (expression, 1) for LEAD and LAG window functions as input parameters

2015-08-24 Thread Deneche A. Hakim (JIRA)

[ 
https://issues.apache.org/jira/browse/DRILL-3596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14710157#comment-14710157
 ] 

Deneche A. Hakim commented on DRILL-3596:
-

[~amansinha100] can you please review ? thx

 Allow only (expression) or (expression, 1) for LEAD and LAG window 
 functions as input parameters
 

 Key: DRILL-3596
 URL: https://issues.apache.org/jira/browse/DRILL-3596
 Project: Apache Drill
  Issue Type: Bug
  Components: Execution - Relational Operators
Affects Versions: 1.2.0
Reporter: Khurram Faraaz
Assignee: Aman Sinha
  Labels: window_function
 Fix For: 1.2.0


 We need to disable the third input parameter in LEAD and LAG window 
 functions. We should support this syntax.
 LEAD(expression) ,or LEAD(expression,1)
 LAG(expression), or LAG(expression,1)
 In both the functions above, the second parameter is the default offset 
 value, use of any other value must he handled and reported to user as error.
 Use of a third input parameter to both the functions must be disallowed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)