[jira] [Commented] (DRILL-4069) Enable RPC Thread Offload by default

2018-05-31 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/DRILL-4069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497355#comment-16497355
 ] 

ASF GitHub Bot commented on DRILL-4069:
---

ilooner closed pull request #352: DRILL-4069: Enable RPC thread offload by 
default
URL: https://github.com/apache/drill/pull/352
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/exec/rpc/src/main/java/org/apache/drill/exec/rpc/RpcBus.java 
b/exec/rpc/src/main/java/org/apache/drill/exec/rpc/RpcBus.java
index acfb862204..69a44add76 100644
--- a/exec/rpc/src/main/java/org/apache/drill/exec/rpc/RpcBus.java
+++ b/exec/rpc/src/main/java/org/apache/drill/exec/rpc/RpcBus.java
@@ -57,7 +57,7 @@
   final org.slf4j.Logger logger = 
org.slf4j.LoggerFactory.getLogger(this.getClass());
 
   private static final OutboundRpcMessage PONG = new 
OutboundRpcMessage(RpcMode.PONG, 0, 0, Acks.OK);
-  private static final boolean ENABLE_SEPARATE_THREADS = 
"true".equals(System.getProperty("drill.enable_rpc_offload"));
+  private static final boolean DISABLE_SEPARATE_THREADS = 
"false".equals(System.getProperty("drill.enable_rpc_offload"));
 
   protected final CoordinationQueue queue = new CoordinationQueue(16, 16);
 
@@ -262,7 +262,7 @@ public void execute(Runnable command) {
 public InboundHandler(C connection) {
   super();
   this.connection = connection;
-  final Executor underlyingExecutor = ENABLE_SEPARATE_THREADS ? 
rpcConfig.getExecutor() : new SameExecutor();
+  final Executor underlyingExecutor = DISABLE_SEPARATE_THREADS ? new 
SameExecutor() : rpcConfig.getExecutor();
   this.exec = new RpcEventHandler(underlyingExecutor);
 }
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Enable RPC Thread Offload by default
> 
>
> Key: DRILL-4069
> URL: https://issues.apache.org/jira/browse/DRILL-4069
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Execution - RPC
>Reporter: Jacques Nadeau
>Assignee: Sudheesh Katkam
>Priority: Major
>
> Once we enabled RPC thread offload, we saw concurrency regressions DRILL-4041 
> and DRILL-4057. The regressions appear to be unrelated to, but exposed by the 
> thread offload. To simplify things, we disabled the RPC thread offload by 
> default. This is the tracking issue to fix the underlying concurrency bug(s).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-4069) Enable RPC Thread Offload by default

2018-05-31 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/DRILL-4069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497354#comment-16497354
 ] 

ASF GitHub Bot commented on DRILL-4069:
---

ilooner commented on issue #352: DRILL-4069: Enable RPC thread offload by 
default
URL: https://github.com/apache/drill/pull/352#issuecomment-393717834
 
 
   The code this PR changes no longer exists in RPC bus. So I am closing this 
PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Enable RPC Thread Offload by default
> 
>
> Key: DRILL-4069
> URL: https://issues.apache.org/jira/browse/DRILL-4069
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Execution - RPC
>Reporter: Jacques Nadeau
>Assignee: Sudheesh Katkam
>Priority: Major
>
> Once we enabled RPC thread offload, we saw concurrency regressions DRILL-4041 
> and DRILL-4057. The regressions appear to be unrelated to, but exposed by the 
> thread offload. To simplify things, we disabled the RPC thread offload by 
> default. This is the tracking issue to fix the underlying concurrency bug(s).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-4069) Enable RPC Thread Offload by default

2016-03-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-4069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176095#comment-15176095
 ] 

ASF GitHub Bot commented on DRILL-4069:
---

Github user sudheeshkatkam commented on the pull request:

https://github.com/apache/drill/pull/352#issuecomment-191349592
  
All unit tests and regression tests "passed". However, in the logs, I saw 
TestFragmentExecutorCancel failed to cleanup properly. When I try to debug the 
issue, there is no problem. So it seems like there is a timing issue. I will 
try other means, and post an update.


> Enable RPC Thread Offload by default
> 
>
> Key: DRILL-4069
> URL: https://issues.apache.org/jira/browse/DRILL-4069
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Execution - RPC
>Reporter: Jacques Nadeau
>
> Once we enabled RPC thread offload, we saw concurrency regressions DRILL-4041 
> and DRILL-4057. The regressions appear to be unrelated to, but exposed by the 
> thread offload. To simplify things, we disabled the RPC thread offload by 
> default. This is the tracking issue to fix the underlying concurrency bug(s).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DRILL-4069) Enable RPC Thread Offload by default

2016-02-01 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-4069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127041#comment-15127041
 ] 

ASF GitHub Bot commented on DRILL-4069:
---

GitHub user sudheeshkatkam opened a pull request:

https://github.com/apache/drill/pull/352

DRILL-4069: Enable RPC thread offload by default


https://github.com/apache/drill/commit/43414e1e2731c85a52febaaedebfa2f392dd6d2f 
removes the usage of recyclers for RequestEvent and ResponseEvent in the RPC 
layer. This change resolves functional regressions mentioned in 
[DRILL-4041](https://issues.apache.org/jira/browse/DRILL-4041) and 
[DRILL-4057](https://issues.apache.org/jira/browse/DRILL-4057).

Multiple test runs with the same setup mentioned in the tickets did not 
show any regressions.

@jacques-n can you please review?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sudheeshkatkam/drill DRILL-4069

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/352.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #352


commit f2d42074d64d2146eb15bee2374edf78864f832e
Author: Sudheesh Katkam 
Date:   2016-01-22T21:12:50Z

DRILL-4069: Enable RPC thread offload by default




> Enable RPC Thread Offload by default
> 
>
> Key: DRILL-4069
> URL: https://issues.apache.org/jira/browse/DRILL-4069
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Execution - RPC
>Reporter: Jacques Nadeau
>
> Once we enabled RPC thread offload, we saw concurrency regressions DRILL-4041 
> and DRILL-4057. The regressions appear to be unrelated to, but exposed by the 
> thread offload. To simplify things, we disabled the RPC thread offload by 
> default. This is the tracking issue to fix the underlying concurrency bug(s).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DRILL-4069) Enable RPC Thread Offload by default

2016-02-01 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-4069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127063#comment-15127063
 ] 

ASF GitHub Bot commented on DRILL-4069:
---

Github user jacques-n commented on the pull request:

https://github.com/apache/drill/pull/352#issuecomment-178199199
  
LGTM. +1

Nice (but strange) that this resolves the other issues.

I wonder if the local channel short circuit would work now...


> Enable RPC Thread Offload by default
> 
>
> Key: DRILL-4069
> URL: https://issues.apache.org/jira/browse/DRILL-4069
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Execution - RPC
>Reporter: Jacques Nadeau
>
> Once we enabled RPC thread offload, we saw concurrency regressions DRILL-4041 
> and DRILL-4057. The regressions appear to be unrelated to, but exposed by the 
> thread offload. To simplify things, we disabled the RPC thread offload by 
> default. This is the tracking issue to fix the underlying concurrency bug(s).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)