[jira] [Commented] (DRILL-4257) Ensure shutting down a Drillbit also shuts down all StoragePlugins

[Khurram Faraaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151944#comment-15151944
 ] 

Khurram Faraaz commented on DRILL-4257:
---

Do we have a unit test to verify this ?
Is there a way to verify this from the drillbit.log, that all StoragePlugins 
are also shut down once a Drillbit is shut down ?




> Ensure shutting down a Drillbit also shuts down all StoragePlugins
> --
>
> Key: DRILL-4257
> URL: https://issues.apache.org/jira/browse/DRILL-4257
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Execution - Flow
>Reporter: Jacques Nadeau
>Assignee: Jacques Nadeau
> Fix For: 1.5.0
>
>
> Right now, if a StoragePlugin implementation relies on the close method to 
> clean up resources, those resources won't be cleaned up when the Drillbit 
> class is shutdown. This is because Drillbit doesn't actually close the 
> StoragePluginRegistry and associated resources. This causes problems in 
> leaking resources in tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DRILL-4257) Ensure shutting down a Drillbit also shuts down all StoragePlugins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15091346#comment-15091346
 ] 

ASF GitHub Bot commented on DRILL-4257:
---

Github user StevenMPhillips commented on the pull request:

https://github.com/apache/drill/pull/321#issuecomment-170419014
  
+1


> Ensure shutting down a Drillbit also shuts down all StoragePlugins
> --
>
> Key: DRILL-4257
> URL: https://issues.apache.org/jira/browse/DRILL-4257
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Execution - Flow
>Reporter: Jacques Nadeau
>Assignee: Jacques Nadeau
> Fix For: 1.5.0
>
>
> Right now, if a StoragePlugin implementation relies on the close method to 
> clean up resources, those resources won't be cleaned up when the Drillbit 
> class is shutdown. This is because Drillbit doesn't actually close the 
> StoragePluginRegistry and associated resources. This causes problems in 
> leaking resources in tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DRILL-4257) Ensure shutting down a Drillbit also shuts down all StoragePlugins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090866#comment-15090866
 ] 

ASF GitHub Bot commented on DRILL-4257:
---

GitHub user jacques-n opened a pull request:

https://github.com/apache/drill/pull/321

DRILL-4257: Fix StoragePluginRegistry clean-up behavior

Fix StoragePluginRegistry clean-up behavior and misc clean up.

- Create the storage plugin registry using a Drill configuration parameter 
to be able to replace the registry implementation.
- Change StoragePluginRegistry into an interface and move the 
implementation to an impl class.
- Write documentation for StoragePluginRegistry.
- Make StoragePluginRegistry and StoragePluginMap AutoCloseable and ensure 
that Drillbit closes registry.
- Misc Drillbit code reorganization so that fields are at top of class (and 
static methods at bottom).
- Update DrillConfig to support reflection-based creation of storage plugin 
objects
- Remove final from DrillConfig so that application developers can extend 
config object.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jacques-n/drill DRILL-4257

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/321.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #321


commit f172aed0380465c6eea480ddcd540038ebbe6a22
Author: Jacques Nadeau 
Date:   2016-01-10T01:48:26Z

DRILL-4257: Fix StoragePluginRegistry clean-up behavior and misc clean up.

- Create the storage plugin registry using a Drill configuration parameter 
to be able to replace the registry implementation.
- Change StoragePluginRegistry into an interface and move the 
implementation to an impl class.
- Write documentation for StoragePluginRegistry.
- Make StoragePluginRegistry and StoragePluginMap AutoCloseable and ensure 
that Drillbit closes registry.
- Misc Drillbit code reorganization so that fields are at top of class (and 
static methods at bottom).
- Update DrillConfig to support reflection-based creation of storage plugin 
objects
- Remove final from DrillConfig so that application developers can extend 
config object.




> Ensure shutting down a Drillbit also shuts down all StoragePlugins
> --
>
> Key: DRILL-4257
> URL: https://issues.apache.org/jira/browse/DRILL-4257
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Execution - Flow
>Reporter: Jacques Nadeau
>Assignee: Jacques Nadeau
> Fix For: 1.5.0
>
>
> Right now, if a StoragePlugin implementation relies on the close method to 
> clean up resources, those resources won't be cleaned up when the Drillbit 
> class is shutdown. This is because Drillbit doesn't actually close the 
> StoragePluginRegistry and associated resources. This causes problems in 
> leaking resources in tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)