[jira] [Commented] (DRILL-4384) Query profile is missing important information on WebUi
[ https://issues.apache.org/jira/browse/DRILL-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178324#comment-15178324 ] Jason Altekruse commented on DRILL-4384: Fixed in c95b5432301fe487d64a1fc06e765228469fc3a2 > Query profile is missing important information on WebUi > --- > > Key: DRILL-4384 > URL: https://issues.apache.org/jira/browse/DRILL-4384 > Project: Apache Drill > Issue Type: Bug >Reporter: Jinfeng Ni >Assignee: Jacques Nadeau >Priority: Blocker > Fix For: 1.6.0 > > Attachments: DRILL-4384.patch > > > Built drill from master branch (0a2518d7cf01a92a27a82e29edac5424bedf31d5) and > started in embedded mode. Then, > run a query and checked the query profile through WebUI. However, > seems that the fragment profiles , operator profiles and visualized > plan sections are all empty. Tried both Mac and CentOS and hit the same > problem. > After doing a binary search over recent commits, seems the patch of > "DRILL-3581: Upgrade HPPC to 0.7.1" is the cause of broken query > profiles [1]. The query profile on the commits before DRILL-3581 > looks fine. > [1] > https://github.com/apache/drill/commit/d27127c94d5c08306697a5627a1bac5f144abb22 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DRILL-4384) Query profile is missing important information on WebUi
[ https://issues.apache.org/jira/browse/DRILL-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178321#comment-15178321 ] Jason Altekruse commented on DRILL-4384: [~jni] Venki merged this yesterday along with some other outstanding patches. I do agree with you about the automated tests for the UI. I have opened DRILL-4471 to track this task. > Query profile is missing important information on WebUi > --- > > Key: DRILL-4384 > URL: https://issues.apache.org/jira/browse/DRILL-4384 > Project: Apache Drill > Issue Type: Bug >Reporter: Jinfeng Ni >Assignee: Jacques Nadeau >Priority: Blocker > Fix For: 1.6.0 > > Attachments: DRILL-4384.patch > > > Built drill from master branch (0a2518d7cf01a92a27a82e29edac5424bedf31d5) and > started in embedded mode. Then, > run a query and checked the query profile through WebUI. However, > seems that the fragment profiles , operator profiles and visualized > plan sections are all empty. Tried both Mac and CentOS and hit the same > problem. > After doing a binary search over recent commits, seems the patch of > "DRILL-3581: Upgrade HPPC to 0.7.1" is the cause of broken query > profiles [1]. The query profile on the commits before DRILL-3581 > looks fine. > [1] > https://github.com/apache/drill/commit/d27127c94d5c08306697a5627a1bac5f144abb22 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DRILL-4384) Query profile is missing important information on WebUi
[ https://issues.apache.org/jira/browse/DRILL-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176681#comment-15176681 ] Jinfeng Ni commented on DRILL-4384: --- [~jnadeau], do you plan to merge this patch into master? > Query profile is missing important information on WebUi > --- > > Key: DRILL-4384 > URL: https://issues.apache.org/jira/browse/DRILL-4384 > Project: Apache Drill > Issue Type: Bug >Reporter: Jinfeng Ni >Assignee: Jacques Nadeau >Priority: Blocker > Fix For: 1.6.0 > > Attachments: DRILL-4384.patch > > > Built drill from master branch (0a2518d7cf01a92a27a82e29edac5424bedf31d5) and > started in embedded mode. Then, > run a query and checked the query profile through WebUI. However, > seems that the fragment profiles , operator profiles and visualized > plan sections are all empty. Tried both Mac and CentOS and hit the same > problem. > After doing a binary search over recent commits, seems the patch of > "DRILL-3581: Upgrade HPPC to 0.7.1" is the cause of broken query > profiles [1]. The query profile on the commits before DRILL-3581 > looks fine. > [1] > https://github.com/apache/drill/commit/d27127c94d5c08306697a5627a1bac5f144abb22 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DRILL-4384) Query profile is missing important information on WebUi
[ https://issues.apache.org/jira/browse/DRILL-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157736#comment-15157736 ] Jinfeng Ni commented on DRILL-4384: --- Applied the patches on the master branch. Run a query and check the query profile. The query profile looks fine now. +1. On a side note, it would be good if we could add some sort of test, either in unit test, or the pre-commit test suite, to ensure the query profile is generated correctly. For now, seems such verification is missing, while the query profile plays an important role to help analyze Drill's performance issue. Without the automatic test, it's hard to track whether there is a regression. > Query profile is missing important information on WebUi > --- > > Key: DRILL-4384 > URL: https://issues.apache.org/jira/browse/DRILL-4384 > Project: Apache Drill > Issue Type: Bug >Reporter: Jinfeng Ni >Assignee: Jinfeng Ni > Fix For: 1.6.0 > > Attachments: DRILL-4384.patch > > > Built drill from master branch (0a2518d7cf01a92a27a82e29edac5424bedf31d5) and > started in embedded mode. Then, > run a query and checked the query profile through WebUI. However, > seems that the fragment profiles , operator profiles and visualized > plan sections are all empty. Tried both Mac and CentOS and hit the same > problem. > After doing a binary search over recent commits, seems the patch of > "DRILL-3581: Upgrade HPPC to 0.7.1" is the cause of broken query > profiles [1]. The query profile on the commits before DRILL-3581 > looks fine. > [1] > https://github.com/apache/drill/commit/d27127c94d5c08306697a5627a1bac5f144abb22 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DRILL-4384) Query profile is missing important information on WebUi
[ https://issues.apache.org/jira/browse/DRILL-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15156150#comment-15156150 ] Jacques Nadeau commented on DRILL-4384: --- Issue had to do with incorrect changes in how HPPC exposes open iterations. Cleaner approach is to use functional iteration. > Query profile is missing important information on WebUi > --- > > Key: DRILL-4384 > URL: https://issues.apache.org/jira/browse/DRILL-4384 > Project: Apache Drill > Issue Type: Bug >Reporter: Jinfeng Ni >Assignee: Jinfeng Ni > Fix For: 1.6.0 > > Attachments: DRILL-4384.patch > > > Built drill from master branch (0a2518d7cf01a92a27a82e29edac5424bedf31d5) and > started in embedded mode. Then, > run a query and checked the query profile through WebUI. However, > seems that the fragment profiles , operator profiles and visualized > plan sections are all empty. Tried both Mac and CentOS and hit the same > problem. > After doing a binary search over recent commits, seems the patch of > "DRILL-3581: Upgrade HPPC to 0.7.1" is the cause of broken query > profiles [1]. The query profile on the commits before DRILL-3581 > looks fine. > [1] > https://github.com/apache/drill/commit/d27127c94d5c08306697a5627a1bac5f144abb22 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
