[jira] [Commented] (DRILL-4416) Quote path separator for windows

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/DRILL-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951354#comment-16951354
 ] 

ASF GitHub Bot commented on DRILL-4416:
---

arina-ielchiieva commented on pull request #385: DRILL-4416: quote path 
separator for cross platform compatibility
URL: https://github.com/apache/drill/pull/385
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Quote path separator for windows
> 
>
> Key: DRILL-4416
> URL: https://issues.apache.org/jira/browse/DRILL-4416
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Hanifi Gunes
>Assignee: Hanifi Gunes
>Priority: Major
>
> Windows uses backslash as its path separator. We need to do string 
> manipulation using the separator during which the separator must be quoted. 
> This issue proposes (i) creating a global static path separator variable in 
> common and (ii) removing all others and (iii) using quoted separator where 
> need be.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (DRILL-4416) Quote path separator for windows

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/DRILL-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951344#comment-16951344
 ] 

ASF GitHub Bot commented on DRILL-4416:
---

arina-ielchiieva commented on issue #385: DRILL-4416: quote path separator for 
cross platform compatibility
URL: https://github.com/apache/drill/pull/385#issuecomment-541909702
 
 
   Closing since PR is outdated.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Quote path separator for windows
> 
>
> Key: DRILL-4416
> URL: https://issues.apache.org/jira/browse/DRILL-4416
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Hanifi Gunes
>Assignee: Hanifi Gunes
>Priority: Major
> Fix For: Future
>
>
> Windows uses backslash as its path separator. We need to do string 
> manipulation using the separator during which the separator must be quoted. 
> This issue proposes (i) creating a global static path separator variable in 
> common and (ii) removing all others and (iii) using quoted separator where 
> need be.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (DRILL-4416) Quote path separator for windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887349#comment-16887349
 ] 

ASF GitHub Bot commented on DRILL-4416:
---

vvysotskyi commented on pull request #385: DRILL-4416: quote path separator for 
cross platform compatibility
URL: https://github.com/apache/drill/pull/385#discussion_r304594338
 
 

 ##
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java
 ##
 @@ -194,7 +193,7 @@ private static String commonPathForFiles(final 
List files) {
 int shortest = Integer.MAX_VALUE;
 for (int i = 0; i < total; i++) {
   final Path path = new Path(files.get(i));
-  folders[i] = 
Path.getPathWithoutSchemeAndAuthority(path).toString().split(PATH_SEPARATOR);
+  folders[i] = 
Path.getPathWithoutSchemeAndAuthority(path).toString().split(FileUtils.PATH_SEPARATOR_QUOTED);
 
 Review comment:
   I don't think that `PATH_SEPARATOR_QUOTED` should be used there since 
`org.apache.hadoop.fs.Path` was used which should use `/` separator 
independently on the system.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Quote path separator for windows
> 
>
> Key: DRILL-4416
> URL: https://issues.apache.org/jira/browse/DRILL-4416
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Hanifi Gunes
>Assignee: Hanifi Gunes
>Priority: Major
> Fix For: Future
>
>
> Windows uses backslash as its path separator. We need to do string 
> manipulation using the separator during which the separator must be quoted. 
> This issue proposes (i) creating a global static path separator variable in 
> common and (ii) removing all others and (iii) using quoted separator where 
> need be.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (DRILL-4416) Quote path separator for windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498305#comment-16498305
 ] 

ASF GitHub Bot commented on DRILL-4416:
---

ilooner commented on issue #385: DRILL-4416: quote path separator for cross 
platform compatibility
URL: https://github.com/apache/drill/pull/385#issuecomment-393953890
 
 
   @hnfgns Are you free to wrap this up?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Quote path separator for windows
> 
>
> Key: DRILL-4416
> URL: https://issues.apache.org/jira/browse/DRILL-4416
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Hanifi Gunes
>Assignee: Hanifi Gunes
>Priority: Major
> Fix For: Future
>
>
> Windows uses backslash as its path separator. We need to do string 
> manipulation using the separator during which the separator must be quoted. 
> This issue proposes (i) creating a global static path separator variable in 
> common and (ii) removing all others and (iii) using quoted separator where 
> need be.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-4416) Quote path separator for windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15179210#comment-15179210
 ] 

ASF GitHub Bot commented on DRILL-4416:
---

Github user hnfgns commented on the pull request:

https://github.com/apache/drill/pull/385#issuecomment-192074959
  
This patch causes a random leak. I am backing it off for a while.


> Quote path separator for windows
> 
>
> Key: DRILL-4416
> URL: https://issues.apache.org/jira/browse/DRILL-4416
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Hanifi Gunes
>Assignee: Hanifi Gunes
> Fix For: 1.7.0
>
>
> Windows uses backslash as its path separator. We need to do string 
> manipulation using the separator during which the separator must be quoted. 
> This issue proposes (i) creating a global static path separator variable in 
> common and (ii) removing all others and (iii) using quoted separator where 
> need be.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DRILL-4416) Quote path separator for windows

[Deneche A. Hakim (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155881#comment-15155881
 ] 

Deneche A. Hakim commented on DRILL-4416:
-

DRILL-4305 is quite likely the same issue fixed by DRILL-4416

> Quote path separator for windows
> 
>
> Key: DRILL-4416
> URL: https://issues.apache.org/jira/browse/DRILL-4416
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Hanifi Gunes
>Assignee: Hanifi Gunes
>
> Windows uses backslash as its path separator. We need to do string 
> manipulation using the separator during which the separator must be quoted. 
> This issue proposes (i) creating a global static path separator variable in 
> common and (ii) removing all others and (iii) using quoted separator where 
> need be.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DRILL-4416) Quote path separator for windows

[Deneche A. Hakim (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155880#comment-15155880
 ] 

Deneche A. Hakim commented on DRILL-4416:
-

This looks indeed similar. Marking DRILL-4305 as duplicate to this one

> Quote path separator for windows
> 
>
> Key: DRILL-4416
> URL: https://issues.apache.org/jira/browse/DRILL-4416
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Hanifi Gunes
>Assignee: Hanifi Gunes
>
> Windows uses backslash as its path separator. We need to do string 
> manipulation using the separator during which the separator must be quoted. 
> This issue proposes (i) creating a global static path separator variable in 
> common and (ii) removing all others and (iii) using quoted separator where 
> need be.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DRILL-4416) Quote path separator for windows

[Zelaine Fong (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155240#comment-15155240
 ] 

Zelaine Fong commented on DRILL-4416:
-

Does this fix DRILL-4305?

> Quote path separator for windows
> 
>
> Key: DRILL-4416
> URL: https://issues.apache.org/jira/browse/DRILL-4416
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Hanifi Gunes
>Assignee: Deneche A. Hakim
>
> Windows uses backslash as its path separator. We need to do string 
> manipulation using the separator during which the separator must be quoted. 
> This issue proposes (i) creating a global static path separator variable in 
> common and (ii) removing all others and (iii) using quoted separator where 
> need be.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DRILL-4416) Quote path separator for windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155205#comment-15155205
 ] 

ASF GitHub Bot commented on DRILL-4416:
---

Github user adeneche commented on the pull request:

https://github.com/apache/drill/pull/385#issuecomment-186464365
  
+1, LGTM


> Quote path separator for windows
> 
>
> Key: DRILL-4416
> URL: https://issues.apache.org/jira/browse/DRILL-4416
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Hanifi Gunes
>Assignee: Deneche A. Hakim
>
> Windows uses backslash as its path separator. We need to do string 
> manipulation using the separator during which the separator must be quoted. 
> This issue proposes (i) creating a global static path separator variable in 
> common and (ii) removing all others and (iii) using quoted separator where 
> need be.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DRILL-4416) Quote path separator for windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155201#comment-15155201
 ] 

ASF GitHub Bot commented on DRILL-4416:
---

GitHub user hnfgns opened a pull request:

https://github.com/apache/drill/pull/385

DRILL-4416: quote path separator for cross platform compatibility



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hnfgns/incubator-drill DRILL-4416

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/385.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #385


commit 955cdc80413d7f66cfb50352974c13e346bad9e1
Author: Hanifi Gunes 
Date:   2016-02-20T00:23:08Z

DRILL-4416: quote path separator for cross platform compatibility




> Quote path separator for windows
> 
>
> Key: DRILL-4416
> URL: https://issues.apache.org/jira/browse/DRILL-4416
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Hanifi Gunes
>Assignee: Hanifi Gunes
>
> Windows us backslash as its path separator. We need to do string manipulation 
> using the separator during which the separator must be quoted. This issue 
> proposes (i) creating a global static path separator variable in common and 
> (ii) removing all others and (iii) using quoted separator where need be.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)