[jira] [Commented] (DRILL-4491) FormatPluginOptionsDescriptor requires FormatPluginConfig fields to be public

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-4491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186430#comment-15186430
 ] 

ASF GitHub Bot commented on DRILL-4491:
---

Github user adityakishore commented on the pull request:

https://github.com/apache/drill/pull/418#issuecomment-194097775
  
Until I looked at the code, I was under assumption that we are using 
Jackson to extract the serializable properties. We can, and should, definitely 
go that route.

The way code currently works is that it iterate through allthe table 
options and see if there is a Java field present in the corresponding 
FormatPluginConfig class. If it does find one, and this is why I say it is a 
bug in the current implementation, it makes is accessible 
(`setAccesible(true)`) implying that it is expected to work with non-public 
fields and sets the value to the one passed as parameter.


> FormatPluginOptionsDescriptor requires FormatPluginConfig fields to be public
> -
>
> Key: DRILL-4491
> URL: https://issues.apache.org/jira/browse/DRILL-4491
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Aditya Kishore
>Assignee: Aditya Kishore
>Priority: Minor
> Fix For: 1.7.0
>
>
> The code uses {{getField()}} instead of {{getDeclaredField()}}, which returns 
> only the public fields.
> {code:title=FormatPluginOptionsDescriptor.java:165|borderStyle=solid}
> Field field = pluginConfigClass.getField(paramDef.name);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DRILL-4491) FormatPluginOptionsDescriptor requires FormatPluginConfig fields to be public

[Aditya Kishore (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-4491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186425#comment-15186425
 ] 

Aditya Kishore commented on DRILL-4491:
---

Until I looked at the code, I was under assumption that we are using Jackson to 
extract the serializable properties. We can definitely go that route.

The way code currently work is that it iterate 

> FormatPluginOptionsDescriptor requires FormatPluginConfig fields to be public
> -
>
> Key: DRILL-4491
> URL: https://issues.apache.org/jira/browse/DRILL-4491
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Aditya Kishore
>Assignee: Aditya Kishore
>Priority: Minor
> Fix For: 1.7.0
>
>
> The code uses {{getField()}} instead of {{getDeclaredField()}}, which returns 
> only the public fields.
> {code:title=FormatPluginOptionsDescriptor.java:165|borderStyle=solid}
> Field field = pluginConfigClass.getField(paramDef.name);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DRILL-4491) FormatPluginOptionsDescriptor requires FormatPluginConfig fields to be public

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-4491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186220#comment-15186220
 ] 

ASF GitHub Bot commented on DRILL-4491:
---

GitHub user adityakishore opened a pull request:

https://github.com/apache/drill/pull/418

DRILL-4491: FormatPluginOptionsDescriptor requires FormatPluginConfig…

… fields to be public

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/adityakishore/drill DRILL-4491

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/418.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #418


commit cce8467c2476da871891bad7db6cab3236537f7c
Author: Aditya Kishore 
Date:   2016-03-09T00:49:55Z

DRILL-4491: FormatPluginOptionsDescriptor requires FormatPluginConfig 
fields to be public




> FormatPluginOptionsDescriptor requires FormatPluginConfig fields to be public
> -
>
> Key: DRILL-4491
> URL: https://issues.apache.org/jira/browse/DRILL-4491
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Aditya Kishore
>Assignee: Aditya Kishore
>Priority: Minor
> Fix For: 1.7.0
>
>
> The code uses {{getField()}} instead of {{getDeclaredField()}}, which returns 
> only the public fields.
> {code:title=FormatPluginOptionsDescriptor.java:165|borderStyle=solid}
> Field field = pluginConfigClass.getField(paramDef.name);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)