[jira] [Commented] (DRILL-4523) Disallow using loopback address in distributed mode
[
https://issues.apache.org/jira/browse/DRILL-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430053#comment-15430053
]
dengjie commented on DRILL-4523:
Test node does not have such a set, can be successfully started, but the
production node does not set on the start of failure.
> Disallow using loopback address in distributed mode
> ---
>
> Key: DRILL-4523
> URL: https://issues.apache.org/jira/browse/DRILL-4523
> Project: Apache Drill
> Issue Type: Improvement
> Components: Server
>Affects Versions: 1.6.0
>Reporter: Arina Ielchiieva
>Assignee: Arina Ielchiieva
> Fix For: 1.7.0
>
>
> If we enable debug for org.apache.drill.exec.coord.zk in logback.xml, we only
> get the hostname and ports information. For example:
> {code}
> 2015-11-04 19:47:02,927 [ServiceCache-0] DEBUG
> o.a.d.e.c.zk.ZKClusterCoordinator - Cache changed, updating.
> 2015-11-04 19:47:02,932 [ServiceCache-0] DEBUG
> o.a.d.e.c.zk.ZKClusterCoordinator - Active drillbit set changed. Now
> includes 2 total bits. New active drillbits:
> h3.poc.com:31010:31011:31012
> h2.poc.com:31010:31011:31012
> {code}
> We need to know the IP address of each hostname to do further troubleshooting.
> Imagine if any drillbit registers itself as "localhost.localdomain" in
> zookeeper, we will never know where it comes from. Enabling IP address
> tracking can help this case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DRILL-4523) Disallow using loopback address in distributed mode
[
https://issues.apache.org/jira/browse/DRILL-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393461#comment-15393461
]
ASF GitHub Bot commented on DRILL-4523:
---
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/445
@halevaavi
you might check your /etc/hosts file. There should be line like this:
172.16.21.16 your.domain.com your_hostname
> Disallow using loopback address in distributed mode
> ---
>
> Key: DRILL-4523
> URL: https://issues.apache.org/jira/browse/DRILL-4523
> Project: Apache Drill
> Issue Type: Improvement
> Components: Server
>Affects Versions: 1.6.0
>Reporter: Arina Ielchiieva
>Assignee: Arina Ielchiieva
> Fix For: 1.7.0
>
>
> If we enable debug for org.apache.drill.exec.coord.zk in logback.xml, we only
> get the hostname and ports information. For example:
> {code}
> 2015-11-04 19:47:02,927 [ServiceCache-0] DEBUG
> o.a.d.e.c.zk.ZKClusterCoordinator - Cache changed, updating.
> 2015-11-04 19:47:02,932 [ServiceCache-0] DEBUG
> o.a.d.e.c.zk.ZKClusterCoordinator - Active drillbit set changed. Now
> includes 2 total bits. New active drillbits:
> h3.poc.com:31010:31011:31012
> h2.poc.com:31010:31011:31012
> {code}
> We need to know the IP address of each hostname to do further troubleshooting.
> Imagine if any drillbit registers itself as "localhost.localdomain" in
> zookeeper, we will never know where it comes from. Enabling IP address
> tracking can help this case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DRILL-4523) Disallow using loopback address in distributed mode
[
https://issues.apache.org/jira/browse/DRILL-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393447#comment-15393447
]
ASF GitHub Bot commented on DRILL-4523:
---
Github user halevaavi commented on the issue:
https://github.com/apache/drill/pull/445
Where does drill takes the address. I've the following setup in
drill-overide.conf :
drill.exec: {
cluster-id: "drillbits1",
zk.connect: "172.16.21.16:2181"
}
172.16.21.16 is a single node that runs both zookeeper & drill and still
drillbit complains about running on the loopback address. Any idea why ?
> Disallow using loopback address in distributed mode
> ---
>
> Key: DRILL-4523
> URL: https://issues.apache.org/jira/browse/DRILL-4523
> Project: Apache Drill
> Issue Type: Improvement
> Components: Server
>Affects Versions: 1.6.0
>Reporter: Arina Ielchiieva
>Assignee: Arina Ielchiieva
> Fix For: 1.7.0
>
>
> If we enable debug for org.apache.drill.exec.coord.zk in logback.xml, we only
> get the hostname and ports information. For example:
> {code}
> 2015-11-04 19:47:02,927 [ServiceCache-0] DEBUG
> o.a.d.e.c.zk.ZKClusterCoordinator - Cache changed, updating.
> 2015-11-04 19:47:02,932 [ServiceCache-0] DEBUG
> o.a.d.e.c.zk.ZKClusterCoordinator - Active drillbit set changed. Now
> includes 2 total bits. New active drillbits:
> h3.poc.com:31010:31011:31012
> h2.poc.com:31010:31011:31012
> {code}
> We need to know the IP address of each hostname to do further troubleshooting.
> Imagine if any drillbit registers itself as "localhost.localdomain" in
> zookeeper, we will never know where it comes from. Enabling IP address
> tracking can help this case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DRILL-4523) Disallow using loopback address in distributed mode
[
https://issues.apache.org/jira/browse/DRILL-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229459#comment-15229459
]
ASF GitHub Bot commented on DRILL-4523:
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/445
> Disallow using loopback address in distributed mode
> ---
>
> Key: DRILL-4523
> URL: https://issues.apache.org/jira/browse/DRILL-4523
> Project: Apache Drill
> Issue Type: Improvement
> Components: Server
>Affects Versions: 1.6.0
>Reporter: Arina Ielchiieva
>Assignee: Arina Ielchiieva
> Fix For: 1.7.0
>
>
> If we enable debug for org.apache.drill.exec.coord.zk in logback.xml, we only
> get the hostname and ports information. For example:
> {code}
> 2015-11-04 19:47:02,927 [ServiceCache-0] DEBUG
> o.a.d.e.c.zk.ZKClusterCoordinator - Cache changed, updating.
> 2015-11-04 19:47:02,932 [ServiceCache-0] DEBUG
> o.a.d.e.c.zk.ZKClusterCoordinator - Active drillbit set changed. Now
> includes 2 total bits. New active drillbits:
> h3.poc.com:31010:31011:31012
> h2.poc.com:31010:31011:31012
> {code}
> We need to know the IP address of each hostname to do further troubleshooting.
> Imagine if any drillbit registers itself as "localhost.localdomain" in
> zookeeper, we will never know where it comes from. Enabling IP address
> tracking can help this case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DRILL-4523) Disallow using loopback address in distributed mode
[
https://issues.apache.org/jira/browse/DRILL-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228261#comment-15228261
]
ASF GitHub Bot commented on DRILL-4523:
---
Github user arina-ielchiieva commented on the pull request:
https://github.com/apache/drill/pull/445#issuecomment-206378459
1. Updated host file so hostname points to the localhost address:
a. started Drill in embedded mode -> started successfully.
b. started drillbit in distributed mode -> expected error.
2. Updated host file so hostname points to the actual IP:
a. started Drill in embedded mode -> started successfully.
b. started drillbit in distributed mode -> started successfully.
> Disallow using loopback address in distributed mode
> ---
>
> Key: DRILL-4523
> URL: https://issues.apache.org/jira/browse/DRILL-4523
> Project: Apache Drill
> Issue Type: Improvement
> Components: Server
>Affects Versions: 1.6.0
>Reporter: Arina Ielchiieva
>Assignee: Arina Ielchiieva
> Fix For: 1.7.0
>
>
> If we enable debug for org.apache.drill.exec.coord.zk in logback.xml, we only
> get the hostname and ports information. For example:
> {code}
> 2015-11-04 19:47:02,927 [ServiceCache-0] DEBUG
> o.a.d.e.c.zk.ZKClusterCoordinator - Cache changed, updating.
> 2015-11-04 19:47:02,932 [ServiceCache-0] DEBUG
> o.a.d.e.c.zk.ZKClusterCoordinator - Active drillbit set changed. Now
> includes 2 total bits. New active drillbits:
> h3.poc.com:31010:31011:31012
> h2.poc.com:31010:31011:31012
> {code}
> We need to know the IP address of each hostname to do further troubleshooting.
> Imagine if any drillbit registers itself as "localhost.localdomain" in
> zookeeper, we will never know where it comes from. Enabling IP address
> tracking can help this case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DRILL-4523) Disallow using loopback address in distributed mode
[
https://issues.apache.org/jira/browse/DRILL-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15226904#comment-15226904
]
ASF GitHub Bot commented on DRILL-4523:
---
Github user sudheeshkatkam commented on the pull request:
https://github.com/apache/drill/pull/445#issuecomment-205945078
+1
How did you test this?
> Disallow using loopback address in distributed mode
> ---
>
> Key: DRILL-4523
> URL: https://issues.apache.org/jira/browse/DRILL-4523
> Project: Apache Drill
> Issue Type: Improvement
> Components: Server
>Affects Versions: 1.6.0
>Reporter: Arina Ielchiieva
>Assignee: Arina Ielchiieva
> Fix For: 1.7.0
>
>
> If we enable debug for org.apache.drill.exec.coord.zk in logback.xml, we only
> get the hostname and ports information. For example:
> {code}
> 2015-11-04 19:47:02,927 [ServiceCache-0] DEBUG
> o.a.d.e.c.zk.ZKClusterCoordinator - Cache changed, updating.
> 2015-11-04 19:47:02,932 [ServiceCache-0] DEBUG
> o.a.d.e.c.zk.ZKClusterCoordinator - Active drillbit set changed. Now
> includes 2 total bits. New active drillbits:
> h3.poc.com:31010:31011:31012
> h2.poc.com:31010:31011:31012
> {code}
> We need to know the IP address of each hostname to do further troubleshooting.
> Imagine if any drillbit registers itself as "localhost.localdomain" in
> zookeeper, we will never know where it comes from. Enabling IP address
> tracking can help this case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DRILL-4523) Disallow using loopback address in distributed mode
[
https://issues.apache.org/jira/browse/DRILL-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225921#comment-15225921
]
ASF GitHub Bot commented on DRILL-4523:
---
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/445#discussion_r58505187
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java
---
@@ -177,6 +182,13 @@ public void run() {
});
}
+ /** If in distributed mode, disallow using loopback address to register
new drillbit. */
+ private void checkLoopbackAddress(String address) throws
DrillbitStartupException, UnknownHostException {
+if (isDistributedMode &&
InetAddress.getByName(address).isLoopbackAddress()) {
+ throw new DrillbitStartupException("Loopback address is not allowed
to be registered in distributed mode");
--- End diff --
Sounds reasonable. Updated PR.
> Disallow using loopback address in distributed mode
> ---
>
> Key: DRILL-4523
> URL: https://issues.apache.org/jira/browse/DRILL-4523
> Project: Apache Drill
> Issue Type: Improvement
> Components: Server
>Affects Versions: 1.6.0
>Reporter: Arina Ielchiieva
>Assignee: Arina Ielchiieva
> Fix For: 1.7.0
>
>
> If we enable debug for org.apache.drill.exec.coord.zk in logback.xml, we only
> get the hostname and ports information. For example:
> {code}
> 2015-11-04 19:47:02,927 [ServiceCache-0] DEBUG
> o.a.d.e.c.zk.ZKClusterCoordinator - Cache changed, updating.
> 2015-11-04 19:47:02,932 [ServiceCache-0] DEBUG
> o.a.d.e.c.zk.ZKClusterCoordinator - Active drillbit set changed. Now
> includes 2 total bits. New active drillbits:
> h3.poc.com:31010:31011:31012
> h2.poc.com:31010:31011:31012
> {code}
> We need to know the IP address of each hostname to do further troubleshooting.
> Imagine if any drillbit registers itself as "localhost.localdomain" in
> zookeeper, we will never know where it comes from. Enabling IP address
> tracking can help this case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DRILL-4523) Disallow using loopback address in distributed mode
[
https://issues.apache.org/jira/browse/DRILL-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225919#comment-15225919
]
ASF GitHub Bot commented on DRILL-4523:
---
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/445#discussion_r58505168
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java
---
@@ -177,6 +182,13 @@ public void run() {
});
}
+ /** If in distributed mode, disallow using loopback address to register
new drillbit. */
+ private void checkLoopbackAddress(String address) throws
DrillbitStartupException, UnknownHostException {
+if (isDistributedMode &&
InetAddress.getByName(address).isLoopbackAddress()) {
+ throw new DrillbitStartupException("Loopback address is not allowed
to be registered in distributed mode");
--- End diff --
Sounds reasonable. Updated PR.
> Disallow using loopback address in distributed mode
> ---
>
> Key: DRILL-4523
> URL: https://issues.apache.org/jira/browse/DRILL-4523
> Project: Apache Drill
> Issue Type: Improvement
> Components: Server
>Affects Versions: 1.6.0
>Reporter: Arina Ielchiieva
>Assignee: Arina Ielchiieva
> Fix For: 1.7.0
>
>
> If we enable debug for org.apache.drill.exec.coord.zk in logback.xml, we only
> get the hostname and ports information. For example:
> {code}
> 2015-11-04 19:47:02,927 [ServiceCache-0] DEBUG
> o.a.d.e.c.zk.ZKClusterCoordinator - Cache changed, updating.
> 2015-11-04 19:47:02,932 [ServiceCache-0] DEBUG
> o.a.d.e.c.zk.ZKClusterCoordinator - Active drillbit set changed. Now
> includes 2 total bits. New active drillbits:
> h3.poc.com:31010:31011:31012
> h2.poc.com:31010:31011:31012
> {code}
> We need to know the IP address of each hostname to do further troubleshooting.
> Imagine if any drillbit registers itself as "localhost.localdomain" in
> zookeeper, we will never know where it comes from. Enabling IP address
> tracking can help this case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DRILL-4523) Disallow using loopback address in distributed mode
[
https://issues.apache.org/jira/browse/DRILL-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225633#comment-15225633
]
ASF GitHub Bot commented on DRILL-4523:
---
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/445#discussion_r58483415
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java
---
@@ -177,6 +182,13 @@ public void run() {
});
}
+ /** If in distributed mode, disallow using loopback address to register
new drillbit. */
+ private void checkLoopbackAddress(String address) throws
DrillbitStartupException, UnknownHostException {
+if (isDistributedMode &&
InetAddress.getByName(address).isLoopbackAddress()) {
+ throw new DrillbitStartupException("Loopback address is not allowed
to be registered in distributed mode");
--- End diff --
How about "Drillbit is disallowed to bind to loopback address in
distributed mode."?
> Disallow using loopback address in distributed mode
> ---
>
> Key: DRILL-4523
> URL: https://issues.apache.org/jira/browse/DRILL-4523
> Project: Apache Drill
> Issue Type: Improvement
> Components: Server
>Affects Versions: 1.6.0
>Reporter: Arina Ielchiieva
>Assignee: Arina Ielchiieva
> Fix For: 1.7.0
>
>
> If we enable debug for org.apache.drill.exec.coord.zk in logback.xml, we only
> get the hostname and ports information. For example:
> {code}
> 2015-11-04 19:47:02,927 [ServiceCache-0] DEBUG
> o.a.d.e.c.zk.ZKClusterCoordinator - Cache changed, updating.
> 2015-11-04 19:47:02,932 [ServiceCache-0] DEBUG
> o.a.d.e.c.zk.ZKClusterCoordinator - Active drillbit set changed. Now
> includes 2 total bits. New active drillbits:
> h3.poc.com:31010:31011:31012
> h2.poc.com:31010:31011:31012
> {code}
> We need to know the IP address of each hostname to do further troubleshooting.
> Imagine if any drillbit registers itself as "localhost.localdomain" in
> zookeeper, we will never know where it comes from. Enabling IP address
> tracking can help this case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DRILL-4523) Disallow using loopback address in distributed mode
[
https://issues.apache.org/jira/browse/DRILL-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15223939#comment-15223939
]
ASF GitHub Bot commented on DRILL-4523:
---
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/445#discussion_r58358260
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java
---
@@ -177,6 +182,18 @@ public void run() {
});
}
+ /** If we are in distributed mode, disallow using loopback address to
register new drillbit
+ * unless zookeeper is on the same node with drillbit. */
+ private void checkLoopbackAddress(String address) throws
DrillbitStartupException, UnknownHostException {
+if (isDistributedMode) {
+ String coordAddress =
StringUtils.substringBefore(config.getString(ExecConstants.ZK_CONNECTION), ":");
+ if (!InetAddress.getByName(coordAddress).isLoopbackAddress()
--- End diff --
At some point, we wanted to allow loopback only if we have one node only
but it's much safer to disallow loopback in distributed mode at all. Updated
pull request.
> Disallow using loopback address in distributed mode
> ---
>
> Key: DRILL-4523
> URL: https://issues.apache.org/jira/browse/DRILL-4523
> Project: Apache Drill
> Issue Type: Improvement
> Components: Server
>Affects Versions: 1.6.0
>Reporter: Arina Ielchiieva
>Assignee: Arina Ielchiieva
> Fix For: 1.7.0
>
>
> If we enable debug for org.apache.drill.exec.coord.zk in logback.xml, we only
> get the hostname and ports information. For example:
> {code}
> 2015-11-04 19:47:02,927 [ServiceCache-0] DEBUG
> o.a.d.e.c.zk.ZKClusterCoordinator - Cache changed, updating.
> 2015-11-04 19:47:02,932 [ServiceCache-0] DEBUG
> o.a.d.e.c.zk.ZKClusterCoordinator - Active drillbit set changed. Now
> includes 2 total bits. New active drillbits:
> h3.poc.com:31010:31011:31012
> h2.poc.com:31010:31011:31012
> {code}
> We need to know the IP address of each hostname to do further troubleshooting.
> Imagine if any drillbit registers itself as "localhost.localdomain" in
> zookeeper, we will never know where it comes from. Enabling IP address
> tracking can help this case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DRILL-4523) Disallow using loopback address in distributed mode
[
https://issues.apache.org/jira/browse/DRILL-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221978#comment-15221978
]
ASF GitHub Bot commented on DRILL-4523:
---
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/445#discussion_r58234800
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java
---
@@ -177,6 +182,18 @@ public void run() {
});
}
+ /** If we are in distributed mode, disallow using loopback address to
register new drillbit
+ * unless zookeeper is on the same node with drillbit. */
+ private void checkLoopbackAddress(String address) throws
DrillbitStartupException, UnknownHostException {
+if (isDistributedMode) {
+ String coordAddress =
StringUtils.substringBefore(config.getString(ExecConstants.ZK_CONNECTION), ":");
+ if (!InetAddress.getByName(coordAddress).isLoopbackAddress()
--- End diff --
In distributed mode, no bit should be allowed to register with a loopback
address.
If bit A is allowed to register with a loopback address and bit B tries to
communicate with bit A, bit B would be sending messages to itself.
> Disallow using loopback address in distributed mode
> ---
>
> Key: DRILL-4523
> URL: https://issues.apache.org/jira/browse/DRILL-4523
> Project: Apache Drill
> Issue Type: Improvement
> Components: Server
>Affects Versions: 1.6.0
>Reporter: Arina Ielchiieva
>Assignee: Arina Ielchiieva
> Fix For: 1.7.0
>
>
> If we enable debug for org.apache.drill.exec.coord.zk in logback.xml, we only
> get the hostname and ports information. For example:
> {code}
> 2015-11-04 19:47:02,927 [ServiceCache-0] DEBUG
> o.a.d.e.c.zk.ZKClusterCoordinator - Cache changed, updating.
> 2015-11-04 19:47:02,932 [ServiceCache-0] DEBUG
> o.a.d.e.c.zk.ZKClusterCoordinator - Active drillbit set changed. Now
> includes 2 total bits. New active drillbits:
> h3.poc.com:31010:31011:31012
> h2.poc.com:31010:31011:31012
> {code}
> We need to know the IP address of each hostname to do further troubleshooting.
> Imagine if any drillbit registers itself as "localhost.localdomain" in
> zookeeper, we will never know where it comes from. Enabling IP address
> tracking can help this case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DRILL-4523) Disallow using loopback address in distributed mode
[
https://issues.apache.org/jira/browse/DRILL-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221613#comment-15221613
]
ASF GitHub Bot commented on DRILL-4523:
---
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/445#discussion_r58196652
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java
---
@@ -177,6 +180,16 @@ public void run() {
});
}
+ /** If we are in distributed mode, disallow using loopback address to
register new drillbit
+ * unless zookeeper is on the same node with drillbit. */
+ private void checkLoopbackAddress(String address) throws
DrillbitStartupException, UnknownHostException {
+String coordAddress =
StringUtils.substringBefore(config.getString(ExecConstants.ZK_CONNECTION), ":");
--- End diff --
Your comment, made me realize that I was wrong assuming that in embedded
mode zookeeper address will be localhost. Actually it will be the same as set
in config. So I have passed flag to ServiceEngine class so we know in which
mode drill. Pull request was updated.
> Disallow using loopback address in distributed mode
> ---
>
> Key: DRILL-4523
> URL: https://issues.apache.org/jira/browse/DRILL-4523
> Project: Apache Drill
> Issue Type: Improvement
> Components: Server
>Affects Versions: 1.6.0
>Reporter: Arina Ielchiieva
>Assignee: Arina Ielchiieva
> Fix For: 1.7.0
>
>
> If we enable debug for org.apache.drill.exec.coord.zk in logback.xml, we only
> get the hostname and ports information. For example:
> {code}
> 2015-11-04 19:47:02,927 [ServiceCache-0] DEBUG
> o.a.d.e.c.zk.ZKClusterCoordinator - Cache changed, updating.
> 2015-11-04 19:47:02,932 [ServiceCache-0] DEBUG
> o.a.d.e.c.zk.ZKClusterCoordinator - Active drillbit set changed. Now
> includes 2 total bits. New active drillbits:
> h3.poc.com:31010:31011:31012
> h2.poc.com:31010:31011:31012
> {code}
> We need to know the IP address of each hostname to do further troubleshooting.
> Imagine if any drillbit registers itself as "localhost.localdomain" in
> zookeeper, we will never know where it comes from. Enabling IP address
> tracking can help this case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DRILL-4523) Disallow using loopback address in distributed mode
[
https://issues.apache.org/jira/browse/DRILL-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220696#comment-15220696
]
ASF GitHub Bot commented on DRILL-4523:
---
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/445#discussion_r58130327
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java
---
@@ -177,6 +180,16 @@ public void run() {
});
}
+ /** If we are in distributed mode, disallow using loopback address to
register new drillbit
+ * unless zookeeper is on the same node with drillbit. */
+ private void checkLoopbackAddress(String address) throws
DrillbitStartupException, UnknownHostException {
+String coordAddress =
StringUtils.substringBefore(config.getString(ExecConstants.ZK_CONNECTION), ":");
--- End diff --
At this point, how do you know you're in distributed and not embedded mode?
> Disallow using loopback address in distributed mode
> ---
>
> Key: DRILL-4523
> URL: https://issues.apache.org/jira/browse/DRILL-4523
> Project: Apache Drill
> Issue Type: Improvement
> Components: Server
>Affects Versions: 1.6.0
>Reporter: Arina Ielchiieva
>Assignee: Arina Ielchiieva
> Fix For: 1.7.0
>
>
> If we enable debug for org.apache.drill.exec.coord.zk in logback.xml, we only
> get the hostname and ports information. For example:
> {code}
> 2015-11-04 19:47:02,927 [ServiceCache-0] DEBUG
> o.a.d.e.c.zk.ZKClusterCoordinator - Cache changed, updating.
> 2015-11-04 19:47:02,932 [ServiceCache-0] DEBUG
> o.a.d.e.c.zk.ZKClusterCoordinator - Active drillbit set changed. Now
> includes 2 total bits. New active drillbits:
> h3.poc.com:31010:31011:31012
> h2.poc.com:31010:31011:31012
> {code}
> We need to know the IP address of each hostname to do further troubleshooting.
> Imagine if any drillbit registers itself as "localhost.localdomain" in
> zookeeper, we will never know where it comes from. Enabling IP address
> tracking can help this case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DRILL-4523) Disallow using loopback address in distributed mode
[
https://issues.apache.org/jira/browse/DRILL-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212215#comment-15212215
]
ASF GitHub Bot commented on DRILL-4523:
---
GitHub user arina-ielchiieva opened a pull request:
https://github.com/apache/drill/pull/445
DRILL-4523: Disallow using loopback address in distributed mode
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arina-ielchiieva/drill DRILL-4523
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/445.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #445
commit 3b79bae5a2534335479ca44a9180567b3ac01549
Author: Arina Ielchiieva
Date: 2016-03-24T16:46:06Z
DRILL-4523: Disallow using loopback address in distributed mode
> Disallow using loopback address in distributed mode
> ---
>
> Key: DRILL-4523
> URL: https://issues.apache.org/jira/browse/DRILL-4523
> Project: Apache Drill
> Issue Type: Improvement
> Components: Server
>Affects Versions: 1.6.0
>Reporter: Arina Ielchiieva
>Assignee: Arina Ielchiieva
> Fix For: 1.7.0
>
>
> If we enable debug for org.apache.drill.exec.coord.zk in logback.xml, we only
> get the hostname and ports information. For example:
> {code}
> 2015-11-04 19:47:02,927 [ServiceCache-0] DEBUG
> o.a.d.e.c.zk.ZKClusterCoordinator - Cache changed, updating.
> 2015-11-04 19:47:02,932 [ServiceCache-0] DEBUG
> o.a.d.e.c.zk.ZKClusterCoordinator - Active drillbit set changed. Now
> includes 2 total bits. New active drillbits:
> h3.poc.com:31010:31011:31012
> h2.poc.com:31010:31011:31012
> {code}
> We need to know the IP address of each hostname to do further troubleshooting.
> Imagine if any drillbit registers itself as "localhost.localdomain" in
> zookeeper, we will never know where it comes from. Enabling IP address
> tracking can help this case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
