[jira] [Commented] (DRILL-4979) Make dataport configurable
[ https://issues.apache.org/jira/browse/DRILL-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691683#comment-15691683 ] ASF GitHub Bot commented on DRILL-4979: --- Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/649 > Make dataport configurable > -- > > Key: DRILL-4979 > URL: https://issues.apache.org/jira/browse/DRILL-4979 > Project: Apache Drill > Issue Type: New Feature > Components: Server >Affects Versions: 1.8.0 > Environment: Scheduling drillbits with Apache Mesos+Aurora >Reporter: Uwe L. Korn > Labels: ready-to-commit > > Currently the dataport of a Drillbit is fixed to +1 on the control port. In a > dynamic execution environment like Apache Mesos+Aurora, each port is > allocated by the scheduler and then passed on to the application process. > There is no possibility or guarantee to allocate two consecutive ports. > Therefore, to run Drill in this environment, the dataport of the drillbit > also needs to configurable by the scheduler. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DRILL-4979) Make dataport configurable
[ https://issues.apache.org/jira/browse/DRILL-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691650#comment-15691650 ] ASF GitHub Bot commented on DRILL-4979: --- Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/649 +1 > Make dataport configurable > -- > > Key: DRILL-4979 > URL: https://issues.apache.org/jira/browse/DRILL-4979 > Project: Apache Drill > Issue Type: New Feature > Components: Server >Affects Versions: 1.8.0 > Environment: Scheduling drillbits with Apache Mesos+Aurora >Reporter: Uwe L. Korn > Labels: ready-to-commit > > Currently the dataport of a Drillbit is fixed to +1 on the control port. In a > dynamic execution environment like Apache Mesos+Aurora, each port is > allocated by the scheduler and then passed on to the application process. > There is no possibility or guarantee to allocate two consecutive ports. > Therefore, to run Drill in this environment, the dataport of the drillbit > also needs to configurable by the scheduler. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DRILL-4979) Make dataport configurable
[ https://issues.apache.org/jira/browse/DRILL-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15652032#comment-15652032 ] ASF GitHub Bot commented on DRILL-4979: --- Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/649 Thanks for the explanation. LGTM > Make dataport configurable > -- > > Key: DRILL-4979 > URL: https://issues.apache.org/jira/browse/DRILL-4979 > Project: Apache Drill > Issue Type: New Feature > Components: Server >Affects Versions: 1.8.0 > Environment: Scheduling drillbits with Apache Mesos+Aurora >Reporter: Uwe L. Korn > > Currently the dataport of a Drillbit is fixed to +1 on the control port. In a > dynamic execution environment like Apache Mesos+Aurora, each port is > allocated by the scheduler and then passed on to the application process. > There is no possibility or guarantee to allocate two consecutive ports. > Therefore, to run Drill in this environment, the dataport of the drillbit > also needs to configurable by the scheduler. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DRILL-4979) Make dataport configurable
[ https://issues.apache.org/jira/browse/DRILL-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651993#comment-15651993 ] ASF GitHub Bot commented on DRILL-4979: --- Github user xhochy commented on the issue: https://github.com/apache/drill/pull/649 No, this patch is actually functioning as the data port is already included in the probuf: https://github.com/apache/drill/blob/master/protocol/src/main/protobuf/Coordination.proto#L11 The `+1 logic` is only used in the initialization code for the port. Also I did a test run with 5 drillbits and random dataports assigned to them. They each were able to talk to them showing that the correct ports are communicated. > Make dataport configurable > -- > > Key: DRILL-4979 > URL: https://issues.apache.org/jira/browse/DRILL-4979 > Project: Apache Drill > Issue Type: New Feature > Components: Server >Affects Versions: 1.8.0 > Environment: Scheduling drillbits with Apache Mesos+Aurora >Reporter: Uwe L. Korn > > Currently the dataport of a Drillbit is fixed to +1 on the control port. In a > dynamic execution environment like Apache Mesos+Aurora, each port is > allocated by the scheduler and then passed on to the application process. > There is no possibility or guarantee to allocate two consecutive ports. > Therefore, to run Drill in this environment, the dataport of the drillbit > also needs to configurable by the scheduler. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DRILL-4979) Make dataport configurable
[ https://issues.apache.org/jira/browse/DRILL-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15617475#comment-15617475 ] Parth Chandra commented on DRILL-4979: -- This seems like a reasonable approach. (You can follow the pattern used for the control port in ControllerImpl.start() ) > Make dataport configurable > -- > > Key: DRILL-4979 > URL: https://issues.apache.org/jira/browse/DRILL-4979 > Project: Apache Drill > Issue Type: New Feature > Components: Server >Affects Versions: 1.8.0 > Environment: Scheduling drillbits with Apache Mesos+Aurora >Reporter: Uwe L. Korn > > Currently the dataport of a Drillbit is fixed to +1 on the control port. In a > dynamic execution environment like Apache Mesos+Aurora, each port is > allocated by the scheduler and then passed on to the application process. > There is no possibility or guarantee to allocate two consecutive ports. > Therefore, to run Drill in this environment, the dataport of the drillbit > also needs to configurable by the scheduler. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DRILL-4979) Make dataport configurable
[
https://issues.apache.org/jira/browse/DRILL-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614793#comment-15614793
]
Uwe L. Korn commented on DRILL-4979:
Implementation-wise it seems like the only point where the {{+1}} is actually
hardcoded is in
{{exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataConnectionCreator.java:62}},
i.e. {{int port = server.bind(partialEndpoint.getControlPort() + 1,
allowPortHunting)}}. Therefore a fix for this could be to introduce a new
configuration option {{drill.exec.rpc.bit.server.dataport}} and use this if
set, otherwise default back to {{controlport + 1}}.
> Make dataport configurable
> --
>
> Key: DRILL-4979
> URL: https://issues.apache.org/jira/browse/DRILL-4979
> Project: Apache Drill
> Issue Type: New Feature
> Components: Server
>Affects Versions: 1.8.0
> Environment: Scheduling drillbits with Apache Mesos+Aurora
>Reporter: Uwe L. Korn
>
> Currently the dataport of a Drillbit is fixed to +1 on the control port. In a
> dynamic execution environment like Apache Mesos+Aurora, each port is
> allocated by the scheduler and then passed on to the application process.
> There is no possibility or guarantee to allocate two consecutive ports.
> Therefore, to run Drill in this environment, the dataport of the drillbit
> also needs to configurable by the scheduler.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
