[jira] [Commented] (DRILL-5167) C++ connector does not set escape string for metadata search pattern
[ https://issues.apache.org/jira/browse/DRILL-5167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893655#comment-15893655 ] Sudheesh Katkam commented on DRILL-5167: Fixed in [c81f588|https://github.com/apache/drill/commit/c81f58884e2cef279a7d60ea611b6a422a2eb56e] > C++ connector does not set escape string for metadata search pattern > > > Key: DRILL-5167 > URL: https://issues.apache.org/jira/browse/DRILL-5167 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.9.0 >Reporter: Laurent Goujon >Assignee: Laurent Goujon >Priority: Minor > Labels: ready-to-commit > Fix For: 1.10.0 > > > C++ connector does not set the escape string for search pattern when doing > metadata operation (getCatalogs/getSchema/getTables/getColumns). It is > assumed to be '\\' as returned by DrillMetadata::getSearchEscapeString(), but > because this is not sent over the wire, the server will actually consider > that there's no escape character, and might return different or no result > compared to what has been requested. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DRILL-5167) C++ connector does not set escape string for metadata search pattern
[ https://issues.apache.org/jira/browse/DRILL-5167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892993#comment-15892993 ] ASF GitHub Bot commented on DRILL-5167: --- Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/712 > C++ connector does not set escape string for metadata search pattern > > > Key: DRILL-5167 > URL: https://issues.apache.org/jira/browse/DRILL-5167 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.9.0 >Reporter: Laurent Goujon >Assignee: Laurent Goujon >Priority: Minor > Labels: ready-to-commit > > C++ connector does not set the escape string for search pattern when doing > metadata operation (getCatalogs/getSchema/getTables/getColumns). It is > assumed to be '\\' as returned by DrillMetadata::getSearchEscapeString(), but > because this is not sent over the wire, the server will actually consider > that there's no escape character, and might return different or no result > compared to what has been requested. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DRILL-5167) C++ connector does not set escape string for metadata search pattern
[ https://issues.apache.org/jira/browse/DRILL-5167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886964#comment-15886964 ] ASF GitHub Bot commented on DRILL-5167: --- Github user vkorukanti commented on the issue: https://github.com/apache/drill/pull/712 +1 > C++ connector does not set escape string for metadata search pattern > > > Key: DRILL-5167 > URL: https://issues.apache.org/jira/browse/DRILL-5167 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.9.0 >Reporter: Laurent Goujon >Assignee: Laurent Goujon >Priority: Minor > > C++ connector does not set the escape string for search pattern when doing > metadata operation (getCatalogs/getSchema/getTables/getColumns). It is > assumed to be '\\' as returned by DrillMetadata::getSearchEscapeString(), but > because this is not sent over the wire, the server will actually consider > that there's no escape character, and might return different or no result > compared to what has been requested. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DRILL-5167) C++ connector does not set escape string for metadata search pattern
[ https://issues.apache.org/jira/browse/DRILL-5167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15784152#comment-15784152 ] ASF GitHub Bot commented on DRILL-5167: --- GitHub user laurentgo opened a pull request: https://github.com/apache/drill/pull/712 DRILL-5167: Send escape character for metadata queries Escape character was not sent when doing metadata queries, which caused the server to return incorrect results as the pattern is interpreted differently form what the user asked for. You can merge this pull request into a Git repository by running: $ git pull https://github.com/laurentgo/drill laurent/DRILL-5167 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/drill/pull/712.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #712 commit 8f0a01a4c589a7918b1c58e0285bfeb57a231ae1 Author: Laurent Goujon Date: 2016-12-29T01:03:37Z DRILL-5167: Send escape character for metadata queries Escape character was not sent when doing metadata queries, which caused the server to return incorrect results as the pattern is interpreted differently form what the user asked for. > C++ connector does not set escape string for metadata search pattern > > > Key: DRILL-5167 > URL: https://issues.apache.org/jira/browse/DRILL-5167 > Project: Apache Drill > Issue Type: Bug >Reporter: Laurent Goujon >Priority: Minor > > C++ connector does not set the escape string for search pattern when doing > metadata operation (getCatalogs/getSchema/getTables/getColumns). It is > assumed to be '\\' as returned by DrillMetadata::getSearchEscapeString(), but > because this is not sent over the wire, the server will actually consider > that there's no escape character, and might return different or no result > compared to what has been requested. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
