[jira] [Commented] (DRILL-5208) Finding path to java executable should be deterministic
[ https://issues.apache.org/jira/browse/DRILL-5208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895119#comment-15895119 ] ASF GitHub Bot commented on DRILL-5208: --- Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/763 > Finding path to java executable should be deterministic > --- > > Key: DRILL-5208 > URL: https://issues.apache.org/jira/browse/DRILL-5208 > Project: Apache Drill > Issue Type: Bug > Components: Tools, Build & Test >Affects Versions: 1.10.0 >Reporter: Krystal >Assignee: Paul Rogers >Priority: Minor > Labels: ready-to-commit > > Command to find JAVA in drill-config.sh is not deterministic. > drill-config.sh uses the following command to find JAVA: > JAVA=`find -L "$JAVA_HOME" -name $JAVA_BIN -type f | head -n 1` > On one of my node the following command returned 2 entries: > find -L $JAVA_HOME -name java -type f > /usr/local/java/jdk1.7.0_67/jre/bin/java > /usr/local/java/jdk1.7.0_67/bin/java > On another node, the same command returned entries in different order: > find -L $JAVA_HOME -name java -type f > /usr/local/java/jdk1.7.0_67/bin/java > /usr/local/java/jdk1.7.0_67/jre/bin/java > The complete command picks the first one returned which may not be the same > on each node: > find -L $JAVA_HOME -name java -type f | head -n 1 > /usr/local/java/jdk1.7.0_67/jre/bin/java > If JAVA_HOME is found, we should just append the "bin/java" to the path" > JAVA=$JAVA_HOME/bin/java -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DRILL-5208) Finding path to java executable should be deterministic
[ https://issues.apache.org/jira/browse/DRILL-5208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887769#comment-15887769 ] ASF GitHub Bot commented on DRILL-5208: --- Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/763 +1, looks good. > Finding path to java executable should be deterministic > --- > > Key: DRILL-5208 > URL: https://issues.apache.org/jira/browse/DRILL-5208 > Project: Apache Drill > Issue Type: Bug > Components: Tools, Build & Test >Affects Versions: 1.10.0 >Reporter: Krystal >Assignee: Paul Rogers >Priority: Minor > > Command to find JAVA in drill-config.sh is not deterministic. > drill-config.sh uses the following command to find JAVA: > JAVA=`find -L "$JAVA_HOME" -name $JAVA_BIN -type f | head -n 1` > On one of my node the following command returned 2 entries: > find -L $JAVA_HOME -name java -type f > /usr/local/java/jdk1.7.0_67/jre/bin/java > /usr/local/java/jdk1.7.0_67/bin/java > On another node, the same command returned entries in different order: > find -L $JAVA_HOME -name java -type f > /usr/local/java/jdk1.7.0_67/bin/java > /usr/local/java/jdk1.7.0_67/jre/bin/java > The complete command picks the first one returned which may not be the same > on each node: > find -L $JAVA_HOME -name java -type f | head -n 1 > /usr/local/java/jdk1.7.0_67/jre/bin/java > If JAVA_HOME is found, we should just append the "bin/java" to the path" > JAVA=$JAVA_HOME/bin/java -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DRILL-5208) Finding path to java executable should be deterministic
[ https://issues.apache.org/jira/browse/DRILL-5208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887708#comment-15887708 ] ASF GitHub Bot commented on DRILL-5208: --- Github user sudheeshkatkam commented on the issue: https://github.com/apache/drill/pull/763 Please squash the commits as well. > Finding path to java executable should be deterministic > --- > > Key: DRILL-5208 > URL: https://issues.apache.org/jira/browse/DRILL-5208 > Project: Apache Drill > Issue Type: Bug > Components: Tools, Build & Test >Affects Versions: 1.10.0 >Reporter: Krystal >Assignee: Paul Rogers >Priority: Minor > > Command to find JAVA in drill-config.sh is not deterministic. > drill-config.sh uses the following command to find JAVA: > JAVA=`find -L "$JAVA_HOME" -name $JAVA_BIN -type f | head -n 1` > On one of my node the following command returned 2 entries: > find -L $JAVA_HOME -name java -type f > /usr/local/java/jdk1.7.0_67/jre/bin/java > /usr/local/java/jdk1.7.0_67/bin/java > On another node, the same command returned entries in different order: > find -L $JAVA_HOME -name java -type f > /usr/local/java/jdk1.7.0_67/bin/java > /usr/local/java/jdk1.7.0_67/jre/bin/java > The complete command picks the first one returned which may not be the same > on each node: > find -L $JAVA_HOME -name java -type f | head -n 1 > /usr/local/java/jdk1.7.0_67/jre/bin/java > If JAVA_HOME is found, we should just append the "bin/java" to the path" > JAVA=$JAVA_HOME/bin/java -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DRILL-5208) Finding path to java executable should be deterministic
[ https://issues.apache.org/jira/browse/DRILL-5208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886619#comment-15886619 ] ASF GitHub Bot commented on DRILL-5208: --- Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/763 Adressed code review comments and rebased onto latest master. > Finding path to java executable should be deterministic > --- > > Key: DRILL-5208 > URL: https://issues.apache.org/jira/browse/DRILL-5208 > Project: Apache Drill > Issue Type: Bug > Components: Tools, Build & Test >Affects Versions: 1.10.0 >Reporter: Krystal >Assignee: Paul Rogers >Priority: Minor > > Command to find JAVA in drill-config.sh is not deterministic. > drill-config.sh uses the following command to find JAVA: > JAVA=`find -L "$JAVA_HOME" -name $JAVA_BIN -type f | head -n 1` > On one of my node the following command returned 2 entries: > find -L $JAVA_HOME -name java -type f > /usr/local/java/jdk1.7.0_67/jre/bin/java > /usr/local/java/jdk1.7.0_67/bin/java > On another node, the same command returned entries in different order: > find -L $JAVA_HOME -name java -type f > /usr/local/java/jdk1.7.0_67/bin/java > /usr/local/java/jdk1.7.0_67/jre/bin/java > The complete command picks the first one returned which may not be the same > on each node: > find -L $JAVA_HOME -name java -type f | head -n 1 > /usr/local/java/jdk1.7.0_67/jre/bin/java > If JAVA_HOME is found, we should just append the "bin/java" to the path" > JAVA=$JAVA_HOME/bin/java -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DRILL-5208) Finding path to java executable should be deterministic
[ https://issues.apache.org/jira/browse/DRILL-5208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15884829#comment-15884829 ] ASF GitHub Bot commented on DRILL-5208: --- Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/763#discussion_r103110976 --- Diff: distribution/src/resources/drill-config.sh --- @@ -359,6 +366,7 @@ if [ -z "$JAVA_HOME" ]; then [[ $SOURCE != /* ]] && SOURCE="$DIR/$SOURCE" done JAVA_HOME="$( cd -P "$( dirname "$SOURCE" )" && cd .. && pwd )" +JAVA = $SOURCE/$JAVA_BIN --- End diff -- $SOURCE already includes bin/java, so concatenating with $JAVA_BIN will give you: `/usr/lib/jvm/java-1.8.0-openjdk-1.8.0.111-1.b15.el7_2.x86_64/jre/bin/java/java`. I guess you should concatenate $JAVA_BIN to $SOURCE dirname. > Finding path to java executable should be deterministic > --- > > Key: DRILL-5208 > URL: https://issues.apache.org/jira/browse/DRILL-5208 > Project: Apache Drill > Issue Type: Bug > Components: Tools, Build & Test >Affects Versions: 1.10.0 >Reporter: Krystal >Assignee: Paul Rogers >Priority: Minor > > Command to find JAVA in drill-config.sh is not deterministic. > drill-config.sh uses the following command to find JAVA: > JAVA=`find -L "$JAVA_HOME" -name $JAVA_BIN -type f | head -n 1` > On one of my node the following command returned 2 entries: > find -L $JAVA_HOME -name java -type f > /usr/local/java/jdk1.7.0_67/jre/bin/java > /usr/local/java/jdk1.7.0_67/bin/java > On another node, the same command returned entries in different order: > find -L $JAVA_HOME -name java -type f > /usr/local/java/jdk1.7.0_67/bin/java > /usr/local/java/jdk1.7.0_67/jre/bin/java > The complete command picks the first one returned which may not be the same > on each node: > find -L $JAVA_HOME -name java -type f | head -n 1 > /usr/local/java/jdk1.7.0_67/jre/bin/java > If JAVA_HOME is found, we should just append the "bin/java" to the path" > JAVA=$JAVA_HOME/bin/java -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DRILL-5208) Finding path to java executable should be deterministic
[ https://issues.apache.org/jira/browse/DRILL-5208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15884828#comment-15884828 ] ASF GitHub Bot commented on DRILL-5208: --- Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/763#discussion_r103110888 --- Diff: distribution/src/resources/drill-config.sh --- @@ -367,12 +375,18 @@ if [ -z "$JAVA_HOME" ]; then fi # Now, verify that 'java' binary exists and is suitable for Drill. -if $is_cygwin; then - JAVA_BIN="java.exe" -else - JAVA_BIN="java" +# If we started with `which java` above, use that path (after replacing +# symlinks. If we started with JAVA_HOME, try in bin. Doing so handles --- End diff -- Close the brace. > Finding path to java executable should be deterministic > --- > > Key: DRILL-5208 > URL: https://issues.apache.org/jira/browse/DRILL-5208 > Project: Apache Drill > Issue Type: Bug > Components: Tools, Build & Test >Affects Versions: 1.10.0 >Reporter: Krystal >Assignee: Paul Rogers >Priority: Minor > > Command to find JAVA in drill-config.sh is not deterministic. > drill-config.sh uses the following command to find JAVA: > JAVA=`find -L "$JAVA_HOME" -name $JAVA_BIN -type f | head -n 1` > On one of my node the following command returned 2 entries: > find -L $JAVA_HOME -name java -type f > /usr/local/java/jdk1.7.0_67/jre/bin/java > /usr/local/java/jdk1.7.0_67/bin/java > On another node, the same command returned entries in different order: > find -L $JAVA_HOME -name java -type f > /usr/local/java/jdk1.7.0_67/bin/java > /usr/local/java/jdk1.7.0_67/jre/bin/java > The complete command picks the first one returned which may not be the same > on each node: > find -L $JAVA_HOME -name java -type f | head -n 1 > /usr/local/java/jdk1.7.0_67/jre/bin/java > If JAVA_HOME is found, we should just append the "bin/java" to the path" > JAVA=$JAVA_HOME/bin/java -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DRILL-5208) Finding path to java executable should be deterministic
[ https://issues.apache.org/jira/browse/DRILL-5208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15883804#comment-15883804 ] Paul Rogers commented on DRILL-5208: [~knguyen], when you get a 1.10 RC, please try your scenario again on your two machines (assuming that their Java setup has not changed.) > Finding path to java executable should be deterministic > --- > > Key: DRILL-5208 > URL: https://issues.apache.org/jira/browse/DRILL-5208 > Project: Apache Drill > Issue Type: Bug > Components: Tools, Build & Test >Affects Versions: 1.10.0 >Reporter: Krystal >Assignee: Paul Rogers >Priority: Minor > > Command to find JAVA in drill-config.sh is not deterministic. > drill-config.sh uses the following command to find JAVA: > JAVA=`find -L "$JAVA_HOME" -name $JAVA_BIN -type f | head -n 1` > On one of my node the following command returned 2 entries: > find -L $JAVA_HOME -name java -type f > /usr/local/java/jdk1.7.0_67/jre/bin/java > /usr/local/java/jdk1.7.0_67/bin/java > On another node, the same command returned entries in different order: > find -L $JAVA_HOME -name java -type f > /usr/local/java/jdk1.7.0_67/bin/java > /usr/local/java/jdk1.7.0_67/jre/bin/java > The complete command picks the first one returned which may not be the same > on each node: > find -L $JAVA_HOME -name java -type f | head -n 1 > /usr/local/java/jdk1.7.0_67/jre/bin/java > If JAVA_HOME is found, we should just append the "bin/java" to the path" > JAVA=$JAVA_HOME/bin/java -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DRILL-5208) Finding path to java executable should be deterministic
[ https://issues.apache.org/jira/browse/DRILL-5208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15883690#comment-15883690 ] Paul Rogers commented on DRILL-5208: Solution uses a more structured approach to finding the Java command. If a JAVA_HOME is provided, look in bin before using find. If no JAVA_HOME, but the java command is on the class path, then use that command (after resolving sym links) as the command. Only if these fail will we resort to using "find." This should ensure we use the JDK java when both a JDK and JRE exist in the same JAVA_HOME. > Finding path to java executable should be deterministic > --- > > Key: DRILL-5208 > URL: https://issues.apache.org/jira/browse/DRILL-5208 > Project: Apache Drill > Issue Type: Bug > Components: Tools, Build & Test >Affects Versions: 1.10.0 >Reporter: Krystal >Assignee: Paul Rogers >Priority: Minor > > Command to find JAVA in drill-config.sh is not deterministic. > drill-config.sh uses the following command to find JAVA: > JAVA=`find -L "$JAVA_HOME" -name $JAVA_BIN -type f | head -n 1` > On one of my node the following command returned 2 entries: > find -L $JAVA_HOME -name java -type f > /usr/local/java/jdk1.7.0_67/jre/bin/java > /usr/local/java/jdk1.7.0_67/bin/java > On another node, the same command returned entries in different order: > find -L $JAVA_HOME -name java -type f > /usr/local/java/jdk1.7.0_67/bin/java > /usr/local/java/jdk1.7.0_67/jre/bin/java > The complete command picks the first one returned which may not be the same > on each node: > find -L $JAVA_HOME -name java -type f | head -n 1 > /usr/local/java/jdk1.7.0_67/jre/bin/java > If JAVA_HOME is found, we should just append the "bin/java" to the path" > JAVA=$JAVA_HOME/bin/java -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DRILL-5208) Finding path to java executable should be deterministic
[ https://issues.apache.org/jira/browse/DRILL-5208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15883681#comment-15883681 ] ASF GitHub Bot commented on DRILL-5208: --- GitHub user paul-rogers opened a pull request: https://github.com/apache/drill/pull/763 DRILL-5208: Finding path to java executable should be deterministic See DRILL-5208 for background. Instead of using “find” to locate the java command, we use the any information available, resorting to find only if the “usual suspects” fails. The result is that we use the JDK java when available, instead of randomly choosing JDK or JRE java. You can merge this pull request into a Git repository by running: $ git pull https://github.com/paul-rogers/drill DRILL-5208 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/drill/pull/763.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #763 commit 19c412e9900bf5db80d4d95f9317d8f308669f4b Author: Paul Rogers Date: 2017-02-24T22:53:23Z DRILL-5208: Finding path to java executable should be deterministic See DRILL-5208 for background. Instead of using “find” to locate the java command, we use the any information available, resorting to find only if the “usual suspects” fails. The result is that we use the JDK java when available, instead of randomly choosing JDK or JRE java. > Finding path to java executable should be deterministic > --- > > Key: DRILL-5208 > URL: https://issues.apache.org/jira/browse/DRILL-5208 > Project: Apache Drill > Issue Type: Bug > Components: Tools, Build & Test >Affects Versions: 1.10.0 >Reporter: Krystal >Assignee: Paul Rogers >Priority: Minor > > Command to find JAVA in drill-config.sh is not deterministic. > drill-config.sh uses the following command to find JAVA: > JAVA=`find -L "$JAVA_HOME" -name $JAVA_BIN -type f | head -n 1` > On one of my node the following command returned 2 entries: > find -L $JAVA_HOME -name java -type f > /usr/local/java/jdk1.7.0_67/jre/bin/java > /usr/local/java/jdk1.7.0_67/bin/java > On another node, the same command returned entries in different order: > find -L $JAVA_HOME -name java -type f > /usr/local/java/jdk1.7.0_67/bin/java > /usr/local/java/jdk1.7.0_67/jre/bin/java > The complete command picks the first one returned which may not be the same > on each node: > find -L $JAVA_HOME -name java -type f | head -n 1 > /usr/local/java/jdk1.7.0_67/jre/bin/java > If JAVA_HOME is found, we should just append the "bin/java" to the path" > JAVA=$JAVA_HOME/bin/java -- This message was sent by Atlassian JIRA (v6.3.15#6346)
