[jira] [Commented] (DRILL-5511) Additional UserException categories for internal errors
[
https://issues.apache.org/jira/browse/DRILL-5511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012923#comment-16012923
]
ASF GitHub Bot commented on DRILL-5511:
---
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/836
Withdrawn based on Parth's comments.
> Additional UserException categories for internal errors
> ---
>
> Key: DRILL-5511
> URL: https://issues.apache.org/jira/browse/DRILL-5511
> Project: Apache Drill
> Issue Type: Improvement
>Affects Versions: 1.11.0
>Reporter: Paul Rogers
>Assignee: Paul Rogers
>Priority: Minor
> Fix For: 1.11.0
>
>
> The {{UserException}} class in Drill is the way that Drill passes error
> conditions from the server to the client. {{UserException}} groups errors
> into a number of categories as defined in [the protobuf
> definitions|https://github.com/apache/drill/blob/master/protocol/src/main/protobuf/UserBitShared.proto].
> As we enhance error handling in operators, it becomes clear that some errors
> do not fit into the existing categories. In particular:
> * Execution errors: problems related to run-time issues where the cause is
> not known, or the error does not fit into an existing category. This might
> occur, say, if a temporary file fills, a spill file is deleted or other
> odd-ball cases.
> * Internal error: error that indicates failure of Drill code, invariants or
> the like. Internal errors are generally not something wrong with the user's
> data, query or environment, but rather something wrong with Drill itself. For
> example, all {{IllegalStateException}}, {{AssertionError}} or
> {{IllegalArgumentException}} errors would map to an internal error.
> * Unspecified error: for cases where Drill code caches an exception from a
> deeper layer, but we don't know enough about the exception to render a useful
> categorization. Most often used in cases of plugins that don't do adequate
> error handing themselves.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (DRILL-5511) Additional UserException categories for internal errors
[
https://issues.apache.org/jira/browse/DRILL-5511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012924#comment-16012924
]
ASF GitHub Bot commented on DRILL-5511:
---
Github user paul-rogers closed the pull request at:
https://github.com/apache/drill/pull/836
> Additional UserException categories for internal errors
> ---
>
> Key: DRILL-5511
> URL: https://issues.apache.org/jira/browse/DRILL-5511
> Project: Apache Drill
> Issue Type: Improvement
>Affects Versions: 1.11.0
>Reporter: Paul Rogers
>Assignee: Paul Rogers
>Priority: Minor
> Fix For: 1.11.0
>
>
> The {{UserException}} class in Drill is the way that Drill passes error
> conditions from the server to the client. {{UserException}} groups errors
> into a number of categories as defined in [the protobuf
> definitions|https://github.com/apache/drill/blob/master/protocol/src/main/protobuf/UserBitShared.proto].
> As we enhance error handling in operators, it becomes clear that some errors
> do not fit into the existing categories. In particular:
> * Execution errors: problems related to run-time issues where the cause is
> not known, or the error does not fit into an existing category. This might
> occur, say, if a temporary file fills, a spill file is deleted or other
> odd-ball cases.
> * Internal error: error that indicates failure of Drill code, invariants or
> the like. Internal errors are generally not something wrong with the user's
> data, query or environment, but rather something wrong with Drill itself. For
> example, all {{IllegalStateException}}, {{AssertionError}} or
> {{IllegalArgumentException}} errors would map to an internal error.
> * Unspecified error: for cases where Drill code caches an exception from a
> deeper layer, but we don't know enough about the exception to render a useful
> categorization. Most often used in cases of plugins that don't do adequate
> error handing themselves.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (DRILL-5511) Additional UserException categories for internal errors
[
https://issues.apache.org/jira/browse/DRILL-5511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011564#comment-16011564
]
Parth Chandra commented on DRILL-5511:
--
There are already categories for RESOURCE, SYSTEM, etc., that cover a whole
range of errors. In particular, SYSTEM is intended for internal errors and
RESOURCE for disk and network errors.
It is not very helpful to have the end user see a 'Unspecified' category error
message, I would put them all in SYSTEM.
In general, for RESOURCE and SYSTEM errors the user cannot do anything except
try again (for some network errors) or contact an administrator. For SYSTEM
errors, it is likely the administrator will have to collect logs and have the
Drill team take a look at them.
> Additional UserException categories for internal errors
> ---
>
> Key: DRILL-5511
> URL: https://issues.apache.org/jira/browse/DRILL-5511
> Project: Apache Drill
> Issue Type: Improvement
>Affects Versions: 1.11.0
>Reporter: Paul Rogers
>Assignee: Paul Rogers
>Priority: Minor
> Fix For: 1.11.0
>
>
> The {{UserException}} class in Drill is the way that Drill passes error
> conditions from the server to the client. {{UserException}} groups errors
> into a number of categories as defined in [the protobuf
> definitions|https://github.com/apache/drill/blob/master/protocol/src/main/protobuf/UserBitShared.proto].
> As we enhance error handling in operators, it becomes clear that some errors
> do not fit into the existing categories. In particular:
> * Execution errors: problems related to run-time issues where the cause is
> not known, or the error does not fit into an existing category. This might
> occur, say, if a temporary file fills, a spill file is deleted or other
> odd-ball cases.
> * Internal error: error that indicates failure of Drill code, invariants or
> the like. Internal errors are generally not something wrong with the user's
> data, query or environment, but rather something wrong with Drill itself. For
> example, all {{IllegalStateException}}, {{AssertionError}} or
> {{IllegalArgumentException}} errors would map to an internal error.
> * Unspecified error: for cases where Drill code caches an exception from a
> deeper layer, but we don't know enough about the exception to render a useful
> categorization. Most often used in cases of plugins that don't do adequate
> error handing themselves.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (DRILL-5511) Additional UserException categories for internal errors
[
https://issues.apache.org/jira/browse/DRILL-5511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011406#comment-16011406
]
ASF GitHub Bot commented on DRILL-5511:
---
GitHub user paul-rogers opened a pull request:
https://github.com/apache/drill/pull/836
DRILL-5511: Additional UserException categories
Adds three kinds of internal errors:
1. General execution exception: something failed due to issues outside
Drill.
2. Internal error: something failed due to a likely code error.
3. Unspecified: something failed, but we don’t know why.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paul-rogers/drill DRILL-5511
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/836.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #836
commit b31d40df314d76ae6c458891e65d423b4b9e61cb
Author: Paul Rogers
Date: 2017-05-15T21:23:10Z
DRILL-5511: Additional UserException categories
Adds three kinds of internal errors:
1. General execution exception: something failed due to issues outside
Drill.
2. Internal error: something failed due to a likely code error.
3. Unspecified: something failed, but we don’t know why.
> Additional UserException categories for internal errors
> ---
>
> Key: DRILL-5511
> URL: https://issues.apache.org/jira/browse/DRILL-5511
> Project: Apache Drill
> Issue Type: Improvement
>Affects Versions: 1.11.0
>Reporter: Paul Rogers
>Assignee: Paul Rogers
>Priority: Minor
> Fix For: 1.11.0
>
>
> The {{UserException}} class in Drill is the way that Drill passes error
> conditions from the server to the client. {{UserException}} groups errors
> into a number of categories as defined in [the protobuf
> definitions|https://github.com/apache/drill/blob/master/protocol/src/main/protobuf/UserBitShared.proto].
> As we enhance error handling in operators, it becomes clear that some errors
> do not fit into the existing categories. In particular:
> * Execution errors: problems related to run-time issues where the cause is
> not known, or the error does not fit into an existing category. This might
> occur, say, if a temporary file fills, a spill file is deleted or other
> odd-ball cases.
> * Internal error: error that indicates failure of Drill code, invariants or
> the like. Internal errors are generally not something wrong with the user's
> data, query or environment, but rather something wrong with Drill itself. For
> example, all {{IllegalStateException}}, {{AssertionError}} or
> {{IllegalArgumentException}} errors would map to an internal error.
> * Unspecified error: for cases where Drill code caches an exception from a
> deeper layer, but we don't know enough about the exception to render a useful
> categorization. Most often used in cases of plugins that don't do adequate
> error handing themselves.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
