[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685690#comment-16685690
]
ASF GitHub Bot commented on DRILL-5571:
---
kkhatua commented on issue #1531: DRILL-5571: Cancel running query from its Web
UI
URL: https://github.com/apache/drill/pull/1531#issuecomment-438419106
Squashed and merged with Commit ID c3080fedf9dcfe3d2c12a7942d3f82713be695f2
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>Assignee: Kunal Khatua
>Priority: Major
> Labels: ready-to-commit
> Fix For: 1.15.0
>
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685687#comment-16685687
]
ASF GitHub Bot commented on DRILL-5571:
---
kkhatua closed pull request #1531: DRILL-5571: Cancel running query from its
Web UI
URL: https://github.com/apache/drill/pull/1531
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/exec/java-exec/src/main/resources/rest/profile/profile.ftl
b/exec/java-exec/src/main/resources/rest/profile/profile.ftl
index c14e1b2e97d..cbef5487453 100644
--- a/exec/java-exec/src/main/resources/rest/profile/profile.ftl
+++ b/exec/java-exec/src/main/resources/rest/profile/profile.ftl
@@ -50,6 +50,22 @@
"info": false
}
);} );
+
+//Close the cancellation status popup
+function refreshStatus() {
+ //Close PopUp Modal
+ $("#queryCancelModal").modal("hide");
+ location.reload(true);
+}
+
+//Cancel query & show cancellation status
+function cancelQuery() {
+ document.getElementById("cancelTitle").innerHTML = "Drillbit on " +
location.hostname + " says";
+ $.get("/profiles/cancel/"+globalconfig.queryid, function(data,
status){/*Not Tracking Response*/});
+ //Show PopUp Modal
+ $("#queryCancelModal").modal("show");
+};
+
/* DataTables Sorting: inherited via sortable class */
@@ -63,6 +79,7 @@ table.sortable thead .sorting { background-image:
url("/static/img/black-unsorte
table.sortable thead .sorting_asc { background-image:
url("/static/img/black-asc.gif"); }
table.sortable thead .sorting_desc { background-image:
url("/static/img/black-desc.gif"); }
+
<#macro page_body>
@@ -171,7 +188,30 @@ table.sortable thead .sorting_desc { background-image:
url("/static/img/black-de
<#assign queued = queueName != "" && queueName != "-" />
- Query Profile : ${model.getQueryId()}
+ Query Profile: ${model.getQueryId()}
+ <#if model.getQueryStateDisplayName() == "Prepared" ||
model.getQueryStateDisplayName() == "Planning" ||
model.getQueryStateDisplayName() == "Enqueued" ||
model.getQueryStateDisplayName() == "Starting">
+
+ Cancel
+
+
+
+
+
+
+
+ ×
+
+
+
+ Cancellation issued for Query ID:${model.getQueryId()}
+
+Close
+
+
+
+
+
+
@@ -214,7 +254,7 @@ table.sortable thead .sorting_desc { background-image:
url("/static/img/black-de
-
+
Duration
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>Assignee: Kunal Khatua
>Priority: Major
> Labels: ready-to-commit
> Fix For: 1.15.0
>
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685597#comment-16685597
]
ASF GitHub Bot commented on DRILL-5571:
---
arina-ielchiieva commented on issue #1531: DRILL-5571: Cancel running query
from its Web UI
URL: https://github.com/apache/drill/pull/1531#issuecomment-438392090
Looks good, please squash the commits.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>Assignee: Kunal Khatua
>Priority: Major
> Labels: ready-to-commit
> Fix For: 1.15.0
>
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684167#comment-16684167
]
ASF GitHub Bot commented on DRILL-5571:
---
kkhatua commented on issue #1531: DRILL-5571: Cancel running query from its Web
UI
URL: https://github.com/apache/drill/pull/1531#issuecomment-437973137
@arina-ielchiieva that is my Drillbit's hostname.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>Assignee: Kunal Khatua
>Priority: Major
> Labels: javascript, newbie
> Fix For: 1.15.0
>
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684065#comment-16684065
]
ASF GitHub Bot commented on DRILL-5571:
---
arina-ielchiieva commented on issue #1531: DRILL-5571: Cancel running query
from its Web UI
URL: https://github.com/apache/drill/pull/1531#issuecomment-437949964
@kkhatua what kk127 on the screenshot with modal window?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>Assignee: Kunal Khatua
>Priority: Major
> Labels: javascript, newbie
> Fix For: 1.15.0
>
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684066#comment-16684066
]
ASF GitHub Bot commented on DRILL-5571:
---
arina-ielchiieva edited a comment on issue #1531: DRILL-5571: Cancel running
query from its Web UI
URL: https://github.com/apache/drill/pull/1531#issuecomment-437949964
@kkhatua what kk127 means on the screenshot with modal window?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>Assignee: Kunal Khatua
>Priority: Major
> Labels: javascript, newbie
> Fix For: 1.15.0
>
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684030#comment-16684030
]
ASF GitHub Bot commented on DRILL-5571:
---
kkhatua commented on a change in pull request #1531: DRILL-5571: Cancel running
query from its Web UI
URL: https://github.com/apache/drill/pull/1531#discussion_r232722408
##
File path: exec/java-exec/src/main/resources/rest/profile/profile.ftl
##
@@ -171,7 +188,30 @@ table.sortable thead .sorting_desc { background-image:
url("/static/img/black-de
<#assign queued = queueName != "" && queueName != "-" />
- Query Profile : ${model.getQueryId()}
+ Query Profile: ${model.getQueryId()}
+ <#if model.getQueryStateDisplayName() == "Running" ||
model.getQueryStateDisplayName() == "Planning">
Review comment:
Actually, on second thoughts, I can add STARTING, etc as well. If the query
ID doesnt exist, the page wouldn't exist, so we should be fine. I'll add the
change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>Assignee: Kunal Khatua
>Priority: Major
> Labels: javascript, newbie
> Fix For: 1.15.0
>
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684010#comment-16684010
]
ASF GitHub Bot commented on DRILL-5571:
---
kkhatua commented on a change in pull request #1531: DRILL-5571: Cancel running
query from its Web UI
URL: https://github.com/apache/drill/pull/1531#discussion_r232718757
##
File path: exec/java-exec/src/main/resources/rest/profile/profile.ftl
##
@@ -171,7 +188,30 @@ table.sortable thead .sorting_desc { background-image:
url("/static/img/black-de
<#assign queued = queueName != "" && queueName != "-" />
- Query Profile : ${model.getQueryId()}
+ Query Profile: ${model.getQueryId()}
+ <#if model.getQueryStateDisplayName() == "Running" ||
model.getQueryStateDisplayName() == "Planning">
Review comment:
I believe a QueryId is not created during STARTING. Will need to check for
other states... as I'm not sure what PREPARING does
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>Assignee: Kunal Khatua
>Priority: Major
> Labels: javascript, newbie
> Fix For: 1.15.0
>
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684009#comment-16684009
]
ASF GitHub Bot commented on DRILL-5571:
---
kkhatua commented on a change in pull request #1531: DRILL-5571: Cancel running
query from its Web UI
URL: https://github.com/apache/drill/pull/1531#discussion_r232718140
##
File path: exec/java-exec/src/main/resources/rest/profile/profile.ftl
##
@@ -50,6 +50,22 @@
"info": false
}
);} );
+
+//Close the cancellation status popup
+function refreshStatus() {
+ //Close PopUp Modal
+ $("#queryCancelModal").modal("hide");
+ location.reload(true);
+}
+
+//Cancel query & show cancellation status
+function cancelQuery() {
+ document.getElementById("cancelTitle").innerHTML = location.hostname;
Review comment:
Indicating the host to which the cancelation was issued.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>Assignee: Kunal Khatua
>Priority: Major
> Labels: javascript, newbie
> Fix For: 1.15.0
>
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684008#comment-16684008
]
ASF GitHub Bot commented on DRILL-5571:
---
kkhatua commented on issue #1531: DRILL-5571: Cancel running query from its Web
UI
URL: https://github.com/apache/drill/pull/1531#issuecomment-437937304
Running Query:
During Cancellation:
Post Cancellation Status:
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>Assignee: Kunal Khatua
>Priority: Major
> Labels: javascript, newbie
> Fix For: 1.15.0
>
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683735#comment-16683735
]
ASF GitHub Bot commented on DRILL-5571:
---
arina-ielchiieva commented on a change in pull request #1531: DRILL-5571:
Cancel running query from its Web UI
URL: https://github.com/apache/drill/pull/1531#discussion_r232642178
##
File path: exec/java-exec/src/main/resources/rest/profile/profile.ftl
##
@@ -50,6 +50,22 @@
"info": false
}
);} );
+
+//Close the cancellation status popup
+function refreshStatus() {
+ //Close PopUp Modal
+ $("#queryCancelModal").modal("hide");
+ location.reload(true);
+}
+
+//Cancel query & show cancellation status
+function cancelQuery() {
+ document.getElementById("cancelTitle").innerHTML = location.hostname;
Review comment:
Why this is needed?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>Assignee: Kunal Khatua
>Priority: Major
> Labels: javascript, newbie
> Fix For: 1.15.0
>
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683734#comment-16683734
]
ASF GitHub Bot commented on DRILL-5571:
---
arina-ielchiieva commented on a change in pull request #1531: DRILL-5571:
Cancel running query from its Web UI
URL: https://github.com/apache/drill/pull/1531#discussion_r232642539
##
File path: exec/java-exec/src/main/resources/rest/profile/profile.ftl
##
@@ -171,7 +188,30 @@ table.sortable thead .sorting_desc { background-image:
url("/static/img/black-de
<#assign queued = queueName != "" && queueName != "-" />
- Query Profile : ${model.getQueryId()}
+ Query Profile: ${model.getQueryId()}
+ <#if model.getQueryStateDisplayName() == "Running" ||
model.getQueryStateDisplayName() == "Planning">
Review comment:
What about other states when query can be cancelled?
STARTING
ENQUEUED
PREPARING
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>Assignee: Kunal Khatua
>Priority: Major
> Labels: javascript, newbie
> Fix For: 1.15.0
>
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683278#comment-16683278
]
ASF GitHub Bot commented on DRILL-5571:
---
kkhatua commented on issue #1531: DRILL-5571: Cancel running query from its Web
UI
URL: https://github.com/apache/drill/pull/1531#issuecomment-437770292
@arina-ielchiieva / @sohami made changes based on review comments.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>Assignee: Kunal Khatua
>Priority: Major
> Labels: javascript, newbie
> Fix For: 1.15.0
>
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683261#comment-16683261
]
ASF GitHub Bot commented on DRILL-5571:
---
kkhatua commented on a change in pull request #1531: DRILL-5571: Cancel running
query from its Web UI
URL: https://github.com/apache/drill/pull/1531#discussion_r232543607
##
File path: exec/java-exec/src/main/resources/rest/profile/profile.ftl
##
@@ -171,7 +229,17 @@ table.sortable thead .sorting_desc { background-image:
url("/static/img/black-de
<#assign queued = queueName != "" && queueName != "-" />
- Query Profile : ${model.getQueryId()}
+ Query Profile : ${model.getQueryId()}
+ <#if model.getQueryStateDisplayName() == "Running" ||
model.getQueryStateDisplayName() == "Planning">
+
+Issued cancellation for queryClick
to continue
+
+
+
+ Cancel
Review comment:
Ok. Dropped the glyphicon and retained the warning (orange) cancellation
button. I didn't want it to be a standard blue button as this is a query
termination button.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>Assignee: Kunal Khatua
>Priority: Major
> Labels: javascript, newbie
> Fix For: 1.15.0
>
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683259#comment-16683259
]
ASF GitHub Bot commented on DRILL-5571:
---
kkhatua commented on a change in pull request #1531: DRILL-5571: Cancel running
query from its Web UI
URL: https://github.com/apache/drill/pull/1531#discussion_r232543357
##
File path: exec/java-exec/src/main/resources/rest/profile/profile.ftl
##
@@ -50,6 +50,34 @@
"info": false
}
);} );
+
+//Show cancellation status
+function showCancelPopup(queryId) {
+document.getElementById("cancelText").innerHTML = "Issued cancellation
for query ID: "+queryId+"Click to continue";
+document.getElementById("cancelPopup").style.display = "block";
+}
+
+//Close the cancellation status popup
+function closePopup() {
+document.getElementById("cancelPopup").style.display = "none";
+location.reload(true);
+}
+
+//Cancel query
+function cancelQuery(queryId) {
+var cancelRestURL = location.protocol + "//" + location.hostname +
"/profiles/cancel/" + queryId;
+let restPort = location.port;
+if (restPort != 0) {
Review comment:
`location.port` returns 0 if the port number is standard. However, I've
changed this because I realized I don't really need the server as the
`/profiles/cancel/...` will be made on the same server that served the profile
UI.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>Assignee: Kunal Khatua
>Priority: Major
> Labels: javascript, newbie
> Fix For: 1.15.0
>
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683134#comment-16683134
]
ASF GitHub Bot commented on DRILL-5571:
---
sohami commented on a change in pull request #1531: DRILL-5571: Cancel running
query from its Web UI
URL: https://github.com/apache/drill/pull/1531#discussion_r232520154
##
File path: exec/java-exec/src/main/resources/rest/profile/profile.ftl
##
@@ -50,6 +50,34 @@
"info": false
}
);} );
+
+//Show cancellation status
+function showCancelPopup(queryId) {
+document.getElementById("cancelText").innerHTML = "Issued cancellation
for query ID: "+queryId+"Click to continue";
+document.getElementById("cancelPopup").style.display = "block";
+}
+
+//Close the cancellation status popup
+function closePopup() {
+document.getElementById("cancelPopup").style.display = "none";
+location.reload(true);
+}
+
+//Cancel query
+function cancelQuery(queryId) {
+var cancelRestURL = location.protocol + "//" + location.hostname +
"/profiles/cancel/" + queryId;
+let restPort = location.port;
+if (restPort != 0) {
Review comment:
in what case `restPort` will be 0 ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>Assignee: Kunal Khatua
>Priority: Major
> Labels: javascript, newbie
> Fix For: 1.15.0
>
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683133#comment-16683133
]
ASF GitHub Bot commented on DRILL-5571:
---
sohami commented on a change in pull request #1531: DRILL-5571: Cancel running
query from its Web UI
URL: https://github.com/apache/drill/pull/1531#discussion_r232521155
##
File path: exec/java-exec/src/main/resources/rest/profile/profile.ftl
##
@@ -171,7 +229,17 @@ table.sortable thead .sorting_desc { background-image:
url("/static/img/black-de
<#assign queued = queueName != "" && queueName != "-" />
- Query Profile : ${model.getQueryId()}
+ Query Profile : ${model.getQueryId()}
+ <#if model.getQueryStateDisplayName() == "Running" ||
model.getQueryStateDisplayName() == "Planning">
+
+Issued cancellation for queryClick
to continue
+
+
+
+ Cancel
Review comment:
Not to be picky but I would say for consistency use the same button format
as in other pages like /storage tab.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>Assignee: Kunal Khatua
>Priority: Major
> Labels: javascript, newbie
> Fix For: 1.15.0
>
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683077#comment-16683077
]
ASF GitHub Bot commented on DRILL-5571:
---
kkhatua commented on a change in pull request #1531: DRILL-5571: Cancel running
query from its Web UI
URL: https://github.com/apache/drill/pull/1531#discussion_r232511516
##
File path: exec/java-exec/src/main/resources/rest/profile/profile.ftl
##
@@ -50,6 +50,34 @@
"info": false
}
);} );
+
+//Show cancellation status
+function showCancelPopup(queryId) {
Review comment:
Wasn't aware of this and not sure if the current Bootstrap supports this.
Will try and if not supported in the current version within Drill, let's
continue with the CSS.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>Assignee: Kunal Khatua
>Priority: Major
> Labels: javascript, newbie
> Fix For: 1.15.0
>
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683075#comment-16683075
]
ASF GitHub Bot commented on DRILL-5571:
---
kkhatua commented on a change in pull request #1531: DRILL-5571: Cancel running
query from its Web UI
URL: https://github.com/apache/drill/pull/1531#discussion_r232511339
##
File path: exec/java-exec/src/main/resources/rest/profile/profile.ftl
##
@@ -50,6 +50,34 @@
"info": false
}
);} );
+
+//Show cancellation status
+function showCancelPopup(queryId) {
+document.getElementById("cancelText").innerHTML = "Issued cancellation
for query ID: "+queryId+"Click to continue";
+document.getElementById("cancelPopup").style.display = "block";
+}
+
+//Close the cancellation status popup
+function closePopup() {
+document.getElementById("cancelPopup").style.display = "none";
+location.reload(true);
+}
+
+//Cancel query
+function cancelQuery(queryId) {
+var cancelRestURL = location.protocol + "//" + location.hostname +
"/profiles/cancel/" + queryId;
+let restPort = location.port;
+if (restPort != 0) {
+cancelRestURL = location.protocol + "//" + location.hostname + ":"
+ restPort + "/profiles/cancel/" + queryId;
+}
+$.get(cancelRestURL, function(data, status){
+//dBug
+console.log("Cancelled >--> " + cancelRestURL);
Review comment:
Missed this. Shouldn't matter, though, because the page refreshes after the
popup is closed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>Assignee: Kunal Khatua
>Priority: Major
> Labels: javascript, newbie
> Fix For: 1.15.0
>
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683074#comment-16683074
]
ASF GitHub Bot commented on DRILL-5571:
---
kkhatua commented on a change in pull request #1531: DRILL-5571: Cancel running
query from its Web UI
URL: https://github.com/apache/drill/pull/1531#discussion_r232511312
##
File path: exec/java-exec/src/main/resources/rest/profile/profile.ftl
##
@@ -171,7 +229,17 @@ table.sortable thead .sorting_desc { background-image:
url("/static/img/black-de
<#assign queued = queueName != "" && queueName != "-" />
- Query Profile : ${model.getQueryId()}
+ Query Profile : ${model.getQueryId()}
+ <#if model.getQueryStateDisplayName() == "Running" ||
model.getQueryStateDisplayName() == "Planning">
+
+Issued cancellation for queryClick
to continue
+
+
+
+ Cancel
Review comment:
Ok. I thought adding an icon makes it more visually informative.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>Assignee: Kunal Khatua
>Priority: Major
> Labels: javascript, newbie
> Fix For: 1.15.0
>
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683071#comment-16683071
]
ASF GitHub Bot commented on DRILL-5571:
---
kkhatua commented on a change in pull request #1531: DRILL-5571: Cancel running
query from its Web UI
URL: https://github.com/apache/drill/pull/1531#discussion_r232511275
##
File path: exec/java-exec/src/main/resources/rest/profile/profile.ftl
##
@@ -171,7 +229,17 @@ table.sortable thead .sorting_desc { background-image:
url("/static/img/black-de
<#assign queued = queueName != "" && queueName != "-" />
- Query Profile : ${model.getQueryId()}
+ Query Profile : ${model.getQueryId()}
Review comment:
Ok. I think it might have been there to make it more readable with the
actual query ID.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>Assignee: Kunal Khatua
>Priority: Major
> Labels: javascript, newbie
> Fix For: 1.15.0
>
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683070#comment-16683070
]
ASF GitHub Bot commented on DRILL-5571:
---
kkhatua commented on a change in pull request #1531: DRILL-5571: Cancel running
query from its Web UI
URL: https://github.com/apache/drill/pull/1531#discussion_r232511213
##
File path: exec/java-exec/src/main/resources/rest/profile/profile.ftl
##
@@ -50,6 +50,34 @@
"info": false
}
);} );
+
+//Show cancellation status
+function showCancelPopup(queryId) {
+document.getElementById("cancelText").innerHTML = "Issued cancellation
for query ID: "+queryId+"Click to continue";
+document.getElementById("cancelPopup").style.display = "block";
+}
+
+//Close the cancellation status popup
+function closePopup() {
+document.getElementById("cancelPopup").style.display = "none";
+location.reload(true);
+}
+
+//Cancel query
+function cancelQuery(queryId) {
+var cancelRestURL = location.protocol + "//" + location.hostname +
"/profiles/cancel/" + queryId;
Review comment:
My assumption is that if HTTPS is enabled, the protocol should reflect it,
though I probably just needed `"/profiles/cancel/" + queryId`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>Assignee: Kunal Khatua
>Priority: Major
> Labels: javascript, newbie
> Fix For: 1.15.0
>
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682369#comment-16682369
]
ASF GitHub Bot commented on DRILL-5571:
---
arina-ielchiieva commented on a change in pull request #1531: DRILL-5571:
Cancel running query from its Web UI
URL: https://github.com/apache/drill/pull/1531#discussion_r232450793
##
File path: exec/java-exec/src/main/resources/rest/profile/profile.ftl
##
@@ -50,6 +50,34 @@
"info": false
}
);} );
+
+//Show cancellation status
+function showCancelPopup(queryId) {
+document.getElementById("cancelText").innerHTML = "Issued cancellation
for query ID: "+queryId+"Click to continue";
+document.getElementById("cancelPopup").style.display = "block";
+}
+
+//Close the cancellation status popup
+function closePopup() {
+document.getElementById("cancelPopup").style.display = "none";
+location.reload(true);
+}
+
+//Cancel query
+function cancelQuery(queryId) {
+var cancelRestURL = location.protocol + "//" + location.hostname +
"/profiles/cancel/" + queryId;
Review comment:
Not sure why we need this, I don't think we had this prior, cancellation was
done without protocol and hostname concatenation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>Assignee: Kunal Khatua
>Priority: Major
> Labels: javascript, newbie
> Fix For: 1.15.0
>
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682372#comment-16682372
]
ASF GitHub Bot commented on DRILL-5571:
---
arina-ielchiieva commented on a change in pull request #1531: DRILL-5571:
Cancel running query from its Web UI
URL: https://github.com/apache/drill/pull/1531#discussion_r232450839
##
File path: exec/java-exec/src/main/resources/rest/profile/profile.ftl
##
@@ -171,7 +229,17 @@ table.sortable thead .sorting_desc { background-image:
url("/static/img/black-de
<#assign queued = queueName != "" && queueName != "-" />
- Query Profile : ${model.getQueryId()}
+ Query Profile : ${model.getQueryId()}
Review comment:
Please remove space before semicolon (i.e. Query Profile:)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>Assignee: Kunal Khatua
>Priority: Major
> Labels: javascript, newbie
> Fix For: 1.15.0
>
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682370#comment-16682370
]
ASF GitHub Bot commented on DRILL-5571:
---
arina-ielchiieva commented on a change in pull request #1531: DRILL-5571:
Cancel running query from its Web UI
URL: https://github.com/apache/drill/pull/1531#discussion_r232450805
##
File path: exec/java-exec/src/main/resources/rest/profile/profile.ftl
##
@@ -50,6 +50,34 @@
"info": false
}
);} );
+
+//Show cancellation status
+function showCancelPopup(queryId) {
Review comment:
Consider using bootstrap modal
(https://getbootstrap.com/docs/4.0/components/modal/), it will look much nicer
and user-friendly plus you won't need all `CSS to control Floating Cancel
Popup` stuff.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>Assignee: Kunal Khatua
>Priority: Major
> Labels: javascript, newbie
> Fix For: 1.15.0
>
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682368#comment-16682368
]
ASF GitHub Bot commented on DRILL-5571:
---
arina-ielchiieva commented on a change in pull request #1531: DRILL-5571:
Cancel running query from its Web UI
URL: https://github.com/apache/drill/pull/1531#discussion_r232450772
##
File path: exec/java-exec/src/main/resources/rest/profile/profile.ftl
##
@@ -50,6 +50,34 @@
"info": false
}
);} );
+
+//Show cancellation status
+function showCancelPopup(queryId) {
+document.getElementById("cancelText").innerHTML = "Issued cancellation
for query ID: "+queryId+"Click to continue";
+document.getElementById("cancelPopup").style.display = "block";
+}
+
+//Close the cancellation status popup
+function closePopup() {
+document.getElementById("cancelPopup").style.display = "none";
+location.reload(true);
+}
+
+//Cancel query
+function cancelQuery(queryId) {
+var cancelRestURL = location.protocol + "//" + location.hostname +
"/profiles/cancel/" + queryId;
+let restPort = location.port;
+if (restPort != 0) {
+cancelRestURL = location.protocol + "//" + location.hostname + ":"
+ restPort + "/profiles/cancel/" + queryId;
+}
+$.get(cancelRestURL, function(data, status){
+//dBug
+console.log("Cancelled >--> " + cancelRestURL);
Review comment:
Please remove.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>Assignee: Kunal Khatua
>Priority: Major
> Labels: javascript, newbie
> Fix For: 1.15.0
>
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682371#comment-16682371
]
ASF GitHub Bot commented on DRILL-5571:
---
arina-ielchiieva commented on a change in pull request #1531: DRILL-5571:
Cancel running query from its Web UI
URL: https://github.com/apache/drill/pull/1531#discussion_r232450851
##
File path: exec/java-exec/src/main/resources/rest/profile/profile.ftl
##
@@ -171,7 +229,17 @@ table.sortable thead .sorting_desc { background-image:
url("/static/img/black-de
<#assign queued = queueName != "" && queueName != "-" />
- Query Profile : ${model.getQueryId()}
+ Query Profile : ${model.getQueryId()}
+ <#if model.getQueryStateDisplayName() == "Running" ||
model.getQueryStateDisplayName() == "Planning">
+
+Issued cancellation for queryClick
to continue
+
+
+
+ Cancel
Review comment:
Please use button without 'x', having Close text on the button is enough.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>Assignee: Kunal Khatua
>Priority: Major
> Labels: javascript, newbie
> Fix For: 1.15.0
>
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681943#comment-16681943
]
ASF GitHub Bot commented on DRILL-5571:
---
kkhatua opened a new pull request #1531: DRILL-5571: Cancel running query from
its Web UI
URL: https://github.com/apache/drill/pull/1531
Currently, a running query can be cancelled by navigating to the Edit Query
Tab of the profile page, making it difficult to access. This commit allows the
user to cancel from the query page.
In addition, the Duration segment is also made visible by default rather
than collapsed.
Screenshot of a running query
Screenshot of a query being cancelled
Screenshot of a query after cancellation
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>Assignee: Kunal Khatua
>Priority: Major
> Labels: javascript, newbie
> Fix For: 1.16.0
>
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681732#comment-16681732
]
Kunal Khatua commented on DRILL-5571:
-
There exists a Cancel Query link in the 'Edit Query' tab of a running query
profile. We probably need to move/copy that to the primary tab.
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>Assignee: Hanumath Rao Maduri
>Priority: Major
> Labels: javascript, newbie
> Fix For: 1.16.0
>
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-5571) Unable to cancel running queries from Web UI
[
https://issues.apache.org/jira/browse/DRILL-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039469#comment-16039469
]
Khurram Faraaz commented on DRILL-5571:
---
[~kedarbcs16] How did you try to CANCEL the query ? Did you use the REST API to
Cancel, like the below example ?
{noformat}
curl http://localhost:8047/profiles/cancel/29b2e988-35e7-4c85-3151-32c7d3347f15
{noformat}
> Unable to cancel running queries from Web UI
>
>
> Key: DRILL-5571
> URL: https://issues.apache.org/jira/browse/DRILL-5571
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Kedar Sankar Behera
>
> We are unable to access profiles of some running queries. Hit the following
> error on the Web UI:
> {code}
> {
> “errorMessage” : “VALIDATION ERROR: No profile with given query id
> ‘26c90b95-928b-15e3-bedc-bfb4a046cc8b’ exists. Please verify the query
> id.\n\n\n[Error Id: e6896a23-6932-469d-9968-d315fdd06dd4 ]”
> }
> {code}
> And we cannot cancel the running queries whose profile page can be accessed:
> {code}
> Failure attempting to cancel query 26c90b33-cf7e-0495-8f76-55220f71f809.
> Unable to find information about where query is actively running.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
