[jira] [Commented] (DRILL-5729) Fix Travis Checks

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151681#comment-16151681
 ] 

ASF GitHub Bot commented on DRILL-5729:
---

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/913


> Fix Travis Checks
> -
>
> Key: DRILL-5729
> URL: https://issues.apache.org/jira/browse/DRILL-5729
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
>  Labels: ready-to-commit
> Fix For: 1.12.0
>
>
> Currently the Travis Checks are failing. The failures are happening because 
> Travis recently switched their default build containers from Ubuntu precise 
> to Ubuntu Trusty and we do not explicitly define the dist we build on in our 
> travis.yml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-5729) Fix Travis Checks

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145864#comment-16145864
 ] 

ASF GitHub Bot commented on DRILL-5729:
---

Github user parthchandra commented on the issue:

https://github.com/apache/drill/pull/913
  
+1


> Fix Travis Checks
> -
>
> Key: DRILL-5729
> URL: https://issues.apache.org/jira/browse/DRILL-5729
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
> Fix For: 1.12.0
>
>
> Currently the Travis Checks are failing. The failures are happening because 
> Travis recently switched their default build containers from Ubuntu precise 
> to Ubuntu Trusty and we do not explicitly define the dist we build on in our 
> travis.yml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-5729) Fix Travis Checks

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144606#comment-16144606
 ] 

ASF GitHub Bot commented on DRILL-5729:
---

Github user ilooner commented on the issue:

https://github.com/apache/drill/pull/913
  
@parthchandra I think the PR still needs a +1 from a committer. If Vlad's 
review is sufficient, could you give this a +1?

Thanks,
Tim


> Fix Travis Checks
> -
>
> Key: DRILL-5729
> URL: https://issues.apache.org/jira/browse/DRILL-5729
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
> Fix For: 1.12.0
>
>
> Currently the Travis Checks are failing. The failures are happening because 
> Travis recently switched their default build containers from Ubuntu precise 
> to Ubuntu Trusty and we do not explicitly define the dist we build on in our 
> travis.yml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-5729) Fix Travis Checks

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141940#comment-16141940
 ] 

ASF GitHub Bot commented on DRILL-5729:
---

Github user ilooner-mapr commented on the issue:

https://github.com/apache/drill/pull/913
  
@vrozov I've fixed the source.skip switch to be maven.source.skip as you 
pointed out. For now I also made the **script** tag a noop since as you said 
the mvn package command is redundant at this point. The **script** tag can't be 
completely removed because then travis runs its own default command for 
**script** which causes failures.


> Fix Travis Checks
> -
>
> Key: DRILL-5729
> URL: https://issues.apache.org/jira/browse/DRILL-5729
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
> Fix For: 1.12.0
>
>
> Currently the Travis Checks are failing. The failures are happening because 
> Travis recently switched their default build containers from Ubuntu precise 
> to Ubuntu Trusty and we do not explicitly define the dist we build on in our 
> travis.yml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-5729) Fix Travis Checks

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141931#comment-16141931
 ] 

ASF GitHub Bot commented on DRILL-5729:
---

Github user ilooner-mapr commented on a diff in the pull request:

https://github.com/apache/drill/pull/913#discussion_r135312783
  
--- Diff: .travis.yml ---
@@ -13,8 +13,9 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-sudo: false
 before_install: git fetch --unshallow
 language: java
-install: mvn install --batch-mode -DskipTests=true 
-Dmaven.javadoc.skip=true -Dsource.skip=true > mvn_install.log || (cat 
mvn_install.log && false)
-script: mvn package -DskipTests=true
+jdk:
+  - openjdk7
--- End diff --

Hmm good to know.


> Fix Travis Checks
> -
>
> Key: DRILL-5729
> URL: https://issues.apache.org/jira/browse/DRILL-5729
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
> Fix For: 1.12.0
>
>
> Currently the Travis Checks are failing. The failures are happening because 
> Travis recently switched their default build containers from Ubuntu precise 
> to Ubuntu Trusty and we do not explicitly define the dist we build on in our 
> travis.yml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-5729) Fix Travis Checks

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141791#comment-16141791
 ] 

ASF GitHub Bot commented on DRILL-5729:
---

Github user vrozov commented on a diff in the pull request:

https://github.com/apache/drill/pull/913#discussion_r135291374
  
--- Diff: .travis.yml ---
@@ -13,8 +13,9 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-sudo: false
 before_install: git fetch --unshallow
 language: java
-install: mvn install --batch-mode -DskipTests=true 
-Dmaven.javadoc.skip=true -Dsource.skip=true > mvn_install.log || (cat 
mvn_install.log && false)
-script: mvn package -DskipTests=true
+jdk:
+  - openjdk7
--- End diff --

@ilooner-mapr Switch to jdk7 is not required, it works with jdk8 as well, 
but enforcing jdk7 helps with validating that the project is java 1.7 
compliant, so I am OK with the change.


> Fix Travis Checks
> -
>
> Key: DRILL-5729
> URL: https://issues.apache.org/jira/browse/DRILL-5729
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
> Fix For: 1.12.0
>
>
> Currently the Travis Checks are failing. The failures are happening because 
> Travis recently switched their default build containers from Ubuntu precise 
> to Ubuntu Trusty and we do not explicitly define the dist we build on in our 
> travis.yml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-5729) Fix Travis Checks

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141764#comment-16141764
 ] 

ASF GitHub Bot commented on DRILL-5729:
---

Github user vrozov commented on the issue:

https://github.com/apache/drill/pull/913
  
@parthchandra LGTM. There are questions that I have related to how 
travis-ci build is configured, but they are for pre-existing settings and can 
be addressed in a follow up PR if necessary.


> Fix Travis Checks
> -
>
> Key: DRILL-5729
> URL: https://issues.apache.org/jira/browse/DRILL-5729
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
> Fix For: 1.12.0
>
>
> Currently the Travis Checks are failing. The failures are happening because 
> Travis recently switched their default build containers from Ubuntu precise 
> to Ubuntu Trusty and we do not explicitly define the dist we build on in our 
> travis.yml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-5729) Fix Travis Checks

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140865#comment-16140865
 ] 

ASF GitHub Bot commented on DRILL-5729:
---

Github user vrozov commented on a diff in the pull request:

https://github.com/apache/drill/pull/913#discussion_r135148431
  
--- Diff: .travis.yml ---
@@ -13,8 +13,10 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-sudo: false
+sudo: required
 before_install: git fetch --unshallow
 language: java
+jdk:
+  - openjdk7
 install: mvn install --batch-mode -DskipTests=true 
-Dmaven.javadoc.skip=true -Dsource.skip=true > mvn_install.log || (cat 
mvn_install.log && false)
 script: mvn package -DskipTests=true
--- End diff --

`install` includes `package` goal and I don't think that javadoc or source 
plugin are enabled in the default profile, so `script` just repeats the 
`install`. Also, if the goal is to skip source jar generation, the proper 
property is maven.source.skip, I believe. 


> Fix Travis Checks
> -
>
> Key: DRILL-5729
> URL: https://issues.apache.org/jira/browse/DRILL-5729
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
> Fix For: 1.12.0
>
>
> Currently the Travis Checks are failing. The failures are happening because 
> Travis recently switched their default build containers from Ubuntu precise 
> to Ubuntu Trusty and we do not explicitly define the dist we build on in our 
> travis.yml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-5729) Fix Travis Checks

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140827#comment-16140827
 ] 

ASF GitHub Bot commented on DRILL-5729:
---

Github user vrozov commented on a diff in the pull request:

https://github.com/apache/drill/pull/913#discussion_r135143313
  
--- Diff: .travis.yml ---
@@ -13,8 +13,10 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-sudo: false
+sudo: required
 before_install: git fetch --unshallow
 language: java
+jdk:
+  - openjdk7
 install: mvn install --batch-mode -DskipTests=true 
-Dmaven.javadoc.skip=true -Dsource.skip=true > mvn_install.log || (cat 
mvn_install.log && false)
--- End diff --

@ilooner-mapr can you remove redirection to mvn_install.log as part of the 
same PR. It is not necessary.


> Fix Travis Checks
> -
>
> Key: DRILL-5729
> URL: https://issues.apache.org/jira/browse/DRILL-5729
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
> Fix For: 1.12.0
>
>
> Currently the Travis Checks are failing. The failures are happening because 
> Travis recently switched their default build containers from Ubuntu precise 
> to Ubuntu Trusty and we do not explicitly define the dist we build on in our 
> travis.yml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-5729) Fix Travis Checks

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140820#comment-16140820
 ] 

ASF GitHub Bot commented on DRILL-5729:
---

Github user vrozov commented on the issue:

https://github.com/apache/drill/pull/913
  
@ilooner-mapr I tested it on my branch and it works with the default jdk 
and without *sudo*. Add `MAVEN_OPTS="-Xms1G -Xmx1G"` before `mvn`.

Can you remove leading dash from the commit message as part of rebase.


> Fix Travis Checks
> -
>
> Key: DRILL-5729
> URL: https://issues.apache.org/jira/browse/DRILL-5729
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
> Fix For: 1.12.0
>
>
> Currently the Travis Checks are failing. The failures are happening because 
> Travis recently switched their default build containers from Ubuntu precise 
> to Ubuntu Trusty and we do not explicitly define the dist we build on in our 
> travis.yml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-5729) Fix Travis Checks

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140721#comment-16140721
 ] 

ASF GitHub Bot commented on DRILL-5729:
---

Github user ilooner-mapr commented on the issue:

https://github.com/apache/drill/pull/913
  
@vrozov I got it working with Trusty and explicitly configuring openjdk7. 
One thing to note is that Trusty was running out of memory doing the build with 
the default 4gb container size. So I had to add the **sudo: required** option 
in order to increase the vm size 
https://docs.travis-ci.com/user/reference/overview/ .


> Fix Travis Checks
> -
>
> Key: DRILL-5729
> URL: https://issues.apache.org/jira/browse/DRILL-5729
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
> Fix For: 1.12.0
>
>
> Currently the Travis Checks are failing. The failures are happening because 
> Travis recently switched their default build containers from Ubuntu precise 
> to Ubuntu Trusty and we do not explicitly define the dist we build on in our 
> travis.yml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-5729) Fix Travis Checks

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140636#comment-16140636
 ] 

ASF GitHub Bot commented on DRILL-5729:
---

Github user ilooner-mapr commented on the issue:

https://github.com/apache/drill/pull/913
  
@vrozov It looks like the default jdk for Trusty on travis is jdk8. I'll 
check to see if explicitly telling travis to use jdk7 with Trusty is also a 
possible fix.


> Fix Travis Checks
> -
>
> Key: DRILL-5729
> URL: https://issues.apache.org/jira/browse/DRILL-5729
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
> Fix For: 1.12.0
>
>
> Currently the Travis Checks are failing. The failures are happening because 
> Travis recently switched their default build containers from Ubuntu precise 
> to Ubuntu Trusty and we do not explicitly define the dist we build on in our 
> travis.yml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-5729) Fix Travis Checks

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140623#comment-16140623
 ] 

ASF GitHub Bot commented on DRILL-5729:
---

Github user vrozov commented on the issue:

https://github.com/apache/drill/pull/913
  
@ilooner-mapr Do you know why it fails on the Trusty (new default)? Going 
back to using Precise is OK for a while, but my guess that it will eventually 
become obsolete.


> Fix Travis Checks
> -
>
> Key: DRILL-5729
> URL: https://issues.apache.org/jira/browse/DRILL-5729
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
> Fix For: 1.12.0
>
>
> Currently the Travis Checks are failing. The failures are happening because 
> Travis recently switched their default build containers from Ubuntu precise 
> to Ubuntu Trusty and we do not explicitly define the dist we build on in our 
> travis.yml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-5729) Fix Travis Checks

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135606#comment-16135606
 ] 

ASF GitHub Bot commented on DRILL-5729:
---

Github user ilooner-mapr commented on the issue:

https://github.com/apache/drill/pull/913
  
@vrozov Spoke with Parth. Could you take a look at this PR? There are other 
issues with the travis build. For example it doesn't even run the unit tests 
right now. But this is a first step to fix what is currently in the travis 
build from failing.


> Fix Travis Checks
> -
>
> Key: DRILL-5729
> URL: https://issues.apache.org/jira/browse/DRILL-5729
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
> Fix For: 1.12.0
>
>
> Currently the Travis Checks are failing. The failures are happening because 
> Travis recently switched their default build containers from Ubuntu precise 
> to Ubuntu Trusty and we do not explicitly define the dist we build on in our 
> travis.yml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-5729) Fix Travis Checks

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131506#comment-16131506
 ] 

ASF GitHub Bot commented on DRILL-5729:
---

Github user ilooner-mapr commented on the issue:

https://github.com/apache/drill/pull/913
  
@parthchandra 


> Fix Travis Checks
> -
>
> Key: DRILL-5729
> URL: https://issues.apache.org/jira/browse/DRILL-5729
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
> Fix For: 1.12.0
>
>
> Currently the Travis Checks are failing. The failures are happening because 
> Travis recently switched their default build containers from Ubuntu precise 
> to Ubuntu Trusty and we do not explicitly define the dist we build on in our 
> travis.yml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-5729) Fix Travis Checks

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131484#comment-16131484
 ] 

ASF GitHub Bot commented on DRILL-5729:
---

GitHub user ilooner-mapr opened a pull request:

https://github.com/apache/drill/pull/913

 - DRILL-5729 Fix Travis Build



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ilooner-mapr/drill DRILL-5729

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/913.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #913


commit b52188f8091a3b22021cb1efaa42f7ebb1b2792d
Author: Timothy Farkas 
Date:   2017-08-17T23:37:24Z

 - DRILL-5729 explicitly made the travis container ubuntu precise to fix 
build errors caused by ubuntu trusty.




> Fix Travis Checks
> -
>
> Key: DRILL-5729
> URL: https://issues.apache.org/jira/browse/DRILL-5729
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
> Fix For: 1.12.0
>
>
> Currently the Travis Checks are failing. The failures are happening because 
> Travis recently switched their default build containers from Ubuntu precise 
> to Ubuntu Trusty and we do not explicitly define the dist we build on in our 
> travis.yml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-5729) Fix Travis Checks

[Timothy Farkas (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131482#comment-16131482
 ] 

Timothy Farkas commented on DRILL-5729:
---

The fix would be to explicitly use ubuntu precise until we understand why 
ubuntu trusty has issues.

> Fix Travis Checks
> -
>
> Key: DRILL-5729
> URL: https://issues.apache.org/jira/browse/DRILL-5729
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
> Fix For: 1.12.0
>
>
> Currently the Travis Checks are failing. The failures are happening because 
> Travis recently switched their default build containers from Ubuntu precise 
> to Ubuntu Trusty and we do not explicitly define the dist we build on in our 
> travis.yml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)