[jira] [Commented] (DRILL-5910) Logging exception when custom AuthenticatorFactory not found
[ https://issues.apache.org/jira/browse/DRILL-5910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311151#comment-16311151 ] Alex commented on DRILL-5910: - The fix was tested (v. drill-1.13), status - *PASSED*: - Another AuthenticatorFactory is used if 1 fails (nonexistent MapRSaslFactory was used during testing activity), the user is able to login/run queries - The error message is logged to log/sqlline.log; > Logging exception when custom AuthenticatorFactory not found > - > > Key: DRILL-5910 > URL: https://issues.apache.org/jira/browse/DRILL-5910 > Project: Apache Drill > Issue Type: Improvement >Affects Versions: 1.11.0 >Reporter: Volodymyr Tkach >Assignee: Volodymyr Tkach >Priority: Minor > Labels: ready-to-commit > Fix For: 1.12.0 > > > We need to log the exception when any of custom AuthenticatorFactory fails to > be instansiated in ClientAuthenticatorProvider constructor. We are doing this > to allow drill to use other available AuthenticatorFactory > Steps to repoduce: > 1) Configure plain authentication > 2) Add > -Ddrill.customAuthFactories=org.apache.drill.exec.rpc.security.maprsasl.MapRSaslFactory > to SQLLINE_JAVA_OPTS or another class that is not present in classpath. > 3) Run sqlline and connect to drillbit -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DRILL-5910) Logging exception when custom AuthenticatorFactory not found
[ https://issues.apache.org/jira/browse/DRILL-5910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226540#comment-16226540 ] Volodymyr Tkach commented on DRILL-5910: Merge into master with commit id b0b7df10da14ab94cd657f0c1e3a0c3ff242bedd > Logging exception when custom AuthenticatorFactory not found > - > > Key: DRILL-5910 > URL: https://issues.apache.org/jira/browse/DRILL-5910 > Project: Apache Drill > Issue Type: Improvement >Affects Versions: 1.11.0 >Reporter: Volodymyr Tkach >Assignee: Volodymyr Tkach >Priority: Minor > Labels: ready-to-commit > Fix For: 1.12.0 > > > We need to log the exception when any of custom AuthenticatorFactory fails to > be instansiated in ClientAuthenticatorProvider constructor. We are doing this > to allow drill to use other available AuthenticatorFactory > Steps to repoduce: > 1) Configure plain authentication > 2) Add > -Ddrill.customAuthFactories=org.apache.drill.exec.rpc.security.maprsasl.MapRSaslFactory > to SQLLINE_JAVA_OPTS or another class that is not present in classpath. > 3) Run sqlline and connect to drillbit -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DRILL-5910) Logging exception when custom AuthenticatorFactory not found
[ https://issues.apache.org/jira/browse/DRILL-5910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225741#comment-16225741 ] ASF GitHub Bot commented on DRILL-5910: --- Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1013 > Logging exception when custom AuthenticatorFactory not found > - > > Key: DRILL-5910 > URL: https://issues.apache.org/jira/browse/DRILL-5910 > Project: Apache Drill > Issue Type: Improvement >Affects Versions: 1.11.0 >Reporter: Volodymyr Tkach >Assignee: Volodymyr Tkach >Priority: Minor > Labels: ready-to-commit > Fix For: 1.12.0 > > > We need to log the exception when any of custom AuthenticatorFactory fails to > be instansiated in ClientAuthenticatorProvider constructor. We are doing this > to allow drill to use other available AuthenticatorFactory > Steps to repoduce: > 1) Configure plain authentication > 2) Add > -Ddrill.customAuthFactories=org.apache.drill.exec.rpc.security.maprsasl.MapRSaslFactory > to SQLLINE_JAVA_OPTS or another class that is not present in classpath. > 3) Run sqlline and connect to drillbit -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DRILL-5910) Logging exception when custom AuthenticatorFactory not found
[ https://issues.apache.org/jira/browse/DRILL-5910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225120#comment-16225120 ] ASF GitHub Bot commented on DRILL-5910: --- Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1013 LGTM > Logging exception when custom AuthenticatorFactory not found > - > > Key: DRILL-5910 > URL: https://issues.apache.org/jira/browse/DRILL-5910 > Project: Apache Drill > Issue Type: Improvement >Affects Versions: 1.11.0 >Reporter: Volodymyr Tkach >Assignee: Volodymyr Tkach >Priority: Minor > Fix For: 1.12.0 > > > We need to log the exception when any of custom AuthenticatorFactory fails to > be instansiated in ClientAuthenticatorProvider constructor. We are doing this > to allow drill to use other available AuthenticatorFactory > Steps to repoduce: > 1) Configure plain authentication > 2) Add > -Ddrill.customAuthFactories=org.apache.drill.exec.rpc.security.maprsasl.MapRSaslFactory > to SQLLINE_JAVA_OPTS or another class that is not present in classpath. > 3) Run sqlline and connect to drillbit -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DRILL-5910) Logging exception when custom AuthenticatorFactory not found
[ https://issues.apache.org/jira/browse/DRILL-5910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224799#comment-16224799 ] ASF GitHub Bot commented on DRILL-5910: --- Github user vladimirtkach commented on the issue: https://github.com/apache/drill/pull/1013 @vrozov made the changes, please review. > Logging exception when custom AuthenticatorFactory not found > - > > Key: DRILL-5910 > URL: https://issues.apache.org/jira/browse/DRILL-5910 > Project: Apache Drill > Issue Type: Improvement >Affects Versions: 1.11.0 >Reporter: Volodymyr Tkach >Assignee: Volodymyr Tkach >Priority: Minor > Fix For: 1.12.0 > > > We need to log the exception when any of custom AuthenticatorFactory fails to > be instansiated in ClientAuthenticatorProvider constructor. We are doing this > to allow drill to use other available AuthenticatorFactory > Steps to repoduce: > 1) Configure plain authentication > 2) Add > -Ddrill.customAuthFactories=org.apache.drill.exec.rpc.security.maprsasl.MapRSaslFactory > to SQLLINE_JAVA_OPTS or another class that is not present in classpath. > 3) Run sqlline and connect to drillbit -- This message was sent by Atlassian JIRA (v6.4.14#64029)
