[jira] [Commented] (DRILL-6190) Packets can be bigger than strictly legal

2018-03-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-6190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384794#comment-16384794
 ] 

ASF GitHub Bot commented on DRILL-6190:
---

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/1133


> Packets can be bigger than strictly legal
> -
>
> Key: DRILL-6190
> URL: https://issues.apache.org/jira/browse/DRILL-6190
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Ted Dunning
>Assignee: Ted Dunning
>Priority: Major
>  Labels: ready-to-commit
> Fix For: 1.13.0
>
>
> Packets, especially those generated by malware, can be bigger than the legal 
> limit for IP. The fix is to leave 64kB padding in the buffers instead of 9kB.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6190) Packets can be bigger than strictly legal

2018-03-01 Thread Ted Dunning (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-6190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382894#comment-16382894
 ] 

Ted Dunning commented on DRILL-6190:


Wasn't this already reviewed? The changes since then are trivial. Same for
6191.




> Packets can be bigger than strictly legal
> -
>
> Key: DRILL-6190
> URL: https://issues.apache.org/jira/browse/DRILL-6190
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Ted Dunning
>Assignee: Ted Dunning
>Priority: Major
>  Labels: ready-to-commit
> Fix For: 1.13.0
>
>
> Packets, especially those generated by malware, can be bigger than the legal 
> limit for IP. The fix is to leave 64kB padding in the buffers instead of 9kB.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6190) Packets can be bigger than strictly legal

2018-02-28 Thread Ted Dunning (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-6190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381429#comment-16381429
 ] 

Ted Dunning commented on DRILL-6190:


Travis build is fixed:
h3. [ #5031 passed|https://travis-ci.org/apache/drill/builds/347567906]
 *  Ran for 43 min 7 sec

> Packets can be bigger than strictly legal
> -
>
> Key: DRILL-6190
> URL: https://issues.apache.org/jira/browse/DRILL-6190
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Ted Dunning
>Assignee: Ted Dunning
>Priority: Major
> Fix For: 1.13.0
>
>
> Packets, especially those generated by malware, can be bigger than the legal 
> limit for IP. The fix is to leave 64kB padding in the buffers instead of 9kB.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6190) Packets can be bigger than strictly legal

2018-02-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-6190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381377#comment-16381377
 ] 

ASF GitHub Bot commented on DRILL-6190:
---

Github user tdunning commented on the issue:

https://github.com/apache/drill/pull/1133
  

Fixed the test regression. Deferring investigation into why the data field 
doesn't look unique to Drill because we will probably need to revamp how raw 
data is returned anyway.


> Packets can be bigger than strictly legal
> -
>
> Key: DRILL-6190
> URL: https://issues.apache.org/jira/browse/DRILL-6190
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Ted Dunning
>Assignee: Ted Dunning
>Priority: Major
> Fix For: 1.13.0
>
>
> Packets, especially those generated by malware, can be bigger than the legal 
> limit for IP. The fix is to leave 64kB padding in the buffers instead of 9kB.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6190) Packets can be bigger than strictly legal

2018-02-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-6190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380097#comment-16380097
 ] 

ASF GitHub Bot commented on DRILL-6190:
---

Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/1133
  
@tdunning travis fails with `
Failed tests: 
  
TestPcapRecordReader.testDistinctQuery:51->runSQLVerifyCount:56->printResultAndVerifyRowCount:68
 expected:<1> but was:<2>`


> Packets can be bigger than strictly legal
> -
>
> Key: DRILL-6190
> URL: https://issues.apache.org/jira/browse/DRILL-6190
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Ted Dunning
>Assignee: Ted Dunning
>Priority: Major
> Fix For: 1.13.0
>
>
> Packets, especially those generated by malware, can be bigger than the legal 
> limit for IP. The fix is to leave 64kB padding in the buffers instead of 9kB.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6190) Packets can be bigger than strictly legal

2018-02-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-6190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380089#comment-16380089
 ] 

ASF GitHub Bot commented on DRILL-6190:
---

Github user parthchandra commented on the issue:

https://github.com/apache/drill/pull/1133
  
+1


> Packets can be bigger than strictly legal
> -
>
> Key: DRILL-6190
> URL: https://issues.apache.org/jira/browse/DRILL-6190
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Ted Dunning
>Assignee: Ted Dunning
>Priority: Major
> Fix For: 1.13.0
>
>
> Packets, especially those generated by malware, can be bigger than the legal 
> limit for IP. The fix is to leave 64kB padding in the buffers instead of 9kB.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6190) Packets can be bigger than strictly legal

2018-02-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-6190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379125#comment-16379125
 ] 

ASF GitHub Bot commented on DRILL-6190:
---

Github user priteshm commented on the issue:

https://github.com/apache/drill/pull/1133
  
@parthchandra or @arina-ielchiieva  can you review this?


> Packets can be bigger than strictly legal
> -
>
> Key: DRILL-6190
> URL: https://issues.apache.org/jira/browse/DRILL-6190
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Ted Dunning
>Assignee: Ted Dunning
>Priority: Major
> Fix For: 1.13.0
>
>
> Packets, especially those generated by malware, can be bigger than the legal 
> limit for IP. The fix is to leave 64kB padding in the buffers instead of 9kB.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6190) Packets can be bigger than strictly legal

2018-02-27 Thread Ted Dunning (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-6190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378817#comment-16378817
 ] 

Ted Dunning commented on DRILL-6190:


Created pull request for this.

> Packets can be bigger than strictly legal
> -
>
> Key: DRILL-6190
> URL: https://issues.apache.org/jira/browse/DRILL-6190
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Ted Dunning
>Priority: Major
>
> Packets, especially those generated by malware, can be bigger than the legal 
> limit for IP. The fix is to leave 64kB padding in the buffers instead of 9kB.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6190) Packets can be bigger than strictly legal

2018-02-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-6190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378813#comment-16378813
 ] 

ASF GitHub Bot commented on DRILL-6190:
---

GitHub user tdunning opened a pull request:

https://github.com/apache/drill/pull/1133

DRILL-6190 - Fix handling of packets longer than legally allowed.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tdunning/drill DRILL-6190

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/1133.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1133


commit 678e17807a0a3f205d35febd6216e2088483ce54
Author: Ted Dunning 
Date:   2018-01-11T00:52:53Z

DRILL-6190 - Fix handling of packets longer than legally allowed.




> Packets can be bigger than strictly legal
> -
>
> Key: DRILL-6190
> URL: https://issues.apache.org/jira/browse/DRILL-6190
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Ted Dunning
>Priority: Major
>
> Packets, especially those generated by malware, can be bigger than the legal 
> limit for IP. The fix is to leave 64kB padding in the buffers instead of 9kB.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)