[jira] [Commented] (DRILL-6837) Missing reference for dynamically created Javascript library
[ https://issues.apache.org/jira/browse/DRILL-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681971#comment-16681971 ] ASF GitHub Bot commented on DRILL-6837: --- kkhatua closed pull request #1529: DRILL-6837: Missing reference for dynamically created Javascript library URL: https://github.com/apache/drill/pull/1529 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/exec/java-exec/src/main/resources/rest/profile/profile.ftl b/exec/java-exec/src/main/resources/rest/profile/profile.ftl index 1d6a0c2c71e..c14e1b2e97d 100644 --- a/exec/java-exec/src/main/resources/rest/profile/profile.ftl +++ b/exec/java-exec/src/main/resources/rest/profile/profile.ftl @@ -29,7 +29,8 @@ - + + This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Missing reference for dynamically created Javascript library > > > Key: DRILL-6837 > URL: https://issues.apache.org/jira/browse/DRILL-6837 > Project: Apache Drill > Issue Type: Bug > Components: Web Server >Affects Versions: 1.15.0 >Reporter: Kunal Khatua >Assignee: Kunal Khatua >Priority: Trivial > Labels: ready-to-commit > Fix For: 1.15.0 > > > A PR for DRILL-6084 broke the auto-complete library required for Edit Query > page, with the removal of the static javascript library. > https://github.com/apache/drill/pull/1491/files#diff-2bb3c04f1a9eead1faf57212cce5d2a9 > The dynamically loaded script is not defined in the Freemarker template page. > The fix is trivial. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6837) Missing reference for dynamically created Javascript library
[ https://issues.apache.org/jira/browse/DRILL-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681194#comment-16681194 ] ASF GitHub Bot commented on DRILL-6837: --- arina-ielchiieva commented on issue #1529: DRILL-6837: Missing reference for dynamically created Javascript library URL: https://github.com/apache/drill/pull/1529#issuecomment-437310536 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Missing reference for dynamically created Javascript library > > > Key: DRILL-6837 > URL: https://issues.apache.org/jira/browse/DRILL-6837 > Project: Apache Drill > Issue Type: Bug > Components: Web Server >Affects Versions: 1.15.0 >Reporter: Kunal Khatua >Assignee: Kunal Khatua >Priority: Trivial > Labels: ready-to-commit > Fix For: 1.15.0 > > > A PR for DRILL-6084 broke the auto-complete library required for Edit Query > page, with the removal of the static javascript library. > https://github.com/apache/drill/pull/1491/files#diff-2bb3c04f1a9eead1faf57212cce5d2a9 > The dynamically loaded script is not defined in the Freemarker template page. > The fix is trivial. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6837) Missing reference for dynamically created Javascript library
[ https://issues.apache.org/jira/browse/DRILL-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680692#comment-16680692 ] ASF GitHub Bot commented on DRILL-6837: --- kkhatua opened a new pull request #1529: DRILL-6837: Missing reference for dynamically created Javascript library URL: https://github.com/apache/drill/pull/1529 A PR for DRILL-6084 broke the auto-complete library required for Edit Query page, with the removal of the static javascript library. https://github.com/apache/drill/pull/1491/files#diff-2bb3c04f1a9eead1faf57212cce5d2a9 The dynamically loaded script is not defined in the Freemarker template page. The fix is trivial. This is the console error:  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Missing reference for dynamically created Javascript library > > > Key: DRILL-6837 > URL: https://issues.apache.org/jira/browse/DRILL-6837 > Project: Apache Drill > Issue Type: Bug > Components: Web Server >Affects Versions: 1.15.0 >Reporter: Kunal Khatua >Assignee: Kunal Khatua >Priority: Trivial > Fix For: 1.15.0 > > > A PR for DRILL-6084 broke the auto-complete library required for Edit Query > page, with the removal of the static javascript library. > https://github.com/apache/drill/pull/1491/files#diff-2bb3c04f1a9eead1faf57212cce5d2a9 > The dynamically loaded script is not defined in the Freemarker template page. > The fix is trivial. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
