[jira] [Commented] (DRILL-8475) The binary version License and NOTICE do not comply with the corresponding terms.
[ https://issues.apache.org/jira/browse/DRILL-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814055#comment-17814055 ] ASF GitHub Bot commented on DRILL-8475: --- jnturton opened a new pull request, #2879: URL: https://github.com/apache/drill/pull/2879 # [DRILL-8475](https://issues.apache.org/jira/browse/DRILL-8475): Update the binary dist LICENSE ## Description The LICENSE file included in the binary distributions of Drill becomes an artifact that is generated automatically by the org.codehaus.mojo:license-maven-plugin (and so is no longer part of the Git source tree). Dependencies that it cannot detect are kept in the LICENSE-base.txt file which is combined with the generated license notices by a new Freemarker template. Various other dependency related changes are included as part of this work. It is still possible that fat jars have introduced hidden depedencies but I propose that those are analysed in a subsequent Jira issue. ## Documentation Comments and updated dev docs. ## Testing Comparison of the jars/ directory of a Drill build against the generated LICENSE file to check that every bundled jar has a license notice in LICENSE. > The binary version License and NOTICE do not comply with the corresponding > terms. > - > > Key: DRILL-8475 > URL: https://issues.apache.org/jira/browse/DRILL-8475 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.21.1 >Reporter: Calvin Kirs >Assignee: James Turton >Priority: Blocker > Fix For: 1.21.2 > > Attachments: dependencies.txt, drill-dep-list.txt > > > I checked the latest released version, and it does not follow the > corresponding rules[1]. This is very important and I hope it will be taken > seriously by the PMC team. I'd be happy to do it if needed. > [1] [https://infra.apache.org/licensing-howto.html#binary] > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DRILL-8475) The binary version License and NOTICE do not comply with the corresponding terms.
[ https://issues.apache.org/jira/browse/DRILL-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806634#comment-17806634 ] Calvin Kirs commented on DRILL-8475: [~dzamo] Hi James，I think ok > The binary version License and NOTICE do not comply with the corresponding > terms. > - > > Key: DRILL-8475 > URL: https://issues.apache.org/jira/browse/DRILL-8475 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.21.1 >Reporter: Calvin Kirs >Assignee: James Turton >Priority: Blocker > Fix For: 1.21.2 > > Attachments: dependencies.txt, drill-dep-list.txt > > > I checked the latest released version, and it does not follow the > corresponding rules[1]. This is very important and I hope it will be taken > seriously by the PMC team. I'd be happy to do it if needed. > [1] [https://infra.apache.org/licensing-howto.html#binary] > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DRILL-8475) The binary version License and NOTICE do not comply with the corresponding terms.
[ https://issues.apache.org/jira/browse/DRILL-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806633#comment-17806633 ] Calvin Kirs commented on DRILL-8475: I executed mvn clean install -DskipTests -Phadoop-2, then checked the dependency file in our jar package in the jars directory, and then filtered it to get the following results. > The binary version License and NOTICE do not comply with the corresponding > terms. > - > > Key: DRILL-8475 > URL: https://issues.apache.org/jira/browse/DRILL-8475 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.21.1 >Reporter: Calvin Kirs >Assignee: James Turton >Priority: Blocker > Fix For: 1.21.2 > > Attachments: dependencies.txt, drill-dep-list.txt > > > I checked the latest released version, and it does not follow the > corresponding rules[1]. This is very important and I hope it will be taken > seriously by the PMC team. I'd be happy to do it if needed. > [1] [https://infra.apache.org/licensing-howto.html#binary] > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DRILL-8475) The binary version License and NOTICE do not comply with the corresponding terms.
[
https://issues.apache.org/jira/browse/DRILL-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805432#comment-17805432
]
James Turton commented on DRILL-8475:
-
The current NOTICE file is reproduced below. It states that third party
licenses and copyright notices are to be found in LICENSE and that Class B libs
are located in jar/classb. Can we continue with this arrangement? Do we then
only need to ensure that LICENSE is fully populated and that we're still
sending all the relevant stuff to jars/classb?
{noformat}
Apache Drill
Copyright 2013-2024 The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
This product depends on third party software that falls under a variety of
licenses.
All dependencies with licenses other than Apache are specified in the LICENSE
file.
For easy reference, all of the dependencies that fall under Class B licenses
Reciprocal
Licenses are included in the binary release under a separate directory located
at jar/classb.
More information on Class B licenses is available here:
http://www.apache.org/legal/3party.html
Please see LICENSE for additional copyright and licensing information.
{noformat}
> The binary version License and NOTICE do not comply with the corresponding
> terms.
> -
>
> Key: DRILL-8475
> URL: https://issues.apache.org/jira/browse/DRILL-8475
> Project: Apache Drill
> Issue Type: Bug
>Affects Versions: 1.21.1
>Reporter: Calvin Kirs
>Assignee: James Turton
>Priority: Blocker
> Fix For: 1.21.2
>
> Attachments: drill-dep-list.txt
>
>
> I checked the latest released version, and it does not follow the
> corresponding rules[1]. This is very important and I hope it will be taken
> seriously by the PMC team. I'd be happy to do it if needed.
> [1] [https://infra.apache.org/licensing-howto.html#binary]
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DRILL-8475) The binary version License and NOTICE do not comply with the corresponding terms.
[ https://issues.apache.org/jira/browse/DRILL-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805065#comment-17805065 ] Calvin Kirs commented on DRILL-8475: We have some shaded JARs, such as drill-hive-exec-shaded, and I believe you missed its dependencies. > The binary version License and NOTICE do not comply with the corresponding > terms. > - > > Key: DRILL-8475 > URL: https://issues.apache.org/jira/browse/DRILL-8475 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.21.1 >Reporter: Calvin Kirs >Assignee: James Turton >Priority: Blocker > Fix For: 1.21.2 > > Attachments: drill-dep-list.txt > > > I checked the latest released version, and it does not follow the > corresponding rules[1]. This is very important and I hope it will be taken > seriously by the PMC team. I'd be happy to do it if needed. > [1] [https://infra.apache.org/licensing-howto.html#binary] > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DRILL-8475) The binary version License and NOTICE do not comply with the corresponding terms.
[ https://issues.apache.org/jira/browse/DRILL-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805061#comment-17805061 ] James Turton commented on DRILL-8475: - I've attached a sorted and deduplicated list of dependency module names taken from Drill's distribution module. > The binary version License and NOTICE do not comply with the corresponding > terms. > - > > Key: DRILL-8475 > URL: https://issues.apache.org/jira/browse/DRILL-8475 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.21.1 >Reporter: Calvin Kirs >Assignee: James Turton >Priority: Blocker > Fix For: 1.21.2 > > Attachments: drill-dep-list.txt > > > I checked the latest released version, and it does not follow the > corresponding rules[1]. This is very important and I hope it will be taken > seriously by the PMC team. I'd be happy to do it if needed. > [1] [https://infra.apache.org/licensing-howto.html#binary] > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
