[jira] [Commented] (EAGLE-968) using Email Notification Feature throws IncompatibleClassChangeError
[
https://issues.apache.org/jira/browse/EAGLE-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031071#comment-16031071
]
ASF GitHub Bot commented on EAGLE-968:
--
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/eagle/pull/941#discussion_r119341799
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/email/EagleMailClient.java
---
@@ -54,6 +54,8 @@ public EagleMailClient(final Properties config) {
velocityEngine = new VelocityEngine();
velocityEngine.setProperty(RuntimeConstants.RESOURCE_LOADER,
"classpath");
velocityEngine.setProperty("classpath.resource.loader.class",
ClasspathResourceLoader.class.getName());
+
velocityEngine.setProperty(RuntimeConstants.RUNTIME_LOG_LOGSYSTEM_CLASS,org.apache.velocity.runtime.log.NullLogChute.class.getName());
--- End diff --
I think it would be better to put the fully qualified name in the `import`
snippet. In addition, here is a problem that `EagleMailClient` need be
refactoring for sloving code duplication, so, in addition to` alert-engine`
module, there `eagle-common` module is also need to be modified.
```java
import org.apache.velocity.runtime.log.NullLogChute;
velocityEngine.setProperty(RuntimeConstants.RUNTIME_LOG_LOGSYSTEM_CLASS,org.apache.velocity.runtime.log.NullLogChute.class.getName());
```
> using Email Notification Feature throws IncompatibleClassChangeError
>
>
> Key: EAGLE-968
> URL: https://issues.apache.org/jira/browse/EAGLE-968
> Project: Eagle
> Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: Jayesh
>Assignee: Jayesh
> Fix For: v0.6.0
>
>
> {code}
> 2017-03-19 20:42:56.369 o.a.e.a.e.p.e.AlertEmailGenerator
> Thread-46-alertPublishBolt-executor[17 17] [ERROR] Failed to send email to
> @gmail.com,@gmail.com, due
> to:java.util.concurrent.ExecutionException:
> java.lang.IncompatibleClassChangeError: Implementing class
> java.util.concurrent.ExecutionException:
> java.lang.IncompatibleClassChangeError: Implementing class
> at java.util.concurrent.FutureTask.report(FutureTask.java:122)
> ~[?:1.8.0_102]
> at java.util.concurrent.FutureTask.get(FutureTask.java:206)
> ~[?:1.8.0_102]
> at
> org.apache.eagle.alert.engine.publisher.email.AlertEmailGenerator.sendAlertEmail(AlertEmailGenerator.java:89)
> [stormjar.jar:?]
> at
> org.apache.eagle.alert.engine.publisher.email.AlertEmailGenerator.sendAlertEmail(AlertEmailGenerator.java:55)
> [stormjar.jar:?]
> at
> org.apache.eagle.alert.engine.publisher.impl.AlertEmailPublisher.onAlert(AlertEmailPublisher.java:130)
> [stormjar.jar:?]
> at
> org.apache.eagle.alert.engine.publisher.impl.AlertPublisherImpl.notifyAlert(AlertPublisherImpl.java:88)
> [stormjar.jar:?]
> at
> org.apache.eagle.alert.engine.publisher.impl.AlertPublisherImpl.nextEvent(AlertPublisherImpl.java:70)
> [stormjar.jar:?]
> at
> org.apache.eagle.alert.engine.runner.AlertPublisherBolt.execute(AlertPublisherBolt.java:92)
> [stormjar.jar:?]
> at
> org.apache.storm.daemon.executor$fn__4973$tuple_action_fn__4975.invoke(executor.clj:727)
> [storm-core-1.0.3.jar:1.0.3]
> at
> org.apache.storm.daemon.executor$mk_task_receiver$fn__4894.invoke(executor.clj:459)
> [storm-core-1.0.3.jar:1.0.3]
> at
> org.apache.storm.disruptor$clojure_handler$reify__4409.onEvent(disruptor.clj:40)
> [storm-core-1.0.3.jar:1.0.3]
> at
> org.apache.storm.utils.DisruptorQueue.consumeBatchToCursor(DisruptorQueue.java:453)
> [storm-core-1.0.3.jar:1.0.3]
> at
> org.apache.storm.utils.DisruptorQueue.consumeBatchWhenAvailable(DisruptorQueue.java:432)
> [storm-core-1.0.3.jar:1.0.3]
> at
> org.apache.storm.disruptor$consume_batch_when_available.invoke(disruptor.clj:73)
> [storm-core-1.0.3.jar:1.0.3]
> at
> org.apache.storm.daemon.executor$fn__4973$fn__4986$fn__5039.invoke(executor.clj:846)
> [storm-core-1.0.3.jar:1.0.3]
> at org.apache.storm.util$async_loop$fn__557.invoke(util.clj:484)
> [storm-core-1.0.3.jar:1.0.3]
> at clojure.lang.AFn.run(AFn.java:22) [clojure-1.7.0.jar:?]
> at java.lang.Thread.run(Thread.java:745) [?:1.8.0_102]
> Caused by: java.lang.IncompatibleClassChangeError: Implementing class
> at java.lang.ClassLoader.defineClass1(Native Method) ~[?:1.8.0_102]
> at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
> ~[?:1.8.0_102]
> at
> java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
> ~[?:1.8.0_102]
> at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
> ~[?:1.8.0_102]
> a
[GitHub] eagle pull request #941: [EAGLE-968] Fix for email issue in 0.5 eagle versio...
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/eagle/pull/941#discussion_r119341799
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/email/EagleMailClient.java
---
@@ -54,6 +54,8 @@ public EagleMailClient(final Properties config) {
velocityEngine = new VelocityEngine();
velocityEngine.setProperty(RuntimeConstants.RESOURCE_LOADER,
"classpath");
velocityEngine.setProperty("classpath.resource.loader.class",
ClasspathResourceLoader.class.getName());
+
velocityEngine.setProperty(RuntimeConstants.RUNTIME_LOG_LOGSYSTEM_CLASS,org.apache.velocity.runtime.log.NullLogChute.class.getName());
--- End diff --
I think it would be better to put the fully qualified name in the `import`
snippet. In addition, here is a problem that `EagleMailClient` need be
refactoring for sloving code duplication, so, in addition to` alert-engine`
module, there `eagle-common` module is also need to be modified.
```java
import org.apache.velocity.runtime.log.NullLogChute;
velocityEngine.setProperty(RuntimeConstants.RUNTIME_LOG_LOGSYSTEM_CLASS,org.apache.velocity.runtime.log.NullLogChute.class.getName());
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (EAGLE-968) using Email Notification Feature throws IncompatibleClassChangeError
[
https://issues.apache.org/jira/browse/EAGLE-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030849#comment-16030849
]
ASF GitHub Bot commented on EAGLE-968:
--
GitHub user rushikesavareddy opened a pull request:
https://github.com/apache/eagle/pull/941
[EAGLE-968] Fix for email issue in 0.5 eagle version
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[EAGLE-] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rushikesavareddy/eagle branch-0.5
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/eagle/pull/941.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #941
commit 215329d7fb13e1e5576b18ad09c0b23e698e14a9
Author: kreddylh
Date: 2017-05-31T08:43:09Z
Fix for email issue in 0.5 eagle version
> using Email Notification Feature throws IncompatibleClassChangeError
>
>
> Key: EAGLE-968
> URL: https://issues.apache.org/jira/browse/EAGLE-968
> Project: Eagle
> Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: Jayesh
>Assignee: Jayesh
> Fix For: v0.6.0
>
>
> {code}
> 2017-03-19 20:42:56.369 o.a.e.a.e.p.e.AlertEmailGenerator
> Thread-46-alertPublishBolt-executor[17 17] [ERROR] Failed to send email to
> @gmail.com,@gmail.com, due
> to:java.util.concurrent.ExecutionException:
> java.lang.IncompatibleClassChangeError: Implementing class
> java.util.concurrent.ExecutionException:
> java.lang.IncompatibleClassChangeError: Implementing class
> at java.util.concurrent.FutureTask.report(FutureTask.java:122)
> ~[?:1.8.0_102]
> at java.util.concurrent.FutureTask.get(FutureTask.java:206)
> ~[?:1.8.0_102]
> at
> org.apache.eagle.alert.engine.publisher.email.AlertEmailGenerator.sendAlertEmail(AlertEmailGenerator.java:89)
> [stormjar.jar:?]
> at
> org.apache.eagle.alert.engine.publisher.email.AlertEmailGenerator.sendAlertEmail(AlertEmailGenerator.java:55)
> [stormjar.jar:?]
> at
> org.apache.eagle.alert.engine.publisher.impl.AlertEmailPublisher.onAlert(AlertEmailPublisher.java:130)
> [stormjar.jar:?]
> at
> org.apache.eagle.alert.engine.publisher.impl.AlertPublisherImpl.notifyAlert(AlertPublisherImpl.java:88)
> [stormjar.jar:?]
> at
> org.apache.eagle.alert.engine.publisher.impl.AlertPublisherImpl.nextEvent(AlertPublisherImpl.java:70)
> [stormjar.jar:?]
> at
> org.apache.eagle.alert.engine.runner.AlertPublisherBolt.execute(AlertPublisherBolt.java:92)
> [stormjar.jar:?]
> at
> org.apache.storm.daemon.executor$fn__4973$tuple_action_fn__4975.invoke(executor.clj:727)
> [storm-core-1.0.3.jar:1.0.3]
> at
> org.apache.storm.daemon.executor$mk_task_receiver$fn__4894.invoke(executor.clj:459)
> [storm-core-1.0.3.jar:1.0.3]
> at
> org.apache.storm.disruptor$clojure_handler$reify__4409.onEvent(disruptor.clj:40)
> [storm-core-1.0.3.jar:1.0.3]
> at
> org.apache.storm.utils.DisruptorQueue.consumeBatchToCursor(DisruptorQueue.java:453)
> [storm-core-1.0.3.jar:1.0.3]
> at
> org.apache.storm.utils.DisruptorQueue.consumeBatchWhenAvailable(DisruptorQueue.java:432)
> [storm-core-1.0.3.jar:1.0.3]
> at
> org.apache.storm.disruptor$consume_batch_when_available.invoke(disruptor.clj:73)
> [storm-core-1.0.3.jar:1.0.3]
> at
> org.apache.storm.daemon.executor$fn__4973$fn__4986$fn__5039.invoke(executor.clj:846)
> [storm-core-1.0.3.jar:1.0.3]
> at org.apache.storm.util$async_loop$fn__557.invoke(util.clj:484)
> [storm-core-1.0.3.jar:1.0.3]
> at clojure.lang.AFn.run(AFn.java:22) [clojure-1.7.0.jar:?]
> at java.lang.Thread.run(Thread.java:745) [?:1.8.0_102]
> Caused by: java.lang.IncompatibleClassChangeError: Implementing class
> at java.lang.ClassLoader.defineClass1(Native Method) ~[?:1.8.0_102]
> at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
> ~[?:1.8.0_102]
> at
> java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
> ~[?:1.8.0_102]
> at java.net.URLClassLoader.defineClass(URLClassLoader.java:
[GitHub] eagle pull request #941: [EAGLE-968] Fix for email issue in 0.5 eagle versio...
GitHub user rushikesavareddy opened a pull request: https://github.com/apache/eagle/pull/941 [EAGLE-968] Fix for email issue in 0.5 eagle version Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[EAGLE-] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/rushikesavareddy/eagle branch-0.5 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/eagle/pull/941.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #941 commit 215329d7fb13e1e5576b18ad09c0b23e698e14a9 Author: kreddylh Date: 2017-05-31T08:43:09Z Fix for email issue in 0.5 eagle version --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
