[ 
https://issues.apache.org/jira/browse/EAGLE-984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated EAGLE-984:
-------------------------
    Description: 
Here is related code:
{code}
    public Tuple2<Long, Long> poll() {
        long oldestTimestamp = timeQueue.poll();
        Tuple2<Long, Long> pair = new Tuple2<>(oldestTimestamp, 
counter.get(oldestTimestamp));
{code}
We should check the return value from timeQueue.poll() before casting to long.

  was:
Here is related code:

{code}
    public Tuple2<Long, Long> poll() {
        long oldestTimestamp = timeQueue.poll();
        Tuple2<Long, Long> pair = new Tuple2<>(oldestTimestamp, 
counter.get(oldestTimestamp));
{code}
We should check the return value from timeQueue.poll() before casting to long.


> Potential null dereference in SimpleWindowCounter#poll()
> --------------------------------------------------------
>
>                 Key: EAGLE-984
>                 URL: https://issues.apache.org/jira/browse/EAGLE-984
>             Project: Eagle
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>             Fix For: v0.5.1
>
>
> Here is related code:
> {code}
>     public Tuple2<Long, Long> poll() {
>         long oldestTimestamp = timeQueue.poll();
>         Tuple2<Long, Long> pair = new Tuple2<>(oldestTimestamp, 
> counter.get(oldestTimestamp));
> {code}
> We should check the return value from timeQueue.poll() before casting to long.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to